The open-source agent harness - the runtime layer that turns an LLM into a working agent.
bugfix: open model settings popup via model parameters summary click in Agent Config (#999)
harshil-20961674b7176d1d
diff --git a/.changeset/open-model-settings-from-params-summary.md b/.changeset/open-model-settings-from-params-summary.mdnew file mode 100644index 000000000..bf667964c--- /dev/null+++ b/.changeset/open-model-settings-from-params-summary.md@@ -0,0 +1,5 @@+---+'@truefoundry/trueforge-ui': patch+---++Allow opening model settings dropdown by clicking the model parameters summary in Agent Config.diff --git a/packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsx b/packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsxindex 56f73cb93..e577f9fab 100644--- a/packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsx+++ b/packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsx@@ -416,18 +416,28 @@ export function AgentConfigPanel({<AgentModelSettingsContent spec={spec} model={model} onChange={next => onChange?.(next)} /></ResponsiveDropdownMenu></div>- <dl className="text-text-secondary mt-2 flex min-w-0 flex-wrap gap-x-3 gap-y-1 text-xs">- {modelParams.length ? (- modelParams.map(entry => (- <div key={entry.label} className="flex gap-1">- <dt>{entry.label}:</dt>- <dd className="text-text-primary font-medium">{entry.value}</dd>- </div>- ))- ) : (- <div>model settings: defaults</div>- )}- </dl>+ <button+ type="button"+ disabled={disabled}+ aria-label="Edit model settings"+ // DropdownMenu dismisses on document mousedown; stop it so click can toggle closed without reopen.+ onMouseDown={event => event.stopPropagation()}+ onClick={() => setModelSettingsMenuOpen(open => !open)}+ className="mt-2 flex w-full cursor-pointer flex-col text-left disabled:cursor-not-allowed disabled:opacity-50"+ >+ <dl className="text-text-secondary flex min-w-0 flex-wrap gap-x-3 gap-y-1 text-xs">+ {modelParams.length ? (+ modelParams.map(entry => (+ <div key={entry.label} className="flex gap-1">+ <dt>{entry.label}:</dt>+ <dd className="text-text-primary font-medium">{entry.value}</dd>+ </div>+ ))+ ) : (+ <div>model settings: defaults</div>+ )}+ </dl>+ </button></Section><Section title="Instructions" description="Define the agent's role, goals, and behavior.">diff --git a/packages/trueforge-ui/test/atoms/draft/AgentConfigPanel.test.tsx b/packages/trueforge-ui/test/atoms/draft/AgentConfigPanel.test.tsxindex f22e42e75..6f6e7a666 100644--- a/packages/trueforge-ui/test/atoms/draft/AgentConfigPanel.test.tsx+++ b/packages/trueforge-ui/test/atoms/draft/AgentConfigPanel.test.tsx@@ -133,6 +133,34 @@ describe('AgentConfigPanel', () => {expect(onOpenEditor).toHaveBeenCalledWith('instructions');});+ it('toggles model settings dropdown when clicking the model params summary', () => {+ const onOpenEditor = vi.fn();+ render(+ <SlotsProvider>+ <AgentConfigPanel+ spec={spec}+ model={model}+ {...catalogProps}+ skillsAvailable+ instructions={spec.instructions ?? ''}+ onOpenEditor={onOpenEditor}+ />+ </SlotsProvider>,+ );++ const summaryButton = screen.getByRole('button', { name: 'Edit model settings' });+ // Real clicks fire mousedown then click; DropdownMenu dismisses on document mousedown.+ fireEvent.mouseDown(summaryButton);+ fireEvent.click(summaryButton);+ expect(screen.getByRole('menu')).toBeInTheDocument();+ expect(screen.getByRole('heading', { name: 'Parameters' })).toBeInTheDocument();+ expect(onOpenEditor).not.toHaveBeenCalledWith('model-settings');++ fireEvent.mouseDown(summaryButton);+ fireEvent.click(summaryButton);+ expect(screen.queryByRole('menu')).not.toBeInTheDocument();+ });+it('opens the model catalog as a dropdown and selects a model', () => {const onChange = vi.fn();const onOpenEditor = vi.fn();