Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

feat: moved model settings to dropdownmenu (#637)

Vinit1d31116d7fd6
diff --git a/.changeset/agent-config-model-dropdown.md b/.changeset/agent-config-model-dropdown.md
deleted file mode 100644
index 418daf97c..000000000
--- a/.changeset/agent-config-model-dropdown.md
+++ /dev/null
@@ -1,6 +0,0 @@
----
-"@truefoundry/trueforge-ui": minor
----
-
-Open the Agent Config model picker as an inline dropdown instead of a separate modal.
-Search providers and models across the full catalog with normalized matching.
diff --git a/.changeset/agent-model-settings-dropdown.md b/.changeset/agent-model-settings-dropdown.md
new file mode 100644
index 000000000..0448e7eca
--- /dev/null
+++ b/.changeset/agent-model-settings-dropdown.md
@@ -0,0 +1,5 @@
+---
+"@truefoundry/trueforge-ui": minor
+---
+
+Open agent model settings inline and support typed custom model parameters.
diff --git a/packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsx b/packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsx
index 0b19f5eb3..cf31cdd69 100644
--- a/packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsx
+++ b/packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsx
@@ -205,7 +205,9 @@ export function AgentConfigPanel({
}: AgentConfigPanelProps) {
const Section = useSlot('AgentConfigSection');
const AgentModelEditorContent = useSlot('AgentModelEditorContent');
+ const AgentModelSettingsContent = useSlot('AgentModelSettingsContent');
const [modelMenuOpen, setModelMenuOpen] = useState(false);
+ const [modelSettingsMenuOpen, setModelSettingsMenuOpen] = useState(false);
const [modelQuery, setModelQuery] = useState('');
const mcp = editableMountsFromSpec(spec.mcpServers);
const skills = editableMountsFromSpec(spec.skills);
@@ -246,84 +248,94 @@ export function AgentConfigPanel({
</header>
<div className="min-h-0 flex-1 overflow-y-auto">
<Section>
- <DropdownMenu
- open={modelMenuOpen}
- onOpenChange={open => {
- setModelMenuOpen(open);
- if (!open) setModelQuery('');
- }}
- closeOnClick={false}
- align="start"
- containerClassName="flex w-full"
- className="w-[min(44rem,calc(100vw-2rem))] overflow-hidden p-0"
- trigger={
- <button
- type="button"
- aria-label="Edit Model"
- title="Edit Model"
- className="py-1 cursor-pointer flex w-full items-center gap-2 rounded-md text-left transition-colors"
- >
- <ProviderMark
- logo={model?.provider.logo}
- label={model?.provider.name ?? spec.model.name}
- className="size-4 text-[0.5rem]"
- />
- <span className="min-w-0 flex-1 truncate text-sm font-medium">
- {displayModelLabel(spec.model.name)}
- </span>
- {modelInfo.length ? (
- <span
- title={modelInfoTitle}
- className="text-text-secondary shrink-0 whitespace-nowrap text-[0.6875rem]"
- >
- {modelInfo.join(' · ')}
- </span>
- ) : null}
- <Icon name="chevrons-up-down" className="text-text-secondary size-3.5 shrink-0" />
- </button>
- }
- >
- <AgentModelEditorContent
- spec={spec}
- models={models}
- loading={modelsLoading}
- error={modelsError}
- query={modelQuery}
- onQueryChange={setModelQuery}
- onChange={next => {
- onChange?.(next);
- setModelMenuOpen(false);
- setModelQuery('');
+ <div className="flex w-full items-center gap-1">
+ <DropdownMenu
+ open={modelMenuOpen}
+ onOpenChange={open => {
+ setModelMenuOpen(open);
+ if (!open) setModelQuery('');
}}
- />
- </DropdownMenu>
- <div className="mt-2 flex items-center gap-2">
- <dl className="text-text-secondary flex min-w-0 flex-1 flex-wrap gap-x-3 gap-y-1 text-xs">
- {modelParams.length ? (
- modelParams.map(entry => (
- <div key={entry.label} className="flex gap-1">
- <dt>{entry.label}:</dt>
- <dd className="text-text-primary font-medium">{entry.value}</dd>
- </div>
- ))
- ) : (
- <div>model settings: defaults</div>
- )}
- </dl>
- <button
- type="button"
- aria-label="Model settings"
- title="Model settings"
- className={auiButtonClass({
- variant: 'ghost',
- size: 'icon',
- className: 'size-7 shrink-0 self-start',
- })}
- onClick={() => onOpenEditor('model-settings')}
+ closeOnClick={false}
+ align="start"
+ containerClassName="flex min-w-0 flex-1"
+ className="w-[min(44rem,calc(100vw-2rem))] overflow-hidden p-0"
+ trigger={
+ <button
+ type="button"
+ aria-label="Edit Model"
+ title="Edit Model"
+ className="flex w-full cursor-pointer items-center gap-2 rounded-md py-1 text-left transition-colors"
+ >
+ <ProviderMark
+ logo={model?.provider.logo}
+ label={model?.provider.name ?? spec.model.name}
+ className="size-4 text-[0.5rem]"
+ />
+ <span className="min-w-0 flex-1 truncate text-sm font-medium">
+ {displayModelLabel(spec.model.name)}
+ </span>
+ {modelInfo.length ? (
+ <span
+ title={modelInfoTitle}
+ className="text-text-secondary shrink-0 whitespace-nowrap text-[0.6875rem]"
+ >
+ {modelInfo.join(' · ')}
+ </span>
+ ) : null}
+ <Icon name="chevrons-up-down" className="text-text-secondary size-3.5 shrink-0" />
+ </button>
+ }
>
- <Icon name="sliders" className="size-3.5" />
- </button>
+ <AgentModelEditorContent
+ spec={spec}
+ models={models}
+ loading={modelsLoading}
+ error={modelsError}
+ query={modelQuery}
+ onQueryChange={setModelQuery}
+ onChange={next => {
+ onChange?.(next);
+ setModelMenuOpen(false);
+ setModelQuery('');
+ }}
+ />
+ </DropdownMenu>
+ <DropdownMenu
+ open={modelSettingsMenuOpen}
+ onOpenChange={setModelSettingsMenuOpen}
+ closeOnClick={false}
+ align="start"
+ className="w-[min(36rem,calc(100vw-2rem))] overflow-hidden p-0"
+ trigger={
+ <button
+ type="button"
+ aria-label="Model settings"
+ title="Model settings"
+ className={auiButtonClass({
+ variant: 'ghost',
+ size: 'icon',
+ className: 'size-7 shrink-0',
+ })}
+ >
+ <Icon name="sliders" className="size-3.5" />
+ </button>
+ }
+ >
+ <AgentModelSettingsContent spec={spec} model={model} onChange={next => onChange?.(next)} />
+ </DropdownMenu>
</div>
+ <dl className="text-text-secondary mt-2 flex min-w-0 flex-wrap gap-x-3 gap-y-1 text-xs">
+ {modelParams.length ? (
+ modelParams.map(entry => (
+ <div key={entry.label} className="flex gap-1">
+ <dt>{entry.label}:</dt>
+ <dd className="text-text-primary font-medium">{entry.value}</dd>
+ </div>
+ ))
+ ) : (
+ <div>model settings: defaults</div>
+ )}
+ </dl>
</Section>
<Section title="Instructions" description="Define the agent's role, goals, and behavior.">
diff --git a/packages/trueforge-ui/src/atoms/draft/AgentCustomParametersEditor.tsx b/packages/trueforge-ui/src/atoms/draft/AgentCustomParametersEditor.tsx
new file mode 100644
index 000000000..7e96f9de4
--- /dev/null
+++ b/packages/trueforge-ui/src/atoms/draft/AgentCustomParametersEditor.tsx
@@ -0,0 +1,262 @@
+'use client';
+
+import { useRef, useState } from 'react';
+
+import { Icon } from '../../icons/Icon.js';
+import { useSlot } from '../../theme/SlotsProvider.js';
+import { cn } from '../lib/cn.js';
+import { DropdownMenu, DropdownMenuItem } from '../primitives/DropdownMenu.js';
+
+type CustomParameterType = 'string' | 'number' | 'json';
+
+type CustomParameterDraft = {
+ id: string;
+ key: string;
+ type: CustomParameterType;
+ value: string;
+};
+
+export type AgentCustomParametersEditorProps = {
+ value: Record<string, unknown>;
+ reservedKeys: ReadonlySet<string>;
+ onChange: (value: Record<string, unknown>) => void;
+};
+
+function customParameterType(value: unknown): CustomParameterType {
+ if (typeof value === 'string') return 'string';
+ if (typeof value === 'number') return 'number';
+ return 'json';
+}
+
+function customParameterValue(value: unknown, type: CustomParameterType): string {
+ if (type === 'string') return typeof value === 'string' ? value : '';
+ if (type === 'number') return typeof value === 'number' ? String(value) : '';
+ return JSON.stringify(value, null, 2) ?? 'null';
+}
+
+function emptyCustomDraft(id: string): CustomParameterDraft {
+ return { id, key: '', type: 'string', value: '' };
+}
+
+function customDraftsFrom(value: Record<string, unknown>): CustomParameterDraft[] {
+ return Object.entries(value).map(([key, entryValue], index) => {
+ const type = customParameterType(entryValue);
+ return {
+ id: `existing-${index}-${key}`,
+ key,
+ type,
+ value: customParameterValue(entryValue, type),
+ };
+ });
+}
+
+function initialCustomDrafts(value: Record<string, unknown>): CustomParameterDraft[] {
+ const drafts = customDraftsFrom(value);
+ return drafts.length > 0 ? drafts : [emptyCustomDraft('new-0')];
+}
+
+function parseCustomValue(
+ draft: CustomParameterDraft,
+): { valid: true; value: unknown } | { valid: false; error: string } {
+ if (draft.type === 'string') return { valid: true, value: draft.value };
+ if (draft.type === 'number') {
+ const value = Number(draft.value);
+ return draft.value.trim() === '' || !Number.isFinite(value)
+ ? { valid: false, error: 'Enter a valid number.' }
+ : { valid: true, value };
+ }
+ try {
+ const value: unknown = JSON.parse(draft.value);
+ return { valid: true, value };
+ } catch {
+ return { valid: false, error: 'Enter valid JSON.' };
+ }
+}
+
+function customDraftError({
+ draft,
+ drafts,
+ reservedKeys,
+}: {
+ draft: CustomParameterDraft;
+ drafts: CustomParameterDraft[];
+ reservedKeys: ReadonlySet<string>;
+}): string | null {
+ const key = draft.key.trim();
+ if (key === '') return 'Enter a parameter name.';
+ if (reservedKeys.has(key)) return 'This parameter already has a dedicated control.';
+ if (drafts.some(candidate => candidate.id !== draft.id && candidate.key.trim() === key)) {
+ return 'Parameter names must be unique.';
+ }
+ const parsed = parseCustomValue(draft);
+ return parsed.valid ? null : parsed.error;
+}
+
+function customParameterTypeMark(type: CustomParameterType): string {
+ if (type === 'string') return 'Aa';
+ if (type === 'number') return '#';
+ return '{ }';
+}
+
+export function AgentCustomParametersEditor({ value, reservedKeys, onChange }: AgentCustomParametersEditorProps) {
+ const CodeEditor = useSlot('CodeEditor');
+ const [drafts, setDrafts] = useState(() => initialCustomDrafts(value));
+ const nextId = useRef(drafts.length);
+
+ const commitDrafts = (nextDrafts: CustomParameterDraft[]) => {
+ if (nextDrafts.some(draft => customDraftError({ draft, drafts: nextDrafts, reservedKeys }) !== null)) {
+ return;
+ }
+ const entries: Array<[string, unknown]> = [];
+ nextDrafts.forEach(draft => {
+ const parsed = parseCustomValue(draft);
+ if (parsed.valid) entries.push([draft.key.trim(), parsed.value]);
+ });
+ onChange(Object.fromEntries(entries));
+ };
+
+ const updateDraft = ({
+ id,
+ patch,
+ }: {
+ id: string;
+ patch: Partial<Pick<CustomParameterDraft, 'key' | 'type' | 'value'>>;
+ }) => {
+ const next = drafts.map(draft => (draft.id === id ? { ...draft, ...patch } : draft));
+ setDrafts(next);
+ commitDrafts(next);
+ };
+
+ const removeDraft = (id: string) => {
+ const next = drafts.filter(draft => draft.id !== id);
+ const replacementId = `new-${nextId.current}`;
+ nextId.current += 1;
+ setDrafts(next.length > 0 ? next : [emptyCustomDraft(replacementId)]);
+ commitDrafts(next);
+ };
+
+ return (
+ <div className="space-y-2">
+ {drafts.map(draft => {
+ const error = customDraftError({ draft, drafts, reservedKeys });
+ const visibleError = draft.key.trim() === '' ? null : error;
+ return (
+ <div key={draft.id}>
+ <div className="flex items-center">
+ <div
+ className={cn(
+ 'bg-secondary-button-bg flex min-w-0 flex-1 items-stretch overflow-hidden rounded-md border border-input-border',
+ draft.type === 'json' && 'rounded-b-none',
+ visibleError && 'border-failure-bg',
+ )}
+ >
+ <input
+ value={draft.key}
+ aria-label="Custom parameter name"
+ placeholder="Key"
+ className="text-text-primary placeholder:text-text-secondary h-8 min-w-0 flex-1 border-0 border-r border-input-border bg-transparent px-3 text-sm outline-none"
+ onChange={event => updateDraft({ id: draft.id, patch: { key: event.target.value } })}
+ />
+ {draft.type !== 'json' ? (
+ <input
+ type={draft.type === 'number' ? 'number' : 'text'}
+ value={draft.value}
+ aria-label={`Value for ${draft.key || 'custom parameter'}`}
+ placeholder="Value"
+ className="text-text-primary placeholder:text-text-secondary h-8 min-w-0 flex-1 border-0 bg-transparent px-3 text-sm outline-none"
+ onChange={event => updateDraft({ id: draft.id, patch: { value: event.target.value } })}
+ />
+ ) : null}
+ <DropdownMenu
+ align="end"
+ className="w-32"
+ trigger={
+ <button
+ type="button"
+ aria-label={`Type for ${draft.key || 'custom parameter'}`}
+ title={draft.type === 'string' ? 'String' : draft.type === 'number' ? 'Number' : 'JSON'}
+ className="text-text-secondary hover:bg-ghost-button-hover flex h-8 w-12 shrink-0 items-center justify-center gap-1 border-l border-input-border text-xs font-semibold"
+ >
+ <span>{customParameterTypeMark(draft.type)}</span>
+ <Icon name="chevron-down" className="size-3" />
+ </button>
+ }
+ >
+ {(['string', 'number', 'json'] as const).map(type => (
+ <DropdownMenuItem
+ key={type}
+ aria-selected={draft.type === type}
+ onClick={() =>
+ updateDraft({
+ id: draft.id,
+ patch: {
+ type,
+ value: type === 'number' ? '0' : type === 'json' ? '{}' : '',
+ },
+ })
+ }
+ >
+ <span aria-hidden className="w-5 text-center font-semibold">
+ {customParameterTypeMark(type)}
+ </span>
+ {type === 'string' ? 'String' : type === 'number' ? 'Number' : 'JSON'}
+ </DropdownMenuItem>
+ ))}
+ </DropdownMenu>
+ </div>
+ <div className="ml-3 flex items-center gap-3">
+ <button
+ type="button"
+ aria-label={`Remove ${draft.key || 'custom parameter'}`}
+ className="text-failure-bg border-failure-bg flex size-5 items-center justify-center rounded-full border text-sm leading-none"
+ onClick={() => removeDraft(draft.id)}
+ >
+ <span aria-hidden>−</span>
+ </button>
+ <button
+ type="button"
+ aria-label="Add parameter"
+ className={cn(
+ 'text-text-secondary flex size-5 items-center justify-center rounded-full border border-current',
+ draft.id !== drafts.at(-1)?.id && 'invisible',
+ )}
+ onClick={() => {
+ const id = `new-${nextId.current}`;
+ nextId.current += 1;
+ const index = drafts.findIndex(candidate => candidate.id === draft.id);
+ const next = [...drafts];
+ next.splice(index + 1, 0, emptyCustomDraft(id));
+ setDrafts(next);
+ }}
+ >
+ <Icon name="plus" className="size-3" />
+ </button>
+ </div>
+ </div>
+ {draft.type === 'json' ? (
+ <CodeEditor
+ value={draft.value}
+ language="json"
+ height="8rem"
+ showToolbar={false}
+ className={cn('mr-16 h-32 rounded-t-none border-t-0', visibleError && 'border-failure-bg')}
+ onChange={entryValue => {
+ if (entryValue !== undefined) {
+ updateDraft({ id: draft.id, patch: { value: entryValue } });
+ }
+ }}
+ />
+ ) : null}
+ {visibleError ? <p className="text-failure-bg mt-1 text-xs">{visibleError}</p> : null}
+ </div>
+ );
+ })}
+ </div>
+ );
+}
+
+declare module '../../theme/SlotsProvider.js' {
+ interface AtomSlots {
+ AgentCustomParametersEditor: typeof AgentCustomParametersEditor;
+ }
+}
diff --git a/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx b/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx
index 996462496..d7d548f99 100644
--- a/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx
+++ b/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx
@@ -1,10 +1,12 @@
'use client';
-import type { ReactNode } from 'react';
+import { useRef, useState, type ReactNode } from 'react';
import type { AgentSpec, ModelParams, ModelSelection } from '../../server/types.js';
+import { useSlot } from '../../theme/SlotsProvider.js';
+import { auiButtonClass } from '../lib/buttonClasses.js';
+import { cn } from '../lib/cn.js';
import { auiInputClass } from '../lib/inputClasses.js';
-import { Switch } from '../primitives/Switch.js';
export type AgentModelSettingsContentProps = {
spec: AgentSpec;
@@ -12,18 +14,108 @@ export type AgentModelSettingsContentProps = {
onChange: (spec: AgentSpec) => void;
};
+enum ParamsView {
+ UI = 'ui',
+ JSON = 'json',
+}
+
+const CONTROLLED_PARAM_KEYS = new Set(['maxTokens', 'reasoningEffort']);
+
function finiteNumber(raw: string): number | null {
if (raw.trim() === '') return null;
const value = Number(raw);
return Number.isFinite(value) ? value : null;
}
+function isRecord(value: unknown): value is Record<string, unknown> {
+ return typeof value === 'object' && value !== null && !Array.isArray(value);
+}
+
+function isModelParams(value: unknown): value is ModelParams {
+ if (!isRecord(value)) return false;
+ const maxTokens = value['maxTokens'];
+ const reasoningEffort = value['reasoningEffort'];
+ return (
+ (maxTokens === undefined || (typeof maxTokens === 'number' && Number.isFinite(maxTokens))) &&
+ (reasoningEffort === undefined || typeof reasoningEffort === 'string')
+ );
+}
+
+function customParamsFrom(params: ModelParams): Record<string, unknown> {
+ return Object.fromEntries(
+ Object.entries(params).filter(([key, value]) => !CONTROLLED_PARAM_KEYS.has(key) && value !== undefined),
+ );
+}
+
+function formatParams(params: ModelParams): string {
+ return JSON.stringify(params, null, 2);
+}
+
export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelSettingsContentProps) {
+ const CodeEditor = useSlot('CodeEditor');
+ const AgentCustomParametersEditor = useSlot('AgentCustomParametersEditor');
+
const params = spec.model.params ?? {};
+ const [view, setView] = useState<ParamsView>(ParamsView.UI);
+ const [jsonValue, setJsonValue] = useState(() => formatParams(params));
+ const [jsonError, setJsonError] = useState<string | null>(null);
+ const [customEnabled, setCustomEnabled] = useState(() => Object.keys(customParamsFrom(params)).length > 0);
+
+ const savedCustomParams = useRef<Record<string, unknown> | null>(null);
const replaceParams = (next: ModelParams) => onChange({ ...spec, model: { ...spec.model, params: next } });
const setParam = <Key extends keyof ModelParams>(key: Key, value: ModelParams[Key]) =>
replaceParams({ ...params, [key]: value });
const removeParam = (key: keyof ModelParams) => replaceParams({ ...params, [key]: undefined });
+
+ const replaceCustomParams = (custom: Record<string, unknown>) => {
+ const clearedCustom = Object.fromEntries(Object.keys(customParamsFrom(params)).map(key => [key, undefined]));
+ replaceParams({ ...params, ...clearedCustom, ...custom });
+ };
+
+ const replaceAllParams = (next: ModelParams) => {
+ const cleared = Object.fromEntries(
+ Object.keys(params)
+ .filter(key => !Object.hasOwn(next, key))
+ .map(key => [key, undefined]),
+ );
+ replaceParams({ ...cleared, ...next });
+ };
+
+ const setParamsView = (nextView: ParamsView) => {
+ setView(nextView);
+ setJsonError(null);
+ if (nextView === ParamsView.JSON) setJsonValue(formatParams(params));
+ };
+
+ const handleJsonChange = (value: string | undefined) => {
+ if (value === undefined) return;
+ setJsonValue(value);
+ try {
+ const parsed: unknown = JSON.parse(value);
+ if (!isModelParams(parsed)) {
+ setJsonError('Parameters must be a JSON object with valid model parameter values.');
+ return;
+ }
+ setJsonError(null);
+ setCustomEnabled(Object.keys(customParamsFrom(parsed)).length > 0);
+ replaceAllParams(parsed);
+ } catch {
+ setJsonError('Invalid JSON.');
+ }
+ };
+
+ const toggleCustomParams = () => {
+ const nextEnabled = !customEnabled;
+ setCustomEnabled(nextEnabled);
+ if (nextEnabled) {
+ const restored = savedCustomParams.current ?? {};
+ replaceCustomParams(restored);
+ return;
+ }
+ savedCustomParams.current = customParamsFrom(params);
+ replaceCustomParams({});
+ };
+
const maxOutputTokens = model?.properties.maxOutputTokens;
const reasoningEfforts = model?.properties.reasoningEfforts ?? [];
const firstReasoningEffort = reasoningEfforts[0];
@@ -41,13 +133,12 @@ export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelS
enabled: params.maxTokens !== undefined,
onToggle: enabled => (enabled ? setParam('maxTokens', maxOutputTokens) : removeParam('maxTokens')),
control: (
- <div className="mt-2 flex items-center gap-3">
+ <div className="flex items-center gap-3">
<input
type="range"
min={1}
max={maxOutputTokens}
value={params.maxTokens ?? maxOutputTokens}
- disabled={params.maxTokens === undefined}
aria-label="Maximum tokens slider"
className="min-w-0 flex-1 accent-primary-button-bg"
onChange={event => {
@@ -60,7 +151,6 @@ export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelS
min={1}
max={maxOutputTokens}
value={params.maxTokens ?? maxOutputTokens}
- disabled={params.maxTokens === undefined}
aria-label="Maximum tokens value"
className={auiInputClass('h-8 w-24')}
onChange={event => {
@@ -82,9 +172,8 @@ export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelS
control: (
<select
value={params.reasoningEffort ?? ''}
- disabled={params.reasoningEffort === undefined}
aria-label="Reasoning effort value"
- className={auiInputClass('mt-2 h-8 cursor-pointer py-1.5')}
+ className={auiInputClass('h-8 cursor-pointer py-1.5')}
onChange={event => setParam('reasoningEffort', event.target.value)}
>
{reasoningEfforts.map(effort => (
@@ -98,21 +187,88 @@ export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelS
}
return (
- <div className="w-full p-5">
- {rows.length > 0 ? (
- <div className="divide-y divide-border">
- {rows.map(row => (
- <div key={row.label} className="py-3">
+ <div className="w-full">
+ <div className="flex items-center justify-between gap-3 border-b border-border px-4 py-3">
+ <h3 className="text-text-primary text-sm font-semibold">Parameters</h3>
+ <div className="bg-secondary-button-bg flex rounded-md border border-input-border p-0.5">
+ {Object.values(ParamsView).map(value => (
+ <button
+ key={value}
+ type="button"
+ aria-pressed={view === value}
+ className={cn(
+ 'min-w-10 rounded px-2 py-1 text-xs font-medium transition-colors',
+ view === value
+ ? 'bg-primary-button-bg text-primary-button-text'
+ : 'text-text-secondary hover:text-text-primary',
+ )}
+ onClick={() => setParamsView(value)}
+ >
+ {value === ParamsView.UI ? 'UI' : 'JSON'}
+ </button>
+ ))}
+ </div>
+ </div>
+
+ {view === ParamsView.UI ? (
+ <div className="max-h-[min(30rem,calc(100dvh-8rem))] overflow-y-auto px-4">
+ <div className="divide-y divide-border">
+ {rows.map(row => (
+ <div key={row.label} className="py-3">
+ <div className="flex items-center justify-between gap-3">
+ <span className="text-text-primary text-sm font-medium">{row.label}</span>
+ <button
+ type="button"
+ aria-label={`Turn ${row.label} ${row.enabled ? 'off' : 'on'}`}
+ aria-pressed={row.enabled}
+ className={auiButtonClass({ variant: 'ghost', size: 'small' })}
+ onClick={() => row.onToggle(!row.enabled)}
+ >
+ {row.enabled ? 'On' : 'Off'}
+ </button>
+ </div>
+ {row.enabled ? <div className="mt-2">{row.control}</div> : null}
+ </div>
+ ))}
+
+ <div className="py-3">
<div className="flex items-center justify-between gap-3">
- <span className="text-text-primary text-sm font-medium">{row.label}</span>
- <Switch checked={row.enabled} onCheckedChange={row.onToggle} aria-label={`Enable ${row.label}`} />
+ <span className="text-text-primary text-sm font-medium">Custom Parameters</span>
+ <button
+ type="button"
+ aria-label={`Turn Custom Parameters ${customEnabled ? 'off' : 'on'}`}
+ aria-pressed={customEnabled}
+ className={auiButtonClass({ variant: 'ghost', size: 'small' })}
+ onClick={toggleCustomParams}
+ >
+ {customEnabled ? 'On' : 'Off'}
+ </button>
</div>
- {row.control}
+
+ {customEnabled ? (
+ <div className="mt-3 mb-2">
+ <AgentCustomParametersEditor
+ value={customParamsFrom(params)}
+ reservedKeys={CONTROLLED_PARAM_KEYS}
+ onChange={replaceCustomParams}
+ />
+ </div>
+ ) : null}
</div>
- ))}
+ </div>
</div>
) : (
- <p className="text-text-secondary text-sm">No configurable parameters are available for this model.</p>
+ <div className="min-h-88 p-4">
+ <CodeEditor
+ value={jsonValue}
+ language="json"
+ height="20rem"
+ showToolbar={false}
+ className={cn('h-80', jsonError && 'border-failure-bg')}
+ onChange={handleJsonChange}
+ />
+ {jsonError ? <p className="text-failure-bg mt-2 text-sm font-medium">{jsonError}</p> : null}
+ </div>
)}
</div>
);
diff --git a/packages/trueforge-ui/src/atoms/primitives/DropdownMenu.tsx b/packages/trueforge-ui/src/atoms/primitives/DropdownMenu.tsx
index 9d7b4411a..b8f49807b 100644
--- a/packages/trueforge-ui/src/atoms/primitives/DropdownMenu.tsx
+++ b/packages/trueforge-ui/src/atoms/primitives/DropdownMenu.tsx
@@ -159,6 +159,7 @@ export function DropdownMenu({
'text-text-primary shadow-md',
className,
)}
+ onMouseDown={event => event.stopPropagation()}
onClick={closeOnClick ? () => setOpen(false) : undefined}
>
{children}
diff --git a/packages/trueforge-ui/src/index.ts b/packages/trueforge-ui/src/index.ts
index 2b284bc9a..b119b4e57 100644
--- a/packages/trueforge-ui/src/index.ts
+++ b/packages/trueforge-ui/src/index.ts
@@ -465,6 +465,8 @@ export { AgentConfigEditors } from './atoms/draft/AgentConfigEditors.js';
export type { AgentConfigEditor, AgentConfigEditorsProps } from './atoms/draft/AgentConfigEditors.js';
export { AgentConfigPanel, AgentConfigSection } from './atoms/draft/AgentConfigPanel.js';
export type { AgentConfigPanelProps } from './atoms/draft/AgentConfigPanel.js';
+export { AgentCustomParametersEditor } from './atoms/draft/AgentCustomParametersEditor.js';
+export type { AgentCustomParametersEditorProps } from './atoms/draft/AgentCustomParametersEditor.js';
export { AgentInstructionsDrawer } from './atoms/draft/AgentInstructionsDrawer.js';
export type { AgentInstructionsDrawerProps } from './atoms/draft/AgentInstructionsDrawer.js';
export { AgentMcpEditorContent } from './atoms/draft/AgentMcpEditorContent.js';
diff --git a/packages/trueforge-ui/src/theme/defaultSlots.ts b/packages/trueforge-ui/src/theme/defaultSlots.ts
index e90eea4ff..abd96b428 100644
--- a/packages/trueforge-ui/src/theme/defaultSlots.ts
+++ b/packages/trueforge-ui/src/theme/defaultSlots.ts
@@ -43,6 +43,7 @@ import { ComposerLeftSection, ComposerRightSection, ComposerSendButton } from '.
import { ComposerShell } from '../atoms/ComposerShell.js';
import { AgentConfigEditors } from '../atoms/draft/AgentConfigEditors.js';
import { AgentConfigPanel, AgentConfigSection } from '../atoms/draft/AgentConfigPanel.js';
+import { AgentCustomParametersEditor } from '../atoms/draft/AgentCustomParametersEditor.js';
import { AgentInstructionsDrawer } from '../atoms/draft/AgentInstructionsDrawer.js';
import { AgentMcpEditorContent } from '../atoms/draft/AgentMcpEditorContent.js';
import { AgentModelConfigModal } from '../atoms/draft/AgentModelConfigModal.js';
@@ -145,6 +146,7 @@ export const defaultSlots = {
DraftComposerRightSection,
DraftAgentConfigTrigger,
DraftCapabilitiesPanel,
+ AgentCustomParametersEditor,
AgentConfigEditors,
AgentInstructionsDrawer,
AgentModelEditorContent,
diff --git a/packages/trueforge-ui/test/atoms/draft/AgentConfigEditors.test.tsx b/packages/trueforge-ui/test/atoms/draft/AgentConfigEditors.test.tsx
index 85704b88d..d5d0acb33 100644
--- a/packages/trueforge-ui/test/atoms/draft/AgentConfigEditors.test.tsx
+++ b/packages/trueforge-ui/test/atoms/draft/AgentConfigEditors.test.tsx
@@ -3,10 +3,17 @@ import { fireEvent, render, screen, waitFor } from '@testing-library/react';
import { beforeAll, describe, expect, it, vi } from 'vitest';
import { AgentConfigEditors } from '@/atoms/draft/AgentConfigEditors.js';
+import { AgentModelSettingsContent } from '@/atoms/draft/AgentModelSettingsContent.js';
import { withInitialUserMessages } from '@/atoms/draft/agentConfigMessages.js';
import type { AgentSpec } from '@/server/types.js';
import { SlotsProvider } from '@/theme/SlotsProvider.js';
+vi.mock('@/atoms/MonacoEditorCore.js', () => ({
+ MonacoEditorCore: ({ value, onChange }: { value: string; onChange?: (value: string) => void }) => (
+ <textarea aria-label="JSON parameters editor" value={value} onChange={event => onChange?.(event.target.value)} />
+ ),
+}));
+
beforeAll(() => {
HTMLDialogElement.prototype.showModal = function showModal() {
this.setAttribute('open', '');
@@ -155,7 +162,7 @@ describe('AgentConfigEditors', () => {
expect(screen.getByText('Context')).toBeInTheDocument();
});
- it('uses toggles and sliders for model settings', () => {
+ it('uses On and Off controls with sliders for model settings', () => {
const spec: AgentSpec = { model: { name: 'openai/gpt' } };
const onChange = vi.fn();
render(
@@ -181,14 +188,14 @@ describe('AgentConfigEditors', () => {
</SlotsProvider>,
);
- fireEvent.click(screen.getByRole('switch', { name: 'Enable Maximum Tokens' }));
+ fireEvent.click(screen.getByRole('button', { name: 'Turn Maximum Tokens on' }));
expect(onChange).toHaveBeenCalledWith({
...spec,
model: { ...spec.model, params: { maxTokens: 8192 } },
});
- expect(screen.queryByRole('button', { name: 'JSON' })).not.toBeInTheDocument();
- expect(screen.queryByRole('switch', { name: 'Enable Temperature' })).not.toBeInTheDocument();
- expect(screen.queryByRole('switch', { name: 'Parallel tool calls' })).not.toBeInTheDocument();
+ expect(screen.getByRole('button', { name: 'JSON' })).toBeInTheDocument();
+ expect(screen.queryByText('Temperature')).not.toBeInTheDocument();
+ expect(screen.queryByText('Parallel tool calls')).not.toBeInTheDocument();
});
it('explicitly clears a model parameter when its toggle is disabled', () => {
@@ -222,7 +229,7 @@ describe('AgentConfigEditors', () => {
</SlotsProvider>,
);
- fireEvent.click(screen.getByRole('switch', { name: 'Enable Maximum Tokens' }));
+ fireEvent.click(screen.getByRole('button', { name: 'Turn Maximum Tokens off' }));
expect(onChange).toHaveBeenCalledWith({
...spec,
model: {
@@ -232,6 +239,142 @@ describe('AgentConfigEditors', () => {
});
});
+ it('edits the complete parameter object in JSON view and rejects invalid JSON', () => {
+ const spec: AgentSpec = {
+ model: {
+ name: 'openai/gpt',
+ params: { maxTokens: 4096 },
+ },
+ };
+ const expectedParams = { maxTokens: 2048, vendor_option: { mode: 'fast' } };
+ const onChange = vi.fn();
+ render(
+ <SlotsProvider>
+ <AgentConfigEditors
+ editor="model-settings"
+ spec={spec}
+ models={[
+ {
+ id: 'openai/gpt',
+ name: 'openai/gpt',
+ provider: { name: 'OpenAI' },
+ properties: { maxOutputTokens: 8_192 },
+ },
+ ]}
+ connectors={[]}
+ skills={[]}
+ loading={false}
+ error={null}
+ onChange={onChange}
+ onClose={vi.fn()}
+ />
+ </SlotsProvider>,
+ );
+
+ fireEvent.click(screen.getByRole('button', { name: 'JSON' }));
+ const editor = screen.getByRole('textbox', { name: 'JSON parameters editor' });
+ expect(editor.closest('.aui-code-editor')).toHaveClass('h-80');
+ fireEvent.change(editor, {
+ target: { value: '{"maxTokens":2048,"vendor_option":{"mode":"fast"}}' },
+ });
+
+ expect(onChange).toHaveBeenLastCalledWith({
+ ...spec,
+ model: {
+ ...spec.model,
+ params: expectedParams,
+ },
+ });
+
+ onChange.mockClear();
+ fireEvent.change(editor, { target: { value: '{"maxTokens":' } });
+ expect(screen.getByText('Invalid JSON.')).toBeInTheDocument();
+ expect(onChange).not.toHaveBeenCalled();
+ });
+
+ it('adds typed custom parameters without replacing dedicated controls', () => {
+ const spec: AgentSpec = {
+ model: {
+ name: 'openai/gpt',
+ params: { maxTokens: 4096 },
+ },
+ };
+ const expectedParams = { maxTokens: 4096, vendor_option: 42 };
+ const onChange = vi.fn();
+ render(
+ <SlotsProvider>
+ <AgentConfigEditors
+ editor="model-settings"
+ spec={spec}
+ models={[
+ {
+ id: 'openai/gpt',
+ name: 'openai/gpt',
+ provider: { name: 'OpenAI' },
+ properties: { maxOutputTokens: 8_192 },
+ },
+ ]}
+ connectors={[]}
+ skills={[]}
+ loading={false}
+ error={null}
+ onChange={onChange}
+ onClose={vi.fn()}
+ />
+ </SlotsProvider>,
+ );
+
+ fireEvent.click(screen.getByRole('button', { name: 'Turn Custom Parameters on' }));
+ fireEvent.change(screen.getByRole('textbox', { name: 'Custom parameter name' }), {
+ target: { value: 'vendor_option' },
+ });
+
+ const typeSelect = screen.getByRole('button', { name: 'Type for vendor_option' });
+ fireEvent.click(typeSelect);
+ expect(screen.getByRole('menuitem', { name: 'String' })).toBeInTheDocument();
+ expect(screen.getByRole('menuitem', { name: 'Number' })).toBeInTheDocument();
+ expect(screen.getByRole('menuitem', { name: 'JSON' })).toBeInTheDocument();
+
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Number' }));
+ fireEvent.change(screen.getByRole('spinbutton', { name: 'Value for vendor_option' }), {
+ target: { value: '42' },
+ });
+
+ expect(onChange).toHaveBeenLastCalledWith({
+ ...spec,
+ model: {
+ ...spec.model,
+ params: expectedParams,
+ },
+ });
+
+ fireEvent.click(screen.getByRole('button', { name: 'Type for vendor_option' }));
+ fireEvent.click(screen.getByRole('menuitem', { name: 'JSON' }));
+ expect(screen.getByRole('textbox', { name: 'JSON parameters editor' }).closest('.aui-code-editor')).toHaveClass(
+ 'h-32',
+ );
+ expect(screen.getByRole('button', { name: 'Add parameter' })).toBeInTheDocument();
+ });
+
+ it('preserves prototype-named custom parameters as own properties', () => {
+ const onChange = vi.fn();
+ const params = Object.fromEntries([['__proto__', 'initial']]);
+ render(
+ <SlotsProvider>
+ <AgentModelSettingsContent spec={{ model: { name: 'openai/gpt', params } }} onChange={onChange} />
+ </SlotsProvider>,
+ );
+
+ expect(screen.getByRole('textbox', { name: 'Custom parameter name' })).toHaveValue('__proto__');
+ fireEvent.change(screen.getByRole('textbox', { name: 'Value for __proto__' }), {
+ target: { value: 'updated' },
+ });
+
+ const changedParams = onChange.mock.lastCall?.[0].model.params;
+ expect(Object.hasOwn(changedParams ?? {}, '__proto__')).toBe(true);
+ expect(changedParams?.['__proto__']).toBe('updated');
+ });
+
it('opens runtime configuration in a right-side drawer', () => {
const spec: AgentSpec = { model: { name: 'openai/gpt' } };
render(
diff --git a/packages/trueforge-ui/test/atoms/draft/AgentConfigPanel.test.tsx b/packages/trueforge-ui/test/atoms/draft/AgentConfigPanel.test.tsx
index 6f7860599..67f3ad61b 100644
--- a/packages/trueforge-ui/test/atoms/draft/AgentConfigPanel.test.tsx
+++ b/packages/trueforge-ui/test/atoms/draft/AgentConfigPanel.test.tsx
@@ -110,7 +110,9 @@ describe('AgentConfigPanel', () => {
);
fireEvent.click(screen.getByRole('button', { name: 'Model settings' }));
- expect(onOpenEditor).toHaveBeenCalledWith('model-settings');
+ expect(screen.getByRole('menu')).toBeInTheDocument();
+ expect(screen.getByRole('heading', { name: 'Parameters' })).toBeInTheDocument();
+ expect(onOpenEditor).not.toHaveBeenCalledWith('model-settings');
fireEvent.click(screen.getByRole('button', { name: 'Edit Runtime Config' }));
expect(onOpenEditor).toHaveBeenCalledWith('runtime');
@@ -154,6 +156,35 @@ describe('AgentConfigPanel', () => {
expect(screen.queryByRole('menu')).not.toBeInTheDocument();
});
+ it('places model settings beside the model selector and opens it independently', () => {
+ const onOpenEditor = vi.fn();
+ render(
+ <SlotsProvider>
+ <AgentConfigPanel
+ spec={spec}
+ model={model}
+ {...catalogProps}
+ skillsAvailable
+ instructions={spec.instructions ?? ''}
+ onOpenEditor={onOpenEditor}
+ onChange={vi.fn()}
+ />
+ </SlotsProvider>,
+ );
+
+ const modelTrigger = screen.getByRole('button', { name: 'Edit Model' });
+ const settingsTrigger = screen.getByRole('button', { name: 'Model settings' });
+ const modelDropdown = modelTrigger.parentElement?.parentElement;
+ const settingsDropdown = settingsTrigger.parentElement?.parentElement;
+
+ expect(modelDropdown?.parentElement).toBe(settingsDropdown?.parentElement);
+
+ fireEvent.click(settingsTrigger);
+ expect(screen.getByRole('menu')).toBeInTheDocument();
+ expect(screen.queryByText('Select model')).not.toBeInTheDocument();
+ expect(onOpenEditor).not.toHaveBeenCalled();
+ });
+
it('previews instructions and summarizes initial user messages', () => {
const specWithMessages = withInitialUserMessages({
spec,
diff --git a/packages/trueforge-ui/test/atoms/primitives/DropdownMenu.test.tsx b/packages/trueforge-ui/test/atoms/primitives/DropdownMenu.test.tsx
index 971f180b5..be880db95 100644
--- a/packages/trueforge-ui/test/atoms/primitives/DropdownMenu.test.tsx
+++ b/packages/trueforge-ui/test/atoms/primitives/DropdownMenu.test.tsx
@@ -148,6 +148,28 @@ describe('DropdownMenu', () => {
expect(screen.getByRole('menu')).toBeInTheDocument();
});
+ it('keeps a parent menu open while selecting from a nested portaled menu', () => {
+ const onSelect = vi.fn();
+ render(
+ <DropdownMenu closeOnClick={false} trigger={<button>Settings</button>}>
+ <DropdownMenu trigger={<button>Type</button>}>
+ <DropdownMenuItem onClick={onSelect}>JSON</DropdownMenuItem>
+ </DropdownMenu>
+ </DropdownMenu>,
+ );
+
+ fireEvent.click(screen.getByRole('button', { name: 'Settings' }));
+ fireEvent.click(screen.getByRole('button', { name: 'Type' }));
+
+ const nestedItem = screen.getByRole('menuitem', { name: 'JSON' });
+ fireEvent.mouseDown(nestedItem);
+ fireEvent.click(nestedItem);
+
+ expect(onSelect).toHaveBeenCalledOnce();
+ expect(screen.getAllByRole('menu')).toHaveLength(1);
+ expect(screen.getByRole('button', { name: 'Settings' })).toHaveAttribute('aria-expanded', 'true');
+ });
+
it('supports controlled open state', () => {
const onOpenChange = vi.fn();
const { rerender } = render(
diff --git a/packages/trueforge-ui/test/publicUiExports.test.ts b/packages/trueforge-ui/test/publicUiExports.test.ts
index 326aec585..5f4560117 100644
--- a/packages/trueforge-ui/test/publicUiExports.test.ts
+++ b/packages/trueforge-ui/test/publicUiExports.test.ts
@@ -7,6 +7,7 @@ const expectedRuntimeExports: Array<keyof typeof sdk> = [
'AgentConfigEditors',
'AgentConfigPanel',
'AgentConfigSection',
+ 'AgentCustomParametersEditor',
'AgentDetailsHeader',
'AgentDetailsPage',
'AgentDetailsTabs',