The open-source agent harness - the runtime layer that turns an LLM into a working agent.
Chore/gv/UI feedbacks sep 9 (#643)
Govinda Vashishtha26a9b80398ba
diff --git a/.changeset/add-agent-schedules-tab.md b/.changeset/add-agent-schedules-tab.mdnew file mode 100644index 000000000..b057195f1--- /dev/null+++ b/.changeset/add-agent-schedules-tab.md@@ -0,0 +1,5 @@+---+"@truefoundry/trueforge-ui": patch+---++Add an agent-scoped Schedules tab and route library schedule actions into it.diff --git a/.changeset/allow-attachment-only-messages.md b/.changeset/allow-attachment-only-messages.mdnew file mode 100644index 000000000..64974f155--- /dev/null+++ b/.changeset/allow-attachment-only-messages.md@@ -0,0 +1,5 @@+---+"@truefoundry/trueforge-ui": patch+---++Allow sending user messages that contain attachments without text.diff --git a/.changeset/build-agent-from-schedule-picker.md b/.changeset/build-agent-from-schedule-picker.mdnew file mode 100644index 000000000..79f33f302--- /dev/null+++ b/.changeset/build-agent-from-schedule-picker.md@@ -0,0 +1,5 @@+---+"@truefoundry/trueforge-ui": patch+---++Add an empty state and Build Agent action to the schedule agent picker.diff --git a/.changeset/correct-builder-timeline-controls.md b/.changeset/correct-builder-timeline-controls.mdnew file mode 100644index 000000000..ac8a49b3c--- /dev/null+++ b/.changeset/correct-builder-timeline-controls.md@@ -0,0 +1,5 @@+---+"@truefoundry/trueforge-ui": patch+---++Hide model selection in the Build Agent composer and correct concurrent sub-agent timeline bars.diff --git a/.changeset/direct-runtime-switch-clicks.md b/.changeset/direct-runtime-switch-clicks.mdnew file mode 100644index 000000000..69a6be81d--- /dev/null+++ b/.changeset/direct-runtime-switch-clicks.md@@ -0,0 +1,5 @@+---+"@truefoundry/trueforge-ui": patch+---++Require direct switch clicks in the Runtime Config sidebar.diff --git a/.changeset/plain-agent-names.md b/.changeset/plain-agent-names.mdnew file mode 100644index 000000000..d6391a643--- /dev/null+++ b/.changeset/plain-agent-names.md@@ -0,0 +1,5 @@+---+"@truefoundry/trueforge-ui": patch+---++Show agent names without an icon in the Agents table.diff --git a/.changeset/weekly-days-before-time.md b/.changeset/weekly-days-before-time.mdnew file mode 100644index 000000000..7b3772dbd--- /dev/null+++ b/.changeset/weekly-days-before-time.md@@ -0,0 +1,5 @@+---+"@truefoundry/trueforge-ui": patch+---++Show weekly schedule days before the time controls.diff --git a/packages/trueforge-ui/src/atoms/AgentsLibrary.tsx b/packages/trueforge-ui/src/atoms/AgentsLibrary.tsxindex 4462e788b..aa144d117 100644--- a/packages/trueforge-ui/src/atoms/AgentsLibrary.tsx+++ b/packages/trueforge-ui/src/atoms/AgentsLibrary.tsx@@ -9,7 +9,7 @@ import { useOptionalAgentSessionsServer, useOptionalScheduleServer } from '../seimport { libraryAgentId, useShellMode } from '../server/ShellModeContext.js';import type { AgentLibraryEntry, AgentSpec, Schedule } from '../server/types.js';import { useSlot } from '../theme/SlotsProvider.js';-import { writeOpenSchedulesForAgentSearch } from '../utils/scheduleShareUrl.js';+import { replaceScheduleShareSearch } from '../utils/scheduleShareUrl.js';import { AgentOverflowMenu } from './AgentOverflowMenu.js';import { EmptyScreen, EmptyScreenQueryHighlight } from './EmptyScreen.js';import { cn } from './lib/cn.js';@@ -129,25 +129,18 @@ export function AgentLibraryRow({return (<TableRow className={hasNoSchedules ? 'group' : undefined}><TableCell className="text-text-primary font-medium">- <div className="flex min-w-0 items-center gap-2.5">- <span className="bg-primary-bg text-text-secondary inline-flex size-8 shrink-0 items-center justify-center rounded-md border border-border">- <Icon name="agent-2" className="size-4" />- </span>- <div className="min-w-0">- {onOpen == null ? (- <span className="block truncate">{agent.name}</span>- ) : (- <button- type="button"- className="block max-w-full cursor-pointer text-left"- aria-label={`Open ${agent.name}`}- onClick={onOpen}- >- <span className="block truncate">{agent.name}</span>- </button>- )}- </div>- </div>+ {onOpen == null ? (+ <span className="block truncate">{agent.name}</span>+ ) : (+ <button+ type="button"+ className="block max-w-full cursor-pointer text-left"+ aria-label={`Open ${agent.name}`}+ onClick={onOpen}+ >+ <span className="block truncate">{agent.name}</span>+ </button>+ )}</TableCell><TableCell>{hasConfiguration ? (@@ -271,8 +264,8 @@ export function AgentsLibrary({ onSelectAgent }: AgentsLibraryProps) {const canMutate = shell.isComposerEnabled === true;const agentsListEpoch = shell.agentsListEpoch;const showSchedulesColumn = isSchedulesChromeEnabled({ schedules: scheduleServer });- const canManageSchedules = showSchedulesColumn;const canOpenAgentDetails = isSessionsChromeEnabled({ sessions: sessionsServer });+ const canOpenAgentSchedules = showSchedulesColumn && canOpenAgentDetails;useEffect(() => {if (!open) setQuery('');@@ -322,8 +315,20 @@ export function AgentsLibrary({ onSelectAgent }: AgentsLibraryProps) {}, [agents, open, scheduleServer, agentsListEpoch]);const openSchedulesForAgent = ({ agentId, isNew }: { agentId: string; isNew?: boolean }) => {- writeOpenSchedulesForAgentSearch({ agentId, ...(isNew === true ? { isNew: true } : {}) });- shell.setSchedulesOpen(true);+ replaceScheduleShareSearch({+ agent: null,+ status: null,+ q: null,+ isNew: isNew === true ? true : null,+ });+ updateShareSearch({+ agentId,+ tab: 'schedules',+ sessionId: null,+ view: null,+ timeRange: null,+ });+ shell.openLibraryAgent(agentId);};const handleTry = (agent: AgentLibraryEntry) => {@@ -418,13 +423,13 @@ export function AgentsLibrary({ onSelectAgent }: AgentsLibraryProps) {key={id}agent={agent}canMutate={canMutate}- canManageSchedules={canManageSchedules}+ canManageSchedules={canOpenAgentSchedules}{...(summary !== undefined ? { scheduleSummary: summary } : {})}- {...(showSchedulesColumn+ {...(canOpenAgentSchedules && agentId != null? {- onOpenSchedules: () => openSchedulesForAgent({ agentId: id }),- onCreateSchedule: () => openSchedulesForAgent({ agentId: id, isNew: true }),- onManageSchedules: () => openSchedulesForAgent({ agentId: id }),+ onOpenSchedules: () => openSchedulesForAgent({ agentId }),+ onCreateSchedule: () => openSchedulesForAgent({ agentId, isNew: true }),+ onManageSchedules: () => openSchedulesForAgent({ agentId }),}: {})}{...(canOpenAgentDetails && agentId != nulldiff --git a/packages/trueforge-ui/src/atoms/UserMessageBubble.tsx b/packages/trueforge-ui/src/atoms/UserMessageBubble.tsxindex ac6fd4bc8..eeb32276f 100644--- a/packages/trueforge-ui/src/atoms/UserMessageBubble.tsx+++ b/packages/trueforge-ui/src/atoms/UserMessageBubble.tsx@@ -18,13 +18,15 @@ export function UserMessageBubble({ text, attachments, editAction, className }:className={cn('group/user-message flex w-full min-w-0 flex-col items-end gap-1', className)}>{attachments}- <div- data-slot="aui_user-message-content"- style={{ borderRadius: 'var(--composer-radius, 1.5rem)' }}- className="max-w-[min(80%,100%)] min-w-0 bg-user-message-bg px-3 py-2 text-sm text-user-message-text whitespace-pre-wrap break-words sm:px-4 sm:py-2.5"- >- {text}- </div>+ {text.trim().length > 0 ? (+ <div+ data-slot="aui_user-message-content"+ style={{ borderRadius: 'var(--composer-radius, 1.5rem)' }}+ className="max-w-[min(80%,100%)] min-w-0 bg-user-message-bg px-3 py-2 text-sm text-user-message-text whitespace-pre-wrap break-words sm:px-4 sm:py-2.5"+ >+ {text}+ </div>+ ) : null}{editAction && (<div className="flex max-w-[min(80%,100%)] justify-end opacity-0 transition-opacity group-hover/user-message:opacity-100 focus-within:opacity-100">{editAction}diff --git a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsHeader.tsx b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsHeader.tsxindex 1259eeb8f..6b2d5378b 100644--- a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsHeader.tsx+++ b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsHeader.tsx@@ -1,10 +1,8 @@'use client';import { Icon } from '../../icons/Icon.js';-import { isSchedulesChromeEnabled } from '../../server/serverChrome.js';-import { useOptionalScheduleServer, useOptionalServer } from '../../server/ServerContext.js';+import { useOptionalServer } from '../../server/ServerContext.js';import { useShellMode } from '../../server/ShellModeContext.js';-import { writeOpenSchedulesForAgentSearch } from '../../utils/scheduleShareUrl.js';import { AgentOverflowMenu } from '../AgentOverflowMenu.js';import { auiButtonClass } from '../lib/buttonClasses.js';import { cn } from '../lib/cn.js';@@ -14,10 +12,8 @@ import type { AgentDetailsHeaderProps } from './types.js';export function AgentDetailsHeader({ agentId, detail, onBack }: AgentDetailsHeaderProps) {const shell = useShellMode();- const scheduleServer = useOptionalScheduleServer();const builder = useOptionalServer();const canMutate = shell.isComposerEnabled && detail != null && builder != null;- const canManageSchedules = isSchedulesChromeEnabled({ schedules: scheduleServer }) && detail != null;const handleTry = () => {if (detail == null) return;@@ -39,11 +35,6 @@ export function AgentDetailsHeader({ agentId, detail, onBack }: AgentDetailsHead});};- const handleManageSchedules = () => {- writeOpenSchedulesForAgentSearch({ agentId });- shell.setSchedulesOpen(true);- };-return (<PageHeaderclassName="bg-primary-bg"@@ -84,9 +75,8 @@ export function AgentDetailsHeader({ agentId, detail, onBack }: AgentDetailsHeadagentName={detail.name}agentSpec={detail.agentSpec}canMutate={canMutate}- canManageSchedules={canManageSchedules}+ canManageSchedules={false}onEdit={handleEdit}- {...(canManageSchedules ? { onManageSchedules: handleManageSchedules } : {})}onDeleted={onBack}/>) : null}diff --git a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsPage.tsx b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsPage.tsxindex f20db188d..a140e1498 100644--- a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsPage.tsx+++ b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsPage.tsx@@ -2,9 +2,13 @@import { Suspense, useCallback, useEffect, useState } from 'react';import { useSessionShareSearch } from '../../hooks/useSessionShareSearch.js';-import { useOptionalAgentMetricsServer, useOptionalAgentSessionsServer } from '../../server/ServerContext.js';+import {+ useOptionalAgentMetricsServer,+ useOptionalAgentSessionsServer,+ useOptionalScheduleServer,+} from '../../server/ServerContext.js';import { useShellMode } from '../../server/ShellModeContext.js';-import { isMetricsChromeEnabled } from '../../server/serverChrome.js';+import { isMetricsChromeEnabled, isSchedulesChromeEnabled } from '../../server/serverChrome.js';import type { AgentDetail, CodeSnippet } from '../../server/types.js';import { useSlot } from '../../theme/SlotsProvider.js';import { libraryAgentTabFromSearch } from '../../utils/sessionShareUrl.js';@@ -14,17 +18,23 @@ import type { AgentDetailsPageProps } from './types.js';export function AgentDetailsPage({ agentId }: AgentDetailsPageProps) {const sessionsServer = useOptionalAgentSessionsServer();const metricsServer = useOptionalAgentMetricsServer();+ const scheduleServer = useOptionalScheduleServer();const shell = useShellMode();const share = useSessionShareSearch();const { updateShareSearch } = share;const requestedTab = libraryAgentTabFromSearch(share, agentId);const showMetrics = isMetricsChromeEnabled({ metrics: metricsServer });- const activeTab = requestedTab === 'metrics' && !showMetrics ? 'overview' : requestedTab;+ const showSchedules = isSchedulesChromeEnabled({ schedules: scheduleServer });+ const activeTab =+ (requestedTab === 'metrics' && !showMetrics) || (requestedTab === 'schedules' && !showSchedules)+ ? 'overview'+ : requestedTab;const AgentDetailsHeader = useSlot('AgentDetailsHeader');const AgentDetailsTabs = useSlot('AgentDetailsTabs');const AgentDetailsUnavailable = useSlot('AgentDetailsUnavailable');const AgentOverview = useSlot('AgentOverview');const AgentSessions = useSlot('AgentSessions');+ const SchedulesPage = useSlot('SchedulesPage');const AgentMetrics = useSlot('AgentMetrics');const AgentCodeSnippets = useSlot('AgentCodeSnippets');const [detail, setDetail] = useState<AgentDetail>();@@ -114,6 +124,8 @@ export function AgentDetailsPage({ agentId }: AgentDetailsPageProps) {content = <AgentOverview detail={detail} />;} else if (activeTab === 'sessions') {content = <AgentSessions agentId={agentId} />;+ } else if (activeTab === 'schedules') {+ content = <SchedulesPage agentId={agentId} />;} else if (activeTab === 'metrics') {content = <AgentMetrics agentId={agentId} />;} else if (snippetsFailed) {@@ -136,6 +148,7 @@ export function AgentDetailsPage({ agentId }: AgentDetailsPageProps) {<AgentDetailsTabsactiveTab={activeTab}showMetrics={showMetrics}+ showSchedules={showSchedules}onTabChange={tab =>updateShareSearch({agentId,diff --git a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsTabs.tsx b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsTabs.tsxindex aad4bfc25..e3bc4dd00 100644--- a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsTabs.tsx+++ b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsTabs.tsx@@ -7,11 +7,17 @@ import type { AgentDetailsTab, AgentDetailsTabsProps } from './types.js';const tabs: Array<{ id: AgentDetailsTab; label: string; icon: string }> = [{ id: 'overview', label: 'Overview', icon: 'info' },{ id: 'sessions', label: 'Sessions', icon: 'message-square-text' },+ { id: 'schedules', label: 'Schedules', icon: 'calendar-clock' },{ id: 'code', label: 'Use In Code', icon: 'code' },{ id: 'metrics', label: 'Metrics', icon: 'chart' },];-export function AgentDetailsTabs({ activeTab, onTabChange, showMetrics = false }: AgentDetailsTabsProps) {+export function AgentDetailsTabs({+ activeTab,+ onTabChange,+ showMetrics = false,+ showSchedules = false,+}: AgentDetailsTabsProps) {return (<divrole="tablist"@@ -19,7 +25,7 @@ export function AgentDetailsTabs({ activeTab, onTabChange, showMetrics = false }className="flex shrink-0 gap-1 overflow-x-auto border-b border-border bg-primary-bg px-3">{tabs- .filter(tab => tab.id !== 'metrics' || showMetrics)+ .filter(tab => (tab.id !== 'metrics' || showMetrics) && (tab.id !== 'schedules' || showSchedules)).map(tab => (<buttonkey={tab.id}diff --git a/packages/trueforge-ui/src/atoms/agent-details/AgentSessionEventTimelineChart.tsx b/packages/trueforge-ui/src/atoms/agent-details/AgentSessionEventTimelineChart.tsxindex 240ef0189..22a2cc1d0 100644--- a/packages/trueforge-ui/src/atoms/agent-details/AgentSessionEventTimelineChart.tsx+++ b/packages/trueforge-ui/src/atoms/agent-details/AgentSessionEventTimelineChart.tsx@@ -36,7 +36,7 @@ import {getTimelineRange,groupCoincidentTimelineMarkers,groupOverlappingToolCalls,- pickLongestNonOverlappingSegments,+ mergeOverlappingSubAgentSegments,TIMELINE_TYPE,type TimelineGap,type TimelineHoverTarget,@@ -196,7 +196,7 @@ export function AgentSessionEventTimelineChart({() => durationSegments.filter(segment => segment.type === 'sub_agent'),[durationSegments],);- const mainSubAgents = useMemo(() => pickLongestNonOverlappingSegments(subAgentSegments), [subAgentSegments]);+ const mainSubAgents = useMemo(() => mergeOverlappingSubAgentSegments(subAgentSegments), [subAgentSegments]);const subAgentGroups = useMemo(() => getSubAgentHoverGroups({ bars: mainSubAgents, subAgentSegments }),[mainSubAgents, subAgentSegments],@@ -206,9 +206,8 @@ export function AgentSessionEventTimelineChart({[durationSegments, msPerPx, subAgentSegments],);const mainCandidates = useMemo(() => {- const kept = new Set(mainSubAgents.map(segment => segment.id));- return durationSegments.filter(- segment => segment.threadId === MAIN_THREAD_ID || (segment.type === 'sub_agent' && kept.has(segment.id)),+ return [...durationSegments.filter(segment => segment.threadId === MAIN_THREAD_ID), ...mainSubAgents].sort(+ (left, right) => left.startMs - right.startMs || left.endMs - right.endMs,);}, [durationSegments, mainSubAgents]);const toolCallGroups = useMemo(diff --git a/packages/trueforge-ui/src/atoms/agent-details/types.ts b/packages/trueforge-ui/src/atoms/agent-details/types.tsindex 90a4acaa7..c6aca6073 100644--- a/packages/trueforge-ui/src/atoms/agent-details/types.ts+++ b/packages/trueforge-ui/src/atoms/agent-details/types.ts@@ -95,6 +95,7 @@ export type AgentDetailsTabsProps = {activeTab: AgentDetailsTab;onTabChange: (tab: AgentDetailsTab) => void;showMetrics?: boolean;+ showSchedules?: boolean;};export type AgentMetricsProps = {diff --git a/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx b/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsxindex d7d548f99..83fcac967 100644--- a/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx+++ b/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx@@ -127,6 +127,29 @@ export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelSonToggle: (enabled: boolean) => void;}> = [];+ if (firstReasoningEffort !== undefined) {+ rows.push({+ label: 'Reasoning Effort',+ enabled: params.reasoningEffort !== undefined,+ onToggle: enabled =>+ enabled ? setParam('reasoningEffort', firstReasoningEffort) : removeParam('reasoningEffort'),+ control: (+ <select+ value={params.reasoningEffort ?? ''}+ aria-label="Reasoning effort value"+ className={auiInputClass('h-8 cursor-pointer py-1.5')}+ onChange={event => setParam('reasoningEffort', event.target.value)}+ >+ {reasoningEfforts.map(effort => (+ <option key={effort} value={effort}>+ {effort}+ </option>+ ))}+ </select>+ ),+ });+ }+if (maxOutputTokens !== undefined) {rows.push({label: 'Maximum Tokens',@@ -163,29 +186,6 @@ export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelS});}- if (firstReasoningEffort !== undefined) {- rows.push({- label: 'Reasoning Effort',- enabled: params.reasoningEffort !== undefined,- onToggle: enabled =>- enabled ? setParam('reasoningEffort', firstReasoningEffort) : removeParam('reasoningEffort'),- control: (- <select- value={params.reasoningEffort ?? ''}- aria-label="Reasoning effort value"- className={auiInputClass('h-8 cursor-pointer py-1.5')}- onChange={event => setParam('reasoningEffort', event.target.value)}- >- {reasoningEfforts.map(effort => (- <option key={effort} value={effort}>- {effort}- </option>- ))}- </select>- ),- });- }-return (<div className="w-full"><div className="flex items-center justify-between gap-3 border-b border-border px-4 py-3">diff --git a/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx b/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsxindex 04802619f..c7bb54240 100644--- a/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx+++ b/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx@@ -137,7 +137,7 @@ export function AgentRuntimeConfigFields({content={field.disabledTooltip ?? ''}triggerClassName={cn('flex w-full min-w-0', wrapperClassName)}>- <label className={cn('flex w-full', className ?? 'items-center justify-between gap-3 py-1.5')}>+ <div className={cn('flex w-full', className ?? 'items-center justify-between gap-3 py-1.5')}><span className="min-w-0"><span className={cn('text-text-primary text-xs', layout === 'detailed' && 'block font-medium')}>{field.label}@@ -152,7 +152,7 @@ export function AgentRuntimeConfigFields({onCheckedChange={enabled => onChange(field.update(enabled))}aria-label={field.label}/>- </label>+ </div></Tooltip>);diff --git a/packages/trueforge-ui/src/atoms/draft/DraftComposerSections.tsx b/packages/trueforge-ui/src/atoms/draft/DraftComposerSections.tsxindex 8901d240b..25c051008 100644--- a/packages/trueforge-ui/src/atoms/draft/DraftComposerSections.tsx+++ b/packages/trueforge-ui/src/atoms/draft/DraftComposerSections.tsx@@ -42,11 +42,13 @@ export function DraftComposerLeftSection({ disabled, isRunning, onAttach }: Comp}export function DraftComposerRightSection({ disabled, isRunning }: ComposerRightSectionProps) {+ const shell = useOptionalShellMode();const DraftModelSelector = useSlot('DraftModelSelector');+ const isBuilder = shell != null && shellIsCreateAgent(shell.mode);return (<div className="flex min-w-0 items-center gap-1">- <DraftModelSelector disabled={disabled} isRunning={isRunning} />+ {!isBuilder ? <DraftModelSelector disabled={disabled} isRunning={isRunning} /> : null}<DraftReasoningEffortSelector disabled={disabled} isRunning={isRunning} /></div>);diff --git a/packages/trueforge-ui/src/atoms/primitives/PopoverSelect.tsx b/packages/trueforge-ui/src/atoms/primitives/PopoverSelect.tsxindex 9149aa440..23193a870 100644--- a/packages/trueforge-ui/src/atoms/primitives/PopoverSelect.tsx+++ b/packages/trueforge-ui/src/atoms/primitives/PopoverSelect.tsx@@ -1,6 +1,6 @@'use client';-import { useEffect, useId, useRef, useState } from 'react';+import { useEffect, useId, useRef, useState, type ReactNode } from 'react';import { Icon } from '../../icons/Icon.js';import { cn } from '../lib/cn.js';@@ -27,6 +27,8 @@ type CommonPopoverSelectProps<T extends string> = {menuPlacement?: 'top' | 'bottom';/** When set, renders a labeled chip trigger (label | value chip + chevron). */prefix?: string;+ emptyContent?: ReactNode;+ footer?: ReactNode;'aria-label': string;};@@ -167,35 +169,44 @@ export function PopoverSelect<T extends string>(props: PopoverSelectProps<T>) {{open ? (<div- ref={listboxRef}- id={listboxId}- role="listbox"- aria-label={props['aria-label']}- aria-multiselectable={props.multiple || undefined}className={cn(auiSelectMenuClass('left-0 min-w-full'),menuPlacement === 'top' && 'top-auto bottom-full mt-0 mb-1',props.menuClassName,)}>- {props.options.map(option => {- const selected = isSelected(option.value);- return (- <button- key={option.value}- type="button"- role="option"- aria-selected={selected}- aria-disabled={option.disabled || undefined}- disabled={option.disabled}- className={auiSelectOptionClass()}- onClick={() => select(option)}- >- <span className="min-w-0 flex-1 truncate">{option.label}</span>- <Icon name="check" className={cn('ml-auto size-4 shrink-0', selected ? 'opacity-100' : 'opacity-0')} />- </button>- );- })}+ <div+ ref={listboxRef}+ id={listboxId}+ role="listbox"+ aria-label={props['aria-label']}+ aria-multiselectable={props.multiple || undefined}+ >+ {props.options.length === 0+ ? props.emptyContent+ : props.options.map(option => {+ const selected = isSelected(option.value);+ return (+ <button+ key={option.value}+ type="button"+ role="option"+ aria-selected={selected}+ aria-disabled={option.disabled || undefined}+ disabled={option.disabled}+ className={auiSelectOptionClass()}+ onClick={() => select(option)}+ >+ <span className="min-w-0 flex-1 truncate">{option.label}</span>+ <Icon+ name="check"+ className={cn('ml-auto size-4 shrink-0', selected ? 'opacity-100' : 'opacity-0')}+ />+ </button>+ );+ })}+ </div>+ {props.footer}</div>) : null}</div>diff --git a/packages/trueforge-ui/src/atoms/schedules/ScheduleFormDrawer.tsx b/packages/trueforge-ui/src/atoms/schedules/ScheduleFormDrawer.tsxindex c9de59e27..a48e7ab08 100644--- a/packages/trueforge-ui/src/atoms/schedules/ScheduleFormDrawer.tsx+++ b/packages/trueforge-ui/src/atoms/schedules/ScheduleFormDrawer.tsx@@ -5,7 +5,7 @@ import { useEffect, useMemo, useState, type FormEvent, type ReactNode } from 'reimport { useToasterOptional } from '../../containers/ToasterContainer.js';import { Icon } from '../../icons/Icon.js';import { useScheduleServer, useServer } from '../../server/ServerContext.js';-import { libraryAgentId } from '../../server/ShellModeContext.js';+import { libraryAgentId, useOptionalShellMode } from '../../server/ShellModeContext.js';import type { AgentLibraryEntry, Schedule } from '../../server/types.js';import { DraftCatalogProvider } from '../draft/DraftCatalogProvider.js';import { mountName } from '../lib/mountName.js';@@ -43,10 +43,12 @@ function ScheduleFormDrawerBody({}: ScheduleFormDrawerProps) {const scheduleServer = useScheduleServer();const server = useServer();+ const shell = useOptionalShellMode();const toaster = useToasterOptional();const [form, setForm] = useState<ScheduleFormValues>(defaultScheduleFormValues);const [agentId, setAgentId] = useState(initialAgentId);const [agents, setAgents] = useState<AgentLibraryEntry[]>([]);+ const [agentsLoaded, setAgentsLoaded] = useState(false);const [view, setView] = useState<DrawerView>({ kind: 'form' });const [saving, setSaving] = useState(false);const [activating, setActivating] = useState(false);@@ -59,10 +61,12 @@ function ScheduleFormDrawerBody({useEffect(() => {if (!open) return;let cancelled = false;+ setAgentsLoaded(false);void searchAllAgents(server).then(rows => {if (cancelled) return;setAgents(rows);+ setAgentsLoaded(true);}).catch(() => undefined);return () => {@@ -297,7 +301,16 @@ function ScheduleFormDrawerBody({agentId={agentId}onAgentIdChange={isExternalEdit || isCreatedEdit ? undefined : setAgentId}agentOptions={agentOptions}+ agentOptionsLoaded={agentsLoaded}agentPickerDisabled={isExternalEdit || isCreatedEdit}+ onBuildAgent={+ mode === 'create' && shell?.isComposerEnabled === true+ ? () => {+ onOpenChange(false);+ shell.openAgentBuilder();+ }+ : undefined+ }/></form>)}diff --git a/packages/trueforge-ui/src/atoms/schedules/ScheduleFormFields.tsx b/packages/trueforge-ui/src/atoms/schedules/ScheduleFormFields.tsxindex d3e1f5424..1614f883e 100644--- a/packages/trueforge-ui/src/atoms/schedules/ScheduleFormFields.tsx+++ b/packages/trueforge-ui/src/atoms/schedules/ScheduleFormFields.tsx@@ -3,6 +3,7 @@import { Icon } from '../../icons/Icon.js';import { cn } from '../lib/cn.js';import { auiInputClass } from '../lib/inputClasses.js';+import { Button } from '../primitives/Button.js';import { PopoverSelect } from '../primitives/PopoverSelect.js';import {WEEKDAY_OPTIONS,@@ -34,7 +35,9 @@ export type ScheduleFormFieldsProps = {agentId: string;onAgentIdChange?: (agentId: string) => void;agentOptions: Array<{ agentId: string; name: string }>;+ agentOptionsLoaded?: boolean;agentPickerDisabled?: boolean;+ onBuildAgent?: () => void;};export function ScheduleFormFields({@@ -43,7 +46,9 @@ export function ScheduleFormFields({agentId,onAgentIdChange,agentOptions,+ agentOptionsLoaded = true,agentPickerDisabled = false,+ onBuildAgent,}: ScheduleFormFieldsProps) {const cron = valuesToCron(values);const cadence = formatCadenceSummary({ cron, timezone: values.timezone });@@ -70,6 +75,21 @@ export function ScheduleFormFields({options={agentOptions.map(agent => ({ value: agent.agentId, label: agent.name }))}onValueChange={value => onAgentIdChange?.(value)}disabled={agentPickerDisabled || onAgentIdChange == null}+ emptyContent={+ agentOptionsLoaded ? (+ <p className="text-text-secondary px-3 py-5 text-center text-sm">No Agents created yet</p>+ ) : null+ }+ footer={+ agentOptionsLoaded && agentOptions.length === 0 && onBuildAgent != null ? (+ <div className="flex justify-end border-t border-border px-2 pt-2">+ <Button.Ghost type="button" onClick={onBuildAgent}>+ <Icon name="plus" className="size-3.5" />+ Build Agent+ </Button.Ghost>+ </div>+ ) : null+ }/></div>@@ -97,7 +117,7 @@ export function ScheduleFormFields({</label><fieldset>- <legend className="mb-1.5 text-sm font-medium">Recurrence</legend>+ <legend className="mb-1.5 text-sm font-medium">Frequency</legend><div className="rounded-t-lg border border-border p-4"><div className="flex flex-col gap-4"><div className="grid grid-cols-3 gap-1 rounded-lg border border-border bg-primary-bg p-1">@@ -132,6 +152,33 @@ export function ScheduleFormFields({</div>) : null}+ {values.recurrence === 'weekly' ? (+ <fieldset>+ <legend className="mb-2 text-sm font-medium">Days</legend>+ <div className="flex gap-2">+ {WEEKDAY_OPTIONS.map(day => {+ const selected = values.weekdays.includes(day.value);+ return (+ <button+ key={day.value}+ type="button"+ className={cn(+ 'min-w-0 flex-1 rounded-md border px-3 py-2 text-[0.8125rem] font-medium',+ selected+ ? 'border-primary-button-bg/40 bg-primary-button-bg/10 font-semibold text-primary-button-bg'+ : 'border-border text-text-secondary hover:bg-ghost-button-hover',+ )}+ aria-pressed={selected}+ onClick={() => toggleWeekday(day.value)}+ >+ {day.label}+ </button>+ );+ })}+ </div>+ </fieldset>+ ) : null}+<div className="flex gap-4">{values.recurrence === 'daily' || values.recurrence === 'weekly' ? (<div className="min-w-0 flex-1">@@ -166,33 +213,6 @@ export function ScheduleFormFields({/></div></div>-- {values.recurrence === 'weekly' ? (- <fieldset>- <legend className="mb-2 text-sm font-medium">Days</legend>- <div className="flex gap-2">- {WEEKDAY_OPTIONS.map(day => {- const selected = values.weekdays.includes(day.value);- return (- <button- key={day.value}- type="button"- className={cn(- 'min-w-0 flex-1 rounded-md border px-3 py-2 text-[0.8125rem] font-medium',- selected- ? 'border-primary-button-bg/40 bg-primary-button-bg/10 font-semibold text-primary-button-bg'- : 'border-border text-text-secondary hover:bg-ghost-button-hover',- )}- aria-pressed={selected}- onClick={() => toggleWeekday(day.value)}- >- {day.label}- </button>- );- })}- </div>- </fieldset>- ) : null}</div></div><div className="rounded-b-lg border border-t-0 border-border bg-primary-button-bg/10 px-4 py-3">diff --git a/packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsx b/packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsxindex 9ae4e072d..0718738ce 100644--- a/packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsx+++ b/packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsx@@ -1,6 +1,6 @@'use client';-import { useCallback, useEffect, useMemo, useRef, useState } from 'react';+import { useCallback, useEffect, useMemo, useRef, useState, type ComponentType } from 'react';import { useToasterOptional } from '../../containers/ToasterContainer.js';import { Icon } from '../../icons/Icon.js';@@ -38,6 +38,11 @@ type AgentOption = { agentId: string; name: string };type DrawerState = { kind: 'closed' } | { kind: 'create'; agentId?: string } | { kind: 'edit'; schedule: Schedule };+export type SchedulesPageProps = {+ /** Lock the page to one agent when embedded in Agent Details. */+ agentId?: string;+};+const STATUS_FILTER_OPTIONS: Array<{ value: 'all' | ScheduleStatus; label: string }> = [{ value: 'all', label: 'All statuses' },{ value: 'active', label: 'Active' },@@ -64,6 +69,16 @@ function filtersFromSearch(search: string): {};}+function initialDrawerState(agentId?: string): DrawerState {+ const share = readScheduleShareSearch(window.location.search);+ if (!share.isNew) return { kind: 'closed' };+ const initialAgentId = agentId ?? share.agent;+ return {+ kind: 'create',+ ...(initialAgentId == null ? {} : { agentId: initialAgentId }),+ };+}+function ScheduleRowActions({schedule,running,@@ -120,7 +135,7 @@ function ScheduleRowActions({);}-export function SchedulesPage() {+export function SchedulesPage({ agentId }: SchedulesPageProps) {const scheduleServer = useScheduleServer();const server = useServer();const toaster = useToasterOptional();@@ -136,8 +151,10 @@ export function SchedulesPage() {const [statusFilter, setStatusFilter] = useState<'all' | ScheduleStatus>(() => filtersFromSearch(window.location.search).statusFilter,);- const [agentFilter, setAgentFilter] = useState(() => filtersFromSearch(window.location.search).agentFilter);- const [drawer, setDrawer] = useState<DrawerState>({ kind: 'closed' });+ const [agentFilter, setAgentFilter] = useState(+ () => agentId ?? filtersFromSearch(window.location.search).agentFilter,+ );+ const [drawer, setDrawer] = useState<DrawerState>(() => initialDrawerState(agentId));const [pendingDelete, setPendingDelete] = useState<Schedule | null>(null);const [pageSize, setPageSize] = useState(() => clampPageSize(DEFAULT_TABLE_PAGE_SIZE));const [pageToken, setPageToken] = useState<string | undefined>(undefined);@@ -217,22 +234,28 @@ export function SchedulesPage() {// Keep filters in the URL so deep links and Agents → Schedules work.useEffect(() => {replaceScheduleShareSearch({- agent: agentFilter === 'all' ? null : agentFilter,+ agent: agentId === undefined && agentFilter !== 'all' ? agentFilter : null,status: statusFilter === 'all' ? null : statusFilter,q: nameQuery.trim().length === 0 ? null : nameQuery,});- }, [agentFilter, statusFilter, nameQuery]);+ }, [agentFilter, agentId, statusFilter, nameQuery]);- // One-shot: Agents "+ Schedule" lands with isNew=true; open create then strip the flag.+ useEffect(() => {+ if (agentId === undefined) return;+ setAgentFilter(current => {+ if (current === agentId) return current;+ setPageToken(undefined);+ setPrevTokenStack([]);+ return agentId;+ });+ }, [agentId]);++ // One-shot: the initial state opens create synchronously; then strip the URL flag.useEffect(() => {if (didConsumeIsNewRef.current) return;const share = readScheduleShareSearch(window.location.search);if (!share.isNew) return;didConsumeIsNewRef.current = true;- setDrawer({- kind: 'create',- ...(share.agent != null ? { agentId: share.agent } : {}),- });replaceScheduleShareSearch({ isNew: null });}, []);@@ -242,17 +265,18 @@ export function SchedulesPage() {setNameQuery(next.nameQuery);setStatusFilter(next.statusFilter);setAgentFilter(current => {- if (current === next.agentFilter) return current;+ const nextAgentFilter = agentId ?? next.agentFilter;+ if (current === nextAgentFilter) return current;setPageToken(undefined);setPrevTokenStack([]);- return next.agentFilter;+ return nextAgentFilter;});};window.addEventListener('popstate', syncFromUrl);return () => {window.removeEventListener('popstate', syncFromUrl);};- }, []);+ }, [agentId]);useEffect(() => {void loadSchedules({ token: pageToken, size: pageSize, agentId: agentFilter });@@ -346,7 +370,7 @@ export function SchedulesPage() {return (<div className="flex h-full min-h-0 flex-col bg-primary-bg"><PageHeader- title="Scheduled Agents"+ title={agentId === undefined ? 'Scheduled Agents' : undefined}end={<><div className="w-full sm:w-56">@@ -359,20 +383,22 @@ export function SchedulesPage() {className="sm:w-40"aria-label="Filter by status"/>- <PopoverSelect- value={agentFilter}- onValueChange={value => {- setAgentFilter(value);- setPageToken(undefined);- setPrevTokenStack([]);- }}- options={[- { value: 'all', label: 'All agents' },- ...agentOptions.map(agent => ({ value: agent.agentId, label: agent.name })),- ]}- className="sm:w-40"- aria-label="Filter by agent"- />+ {agentId === undefined ? (+ <PopoverSelect+ value={agentFilter}+ onValueChange={value => {+ setAgentFilter(value);+ setPageToken(undefined);+ setPrevTokenStack([]);+ }}+ options={[+ { value: 'all', label: 'All agents' },+ ...agentOptions.map(agent => ({ value: agent.agentId, label: agent.name })),+ ]}+ className="sm:w-40"+ aria-label="Filter by agent"+ />+ ) : null}<Button.Primarytype="button"onClick={() =>@@ -428,7 +454,7 @@ export function SchedulesPage() {<TableRow className="hover:bg-transparent"><TableHead>Name</TableHead><TableHead>Agent</TableHead>- <TableHead>Cadence</TableHead>+ <TableHead>Frequency</TableHead><TableHead>Status</TableHead><TableHead>Last 5 runs</TableHead><TableHead>@@ -545,3 +571,9 @@ export function SchedulesPage() {</div>);}++declare module '../../theme/SlotsProvider.js' {+ interface AtomSlots {+ SchedulesPage: ComponentType<SchedulesPageProps>;+ }+}diff --git a/packages/trueforge-ui/src/containers/ComposerContainer.tsx b/packages/trueforge-ui/src/containers/ComposerContainer.tsxindex 348422c4a..fc15c1f76 100644--- a/packages/trueforge-ui/src/containers/ComposerContainer.tsx+++ b/packages/trueforge-ui/src/containers/ComposerContainer.tsx@@ -19,6 +19,22 @@ export type ComposerContainerProps = {placeholder?: string;};+export function canSubmitComposer({+ disabled,+ hasText,+ hasAttachments,+ requiresModel,+ hasModel,+}: {+ disabled: boolean;+ hasText: boolean;+ hasAttachments: boolean;+ requiresModel: boolean;+ hasModel: boolean;+}): boolean {+ return !disabled && (hasText || hasAttachments) && (!requiresModel || hasModel);+}+function ComposerBody({placeholder,forceDisabled = false,@@ -33,6 +49,7 @@ function ComposerBody({const aui = useAui();const shell = useOptionalShellMode();const hasText = useAuiState(s => s.composer.text.trim().length > 0);+ const hasAttachments = useAuiState(s => s.composer.attachments.length > 0);const { agentSpec } = useTrueFoundryAgentSpec();// Named (immutable) agents use a server-side model; only draft/mutable composers pick one here.const requiresModel = shell == null || (shell.mode.status === 'active' && shell.mode.isMutable);@@ -41,7 +58,7 @@ function ComposerBody({const cancel = useTrueFoundryCancel();const fileInputRef = useRef<HTMLInputElement>(null);const disabled = isBusy || forceDisabled;- const canSubmit = !disabled && hasText && (!requiresModel || hasModel);+ const canSubmit = canSubmitComposer({ disabled, hasText, hasAttachments, requiresModel, hasModel });const submit = () => {if (!canSubmit) return;send(() => aui.composer().send());diff --git a/packages/trueforge-ui/src/index.ts b/packages/trueforge-ui/src/index.tsindex add5b2110..12433e3ac 100644--- a/packages/trueforge-ui/src/index.ts+++ b/packages/trueforge-ui/src/index.ts@@ -72,6 +72,7 @@ export type { ScheduleFormFieldsProps } from './atoms/schedules/ScheduleFormFielexport { ScheduleLastRunsCell } from './atoms/schedules/ScheduleLastRunsCell.js';export { ScheduleRunChip } from './atoms/schedules/ScheduleRunChip.js';export { SchedulesPage } from './atoms/schedules/SchedulesPage.js';+export type { SchedulesPageProps } from './atoms/schedules/SchedulesPage.js';export { ScheduleStatusBadge } from './atoms/schedules/ScheduleStatusBadge.js';export { TestScheduleScreen } from './atoms/schedules/TestScheduleScreen.js';export type { ScheduleMcpMount, TestScheduleScreenProps } from './atoms/schedules/TestScheduleScreen.js';diff --git a/packages/trueforge-ui/src/routing/paths.ts b/packages/trueforge-ui/src/routing/paths.tsindex cf1336d84..0050515d4 100644--- a/packages/trueforge-ui/src/routing/paths.ts+++ b/packages/trueforge-ui/src/routing/paths.ts@@ -1,4 +1,8 @@-import { clearScheduleShareSearch } from '../utils/scheduleShareUrl.js';+import {+ clearScheduleShareSearch,+ readScheduleShareSearch,+ writeScheduleShareSearch,+} from '../utils/scheduleShareUrl.js';import { readSessionShareSearch, writeSessionShareSearch } from '../utils/sessionShareUrl.js';import type { ResolvedRoutes, RoutePlace, RoutesConfig } from './types.js';@@ -112,12 +116,20 @@ export function sanitizeSearchForPlace(place: RoutePlace, search: string): strinclearScheduleShareSearch(params);} else if (place.type === 'libraryAgent') {const share = readSessionShareSearch(search);+ const scheduleShare = readScheduleShareSearch(search);writeSessionShareSearch(params, {view: null,timeRange: null,...(share.sessionId != null && share.agentId !== place.agentId ? { sessionId: null, agentId: null } : {}),});clearScheduleShareSearch(params);+ if (share.tab === 'schedules') {+ writeScheduleShareSearch(params, {+ status: scheduleShare.status,+ q: scheduleShare.q,+ isNew: scheduleShare.isNew,+ });+ }} else if (place.type === 'schedules') {writeSessionShareSearch(params, {sessionId: null,diff --git a/packages/trueforge-ui/src/theme/defaultSlots.ts b/packages/trueforge-ui/src/theme/defaultSlots.tsindex 9fe37eb20..9c756f2b3 100644--- a/packages/trueforge-ui/src/theme/defaultSlots.ts+++ b/packages/trueforge-ui/src/theme/defaultSlots.ts@@ -73,6 +73,7 @@ import { SandboxArtifactDownload } from '../atoms/SandboxArtifactDownload.js';import { SandboxToolCallCard } from '../atoms/SandboxToolCallCard.js';import { SaveAgentButton } from '../atoms/SaveAgentButton.js';import { SaveAgentForm } from '../atoms/SaveAgentForm.js';+import type { SchedulesPageProps } from '../atoms/schedules/SchedulesPage.js';import { SchedulesButton } from '../atoms/SchedulesButton.js';import { ScrollToBottomButton } from '../atoms/ScrollToBottomButton.js';import { SelectAgentEmptyState } from '../atoms/SelectAgentEmptyState.js';@@ -111,6 +112,10 @@ const AgentSessions: ComponentType<AgentSessionsProps> = lazy(async () => {const AgentCodeSnippets: ComponentType<AgentCodeSnippetsProps> = lazy(() => import('../atoms/agent-details/AgentCodeSnippets.js'),);+const SchedulesPage: ComponentType<SchedulesPageProps> = lazy(async () => {+ const mod = await import('../atoms/schedules/SchedulesPage.js');+ return { default: mod.SchedulesPage };+});const AgentSessionEventTimeline: ComponentType<AgentSessionEventTimelineProps> = lazy(async () => {const mod = await import('../atoms/agent-details/AgentSessionEventTimeline.js');return { default: mod.AgentSessionEventTimeline };@@ -226,6 +231,7 @@ export const defaultSlots = {AgentSessions,AgentCodeSnippets,AgentCodeBlock,+ SchedulesPage,SchedulesButton,SaveAgentButton,SaveAgentForm,diff --git a/packages/trueforge-ui/src/utils/buildSessionTimelineSegments.ts b/packages/trueforge-ui/src/utils/buildSessionTimelineSegments.tsindex 3aed07590..fe1a52fe8 100644--- a/packages/trueforge-ui/src/utils/buildSessionTimelineSegments.ts+++ b/packages/trueforge-ui/src/utils/buildSessionTimelineSegments.ts@@ -21,6 +21,12 @@ import {} from './sessionTimelineEvents.js';import type { SessionTurnView } from './sessionTurnViews.js';+type SubAgentToolCallRequest = {+ startedAtMs: number;+ threadId: string;+ modelEventId: string;+};+/*** Convert server turns and events into the transport-independent intervals* consumed by the Sessions timeline.@@ -46,7 +52,7 @@ export function buildSessionTimelineSegments(turns: SessionTurnView[]): SessionEconst approvalRequiredIdsByTurnId = new Map<string, Set<string>>();const threadDoneEvents = new Map<string, TimelineEvent>();const subAgentToolCallIds = new Set<string>();- const toolCallRequestsByTurnId = new Map<string, Map<string, { startedAtMs: number; threadId: string }>>();+ const toolCallRequestsByTurnId = new Map<string, Map<string, SubAgentToolCallRequest>>();let latestMs = originMs;for (const turn of turns) {@@ -79,7 +85,11 @@ export function buildSessionTimelineSegments(turns: SessionTurnView[]): SessionEconst requests = toolCallRequestsByTurnId.get(turn.turnId) ?? new Map();for (const toolCall of toolCallsOf(event)) {if (typeof toolCall.id === 'string') {- requests.set(toolCall.id, { startedAtMs, threadId: eventThreadId(event) });+ requests.set(toolCall.id, {+ startedAtMs,+ threadId: eventThreadId(event),+ modelEventId: eventId(event),+ });}}toolCallRequestsByTurnId.set(turn.turnId, requests);@@ -88,6 +98,7 @@ export function buildSessionTimelineSegments(turns: SessionTurnView[]): SessionE}const segments: SessionEventTimelineSegment[] = [];+ const emittedWaitingRequestIds = new Set<string>();for (const turn of turns) {const createdMs = parseTimestamp(turn.created.createdAt);@@ -134,6 +145,7 @@ export function buildSessionTimelineSegments(turns: SessionTurnView[]): SessionEsubAgentToolCallIds,toolCallRequestsByTurnId,threadDoneEvents,+ emittedWaitingRequestIds,segments,});lastTimestampByThreadId.set(threadId, eventMs);@@ -171,6 +183,7 @@ function appendEventSegments({subAgentToolCallIds,toolCallRequestsByTurnId,threadDoneEvents,+ emittedWaitingRequestIds,segments,}: {event: TimelineEvent;@@ -184,8 +197,9 @@ function appendEventSegments({toolResponsesByTurnId: Map<string, Map<string, TimelineEvent>>;approvalRequiredIdsByTurnId: Map<string, Set<string>>;subAgentToolCallIds: Set<string>;- toolCallRequestsByTurnId: Map<string, Map<string, { startedAtMs: number; threadId: string }>>;+ toolCallRequestsByTurnId: Map<string, Map<string, SubAgentToolCallRequest>>;threadDoneEvents: Map<string, TimelineEvent>;+ emittedWaitingRequestIds: Set<string>;segments: SessionEventTimelineSegment[];}): void {switch (event.type) {@@ -240,17 +254,23 @@ function appendEventSegments({// assigned to the same thread id and rendered on the track's lane.const parentCallId = parentToolCallId(event);const request = parentCallId == null ? undefined : toolCallRequestsByTurnId.get(turn.turnId)?.get(parentCallId);- if (request != null && request.startedAtMs < eventMs) {- segments.push({- id: `${eventId(event)}-waiting`,- type: 'system',- title: 'system.waiting_for_sub_agent',- description: 'System waiting for sub-agent to start executing',- startMs: request.startedAtMs - originMs,- endMs: eventMs - originMs,- turnIndex,- threadId: request.threadId,- });+ if (request != null) {+ const waitingRequestId = `${turn.turnId}:${request.modelEventId}`;+ if (!emittedWaitingRequestIds.has(waitingRequestId)) {+ emittedWaitingRequestIds.add(waitingRequestId);+ if (request.startedAtMs < eventMs) {+ segments.push({+ id: `${eventId(event)}-waiting`,+ type: 'system',+ title: 'system.waiting_for_sub_agent',+ description: 'System waiting for sub-agent to start executing',+ startMs: request.startedAtMs - originMs,+ endMs: eventMs - originMs,+ turnIndex,+ threadId: request.threadId,+ });+ }+ }}const doneEvent = threadDoneEvents.get(threadId);const doneMs = doneEvent == null ? null : parseTimestamp(eventCreatedAt(doneEvent));diff --git a/packages/trueforge-ui/src/utils/sessionEventTimelineChart.ts b/packages/trueforge-ui/src/utils/sessionEventTimelineChart.tsindex 297eaeec9..6a1d94fb8 100644--- a/packages/trueforge-ui/src/utils/sessionEventTimelineChart.ts+++ b/packages/trueforge-ui/src/utils/sessionEventTimelineChart.ts@@ -189,24 +189,22 @@ function segmentsOverlap(left: SessionEventTimelineSegment, right: SessionEventTreturn left.startMs < right.endMs && right.startMs < left.endMs;}-/**- * Select representative sub-agent tracks for the main event row.- *- * Longest-first selection preserves the tracks that explain the most elapsed- * time; overlapping tracks are still available in dedicated sub-agent lanes.- */-export function pickLongestNonOverlappingSegments(+/** Merge transitively overlapping sub-agent runs into summary bars for the main event row. */+export function mergeOverlappingSubAgentSegments(segments: SessionEventTimelineSegment[],): SessionEventTimelineSegment[] {- const selected: SessionEventTimelineSegment[] = [];- for (const segment of [...segments].sort((left, right) => {- const durationDiff = right.endMs - right.startMs - (left.endMs - left.startMs);- return durationDiff !== 0 ? durationDiff : left.startMs - right.startMs;- })) {- if (selected.some(kept => segmentsOverlap(kept, segment))) continue;- selected.push(segment);+ const merged: SessionEventTimelineSegment[] = [];+ for (const segment of [...segments].sort(+ (left, right) => left.turnIndex - right.turnIndex || left.startMs - right.startMs || left.endMs - right.endMs,+ )) {+ const current = merged.at(-1);+ if (current == null || current.turnIndex !== segment.turnIndex || !segmentsOverlap(current, segment)) {+ merged.push({ ...segment });+ continue;+ }+ current.endMs = Math.max(current.endMs, segment.endMs);}- return selected.sort((left, right) => left.startMs - right.startMs);+ return merged;}/**@@ -240,8 +238,7 @@ export function groupOverlappingToolCalls(segments: SessionEventTimelineSegment[return groups;}-// Each visible main-row bar owns a tooltip containing only runs that overlap it.-// This avoids pulling in distant runs through a chain of transitive overlaps.+// Each merged main-row bar owns the runs represented by its full interval.export function getSubAgentHoverGroups({bars,subAgentSegments,diff --git a/packages/trueforge-ui/src/utils/sessionShareUrl.ts b/packages/trueforge-ui/src/utils/sessionShareUrl.tsindex a217874d0..2198ab256 100644--- a/packages/trueforge-ui/src/utils/sessionShareUrl.ts+++ b/packages/trueforge-ui/src/utils/sessionShareUrl.ts@@ -10,7 +10,7 @@ export const SESSION_TIME_BUFFER_MS = 5 * 60 * 1000;export const SESSION_CUSTOM_RANGE_MAX_DAYS = 70;export const DEFAULT_SESSION_TIME_WINDOW_MS = 30 * 24 * 60 * 60 * 1000;-export type LibraryAgentTab = 'overview' | 'sessions' | 'code' | 'metrics';+export type LibraryAgentTab = 'overview' | 'sessions' | 'schedules' | 'code' | 'metrics';export type SessionTimeRange = {startTs: number;@@ -35,7 +35,15 @@ export type SessionShareWrite = {};function parseLibraryAgentTab(value: string | null): LibraryAgentTab | null {- if (value === 'overview' || value === 'sessions' || value === 'code' || value === 'metrics') return value;+ if (+ value === 'overview' ||+ value === 'sessions' ||+ value === 'schedules' ||+ value === 'code' ||+ value === 'metrics'+ ) {+ return value;+ }return null;}diff --git a/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx b/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsxindex 02c079568..96bfbcdb6 100644--- a/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx+++ b/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx@@ -11,12 +11,13 @@ import type {AgentDetail,AgentMetricsServer,CodeSnippet,+ ScheduleServer,Session,SessionEventItem,SessionListEntry,} from '@/server/types.js';import { SlotsProvider, type SlotOverrides } from '@/theme/SlotsProvider.js';-import { createMockAgentUIServer } from '../server/mockServer.js';+import { createMockAgentUIServer, createMockScheduleServer } from '../server/mockServer.js';beforeAll(() => {HTMLDialogElement.prototype.showModal = function showModal() {@@ -85,6 +86,7 @@ function renderPage({})),withSessions = true,metrics,+ schedules,overrides,initialEntries = ['/library/agent-1'],serverOverrides,@@ -96,6 +98,7 @@ function renderPage({getSession?: () => Promise<Session>;withSessions?: boolean;metrics?: AgentMetricsServer;+ schedules?: ScheduleServer;overrides?: SlotOverrides;initialEntries?: string[];serverOverrides?: Parameters<typeof createMockAgentUIServer>[0];@@ -104,6 +107,7 @@ function renderPage({getSession,...(withSessions ? { sessions: { getAgent, getCodeSnippets, listSessions, listSessionEvents } } : {}),...(metrics == null ? {} : { metrics }),+ ...(schedules == null ? {} : { schedules }),...serverOverrides,});render(@@ -191,6 +195,36 @@ describe('AgentDetailsPage', () => {expect(screen.getByText('Metrics deep link')).toBeInTheDocument();});+ it('shows an agent-scoped Schedules tab when supported', async () => {+ renderPage({+ schedules: createMockScheduleServer(),+ overrides: {+ SchedulesPage: ({ agentId }) => <div>Schedules for {agentId}</div>,+ },+ });++ fireEvent.click(await screen.findByRole('button', { name: 'Actions for release-notes-writer' }));+ expect(screen.queryByRole('menuitem', { name: 'Manage Schedules' })).not.toBeInTheDocument();++ fireEvent.click(await screen.findByRole('tab', { name: 'Schedules' }));+ expect(screen.getByText('Schedules for agent-1')).toBeInTheDocument();+ expect(new URL(window.location.href).searchParams.get('tab')).toBe('schedules');+ expect(new URL(window.location.href).searchParams.get('agent')).toBeNull();+ });++ it('opens the create schedule drawer after redirecting from + Schedule', async () => {+ window.history.replaceState(null, '', '/library/agent-1?agentId=agent-1&tab=schedules&isNew=true');+ renderPage({+ initialEntries: ['/library/agent-1?agentId=agent-1&tab=schedules&isNew=true'],+ schedules: createMockScheduleServer(),+ });++ expect(await screen.findByRole('heading', { name: 'New Schedule' })).toBeInTheDocument();+ await waitFor(() => {+ expect(new URL(window.location.href).searchParams.get('isNew')).toBeNull();+ });+ });+it('loads code snippets lazily and retains them across tab changes', async () => {const { getCodeSnippets } = renderPage();await screen.findByText('release-notes-writer');diff --git a/packages/trueforge-ui/test/atoms/AgentsLibrary.test.tsx b/packages/trueforge-ui/test/atoms/AgentsLibrary.test.tsxindex 9c3a861c1..236f851a0 100644--- a/packages/trueforge-ui/test/atoms/AgentsLibrary.test.tsx+++ b/packages/trueforge-ui/test/atoms/AgentsLibrary.test.tsx@@ -435,7 +435,7 @@ describe('AgentsLibraryButton', () => {expect(searchAgents).not.toHaveBeenCalled();});- it('shows a schedules count badge for visible agents and opens schedules on click', async () => {+ it('routes schedule actions to the agent Schedules tab', async () => {const listSchedules = vi.fn(async () => ({data: [{@@ -467,6 +467,12 @@ describe('AgentsLibraryButton', () => {{ name: 'alpha-agent', agentId: 'alpha-agent' },{ name: 'beta-agent', agentId: 'beta-agent' },]),+ sessions: {+ getAgent: vi.fn(),+ getCodeSnippets: vi.fn(),+ listSessions: vi.fn(async () => ({ data: [] })),+ listSessionEvents: vi.fn(async () => ({ data: [] })),+ },schedules: {listSchedules,getSchedule: vi.fn(),@@ -478,17 +484,7 @@ describe('AgentsLibraryButton', () => {},});- function SchedulesOpenProbe() {- const shell = useShellMode();- return <output data-testid="schedules-open">{shell.schedulesOpen ? 'yes' : 'no'}</output>;- }-- renderLibrary(- <LibraryHarness>- <SchedulesOpenProbe />- </LibraryHarness>,- { server },- );+ renderLibrary(<LibraryHarness />, { server });fireEvent.click(screen.getByRole('button', { name: 'Open library' }));await waitFor(() => {@@ -503,15 +499,22 @@ describe('AgentsLibraryButton', () => {expect(addSchedule).toHaveTextContent('-');fireEvent.click(addSchedule);- expect(screen.getByTestId('schedules-open')).toHaveTextContent('yes');- expect(new URL(window.location.href).searchParams.get('agent')).toBe('beta-agent');+ expect(screen.getByTestId('library-agent-id')).toHaveTextContent('beta-agent');+ expect(new URL(window.location.href).searchParams.get('agentId')).toBe('beta-agent');+ expect(new URL(window.location.href).searchParams.get('tab')).toBe('schedules');+ expect(new URL(window.location.href).searchParams.get('agent')).toBeNull();expect(new URL(window.location.href).searchParams.get('isNew')).toBe('true');- fireEvent.click(screen.getByRole('button', { name: 'Open library' }));- await screen.findByRole('button', { name: /2 schedules for alpha-agent/ });fireEvent.click(screen.getByRole('button', { name: /2 schedules for alpha-agent/ }));- expect(new URL(window.location.href).searchParams.get('agent')).toBe('alpha-agent');+ expect(screen.getByTestId('library-agent-id')).toHaveTextContent('alpha-agent');+ expect(new URL(window.location.href).searchParams.get('agentId')).toBe('alpha-agent');+ expect(new URL(window.location.href).searchParams.get('tab')).toBe('schedules');expect(new URL(window.location.href).searchParams.get('isNew')).toBeNull();++ fireEvent.click(screen.getByRole('button', { name: 'Actions for alpha-agent' }));+ fireEvent.click(screen.getByRole('menuitem', { name: 'Manage Schedules' }));+ expect(screen.getByTestId('library-agent-id')).toHaveTextContent('alpha-agent');+ expect(new URL(window.location.href).searchParams.get('tab')).toBe('schedules');});it('does not show an empty-schedules action before schedule counts load', async () => {diff --git a/packages/trueforge-ui/test/atoms/UserMessageBubble.test.tsx b/packages/trueforge-ui/test/atoms/UserMessageBubble.test.tsxindex 23a97322c..f56d8b4bf 100644--- a/packages/trueforge-ui/test/atoms/UserMessageBubble.test.tsx+++ b/packages/trueforge-ui/test/atoms/UserMessageBubble.test.tsx@@ -31,4 +31,11 @@ describe('UserMessageBubble', () => {expect(screen.queryByRole('button')).not.toBeInTheDocument();expect(screen.queryByRole('link')).not.toBeInTheDocument();});++ it('renders attachments without an empty text bubble', () => {+ const { container } = render(<UserMessageBubble text="" attachments={<a href="/image.png">image.png</a>} />);++ expect(container.querySelector('[data-slot="aui_user-message-content"]')).not.toBeInTheDocument();+ expect(screen.getByRole('link', { name: 'image.png' })).toBeInTheDocument();+ });});diff --git a/packages/trueforge-ui/test/atoms/draft/AgentConfigEditors.test.tsx b/packages/trueforge-ui/test/atoms/draft/AgentConfigEditors.test.tsxindex 8f7e5497d..3d457210e 100644--- a/packages/trueforge-ui/test/atoms/draft/AgentConfigEditors.test.tsx+++ b/packages/trueforge-ui/test/atoms/draft/AgentConfigEditors.test.tsx@@ -398,6 +398,32 @@ describe('AgentConfigEditors', () => {expect(screen.getByRole('switch', { name: 'Context compaction' })).toBeInTheDocument();});+ it('changes runtime switches only when the switch is clicked', () => {+ const onChange = vi.fn();+ render(+ <SlotsProvider>+ <AgentConfigEditors+ editor="runtime"+ spec={{ model: { name: 'openai/gpt' } }}+ models={[]}+ connectors={[]}+ skills={[]}+ loading={false}+ error={null}+ sandboxAvailable+ onChange={onChange}+ onClose={vi.fn()}+ />+ </SlotsProvider>,+ );++ fireEvent.click(screen.getByText('Context compaction'));+ expect(onChange).not.toHaveBeenCalled();++ fireEvent.click(screen.getByRole('switch', { name: 'Context compaction' }));+ expect(onChange).toHaveBeenCalledOnce();+ });+it('retains nested runtime values while their parent is disabled', () => {const spec: AgentSpec = {model: { name: 'openai/gpt' },diff --git a/packages/trueforge-ui/test/atoms/draft/DraftComposerSections.test.tsx b/packages/trueforge-ui/test/atoms/draft/DraftComposerSections.test.tsxindex 2fe4be041..112304679 100644--- a/packages/trueforge-ui/test/atoms/draft/DraftComposerSections.test.tsx+++ b/packages/trueforge-ui/test/atoms/draft/DraftComposerSections.test.tsx@@ -89,6 +89,19 @@ describe('draft composer sections', () => {expect(screen.queryByRole('button', { name: 'Agent config' })).not.toBeInTheDocument();});+ it('keeps only the reasoning selector in the builder composer', async () => {+ render(+ <ShellModeProvider agentConfig={{ mode: 'AgentComposer' }}>+ <BuilderMode>+ <DraftSections />+ </BuilderMode>+ </ShellModeProvider>,+ );++ expect(await screen.findByTitle('Select reasoning effort')).toHaveTextContent('high');+ expect(screen.queryByTitle('Select model')).not.toBeInTheDocument();+ });+it('shows the Agent config trigger only in compact builder layouts', () => {const { rerender } = render(<ShellModeProvider agentConfig={{ mode: 'AgentComposer' }}>diff --git a/packages/trueforge-ui/test/atoms/primitives/PopoverSelect.test.tsx b/packages/trueforge-ui/test/atoms/primitives/PopoverSelect.test.tsxindex 29dfe233b..368924e6c 100644--- a/packages/trueforge-ui/test/atoms/primitives/PopoverSelect.test.tsx+++ b/packages/trueforge-ui/test/atoms/primitives/PopoverSelect.test.tsx@@ -83,7 +83,6 @@ describe('PopoverSelect', () => {fireEvent.click(screen.getByRole('button', { name: 'Timezone' }));- expect(screen.getByRole('listbox').className).toContain('bottom-full');- expect(screen.getByRole('listbox').className).toContain('mb-1');+ expect(screen.getByRole('listbox').parentElement).toHaveClass('bottom-full', 'mb-1');});});diff --git a/packages/trueforge-ui/test/atoms/schedules/ScheduleFormDrawer.test.tsx b/packages/trueforge-ui/test/atoms/schedules/ScheduleFormDrawer.test.tsxindex abaada2a2..6177b333c 100644--- a/packages/trueforge-ui/test/atoms/schedules/ScheduleFormDrawer.test.tsx+++ b/packages/trueforge-ui/test/atoms/schedules/ScheduleFormDrawer.test.tsx@@ -6,6 +6,7 @@ import { beforeAll, describe, expect, it, vi } from 'vitest';import { ScheduleFormDrawer } from '@/atoms/schedules/ScheduleFormDrawer.js';import { ToasterProvider } from '@/containers/ToasterContainer.js';import { ServerProvider } from '@/server/ServerContext.js';+import { ShellModeProvider, useShellMode } from '@/server/ShellModeContext.js';import type { AgentUIServer, ConnectorBase, Schedule, ScheduleServer } from '@/server/types.js';import { SlotsProvider } from '@/theme/SlotsProvider.js';import { createMockAgentUIServer, createMockCatalog } from '../../server/mockServer.js';@@ -74,13 +75,20 @@ function mockScheduleServer(overrides: Partial<ScheduleServer> = {}): ScheduleSe};}+function AgentBuilderProbe() {+ const { mode } = useShellMode();+ return mode.status === 'active' && mode.isCreateAgent ? <span>Agent builder open</span> : null;+}+function renderDrawer({server,scheduleServer,+ withShell = false,...props}: Partial<ComponentProps<typeof ScheduleFormDrawer>> & {server?: AgentUIServer;scheduleServer?: ScheduleServer;+ withShell?: boolean;}) {const agentServer =server ??@@ -110,13 +118,21 @@ function renderDrawer({}),});const schedules = scheduleServer ?? mockScheduleServer();+ const drawer = <ScheduleFormDrawer open mode="create" onOpenChange={() => undefined} {...props} />;return {schedules,...render(<SlotsProvider><ToasterProvider><ServerProvider server={{ ...agentServer, schedules }}>- <ScheduleFormDrawer open mode="create" onOpenChange={() => undefined} {...props} />+ {withShell ? (+ <ShellModeProvider>+ {drawer}+ <AgentBuilderProbe />+ </ShellModeProvider>+ ) : (+ drawer+ )}</ServerProvider></ToasterProvider></SlotsProvider>,@@ -142,6 +158,23 @@ describe('ScheduleFormDrawer', () => {});});+ it('offers to build an agent when none have been created', async () => {+ const onOpenChange = vi.fn();+ renderDrawer({+ server: createMockAgentUIServer({ searchAgents: vi.fn(async () => []) }),+ onOpenChange,+ withShell: true,+ });++ fireEvent.click(await screen.findByLabelText('Agent'));++ expect(await screen.findByText('No Agents created yet')).toBeInTheDocument();+ fireEvent.click(screen.getByRole('button', { name: 'Build Agent' }));++ expect(onOpenChange).toHaveBeenCalledWith(false);+ expect(screen.getByText('Agent builder open')).toBeInTheDocument();+ });+it('disables agent picker on edit', async () => {renderDrawer({ mode: 'edit', schedule: pausedSchedule({ status: 'active' }) });expect(await screen.findByLabelText('Agent')).toBeDisabled();@@ -150,7 +183,7 @@ describe('ScheduleFormDrawer', () => {it('groups standard recurrence controls with a schedule summary', async () => {renderDrawer({});- const recurrence = within(await screen.findByRole('group', { name: 'Recurrence' }));+ const recurrence = within(await screen.findByRole('group', { name: 'Frequency' }));expect(recurrence.getByRole('button', { name: 'Hourly' })).toBeInTheDocument();expect(recurrence.getByRole('button', { name: 'Daily' })).toBeInTheDocument();expect(recurrence.getByRole('button', { name: 'Weekly' })).toBeInTheDocument();@@ -159,6 +192,12 @@ describe('ScheduleFormDrawer', () => {expect(recurrence.queryByLabelText('Cron expression')).not.toBeInTheDocument();expect(recurrence.getByText('Schedule')).toBeInTheDocument();expect(recurrence.getByText(/^Daily 9:00 AM/)).toBeInTheDocument();++ fireEvent.click(recurrence.getByRole('button', { name: 'Weekly' }));+ expect(+ recurrence.getByText('Days').compareDocumentPosition(recurrence.getByText('Hour')) &+ Node.DOCUMENT_POSITION_FOLLOWING,+ ).toBeTruthy();});it('keeps a legacy custom cron read-only until its recurrence is replaced', async () => {diff --git a/packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsx b/packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsxindex b4646852e..b42335997 100644--- a/packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsx+++ b/packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsx@@ -61,6 +61,7 @@ function renderPage(overrides: Partial<ScheduleServer> = {},listImpl?: ScheduleServer['listSchedules'],searchAgents?: AgentUIServer['searchAgents'],+ options: { agentId?: string } = {},) {const scheduleServer: ScheduleServer = {listSchedules: vi.fn(@@ -84,7 +85,7 @@ function renderPage(render(<ServerProvider server={server}><ToasterProvider>- <SchedulesPage />+ <SchedulesPage {...options} /></ToasterProvider></ServerProvider>,);@@ -104,6 +105,18 @@ describe('SchedulesPage', () => {expect(scheduleServer.listSchedules).toHaveBeenCalledWith(expect.objectContaining({ limit: 10 }));});+ it('locks embedded schedules to the supplied agent', async () => {+ const { scheduleServer } = renderPage(sampleSchedules, {}, undefined, undefined, { agentId: 'demo-agent' });++ await waitFor(() => {+ expect(scheduleServer.listSchedules).toHaveBeenCalledWith(+ expect.objectContaining({ agentIds: ['demo-agent'], limit: 10 }),+ );+ });+ expect(screen.queryByRole('heading', { name: 'Scheduled Agents' })).not.toBeInTheDocument();+ expect(screen.queryByRole('button', { name: 'Filter by agent' })).not.toBeInTheDocument();+ });+it('shows empty state when there are no schedules', async () => {renderPage([]);expect(await screen.findByRole('heading', { name: 'No Schedules Found' })).toBeInTheDocument();diff --git a/packages/trueforge-ui/test/containers/ComposerContainer.test.tsx b/packages/trueforge-ui/test/containers/ComposerContainer.test.tsxindex dfc603c2f..c15620707 100644--- a/packages/trueforge-ui/test/containers/ComposerContainer.test.tsx+++ b/packages/trueforge-ui/test/containers/ComposerContainer.test.tsx@@ -3,7 +3,7 @@ import type { AppendMessage } from '@assistant-ui/react';import { fireEvent, render, screen, waitFor } from '@testing-library/react';import { beforeEach, describe, expect, it, vi } from 'vitest';-import { ComposerContainer } from '@/containers/ComposerContainer.js';+import { canSubmitComposer, ComposerContainer } from '@/containers/ComposerContainer.js';import { ComposerBusyProvider } from '@/hooks/useComposerBusyState.js';import {CustomActionRenderersProvider,@@ -39,14 +39,6 @@ vi.mock('@truefoundry/assistant-ui-runtime', () => ({useTrueFoundryAgentSpec: () => ({ agentSpec: agentSpecState.agentSpec }),}));-vi.mock('@assistant-ui/core/react', async importOriginal => {- const actual = await importOriginal<typeof import('@assistant-ui/core/react')>();- return {- ...actual,- useThreadIsRunning: () => false,- };-});-function SecretSelectProbe({ onSubmit }: CustomActionRendererProps) {return (<button type="button" onClick={() => onSubmit('chosen-secret')}>@@ -65,6 +57,45 @@ function renderComposer(onNew?: (message: AppendMessage) => Promise<void>) {);}+describe('canSubmitComposer', () => {+ it.each([+ { name: 'New Chat', requiresModel: true, hasModel: true },+ { name: 'Try Agent', requiresModel: false, hasModel: false },+ { name: 'Build Agent', requiresModel: true, hasModel: true },+ ])('allows attachment-only submission in $name', ({ requiresModel, hasModel }) => {+ expect(+ canSubmitComposer({+ disabled: false,+ hasText: false,+ hasAttachments: true,+ requiresModel,+ hasModel,+ }),+ ).toBe(true);+ });++ it('blocks empty messages and mutable drafts without a model', () => {+ expect(+ canSubmitComposer({+ disabled: false,+ hasText: false,+ hasAttachments: false,+ requiresModel: false,+ hasModel: false,+ }),+ ).toBe(false);+ expect(+ canSubmitComposer({+ disabled: false,+ hasText: false,+ hasAttachments: true,+ requiresModel: true,+ hasModel: false,+ }),+ ).toBe(false);+ });+});+describe('ComposerContainer', () => {beforeEach(() => {agentSpecState.agentSpec = { model: { name: 'test/model' } };diff --git a/packages/trueforge-ui/test/routing/paths.test.ts b/packages/trueforge-ui/test/routing/paths.test.tsindex cf052d1a4..9373fe0e4 100644--- a/packages/trueforge-ui/test/routing/paths.test.ts+++ b/packages/trueforge-ui/test/routing/paths.test.ts@@ -113,6 +113,13 @@ describe('sanitizeSearchForPlace', () => {);expect(sanitizeSearchForPlace({ type: 'library' }, scheduleSearch)).toBe('?theme=dark');});++ it('keeps embedded schedule state on an agent Schedules tab', () => {+ const search = '?theme=dark&agentId=agent-1&tab=schedules&agent=stale&status=paused&q=digest&isNew=true';+ expect(sanitizeSearchForPlace({ type: 'libraryAgent', agentId: 'agent-1' }, search)).toBe(+ '?theme=dark&agentId=agent-1&tab=schedules&status=paused&q=digest&isNew=true',+ );+ });});describe('matchPath', () => {diff --git a/packages/trueforge-ui/test/utils/sessionEventTimeline.test.ts b/packages/trueforge-ui/test/utils/sessionEventTimeline.test.tsindex 005d9b6ed..5bf9f003c 100644--- a/packages/trueforge-ui/test/utils/sessionEventTimeline.test.ts+++ b/packages/trueforge-ui/test/utils/sessionEventTimeline.test.ts@@ -14,7 +14,7 @@ import {getSubAgentLanes,groupCoincidentTimelineMarkers,groupOverlappingToolCalls,- pickLongestNonOverlappingSegments,+ mergeOverlappingSubAgentSegments,} from '@/utils/sessionEventTimelineChart.js';import { buildSessionTurnViews } from '@/utils/sessionTurnViews.js';@@ -186,6 +186,69 @@ describe('buildSessionTimelineSegments', () => {assert.equal(groups.length, 1);assert.equal(groups[0]?.segments.length, 2);});++ it('waits only for the first sub-agent in a concurrent batch', () => {+ const subAgentEvents: SessionEventItem[] = [+ {+ turnId: 't1',+ event: {+ type: 'model.message',+ id: 'model-sub-agents',+ threadId: 'main',+ content: '',+ createdAt: '2026-01-01T00:00:00.005Z',+ toolCalls: ['a', 'b', 'c'].map(id => ({+ id: `call-${id}`,+ type: 'function',+ function: { name: 'create_sub_agent', arguments: '{}' },+ })),+ },+ },+ ...['a', 'b', 'c'].map((id, index): SessionEventItem => ({+ turnId: 't1',+ event: {+ type: 'thread.created',+ id: `thread-${id}`,+ threadId: `child-${id}`,+ title: `Agent ${id}`,+ createdAt: `2026-01-01T00:00:00.0${10 + index * 5}Z`,+ agentInfo: { type: 'dynamic', name: `agent-${id}`, input: id },+ parent: { threadId: 'main', toolCallId: `call-${id}` },+ },+ })),+ ...['a', 'b', 'c'].map((id, index): SessionEventItem => ({+ turnId: 't1',+ event: {+ type: 'thread.done',+ id: `thread-${id}-done`,+ threadId: `child-${id}`,+ title: `Agent ${id}`,+ createdAt: `2026-01-01T00:00:00.0${40 + index * 10}Z`,+ state: { status: 'completed' },+ },+ })),+ ];+ const turns = buildSessionTurnViews([+ created({ turnId: 't1', createdAt: '2026-01-01T00:00:00.000Z' }),+ ...subAgentEvents,+ done({ turnId: 't1', createdAt: '2026-01-01T00:00:00.070Z' }),+ ]);++ const segments = buildSessionTimelineSegments(turns);+ assert.deepEqual(+ segments+ .filter(segment => segment.title === 'system.waiting_for_sub_agent')+ .map(segment => [segment.startMs, segment.endMs]),+ [[5, 10]],+ );+ assert.deepEqual(+ mergeOverlappingSubAgentSegments(segments.filter(segment => segment.type === 'sub_agent')).map(segment => [+ segment.startMs,+ segment.endMs,+ ]),+ [[10, 60]],+ );+ });});describe('sessionEventTimelineChart helpers', () => {@@ -216,21 +279,21 @@ describe('sessionEventTimelineChart helpers', () => {isMarker: true,});- it('picks the longest non-overlapping sub-agent bars', () => {- const selected = pickLongestNonOverlappingSegments(+ it('merges overlapping sub-agent bars from the first start through the last end', () => {+ const selected = mergeOverlappingSubAgentSegments(bars([- [0, 10, 0],- [2, 4, 0],- [12, 20, 0],+ [10, 40, 0],+ [15, 50, 0],+ [20, 60, 0],]),);assert.deepEqual(- selected.map(segment => segment.id),- ['s0', 's2'],+ selected.map(segment => ({ id: segment.id, startMs: segment.startMs, endMs: segment.endMs })),+ [{ id: 's0', startMs: 10, endMs: 60 }],);});- it('scopes each sub-agent tooltip to runs directly overlapping its visible bar', () => {+ it('scopes each sub-agent tooltip to its merged visible bar', () => {const subAgents = bars([[0, 10, 0],[9, 11, 0],@@ -240,7 +303,7 @@ describe('sessionEventTimelineChart helpers', () => {type: 'sub_agent',threadId: `child-${index}`,}));- const visibleBars = pickLongestNonOverlappingSegments(subAgents);+ const visibleBars = mergeOverlappingSubAgentSegments(subAgents);const groups = getSubAgentHoverGroups({bars: visibleBars,subAgentSegments: subAgents,@@ -248,7 +311,7 @@ describe('sessionEventTimelineChart helpers', () => {assert.deepEqual(visibleBars.map(segment => segment.id),- ['s0', 's2'],+ ['s0'],);assert.deepEqual(groups.map(group => ({@@ -257,10 +320,7 @@ describe('sessionEventTimelineChart helpers', () => {endMs: group.endMs,segments: group.segments.map(segment => segment.id),})),- [- { barId: 's0', startMs: 0, endMs: 10, segments: ['s0', 's1'] },- { barId: 's2', startMs: 10.5, endMs: 20, segments: ['s1', 's2'] },- ],+ [{ barId: 's0', startMs: 0, endMs: 20, segments: ['s0', 's1', 's2'] }],);});diff --git a/packages/trueforge-ui/test/utils/sessionShareUrl.test.ts b/packages/trueforge-ui/test/utils/sessionShareUrl.test.tsindex ffbe51952..cb8b2d10c 100644--- a/packages/trueforge-ui/test/utils/sessionShareUrl.test.ts+++ b/packages/trueforge-ui/test/utils/sessionShareUrl.test.ts@@ -101,5 +101,6 @@ describe('sessionShareUrl', () => {);assert.equal(libraryAgentTabFromSearch(readSessionShareSearch('?tab=code'), 'agent-1'), 'code');assert.equal(libraryAgentTabFromSearch(readSessionShareSearch('?tab=metrics'), 'agent-1'), 'metrics');+ assert.equal(libraryAgentTabFromSearch(readSessionShareSearch('?tab=schedules'), 'agent-1'), 'schedules');});});