The open-source agent harness - the runtime layer that turns an LLM into a working agent.
bugfix: add tooltip to display full model name in model selector (#1026)
harshil-20962bbdf4eb76be
diff --git a/.changeset/draft-model-selector-full-name-tooltip.md b/.changeset/draft-model-selector-full-name-tooltip.mdnew file mode 100644index 000000000..97dc0c36d--- /dev/null+++ b/.changeset/draft-model-selector-full-name-tooltip.md@@ -0,0 +1,5 @@+---+'@truefoundry/trueforge-ui': patch+---++Show the full model name in a tooltip when the new-chat model selector label is truncated.diff --git a/packages/trueforge-ui/src/atoms/draft/DraftModelSelector.tsx b/packages/trueforge-ui/src/atoms/draft/DraftModelSelector.tsxindex 504465d05..5489bfa24 100644--- a/packages/trueforge-ui/src/atoms/draft/DraftModelSelector.tsx+++ b/packages/trueforge-ui/src/atoms/draft/DraftModelSelector.tsx@@ -11,6 +11,7 @@ import { cn } from '../lib/cn.js';import { useCompactLayout } from '../lib/CompactLayoutContext.js';import { useIsMobile } from '../lib/useIsMobile.js';import { BottomSheet } from '../primitives/BottomSheet.js';+import { Tooltip } from '../primitives/Tooltip.js';import { useDraftCatalog } from './DraftCatalogProvider.js';import { displayModelLabel, DraftModelCatalogPanel, ProviderMark } from './DraftModelCatalogPanel.js';import { modelPatchWithReasoningEffort } from './reasoningEffort.js';@@ -113,24 +114,26 @@ export function DraftModelSelector({ disabled, isRunning }: DraftModelSelectorPrreturn (<div ref={containerRef} className="relative">- <button- type="button"- disabled={disabled || isRunning}- aria-haspopup="listbox"- aria-expanded={open}- aria-controls={open ? menuId : undefined}- title="Select model"- className={auiButtonClass({- variant: 'ghost',- size: 'small',- className: cn('h-8 max-w-48 gap-1.5 rounded-full px-2 text-xs font-medium', 'hover:bg-ghost-button-hover'),- })}- onClick={() => setOpen(v => !v)}- >- <ProviderMark logo={selected?.provider.logo} label={account} className="size-4 text-xs" />- <span className="truncate">{label}</span>- <Icon name="chevron-down" className="size-3.5 shrink-0 opacity-60" />- </button>+ <Tooltip content={selectedName || 'Select model'} className="max-w-xs whitespace-normal break-all">+ <button+ type="button"+ disabled={disabled || isRunning}+ aria-haspopup="listbox"+ aria-expanded={open}+ aria-controls={open ? menuId : undefined}+ aria-label="Select model"+ className={auiButtonClass({+ variant: 'ghost',+ size: 'small',+ className: cn('h-8 max-w-48 gap-1.5 rounded-full px-2 text-xs font-medium', 'hover:bg-ghost-button-hover'),+ })}+ onClick={() => setOpen(v => !v)}+ >+ <ProviderMark logo={selected?.provider.logo} label={account} className="size-4 text-xs" />+ <span className="truncate">{label}</span>+ <Icon name="chevron-down" className="size-3.5 shrink-0 opacity-60" />+ </button>+ </Tooltip>{open ? (isMobile || compactLayout ? (diff --git a/packages/trueforge-ui/test/atoms/draft/DraftComposerSections.test.tsx b/packages/trueforge-ui/test/atoms/draft/DraftComposerSections.test.tsxindex 369f32d25..4a150dbe3 100644--- a/packages/trueforge-ui/test/atoms/draft/DraftComposerSections.test.tsx+++ b/packages/trueforge-ui/test/atoms/draft/DraftComposerSections.test.tsx@@ -88,7 +88,7 @@ describe('draft composer sections', () => {it('composes model and reasoning selectors in the right section', async () => {render(<DraftSections />);- expect(await screen.findByTitle('Select model')).toHaveTextContent('gpt-4.1');+ expect(await screen.findByRole('button', { name: 'Select model' })).toHaveTextContent('gpt-4.1');expect(await screen.findByTitle('Select reasoning effort')).toHaveTextContent('high');// Without shell builder mode, left chrome is Tools — not Agent config.expect(screen.queryByRole('button', { name: 'Agent config' })).not.toBeInTheDocument();@@ -104,7 +104,7 @@ describe('draft composer sections', () => {);expect(await screen.findByTitle('Select reasoning effort')).toHaveTextContent('high');- expect(screen.queryByTitle('Select model')).not.toBeInTheDocument();+ expect(screen.queryByRole('button', { name: 'Select model' })).not.toBeInTheDocument();});it('shows the Agent config trigger only in compact builder layouts', () => {@@ -147,12 +147,12 @@ describe('draft composer sections', () => {const { rerender } = render(<DraftSections disabled />);expect(screen.getByRole('button', { name: 'Tools (3)' })).toBeDisabled();- expect(await screen.findByTitle('Select model')).toBeDisabled();+ expect(await screen.findByRole('button', { name: 'Select model' })).toBeDisabled();expect(await screen.findByTitle('Select reasoning effort')).toBeDisabled();rerender(<DraftSections isRunning />);expect(screen.getByRole('button', { name: 'Tools (3)' })).toBeDisabled();- expect(await screen.findByTitle('Select model')).toBeDisabled();+ expect(await screen.findByRole('button', { name: 'Select model' })).toBeDisabled();expect(await screen.findByTitle('Select reasoning effort')).toBeDisabled();});});diff --git a/packages/trueforge-ui/test/atoms/draft/DraftModelSelector.test.tsx b/packages/trueforge-ui/test/atoms/draft/DraftModelSelector.test.tsxindex d9cf85537..d6638d2e4 100644--- a/packages/trueforge-ui/test/atoms/draft/DraftModelSelector.test.tsx+++ b/packages/trueforge-ui/test/atoms/draft/DraftModelSelector.test.tsx@@ -69,10 +69,33 @@ describe('DraftModelSelector', () => {updateAgentSpec.mockReset();});+ it('shows the full model name in a tooltip on hover', async () => {+ const longName = 'global.anthropic.claude-sonnet-4-20250514';+ agentSpec = { model: { name: longName } };+ renderSelector(+ {},+ {+ getModels: async () => [+ {+ id: 'claude-sonnet-4',+ name: longName,+ provider: { name: 'Anthropic' },+ properties: {},+ },+ ],+ },+ );++ const trigger = await screen.findByRole('button', { name: 'Select model' });+ await waitFor(() => expect(trigger).toHaveTextContent(longName));+ fireEvent.mouseEnter(trigger);+ expect(screen.getByRole('tooltip')).toHaveTextContent(longName);+ });+it('filters models and updates the agent spec when a model is selected', async () => {renderSelector();- const trigger = await screen.findByTitle('Select model');+ const trigger = await screen.findByRole('button', { name: 'Select model' });await waitFor(() => expect(trigger).toHaveTextContent('gpt-4.1'));expect(trigger.querySelector('img')?.getAttribute('src')).toBe('https://assets.example/openai.svg');fireEvent.click(trigger);@@ -122,7 +145,7 @@ describe('DraftModelSelector', () => {};renderSelector();- const trigger = await screen.findByTitle('Select model');+ const trigger = await screen.findByRole('button', { name: 'Select model' });await waitFor(() => expect(trigger).toHaveTextContent('claude-3.7-sonnet'));fireEvent.click(trigger);fireEvent.click(screen.getByRole('option', { name: /gpt-4.1/i }));@@ -139,7 +162,7 @@ describe('DraftModelSelector', () => {agentSpec = undefined;renderSelector();- await waitFor(() => expect(screen.getByTitle('Select model')).toHaveTextContent('gpt-4.1'));+ await waitFor(() => expect(screen.getByRole('button', { name: 'Select model' })).toHaveTextContent('gpt-4.1'));await waitFor(() => {expect(updateAgentSpec).toHaveBeenCalledWith({model: { name: 'openai/gpt-4.1' },@@ -161,17 +184,17 @@ describe('DraftModelSelector', () => {it('does not rewrite agentSpec when the selected model is already in the catalog', async () => {renderSelector();- await waitFor(() => expect(screen.getByTitle('Select model')).toHaveTextContent('gpt-4.1'));+ await waitFor(() => expect(screen.getByRole('button', { name: 'Select model' })).toHaveTextContent('gpt-4.1'));expect(updateAgentSpec).not.toHaveBeenCalled();});it('disables selection while disabled or running', () => {const { rerender } = render(<DraftModelSelector disabled />);- expect(screen.getByTitle('Select model')).toBeDisabled();+ expect(screen.getByRole('button', { name: 'Select model' })).toBeDisabled();rerender(<DraftModelSelector isRunning />);- expect(screen.getByTitle('Select model')).toBeDisabled();+ expect(screen.getByRole('button', { name: 'Select model' })).toBeDisabled();});it('shows a settings CTA when the host has a catalog and no models', async () => {@@ -183,7 +206,7 @@ describe('DraftModelSelector', () => {},);- fireEvent.click(await screen.findByTitle('Select model'));+ fireEvent.click(await screen.findByRole('button', { name: 'Select model' }));const cta = await screen.findByRole('button', { name: /Please configure Models in the settings/i });expect(cta.querySelector('.underline')).toHaveTextContent('settings');@@ -195,7 +218,7 @@ describe('DraftModelSelector', () => {it('shows No models when the catalog is not configured', async () => {renderSelector({}, { getModels: async () => [] });- fireEvent.click(await screen.findByTitle('Select model'));+ fireEvent.click(await screen.findByRole('button', { name: 'Select model' }));await waitFor(() => expect(screen.getByText('No models')).toBeInTheDocument());expect(screen.queryByRole('button', { name: /Please configure Models/i })).not.toBeInTheDocument();});