The open-source agent harness - the runtime layer that turns an LLM into a working agent.
Remove unused sandbox network_policy from AgentSpec and docs. (#346)
debajyoti-truefoundry2ca7fb250ce6
diff --git a/.changeset/remove-sandbox-network-policy.md b/.changeset/remove-sandbox-network-policy.mdnew file mode 100644index 000000000..ebc63132d--- /dev/null+++ b/.changeset/remove-sandbox-network-policy.md@@ -0,0 +1,5 @@+---+'@truefoundry/trueforge-core': patch+---++Remove unused `config.sandbox.network_policy` (git auth inject) from the public AgentSpec.diff --git a/.github/fern/openapi/openapi.json b/.github/fern/openapi/openapi.jsonindex 59408e26d..f342b9f34 100644--- a/.github/fern/openapi/openapi.json+++ b/.github/fern/openapi/openapi.json@@ -2714,9 +2714,6 @@"default": true,"description": "Allow downloading agent-produced files via the turn download endpoint. Default: true.","type": "boolean"- },- "network_policy": {- "$ref": "#/components/schemas/SandboxNetworkPolicy"}},"required": [@@ -2762,78 +2759,6 @@],"type": "object"},- "SandboxNetworkPolicy": {- "properties": {- "auth_inject": {- "description": "Up to one rule injecting git basic-auth credentials for exact hosts.",- "items": {- "properties": {- "auth_data": {- "properties": {- "password": {- "description": "Basic-auth password.",- "minLength": 1,- "type": "string"- },- "type": {- "description": "Basic auth credential type.",- "enum": [- "basic"- ],- "type": "string"- },- "username": {- "description": "Basic-auth username (no whitespace).",- "pattern": "^\\S+$",- "type": "string"- }- },- "required": [- "type",- "username",- "password"- ],- "type": "object"- },- "match": {- "properties": {- "hosts": {- "description": "Hostnames that receive injected credentials.",- "items": {- "description": "Exact hostname to match (no wildcards).",- "minLength": 1,- "type": "string"- },- "minItems": 1,- "type": "array"- }- },- "required": [- "hosts"- ],- "type": "object"- },- "type": {- "description": "Inject credentials for git HTTPS clones.",- "enum": [- "git"- ],- "type": "string"- }- },- "required": [- "type",- "match",- "auth_data"- ],- "type": "object"- },- "maxItems": 1,- "type": "array"- }- },- "type": "object"- },"SandboxProvider": {"additionalProperties": false,"properties": {diff --git a/docs/create-agent/overview.mdx b/docs/create-agent/overview.mdxindex 845db64a3..927978f07 100644--- a/docs/create-agent/overview.mdx+++ b/docs/create-agent/overview.mdx@@ -66,9 +66,9 @@ Each option below is part of the agent definition. The **Set in** line on each s<Accordion title="Sandbox" icon="box">An isolated environment for running code, files, and shell commands, separate from the server. It's **off by default** and provisioned only when the agent needs it. Required for [skills](/skills) and [Code Mode](/key-features/code-mode).- Optional extras (API): allow clients to **download files** the agent produces, and **inject git credentials** so the sandbox can clone private repos without the agent ever seeing the secret.+ Optional extras (API): allow clients to **download files** the agent produces.- **Set in:** UI (on/off) · API (on/off + file downloads + git auth injection)+ **Set in:** UI (on/off) · API (on/off + file downloads)</Accordion><Accordion title="Generative UI" icon="chart-column">@@ -327,7 +327,6 @@ Runtime behavior. Every field has a default, so `config` can be omitted entirely| ---------------------------- | ------- | -------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- || `enabled` | `false` | UI + API | Give the agent a sandbox. Required for skills and Code Mode. || `file_downloads` | `true` | API | Allow clients to download files the agent produces in the sandbox. |-| `network_policy.auth_inject` | — | API | Up to one rule injecting git basic-auth credentials for exact hosts: `{ "type": "git", "match": { "hosts": ["github.com"] }, "auth_data": { "type": "basic", "username": "...", "password": "..." } }`. |#### `config.context_management`diff --git a/docs/openapi.json b/docs/openapi.jsonindex 59408e26d..f342b9f34 100644--- a/docs/openapi.json+++ b/docs/openapi.json@@ -2714,9 +2714,6 @@"default": true,"description": "Allow downloading agent-produced files via the turn download endpoint. Default: true.","type": "boolean"- },- "network_policy": {- "$ref": "#/components/schemas/SandboxNetworkPolicy"}},"required": [@@ -2762,78 +2759,6 @@],"type": "object"},- "SandboxNetworkPolicy": {- "properties": {- "auth_inject": {- "description": "Up to one rule injecting git basic-auth credentials for exact hosts.",- "items": {- "properties": {- "auth_data": {- "properties": {- "password": {- "description": "Basic-auth password.",- "minLength": 1,- "type": "string"- },- "type": {- "description": "Basic auth credential type.",- "enum": [- "basic"- ],- "type": "string"- },- "username": {- "description": "Basic-auth username (no whitespace).",- "pattern": "^\\S+$",- "type": "string"- }- },- "required": [- "type",- "username",- "password"- ],- "type": "object"- },- "match": {- "properties": {- "hosts": {- "description": "Hostnames that receive injected credentials.",- "items": {- "description": "Exact hostname to match (no wildcards).",- "minLength": 1,- "type": "string"- },- "minItems": 1,- "type": "array"- }- },- "required": [- "hosts"- ],- "type": "object"- },- "type": {- "description": "Inject credentials for git HTTPS clones.",- "enum": [- "git"- ],- "type": "string"- }- },- "required": [- "type",- "match",- "auth_data"- ],- "type": "object"- },- "maxItems": 1,- "type": "array"- }- },- "type": "object"- },"SandboxProvider": {"additionalProperties": false,"properties": {diff --git a/docs/sandbox.mdx b/docs/sandbox.mdxindex fc7f37895..a71828040 100644--- a/docs/sandbox.mdx+++ b/docs/sandbox.mdx@@ -14,8 +14,8 @@ There are two common patterns for combining agents with sandboxes:| Pattern | Where the agent runs | Trade-off || --- | --- | --- |-| **Agent in sandbox** | Inside the sandbox image | Secrets must live in the sandbox; updates mean rebuilding images |-| **Sandbox as tool** | Outside, on the server | Secrets stay in the harness; sandbox is only for exec/files |+| **Agent in sandbox** | Inside the sandbox image | Sandbox is provisioned even for the simplest request; secrets must live in the sandbox; updates mean rebuilding images |+| **Sandbox as tool** | Outside, on the server | Sandbox is provisioned on demand when needed; secrets stay in the harness; sandbox is only for exec/files |TrueForge uses **sandbox as tool**: the agent loop and credentials stay in the harness; the sandbox only runs code, file, and shell operations.@@ -51,7 +51,6 @@ The sandbox is **off by default** per agent. Turn it on in the agent builder wheOptional controls:- **File downloads** — let users download files the agent produces (on by default in the chat UI).-- **Git auth inject** — inject credentials for private git hosts so the sandbox can clone repos without the agent seeing the secret.## Lifecycle@@ -63,4 +62,3 @@ Optional controls:- Model and MCP credentials stay in the harness.- MCP calls from [Code Mode](/key-features/code-mode) scripts are bridged back to the harness — the sandbox never holds those tokens.-- The only credentials that enter the sandbox are ones you explicitly inject for private git clones.diff --git a/eslint.config.mjs b/eslint.config.mjsindex 14373946e..58d4670e4 100644--- a/eslint.config.mjs+++ b/eslint.config.mjs@@ -55,6 +55,8 @@ export default defineConfig('**/*.test.ts',// Fern-generated SDK: not part of any tsconfig project, and not ours to lint.'packages/trueforge-sdk/**',+ // Build-generated sources (catalogs, sandbox scripts); not in package tsconfigs.+ '**/*.gen.ts',],},{diff --git a/packages/trueforge-core/src/agent-session/schemas/agentSpec.ts b/packages/trueforge-core/src/agent-session/schemas/agentSpec.tsindex 8c83fa2b8..0493c8cde 100644--- a/packages/trueforge-core/src/agent-session/schemas/agentSpec.ts+++ b/packages/trueforge-core/src/agent-session/schemas/agentSpec.ts@@ -151,53 +151,6 @@ const LargeToolResponseSettingsSchema = z.object({),});-const BASIC_AUTH_USERNAME_PATTERN = /^\S+$/;--/** True when any hostname segment contains `*` (e.g. `*.github.com`). */-function hostContainsWildcard(host: string): boolean {- return host.split('.').some(segment => segment.includes('*'));-}--const SandboxAuthInjectMatchSchema = z.object({- hosts: z- .array(- z- .string()- .min(1)- .refine(host => !hostContainsWildcard(host), {- message: 'Hosts must be exact hostnames without wildcards',- })- .describe('Exact hostname to match (no wildcards).'),- )- .min(1)- .describe('Hostnames that receive injected credentials.'),-});--const SandboxBasicAuthDataSchema = z.object({- type: z.literal('basic').describe('Basic auth credential type.'),- username: z- .string()- .regex(BASIC_AUTH_USERNAME_PATTERN, 'Username must be non-empty and contain no whitespace')- .describe('Basic-auth username (no whitespace).'),- password: z.string().min(1).describe('Basic-auth password.'),-});--const SandboxGitAuthInjectSchema = z.object({- type: z.literal('git').describe('Inject credentials for git HTTPS clones.'),- match: SandboxAuthInjectMatchSchema,- auth_data: SandboxBasicAuthDataSchema,-});--const SandboxNetworkPolicySchema = z- .object({- auth_inject: z- .array(SandboxGitAuthInjectSchema)- .max(1, 'At most one auth inject rule is supported (type: git)')- .optional()- .describe('Up to one rule injecting git basic-auth credentials for exact hosts.'),- })- .openapi('SandboxNetworkPolicy');-const SandboxConfigSchema = z.object({enabled: z.boolean().describe('Give the agent a sandbox. Required for skills and Code Mode.'),@@ -205,7 +158,6 @@ const SandboxConfigSchema = z.boolean().default(true).describe('Allow downloading agent-produced files via the turn download endpoint. Default: true.'),- network_policy: SandboxNetworkPolicySchema.optional(),}).openapi('SandboxConfig');diff --git a/packages/trueforge-sdk/src/api/types/SandboxConfig.ts b/packages/trueforge-sdk/src/api/types/SandboxConfig.tsindex 3f3a3a2e6..ebd8ca110 100644--- a/packages/trueforge-sdk/src/api/types/SandboxConfig.ts+++ b/packages/trueforge-sdk/src/api/types/SandboxConfig.ts@@ -1,11 +1,8 @@// This file was auto-generated by Fern from our API Definition.-import type * as TrueForge from "../index.js";-export interface SandboxConfig {/** Give the agent a sandbox. Required for skills and Code Mode. */enabled: boolean;/** Allow downloading agent-produced files via the turn download endpoint. Default: true. */fileDownloads?: boolean;- networkPolicy?: TrueForge.SandboxNetworkPolicy;}diff --git a/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicy.ts b/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicy.tsdeleted file mode 100644index d537d0ad9..000000000--- a/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicy.ts+++ /dev/null@@ -1,8 +0,0 @@-// This file was auto-generated by Fern from our API Definition.--import type * as TrueForge from "../index.js";--export interface SandboxNetworkPolicy {- /** Up to one rule injecting git basic-auth credentials for exact hosts. */- authInject?: TrueForge.SandboxNetworkPolicyAuthInjectItem[];-}diff --git a/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItem.ts b/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItem.tsdeleted file mode 100644index e41ddec6b..000000000--- a/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItem.ts+++ /dev/null@@ -1,10 +0,0 @@-// This file was auto-generated by Fern from our API Definition.--import type * as TrueForge from "../index.js";--export interface SandboxNetworkPolicyAuthInjectItem {- authData: TrueForge.SandboxNetworkPolicyAuthInjectItemAuthData;- match: TrueForge.SandboxNetworkPolicyAuthInjectItemMatch;- /** Inject credentials for git HTTPS clones. */- type: "git";-}diff --git a/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItemAuthData.ts b/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItemAuthData.tsdeleted file mode 100644index c2a770a34..000000000--- a/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItemAuthData.ts+++ /dev/null@@ -1,10 +0,0 @@-// This file was auto-generated by Fern from our API Definition.--export interface SandboxNetworkPolicyAuthInjectItemAuthData {- /** Basic-auth password. */- password: string;- /** Basic auth credential type. */- type: "basic";- /** Basic-auth username (no whitespace). */- username: string;-}diff --git a/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItemMatch.ts b/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItemMatch.tsdeleted file mode 100644index 97d1a238c..000000000--- a/packages/trueforge-sdk/src/api/types/SandboxNetworkPolicyAuthInjectItemMatch.ts+++ /dev/null@@ -1,6 +0,0 @@-// This file was auto-generated by Fern from our API Definition.--export interface SandboxNetworkPolicyAuthInjectItemMatch {- /** Hostnames that receive injected credentials. */- hosts: string[];-}diff --git a/packages/trueforge-sdk/src/api/types/index.ts b/packages/trueforge-sdk/src/api/types/index.tsindex 90b4501e3..ab8c00f19 100644--- a/packages/trueforge-sdk/src/api/types/index.ts+++ b/packages/trueforge-sdk/src/api/types/index.ts@@ -128,10 +128,6 @@ export * from "./RuntimeConfig.js";export * from "./SandboxBuildStatus.js";export * from "./SandboxConfig.js";export * from "./SandboxCreatedEvent.js";-export * from "./SandboxNetworkPolicy.js";-export * from "./SandboxNetworkPolicyAuthInjectItem.js";-export * from "./SandboxNetworkPolicyAuthInjectItemAuthData.js";-export * from "./SandboxNetworkPolicyAuthInjectItemMatch.js";export * from "./SandboxProvider.js";export * from "./SandboxProviderManifest.js";export * from "./Session.js";diff --git a/packages/trueforge-sdk/src/serialization/types/SandboxConfig.ts b/packages/trueforge-sdk/src/serialization/types/SandboxConfig.tsindex 08b00b6c2..6476134b7 100644--- a/packages/trueforge-sdk/src/serialization/types/SandboxConfig.ts+++ b/packages/trueforge-sdk/src/serialization/types/SandboxConfig.ts@@ -3,19 +3,16 @@import type * as TrueForge from "../../api/index.js";import * as core from "../../core/index.js";import type * as serializers from "../index.js";-import { SandboxNetworkPolicy } from "./SandboxNetworkPolicy.js";export const SandboxConfig: core.serialization.ObjectSchema<serializers.SandboxConfig.Raw, TrueForge.SandboxConfig> =core.serialization.object({enabled: core.serialization.boolean(),fileDownloads: core.serialization.property("file_downloads", core.serialization.boolean().optional()),- networkPolicy: core.serialization.property("network_policy", SandboxNetworkPolicy.optional()),});export declare namespace SandboxConfig {export interface Raw {enabled: boolean;file_downloads?: boolean | null;- network_policy?: SandboxNetworkPolicy.Raw | null;}}diff --git a/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicy.ts b/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicy.tsdeleted file mode 100644index 2b34573ee..000000000--- a/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicy.ts+++ /dev/null@@ -1,22 +0,0 @@-// This file was auto-generated by Fern from our API Definition.--import type * as TrueForge from "../../api/index.js";-import * as core from "../../core/index.js";-import type * as serializers from "../index.js";-import { SandboxNetworkPolicyAuthInjectItem } from "./SandboxNetworkPolicyAuthInjectItem.js";--export const SandboxNetworkPolicy: core.serialization.ObjectSchema<- serializers.SandboxNetworkPolicy.Raw,- TrueForge.SandboxNetworkPolicy-> = core.serialization.object({- authInject: core.serialization.property(- "auth_inject",- core.serialization.list(SandboxNetworkPolicyAuthInjectItem).optional(),- ),-});--export declare namespace SandboxNetworkPolicy {- export interface Raw {- auth_inject?: SandboxNetworkPolicyAuthInjectItem.Raw[] | null;- }-}diff --git a/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItem.ts b/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItem.tsdeleted file mode 100644index 576de24da..000000000--- a/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItem.ts+++ /dev/null@@ -1,24 +0,0 @@-// This file was auto-generated by Fern from our API Definition.--import type * as TrueForge from "../../api/index.js";-import * as core from "../../core/index.js";-import type * as serializers from "../index.js";-import { SandboxNetworkPolicyAuthInjectItemAuthData } from "./SandboxNetworkPolicyAuthInjectItemAuthData.js";-import { SandboxNetworkPolicyAuthInjectItemMatch } from "./SandboxNetworkPolicyAuthInjectItemMatch.js";--export const SandboxNetworkPolicyAuthInjectItem: core.serialization.ObjectSchema<- serializers.SandboxNetworkPolicyAuthInjectItem.Raw,- TrueForge.SandboxNetworkPolicyAuthInjectItem-> = core.serialization.object({- authData: core.serialization.property("auth_data", SandboxNetworkPolicyAuthInjectItemAuthData),- match: SandboxNetworkPolicyAuthInjectItemMatch,- type: core.serialization.stringLiteral("git"),-});--export declare namespace SandboxNetworkPolicyAuthInjectItem {- export interface Raw {- auth_data: SandboxNetworkPolicyAuthInjectItemAuthData.Raw;- match: SandboxNetworkPolicyAuthInjectItemMatch.Raw;- type: "git";- }-}diff --git a/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItemAuthData.ts b/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItemAuthData.tsdeleted file mode 100644index 7c451fe3f..000000000--- a/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItemAuthData.ts+++ /dev/null@@ -1,22 +0,0 @@-// This file was auto-generated by Fern from our API Definition.--import type * as TrueForge from "../../api/index.js";-import * as core from "../../core/index.js";-import type * as serializers from "../index.js";--export const SandboxNetworkPolicyAuthInjectItemAuthData: core.serialization.ObjectSchema<- serializers.SandboxNetworkPolicyAuthInjectItemAuthData.Raw,- TrueForge.SandboxNetworkPolicyAuthInjectItemAuthData-> = core.serialization.object({- password: core.serialization.string(),- type: core.serialization.stringLiteral("basic"),- username: core.serialization.string(),-});--export declare namespace SandboxNetworkPolicyAuthInjectItemAuthData {- export interface Raw {- password: string;- type: "basic";- username: string;- }-}diff --git a/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItemMatch.ts b/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItemMatch.tsdeleted file mode 100644index 8253e1bc9..000000000--- a/packages/trueforge-sdk/src/serialization/types/SandboxNetworkPolicyAuthInjectItemMatch.ts+++ /dev/null@@ -1,18 +0,0 @@-// This file was auto-generated by Fern from our API Definition.--import type * as TrueForge from "../../api/index.js";-import * as core from "../../core/index.js";-import type * as serializers from "../index.js";--export const SandboxNetworkPolicyAuthInjectItemMatch: core.serialization.ObjectSchema<- serializers.SandboxNetworkPolicyAuthInjectItemMatch.Raw,- TrueForge.SandboxNetworkPolicyAuthInjectItemMatch-> = core.serialization.object({- hosts: core.serialization.list(core.serialization.string()),-});--export declare namespace SandboxNetworkPolicyAuthInjectItemMatch {- export interface Raw {- hosts: string[];- }-}diff --git a/packages/trueforge-sdk/src/serialization/types/index.ts b/packages/trueforge-sdk/src/serialization/types/index.tsindex 90b4501e3..ab8c00f19 100644--- a/packages/trueforge-sdk/src/serialization/types/index.ts+++ b/packages/trueforge-sdk/src/serialization/types/index.ts@@ -128,10 +128,6 @@ export * from "./RuntimeConfig.js";export * from "./SandboxBuildStatus.js";export * from "./SandboxConfig.js";export * from "./SandboxCreatedEvent.js";-export * from "./SandboxNetworkPolicy.js";-export * from "./SandboxNetworkPolicyAuthInjectItem.js";-export * from "./SandboxNetworkPolicyAuthInjectItemAuthData.js";-export * from "./SandboxNetworkPolicyAuthInjectItemMatch.js";export * from "./SandboxProvider.js";export * from "./SandboxProviderManifest.js";export * from "./Session.js";diff --git a/packages/trueforge-ui/docs/server-types.temp.md b/packages/trueforge-ui/docs/server-types.temp.mdindex af9f0b949..435b20dee 100644--- a/packages/trueforge-ui/docs/server-types.temp.md+++ b/packages/trueforge-ui/docs/server-types.temp.md@@ -183,13 +183,6 @@ export interface RuntimeConfig {sandbox?: {enabled: boolean;fileDownloads?: boolean;- networkPolicy?: {- authInject?: Array<{- type: 'git';- match: { hosts: string[] };- authData: { type: 'basic'; username: string; password: string };- }>;- };};dynamicSubAgents?: { enabled?: boolean };contextManagement?: {diff --git a/packages/trueforge-ui/docs/server-types.temp.ts b/packages/trueforge-ui/docs/server-types.temp.tsindex 0efd44456..46650991e 100644--- a/packages/trueforge-ui/docs/server-types.temp.ts+++ b/packages/trueforge-ui/docs/server-types.temp.ts@@ -193,13 +193,6 @@ export interface RuntimeConfig {sandbox?: {enabled: boolean;fileDownloads?: boolean;- networkPolicy?: {- authInject?: Array<{- type: 'git';- match: { hosts: string[] };- authData: { type: 'basic'; username: string; password: string };- }>;- };};dynamicSubAgents?: { enabled?: boolean };contextManagement?: {diff --git a/packages/trueforge-ui/docs/server.md b/packages/trueforge-ui/docs/server.mdindex 59dab5178..392688a92 100644--- a/packages/trueforge-ui/docs/server.md+++ b/packages/trueforge-ui/docs/server.md@@ -376,13 +376,6 @@ interface RuntimeConfig {sandbox?: {enabled: boolean;fileDownloads?: boolean;- networkPolicy?: {- authInject?: Array<{- type: 'git';- match: { hosts: string[] };- authData: { type: 'basic'; username: string; password: string };- }>;- };};dynamicSubAgents?: { enabled?: boolean };contextManagement?: {