Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

Fix workflow call from release.yml

Chirag Jain37062bc25234
diff --git a/.github/workflows/build-and-prepare-chart-release.yml b/.github/workflows/build-and-prepare-chart-release.yml
index 12fae118d..c7738bbea 100644
--- a/.github/workflows/build-and-prepare-chart-release.yml
+++ b/.github/workflows/build-and-prepare-chart-release.yml
@@ -3,8 +3,21 @@ name: Build and prepare chart release
# Prod lane: build the npm-install Dockerfile, push {appVersion}-{shortSha},
# then open/update the chart-release bot PR (merge of that PR tags + publishes).
#
-# Triggered manually, including by release.yml through workflow_dispatch.
+# Called from release.yml after npm publish (same commit as the publish job).
+# workflow_dispatch is for manual rebuilds. Do not use `gh workflow run --ref
+# $GITHUB_SHA`: the dispatch API only accepts a branch or tag name (HTTP 422).
on:
+ workflow_call:
+ inputs:
+ app_version:
+ description: npm version to install (empty = Chart.yaml appVersion)
+ required: false
+ type: string
+ update_app_version:
+ description: Also set Chart.yaml appVersion to app_version on the bot PR
+ required: false
+ type: boolean
+ default: false
workflow_dispatch:
inputs:
app_version:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 7fd97bf70..71f981105 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -141,8 +141,10 @@ jobs:
needs: pack
runs-on: ubuntu-latest
timeout-minutes: 20
+ outputs:
+ trueforge_published: ${{ steps.trueforge.outputs.published }}
+ trueforge_version: ${{ steps.trueforge.outputs.version }}
permissions:
- actions: write
contents: write
id-token: write
steps:
@@ -208,15 +210,18 @@ jobs:
echo "@truefoundry/trueforge was not in this publish set"
fi
- - name: Start prod image release
- if: steps.trueforge.outputs.published == 'true'
- env:
- GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- VERSION: ${{ steps.trueforge.outputs.version }}
- run: |
- # Pin to this publish commit so a newer main push cannot change the
- # Dockerfile / shortSha used for the prod image tag.
- gh workflow run build-and-prepare-chart-release.yml \
- --ref "$GITHUB_SHA" \
- -f app_version="$VERSION" \
- -f update_app_version=true
+ # Same commit as this publish run (GITHUB_SHA). A workflow_dispatch --ref SHA
+ # is rejected: the dispatch API only accepts a branch or tag name (HTTP 422).
+ build-and-prepare-chart-release:
+ name: Build and prepare chart release
+ needs: publish
+ if: needs.publish.outputs.trueforge_published == 'true'
+ uses: ./.github/workflows/build-and-prepare-chart-release.yml
+ permissions:
+ contents: write
+ id-token: write
+ pull-requests: write
+ secrets: inherit
+ with:
+ app_version: ${{ needs.publish.outputs.trueforge_version }}
+ update_app_version: true
diff --git a/RELEASING.md b/RELEASING.md
index bf557cbe5..f159af5e4 100644
--- a/RELEASING.md
+++ b/RELEASING.md
@@ -3,12 +3,12 @@
This repo ships npm packages, a production container image, a Helm chart, and
optional from-source **dev** images.
-| What | Trigger | Workflow |
-| ----------------------------------- | ---------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------- |
-| npm packages | Push to `main` (Changesets) | [`release.yml`](.github/workflows/release.yml) |
-| Prod image + chart-release PR | After `@truefoundry/trueforge` npm publish, or manual dispatch | [`build-and-prepare-chart-release.yml`](.github/workflows/build-and-prepare-chart-release.yml) |
-| Chart tag, GitHub Release, OCI push | Merge of `release-chart/trueforge`, or push/dispatch of `charts/trueforge@*` | [`release-chart.yml`](.github/workflows/release-chart.yml) |
-| Dev (from-source) image | Manual `workflow_dispatch` | [`build-dev-image.yml`](.github/workflows/build-dev-image.yml) |
+| What | Trigger | Workflow |
+| ----------------------------------- | ---------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------- |
+| npm packages | Push to `main` (Changesets) | [`release.yml`](.github/workflows/release.yml) |
+| Prod image + chart-release PR | After `@truefoundry/trueforge` npm publish (reusable workflow), or manual dispatch | [`build-and-prepare-chart-release.yml`](.github/workflows/build-and-prepare-chart-release.yml) |
+| Chart tag, GitHub Release, OCI push | Merge of `release-chart/trueforge`, or push/dispatch of `charts/trueforge@*` | [`release-chart.yml`](.github/workflows/release-chart.yml) |
+| Dev (from-source) image | Manual `workflow_dispatch` | [`build-dev-image.yml`](.github/workflows/build-dev-image.yml) |
## Versioning
@@ -53,9 +53,10 @@ No `v*` tag publish. [`release.yml`](.github/workflows/release.yml) does both ve
(`pnpm run version`). Review and merge.
3. With no pending changesets, **pack** (build/test) then **publish** via npm
trusted publishing (OIDC; no `NPM_TOKEN`).
-4. If `@truefoundry/trueforge` was published, the publish job dispatches
- **Build and prepare chart release** at `--ref "$GITHUB_SHA"` (pinned to the
- publish commit, not floating `main`).
+4. If `@truefoundry/trueforge` was published, **Release** calls **Build and
+ prepare chart release** as a reusable workflow on the same commit (so a
+ newer `main` push cannot change the Dockerfile / shortSha). GitHub's
+ `workflow_dispatch` API only accepts a branch or tag name, not a SHA.
5. Pin dependents to exact versions during early `0.x`.
`workflow_dispatch` on **Release** re-runs the same workflow.
@@ -81,7 +82,7 @@ Each public package must list this repo + workflow as a trusted publisher on npm
- No GitHub Environment name
Do not set `NPM_TOKEN` / `_authToken` on the publish job — that disables OIDC.
-Only the **publish** job has `id-token: write`.
+Only the **publish** job uses npm OIDC (`id-token: write`).
Publish attaches npm provenance (`NPM_CONFIG_PROVENANCE` on the publish job, and
`publishConfig.provenance: true` on every public package). That publicly attests
@@ -103,6 +104,8 @@ pnpm clean && pnpm build && pnpm standalone:start
- **Missing `dist/_frontend/index.html`** — root `pnpm build` must build `frontend` first.
- **SDK not regenerated on Version PR** — only when `@truefoundry/trueforge-sdk` version moved
(`scripts/version.mjs`; needs Docker).
+- **Prod image missing after npm publish** — dispatch the chart workflow on a
+ **branch or tag** (not a SHA): `gh workflow run build-and-prepare-chart-release.yml --ref main -f app_version=X.Y.Z -f update_app_version=true`.
---
@@ -110,7 +113,7 @@ pnpm clean && pnpm build && pnpm standalone:start
```text
npm publish @truefoundry/[email protected]
- → dispatch build-and-prepare-chart-release @ publish SHA
+ → call build-and-prepare-chart-release (same commit as publish)
→ build Dockerfile (APP_VERSION=X.Y.Z) → push X.Y.Z-<shortSha>
→ open/update PR on branch release-chart/trueforge
→ merge PR → tag + GH Release + OCI push (release-chart.yml)
@@ -138,7 +141,7 @@ even when `main` has moved on.
## Build and prepare chart release
[`build-and-prepare-chart-release.yml`](.github/workflows/build-and-prepare-chart-release.yml)
-(`workflow_dispatch`):
+(`workflow_call` from **Release**, or manual `workflow_dispatch`):
| Input | Default | Meaning |
| -------------------- | ------------------------- | -------------------------------------------------------------------- |