Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

fix(ui): clearer Skills settings labels (Enable CTA, GitHub import form) (#162)

shubhamagarwal-create3dd596b2c107
diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ImportGithubSkillForm.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ImportGithubSkillForm.tsx
index 42d2f2623..9bc885f3f 100644
--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ImportGithubSkillForm.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ImportGithubSkillForm.tsx
@@ -82,7 +82,7 @@ const ImportGithubSkillForm = ({ open, onOpenChange, onImport, busy = false }: I
onChange={event => {
setName(event.target.value);
}}
- placeholder="Release notes"
+ placeholder="release-notes"
autoFocus
required
className="h-11 w-full rounded-md border border-input bg-background px-3 text-sm text-foreground outline-none placeholder:text-muted-foreground/70 focus-visible:ring-2 focus-visible:ring-ring/40"
@@ -125,7 +125,7 @@ const ImportGithubSkillForm = ({ open, onOpenChange, onImport, busy = false }: I
<div>
<label htmlFor="skill-path" className="mb-2 block text-sm font-semibold text-foreground">
- Path
+ Folder containing the SKILL.md
</label>
<input
id="skill-path"
@@ -141,7 +141,7 @@ const ImportGithubSkillForm = ({ open, onOpenChange, onImport, busy = false }: I
<div>
<label htmlFor="skill-ref" className="mb-2 block text-sm font-semibold text-foreground">
- Ref
+ Branch
</label>
<input
id="skill-ref"
diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx
index 4ddbf7c83..1a711713d 100644
--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx
@@ -168,12 +168,12 @@ const SkillSettings = () => {
{loading ? <p className="py-8 text-center text-sm text-muted-foreground">Loading…</p> : null}
{!loading && selectedSkills.length > 0 ? (
- <section aria-labelledby="selected-skills-heading">
+ <section aria-labelledby="enabled-skills-heading">
<h4
- id="selected-skills-heading"
+ id="enabled-skills-heading"
className="mb-2 text-[0.8125rem] font-semibold uppercase text-muted-foreground"
>
- Selected · {selectedSkills.length}
+ Enabled · {selectedSkills.length}
</h4>
<div className="overflow-hidden rounded-xl border border-border bg-card">
{selectedSkills.map(skill =>
@@ -221,12 +221,12 @@ const SkillSettings = () => {
size="sm"
type="button"
disabled={busy}
- aria-label={`Select ${entry.name}`}
+ aria-label={`Enable ${entry.name}`}
onClick={() => {
handleSelect(entry);
}}
>
- Select
+ Enable
</Button>
),
}),
diff --git a/packages/trueforge-ui-sdk/test/containers/SettingsBuilder/ImportGithubSkillForm.test.tsx b/packages/trueforge-ui-sdk/test/containers/SettingsBuilder/ImportGithubSkillForm.test.tsx
index 49abc1633..200cae898 100644
--- a/packages/trueforge-ui-sdk/test/containers/SettingsBuilder/ImportGithubSkillForm.test.tsx
+++ b/packages/trueforge-ui-sdk/test/containers/SettingsBuilder/ImportGithubSkillForm.test.tsx
@@ -25,10 +25,10 @@ describe('ImportGithubSkillForm', () => {
fireEvent.change(screen.getByLabelText('Repository URL'), {
target: { value: ' https://github.com/org/repo ' },
});
- fireEvent.change(screen.getByLabelText('Path'), {
+ fireEvent.change(screen.getByLabelText('Folder containing the SKILL.md'), {
target: { value: ' skills/release-notes ' },
});
- fireEvent.change(screen.getByLabelText('Ref'), {
+ fireEvent.change(screen.getByLabelText('Branch'), {
target: { value: ' main ' },
});
fireEvent.click(screen.getByRole('button', { name: 'Import' }));
diff --git a/packages/trueforge-ui-sdk/test/containers/SettingsBuilder/SkillSettings.test.tsx b/packages/trueforge-ui-sdk/test/containers/SettingsBuilder/SkillSettings.test.tsx
index fa0d2fb0a..8794ef0ff 100644
--- a/packages/trueforge-ui-sdk/test/containers/SettingsBuilder/SkillSettings.test.tsx
+++ b/packages/trueforge-ui-sdk/test/containers/SettingsBuilder/SkillSettings.test.tsx
@@ -79,12 +79,12 @@ describe('SkillSettings', () => {
</Wrapper>,
);
- fireEvent.click(await screen.findByRole('button', { name: 'Select Code Review' }));
+ fireEvent.click(await screen.findByRole('button', { name: 'Enable Code Review' }));
await waitFor(() => {
expect(screen.getByRole('button', { name: 'Remove Code Review' })).toBeTruthy();
});
- expect(screen.queryByRole('button', { name: 'Select Code Review' })).toBeNull();
+ expect(screen.queryByRole('button', { name: 'Enable Code Review' })).toBeNull();
expect(host.created).toEqual([
{
catalogId: catalogEntry.id,
@@ -116,7 +116,7 @@ describe('SkillSettings', () => {
fireEvent.click(await screen.findByRole('button', { name: 'Remove Code Review' }));
await waitFor(() => {
- expect(screen.getByRole('button', { name: 'Select Code Review' })).toBeTruthy();
+ expect(screen.getByRole('button', { name: 'Enable Code Review' })).toBeTruthy();
});
});
@@ -165,10 +165,10 @@ describe('SkillSettings', () => {
fireEvent.change(screen.getByLabelText('Repository URL'), {
target: { value: 'https://github.com/org/repo' },
});
- fireEvent.change(screen.getByLabelText('Path'), {
+ fireEvent.change(screen.getByLabelText('Folder containing the SKILL.md'), {
target: { value: 'skills/house-style' },
});
- fireEvent.change(screen.getByLabelText('Ref'), { target: { value: 'main' } });
+ fireEvent.change(screen.getByLabelText('Branch'), { target: { value: 'main' } });
fireEvent.click(screen.getByRole('button', { name: 'Import' }));
await waitFor(() => {