The open-source agent harness - the runtime layer that turns an LLM into a working agent.
refactor(ui): hide clear chat and save agent button when chat empty (#185)
Vinit3f675ba476cc
diff --git a/packages/trueforge-ui-sdk/src/atoms/ClearChatButton.tsx b/packages/trueforge-ui-sdk/src/atoms/ClearChatButton.tsxindex 0e3900e82..5c64052b9 100644--- a/packages/trueforge-ui-sdk/src/atoms/ClearChatButton.tsx+++ b/packages/trueforge-ui-sdk/src/atoms/ClearChatButton.tsx@@ -1,14 +1,16 @@'use client';+import { useChatChromeActionsVisible } from '../hooks/useChatChromeActionsVisible.js';import { Icon } from '../icons/Icon.js';import { useOptionalShellMode } from '../server/ShellModeContext.js';import { auiButtonClass } from './lib/buttonClasses.js';-/** Resets an immutable (named) chat. Hidden while idle or on mutable drafts. */+// Resets the current named or draft chat. Hidden on untitled empty drafts.export function ClearChatButton() {const shell = useOptionalShellMode();+ const visible = useChatChromeActionsVisible();- if (shell == null || shell.mode.status !== 'active' || shell.mode.isMutable) return null;+ if (!visible || shell == null) return null;return (<buttondiff --git a/packages/trueforge-ui-sdk/src/atoms/NamedAgentHeaderLabel.tsx b/packages/trueforge-ui-sdk/src/atoms/NamedAgentHeaderLabel.tsxindex f31a2f7b1..1266905b4 100644--- a/packages/trueforge-ui-sdk/src/atoms/NamedAgentHeaderLabel.tsx+++ b/packages/trueforge-ui-sdk/src/atoms/NamedAgentHeaderLabel.tsx@@ -1,5 +1,6 @@'use client';+import { useNamedAgentHeaderVisible } from '../hooks/useChatChromeActionsVisible.js';import { Icon } from '../icons/Icon.js';import { useOptionalShellMode } from '../server/ShellModeContext.js';import { cn } from './lib/cn.js';@@ -7,7 +8,8 @@ import { cn } from './lib/cn.js';/** Left-of-header title for an immutable (named) agent chat. Hidden for idle / draft. */export function NamedAgentHeaderLabel({ className }: { className?: string }) {const shell = useOptionalShellMode();- if (shell == null || shell.mode.status !== 'active' || shell.mode.isMutable) return null;+ const visible = useNamedAgentHeaderVisible();+ if (!visible || shell == null || shell.mode.status !== 'active') return null;const name = shell.mode.agentName ?? shell.mode.agentId;if (name == null || name.length === 0) return null;diff --git a/packages/trueforge-ui-sdk/src/atoms/SaveAgentButton.tsx b/packages/trueforge-ui-sdk/src/atoms/SaveAgentButton.tsxindex d0a3eb6c0..61ca6ad0d 100644--- a/packages/trueforge-ui-sdk/src/atoms/SaveAgentButton.tsx+++ b/packages/trueforge-ui-sdk/src/atoms/SaveAgentButton.tsx@@ -3,6 +3,7 @@import { useTrueFoundryAgentSpec } from '@truefoundry/assistant-ui-runtime';import { useId, useState, type FormEvent } from 'react';+import { useSaveAgentVisible } from '../hooks/useChatChromeActionsVisible.js';import { useOptionalServer } from '../server/ServerContext.js';import { useOptionalShellMode } from '../server/ShellModeContext.js';import type { AgentSpec } from '../server/types.js';@@ -17,6 +18,7 @@ export function SaveAgentButton() {const shell = useOptionalShellMode();const server = useOptionalServer();const { agentSpec } = useTrueFoundryAgentSpec();+ const visible = useSaveAgentVisible();const [open, setOpen] = useState(false);const [name, setName] = useState('');const [instructions, setInstructions] = useState('');@@ -25,7 +27,7 @@ export function SaveAgentButton() {const nameId = useId();const instructionsId = useId();- if (shell?.mode.status !== 'active' || !shell.mode.isMutable || server == null) return null;+ if (!visible || shell?.mode.status !== 'active' || !shell.mode.isMutable || server == null) return null;const editingAgentName = shell.mode.agentName ?? shell.mode.agentId;const isUpdate = editingAgentName != null && editingAgentName !== '';diff --git a/packages/trueforge-ui-sdk/src/atoms/draft/DraftModelSelector.tsx b/packages/trueforge-ui-sdk/src/atoms/draft/DraftModelSelector.tsxindex b325e0c9d..423fa1e6e 100644--- a/packages/trueforge-ui-sdk/src/atoms/draft/DraftModelSelector.tsx+++ b/packages/trueforge-ui-sdk/src/atoms/draft/DraftModelSelector.tsx@@ -85,11 +85,34 @@ export function DraftModelSelector({ disabled, isRunning }: DraftModelSelectorPrconst isMobile = useIsMobile();const compactLayout = useCompactLayout();const showConfigureSettingsCta = !loading && models.length === 0 && catalog != null;+ const seededDefaultModelRef = useRef<string | null>(null);useEffect(() => {ensureLoaded();}, [ensureLoaded]);+ // Keep agentSpec in sync with the visual default: when no model is set (or the+ // current name is not in the catalog), commit the first available catalog model.+ useEffect(() => {+ if (!updateAgentSpec || loading || models.length === 0) return;+ const first = models[0];+ if (first === undefined) return;+ const firstValue = first.name;+ const currentName = agentSpec?.model?.name?.trim() ?? '';+ if (currentName) {+ const inCatalog = models.some(m => m.name === currentName);+ if (inCatalog) {+ seededDefaultModelRef.current = null;+ return;+ }+ }+ if (seededDefaultModelRef.current === firstValue) return;+ seededDefaultModelRef.current = firstValue;+ updateAgentSpec({+ model: modelPatchWithReasoningEffort(firstValue, agentSpec?.model?.params, first.properties.reasoningEfforts),+ });+ }, [updateAgentSpec, loading, models, agentSpec?.model?.name, agentSpec?.model?.params]);+const selectedName = agentSpec?.model?.name ?? models[0]?.name ?? '';const selected = models.find(m => m.name === selectedName);const label = selecteddiff --git a/packages/trueforge-ui-sdk/src/containers/ThreadContainer.tsx b/packages/trueforge-ui-sdk/src/containers/ThreadContainer.tsxindex 2e722bdad..ec04e72be 100644--- a/packages/trueforge-ui-sdk/src/containers/ThreadContainer.tsx+++ b/packages/trueforge-ui-sdk/src/containers/ThreadContainer.tsx@@ -1,32 +1,20 @@'use client';-import { ThreadPrimitive, useAuiState, type AssistantState } from '@assistant-ui/react';+import { ThreadPrimitive, useAuiState } from '@assistant-ui/react';import { useEffect, type ReactNode } from 'react';import { preloadMarkdownOpenUI } from '../atoms/Markdown.js';import { ComposerBusyProvider } from '../hooks/useComposerBusyState.js';import { useSyncSessionTitle } from '../hooks/useSyncSessionTitle.js';import { useOptionalShellMode } from '../server/ShellModeContext.js';import { useSlot } from '../theme/SlotsProvider.js';+import { isNewChatView } from '../utils/isNewChatView.js';import { AssistantMessageContainer } from './AssistantMessageContainer.js';import { HistoryLoaderContainer } from './HistoryLoaderContainer.js';import { ResumeUnavailableContainer } from './ResumeUnavailableContainer.js';import { UserEditComposerContainer } from './UserEditComposerContainer.js';import { UserMessageContainer } from './UserMessageContainer.js';-// Startup exposes a loading placeholder thread; treat it as a new chat so the-// composer mounts centered. Loads after startup keep the docked layout.-//-// `remoteId == null` keeps welcome off during first-turn edit/retry: the-// runtime briefly rewinds to an empty snapshot before applying pendingUser,-// and messages.length===0 alone would flash the welcome screen.-type NewChatViewState = {- thread: Pick<AssistantState['thread'], 'messages' | 'isLoading'>;- threads: Pick<AssistantState['threads'], 'isLoading'>;- threadListItem: Pick<AssistantState['threadListItem'], 'remoteId'>;-};--export const isNewChatView = (s: NewChatViewState) =>- s.thread.messages.length === 0 && (!s.thread.isLoading || s.threads.isLoading) && s.threadListItem.remoteId == null;+export { isNewChatView } from '../utils/isNewChatView.js';/** Mount-only lift. Keyed by message.id via ThreadPrimitive.Messages — not content (streaming). */function AnimatedMessageShell({ children }: { children: ReactNode }) {diff --git a/packages/trueforge-ui-sdk/src/hooks/useChatChromeActionsVisible.ts b/packages/trueforge-ui-sdk/src/hooks/useChatChromeActionsVisible.tsnew file mode 100644index 000000000..84e112cf5--- /dev/null+++ b/packages/trueforge-ui-sdk/src/hooks/useChatChromeActionsVisible.ts@@ -0,0 +1,49 @@+'use client';++import { useAuiState } from '@assistant-ui/react';+import { useTrueFoundryAgentSpec } from '@truefoundry/assistant-ui-runtime';++import { useOptionalShellMode } from '../server/ShellModeContext.js';+import { isNewChatView } from '../utils/isNewChatView.js';++// Immutable named-agent title in the thread header.+export function useNamedAgentHeaderVisible(): boolean {+ const shell = useOptionalShellMode();+ if (shell == null || shell.mode.status !== 'active' || shell.mode.isMutable) return false;+ const name = shell.mode.agentName ?? shell.mode.agentId;+ return name != null && name.length > 0;+}++// Mutable draft/edit with a selected model — drives Save Agent + header chrome.+export function useSaveAgentVisible(): boolean {+ const shell = useOptionalShellMode();+ const { agentSpec } = useTrueFoundryAgentSpec();+ if (shell == null || shell.mode.status !== 'active' || !shell.mode.isMutable) return false;+ return Boolean(agentSpec?.model?.name?.trim());+}++// Clear chat: after a chat has started (drafts need a model).+// Named / saved agents keep Clear visible even on an empty welcome thread.+export function useChatChromeActionsVisible(): boolean {+ const shell = useOptionalShellMode();+ const { agentSpec } = useTrueFoundryAgentSpec();+ const isEmpty = useAuiState(isNewChatView);++ if (shell == null || shell.mode.status !== 'active') return false;+ if (shell.mode.isMutable && !agentSpec?.model?.name?.trim()) return false;+ if (isEmpty) {+ const boundName = shell.mode.agentName ?? shell.mode.agentId;+ const isNamedOrSaved = boundName != null && boundName.length > 0;+ if (!isNamedOrSaved) return false;+ }+ return true;+}++// True when the thread header has anything to show (title, Save, and/or Clear).+// Clear alone matters for orphaned immutable history (deleted agent, no name).+export function useChatHeaderContentVisible(): boolean {+ const namedVisible = useNamedAgentHeaderVisible();+ const saveVisible = useSaveAgentVisible();+ const clearVisible = useChatChromeActionsVisible();+ return namedVisible || saveVisible || clearVisible;+}diff --git a/packages/trueforge-ui-sdk/src/layouts/SidebarLayout.tsx b/packages/trueforge-ui-sdk/src/layouts/SidebarLayout.tsxindex 349fa9258..21511cfb1 100644--- a/packages/trueforge-ui-sdk/src/layouts/SidebarLayout.tsx+++ b/packages/trueforge-ui-sdk/src/layouts/SidebarLayout.tsx@@ -10,6 +10,7 @@ import { Spinner } from '../atoms/primitives/Spinner.js';import { ShellActions } from '../atoms/ShellActions.js';import { Thread } from '../containers/Thread.js';import { ThreadListContainer } from '../containers/ThreadListContainer.js';+import { useChatHeaderContentVisible } from '../hooks/useChatChromeActionsVisible.js';import { Icon } from '../icons/Icon.js';import { useOptionalShellMode } from '../server/ShellModeContext.js';import { useBrandName } from '../theme/brand.js';@@ -44,6 +45,7 @@ export function SidebarLayout({ className }: { className?: string }) {const wasOpen = useRef(false);const isIdle = shell?.mode.status === 'idle';const settingsOpen = shell?.settingsOpen === true;+ const hasChatHeaderContent = useChatHeaderContentVisible();useEffect(() => {if (!mobileNavOpen) return;@@ -141,8 +143,9 @@ export function SidebarLayout({ className }: { className?: string }) {<headerclassName={cn('flex shrink-0 items-center gap-1 border-b border-border bg-topbar-bg px-2 py-1.5',- // Settings / idle: desktop uses aside chrome; mobile still needs ShellActions.- (settingsOpen || isIdle) && 'md:hidden',+ // Desktop: hide when settings/idle or the thread header has nothing to show+ // (empty untitled draft). Mobile still needs Sessions + ShellActions.+ (settingsOpen || isIdle || !hasChatHeaderContent) && 'md:hidden',)}>{!settingsOpen ? (diff --git a/packages/trueforge-ui-sdk/src/utils/isNewChatView.ts b/packages/trueforge-ui-sdk/src/utils/isNewChatView.tsnew file mode 100644index 000000000..48aded2e5--- /dev/null+++ b/packages/trueforge-ui-sdk/src/utils/isNewChatView.ts@@ -0,0 +1,16 @@+import type { AssistantState } from '@assistant-ui/react';++// Startup exposes a loading placeholder thread; treat it as a new chat so the+// composer mounts centered. Loads after startup keep the docked layout.+//+// `remoteId == null` keeps welcome off during first-turn edit/retry: the+// runtime briefly rewinds to an empty snapshot before applying pendingUser,+// and messages.length===0 alone would flash the welcome screen.+export type NewChatViewState = {+ thread: Pick<AssistantState['thread'], 'messages' | 'isLoading'>;+ threads: Pick<AssistantState['threads'], 'isLoading'>;+ threadListItem: Pick<AssistantState['threadListItem'], 'remoteId'>;+};++export const isNewChatView = (s: NewChatViewState) =>+ s.thread.messages.length === 0 && (!s.thread.isLoading || s.threads.isLoading) && s.threadListItem.remoteId == null;diff --git a/packages/trueforge-ui-sdk/test/atoms/ClearChatButton.test.tsx b/packages/trueforge-ui-sdk/test/atoms/ClearChatButton.test.tsxindex 71693f33b..ca82b00f1 100644--- a/packages/trueforge-ui-sdk/test/atoms/ClearChatButton.test.tsx+++ b/packages/trueforge-ui-sdk/test/atoms/ClearChatButton.test.tsx@@ -7,8 +7,19 @@ import { SelectAgentEmptyState } from '@/atoms/SelectAgentEmptyState.js';import { ServerProvider } from '@/server/ServerContext.js';import { ShellModeProvider } from '@/server/ShellModeContext.js';import { SlotsProvider } from '@/theme/SlotsProvider.js';+import { RuntimeHarness } from '../containers/RuntimeHarness.js';import { createMockAgentUIServer } from '../server/mockServer.js';+vi.mock('@truefoundry/assistant-ui-runtime', () => ({+ useTrueFoundryAgentSpec: () => ({+ agentSpec: {+ model: { name: 'openai-main/gpt-4.1' },+ },+ }),+}));++const startedMessages = [{ role: 'user' as const, content: 'hello', id: 'm1' }];+function mockServer() {return createMockAgentUIServer({searchAgents: vi.fn(async () => [{ name: 'alpha', agentId: 'alpha' }]),@@ -20,29 +31,48 @@ describe('ClearChatButton', () => {render(<SlotsProvider><ShellModeProvider agentConfig={{ mode: 'AgentLibrary' }}>- <ClearChatButton />+ <RuntimeHarness messages={[]}>+ <ClearChatButton />+ </RuntimeHarness></ShellModeProvider></SlotsProvider>,);expect(screen.queryByRole('button', { name: 'Clear chat' })).not.toBeInTheDocument();});- it('is hidden on mutable sessions', () => {+ it('is visible on an empty named agent chat', () => {+ render(+ <SlotsProvider>+ <ShellModeProvider agentConfig={{ mode: 'SingleAgent', name: 'a' }}>+ <RuntimeHarness messages={[]}>+ <ClearChatButton />+ </RuntimeHarness>+ </ShellModeProvider>+ </SlotsProvider>,+ );+ expect(screen.getByRole('button', { name: 'Clear chat' })).toBeInTheDocument();+ });++ it('is hidden on an empty untitled draft', () => {render(<SlotsProvider><ShellModeProvider agentConfig={{ mode: 'AgentComposer' }}>- <ClearChatButton />+ <RuntimeHarness messages={[]}>+ <ClearChatButton />+ </RuntimeHarness></ShellModeProvider></SlotsProvider>,);expect(screen.queryByRole('button', { name: 'Clear chat' })).not.toBeInTheDocument();});- it('calls clearChat when clicked in named mode', () => {+ it('calls clearChat when clicked after a chat has started', () => {render(<SlotsProvider><ShellModeProvider agentConfig={{ mode: 'SingleAgent', name: 'a' }}>- <ClearChatButton />+ <RuntimeHarness messages={startedMessages}>+ <ClearChatButton />+ </RuntimeHarness></ShellModeProvider></SlotsProvider>,);diff --git a/packages/trueforge-ui-sdk/test/atoms/SaveAgentButton.test.tsx b/packages/trueforge-ui-sdk/test/atoms/SaveAgentButton.test.tsxindex 902ad777f..f634668cc 100644--- a/packages/trueforge-ui-sdk/test/atoms/SaveAgentButton.test.tsx+++ b/packages/trueforge-ui-sdk/test/atoms/SaveAgentButton.test.tsx@@ -1,20 +1,31 @@// @vitest-environment jsdomimport { fireEvent, render, screen, waitFor } from '@testing-library/react';-import { useEffect, useRef } from 'react';+import { useEffect, useRef, type ReactNode } from 'react';import { beforeAll, describe, expect, it, vi } from 'vitest';import { SaveAgentButton } from '@/atoms/SaveAgentButton.js';import { ServerProvider } from '@/server/ServerContext.js';import { ShellModeProvider, useShellMode } from '@/server/ShellModeContext.js';import { SlotsProvider } from '@/theme/SlotsProvider.js';+import { RuntimeHarness } from '../containers/RuntimeHarness.js';import { createMockAgentUIServer } from '../server/mockServer.js';+type MockAgentSpec = {+ model?: { name?: string };+ skills?: { id: string; name: string }[];+ instructions?: string;+};++const agentSpecState: { agentSpec: MockAgentSpec } = {+ agentSpec: {+ model: { name: 'openai-main/gpt-4.1' },+ skills: [{ id: 's1', name: 'Skill One' }],+ },+};+vi.mock('@truefoundry/assistant-ui-runtime', () => ({useTrueFoundryAgentSpec: () => ({- agentSpec: {- model: { name: 'openai-main/gpt-4.1' },- skills: [{ id: 's1', name: 'Skill One' }],- },+ agentSpec: agentSpecState.agentSpec,}),}));@@ -28,6 +39,8 @@ beforeAll(() => {};});+const startedMessages = [{ role: 'user' as const, content: 'hello', id: 'm1' }];+function mockServer(saveAgent = vi.fn(async () => ({ ok: true }))) {return createMockAgentUIServer({ saveAgent });}@@ -40,33 +53,67 @@ function getSubmitButton(dialog: HTMLElement): HTMLButtonElement {return button;}+function renderSaveAgent({+ children,+ messages = startedMessages,+ agentConfig,+ saveAgent,+}: {+ children: ReactNode;+ messages?: typeof startedMessages | [];+ agentConfig?: Parameters<typeof ShellModeProvider>[0]['agentConfig'];+ saveAgent?: ReturnType<typeof vi.fn>;+}) {+ return render(+ <SlotsProvider>+ <ServerProvider server={mockServer(saveAgent)}>+ <ShellModeProvider agentConfig={agentConfig}>+ <RuntimeHarness messages={messages}>{children}</RuntimeHarness>+ </ShellModeProvider>+ </ServerProvider>+ </SlotsProvider>,+ );+}+describe('SaveAgentButton', () => {it('is hidden when the shell is locked to a named agent', () => {- render(- <SlotsProvider>- <ServerProvider server={mockServer()}>- <ShellModeProvider agentConfig={{ mode: 'SingleAgent', name: 'locked-agent' }}>- <SaveAgentButton />- </ShellModeProvider>- </ServerProvider>- </SlotsProvider>,- );+ renderSaveAgent({+ agentConfig: { mode: 'SingleAgent', name: 'locked-agent' },+ children: <SaveAgentButton />,+ });expect(screen.queryByRole('button', { name: 'Save agent' })).not.toBeInTheDocument();});+ it('shows on an empty new chat when a model is selected', () => {+ renderSaveAgent({+ messages: [],+ children: <SaveAgentButton />,+ });++ expect(screen.getByRole('button', { name: 'Save agent' })).toBeInTheDocument();+ });++ it('is hidden when the draft has no model', () => {+ const previous = agentSpecState.agentSpec;+ agentSpecState.agentSpec = { skills: [{ id: 's1', name: 'Skill One' }] };+ try {+ renderSaveAgent({+ children: <SaveAgentButton />,+ });+ expect(screen.queryByRole('button', { name: 'Save agent' })).not.toBeInTheDocument();+ } finally {+ agentSpecState.agentSpec = previous;+ }+ });+it('opens a modal with name + system instructions and saves them on agentSpec', async () => {const saveAgent = vi.fn(async () => ({ ok: true }));- render(- <SlotsProvider>- <ServerProvider server={mockServer(saveAgent)}>- <ShellModeProvider>- <SaveAgentButton />- </ShellModeProvider>- </ServerProvider>- </SlotsProvider>,- );+ renderSaveAgent({+ saveAgent,+ children: <SaveAgentButton />,+ });fireEvent.click(screen.getByRole('button', { name: 'Save agent' }));const dialog = screen.getByRole('dialog', { name: 'Save agent' });@@ -110,15 +157,10 @@ describe('SaveAgentButton', () => {return <SaveAgentButton />;}- render(- <SlotsProvider>- <ServerProvider server={mockServer(saveAgent)}>- <ShellModeProvider>- <Probe />- </ShellModeProvider>- </ServerProvider>- </SlotsProvider>,- );+ renderSaveAgent({+ saveAgent,+ children: <Probe />,+ });expect(shellSnap).toBeDefined();if (shellSnap == null) throw new Error('expected shell');@@ -160,15 +202,10 @@ describe('SaveAgentButton', () => {throw new Error('Name taken');});- render(- <SlotsProvider>- <ServerProvider server={mockServer(saveAgent)}>- <ShellModeProvider>- <SaveAgentButton />- </ShellModeProvider>- </ServerProvider>- </SlotsProvider>,- );+ renderSaveAgent({+ saveAgent,+ children: <SaveAgentButton />,+ });fireEvent.click(screen.getByRole('button', { name: 'Save agent' }));const dialog = screen.getByRole('dialog', { name: 'Save agent' });@@ -181,7 +218,7 @@ describe('SaveAgentButton', () => {expect(screen.getByRole('dialog', { name: 'Save agent' })).toBeInTheDocument();});- it('shows Update Agent and prefills name when editing a library agent', async () => {+ it('shows Update Agent on an empty library Edit and prefills name', async () => {function EditSeed() {const shell = useShellMode();const seeded = useRef(false);@@ -201,15 +238,11 @@ describe('SaveAgentButton', () => {return <SaveAgentButton />;}- render(- <SlotsProvider>- <ServerProvider server={mockServer()}>- <ShellModeProvider agentConfig={{ mode: 'AgentLibraryWithComposer' }}>- <EditSeed />- </ShellModeProvider>- </ServerProvider>- </SlotsProvider>,- );+ renderSaveAgent({+ messages: [],+ agentConfig: { mode: 'AgentLibraryWithComposer' },+ children: <EditSeed />,+ });await waitFor(() => {expect(screen.getByRole('button', { name: 'Update Agent' })).toBeInTheDocument();diff --git a/packages/trueforge-ui-sdk/test/atoms/draft/DraftModelSelector.test.tsx b/packages/trueforge-ui-sdk/test/atoms/draft/DraftModelSelector.test.tsxindex 485b5bdc8..e008b15c9 100644--- a/packages/trueforge-ui-sdk/test/atoms/draft/DraftModelSelector.test.tsx+++ b/packages/trueforge-ui-sdk/test/atoms/draft/DraftModelSelector.test.tsx@@ -136,6 +136,29 @@ describe('DraftModelSelector', () => {renderSelector();await waitFor(() => expect(screen.getByTitle('Select model')).toHaveTextContent('gpt-4.1'));+ await waitFor(() => {+ expect(updateAgentSpec).toHaveBeenCalledWith({+ model: { name: 'openai/gpt-4.1' },+ });+ });+ });++ it('replaces a stale agentSpec model that is missing from the catalog', async () => {+ agentSpec = { model: { name: 'openai-main/gpt-4.1' } };+ renderSelector();++ await waitFor(() => {+ expect(updateAgentSpec).toHaveBeenCalledWith({+ model: { name: 'openai/gpt-4.1' },+ });+ });+ });++ it('does not rewrite agentSpec when the selected model is already in the catalog', async () => {+ renderSelector();++ await waitFor(() => expect(screen.getByTitle('Select model')).toHaveTextContent('gpt-4.1'));+ expect(updateAgentSpec).not.toHaveBeenCalled();});it('disables selection while disabled or running', () => {diff --git a/packages/trueforge-ui-sdk/test/hooks/useChatChromeActionsVisible.test.tsx b/packages/trueforge-ui-sdk/test/hooks/useChatChromeActionsVisible.test.tsxnew file mode 100644index 000000000..037df803c--- /dev/null+++ b/packages/trueforge-ui-sdk/test/hooks/useChatChromeActionsVisible.test.tsx@@ -0,0 +1,86 @@+// @vitest-environment jsdom+import { act, renderHook } from '@testing-library/react';+import type { ReactNode } from 'react';+import { describe, expect, it, vi } from 'vitest';++import {+ useChatChromeActionsVisible,+ useChatHeaderContentVisible,+ useNamedAgentHeaderVisible,+ useSaveAgentVisible,+} from '@/hooks/useChatChromeActionsVisible.js';+import { ShellModeProvider, useShellMode } from '@/server/ShellModeContext.js';+import { RuntimeHarness } from '../containers/RuntimeHarness.js';++vi.mock('@truefoundry/assistant-ui-runtime', () => ({+ useTrueFoundryAgentSpec: () => ({+ agentSpec: {},+ }),+}));++const startedMessages = [{ role: 'user' as const, content: 'hello', id: 'm1' }];++function wrap({+ messages = startedMessages,+ agentConfig,+}: {+ messages?: typeof startedMessages | [];+ agentConfig?: Parameters<typeof ShellModeProvider>[0]['agentConfig'];+}) {+ return function Wrapper({ children }: { children: ReactNode }) {+ return (+ <ShellModeProvider agentConfig={agentConfig}>+ <RuntimeHarness messages={messages}>{children}</RuntimeHarness>+ </ShellModeProvider>+ );+ };+}++describe('useChatHeaderContentVisible', () => {+ it('stays true when only Clear Chat is visible (orphaned immutable history)', () => {+ const { result } = renderHook(+ () => {+ const shell = useShellMode();+ return {+ shell,+ named: useNamedAgentHeaderVisible(),+ save: useSaveAgentVisible(),+ clear: useChatChromeActionsVisible(),+ header: useChatHeaderContentVisible(),+ };+ },+ { wrapper: wrap({ agentConfig: { mode: 'AgentLibraryWithComposer' } }) },+ );++ act(() => {+ result.current.shell.openHistorySession({ sessionId: 'sess-orphan', isMutable: false });+ });++ expect(result.current.named).toBe(false);+ expect(result.current.save).toBe(false);+ expect(result.current.clear).toBe(true);+ expect(result.current.header).toBe(true);+ });++ it('is false on an empty untitled draft with no model', () => {+ const { result } = renderHook(+ () => ({+ named: useNamedAgentHeaderVisible(),+ save: useSaveAgentVisible(),+ clear: useChatChromeActionsVisible(),+ header: useChatHeaderContentVisible(),+ }),+ {+ wrapper: wrap({+ messages: [],+ agentConfig: { mode: 'AgentComposer' },+ }),+ },+ );++ expect(result.current.named).toBe(false);+ expect(result.current.save).toBe(false);+ expect(result.current.clear).toBe(false);+ expect(result.current.header).toBe(false);+ });+});