The open-source agent harness - the runtime layer that turns an LLM into a working agent.
chore: show form errors in modal and show success toast for successful submissions (#195)
sayan-truefoundry5354f4fcc8ff
diff --git a/docs/ui-sdk/reference/containers.mdx b/docs/ui-sdk/reference/containers.mdxindex 02a5b37ef..2d1324c4e 100644--- a/docs/ui-sdk/reference/containers.mdx+++ b/docs/ui-sdk/reference/containers.mdx@@ -52,9 +52,9 @@ list to a single agent — that is how `TrueforgeUI` scopes the thread list.`McpAuthContainer`, `PostMcpOauthScreen`.-## Errors+## Notifications-`ErrorToasterProvider`, `useErrorToaster()`, `useErrorToasterOptional()`.+`ToasterProvider`, `useToaster()`, `useToasterOptional()`.<Note>The settings panel is part of the built-in layouts and has no standalone container. Customdiff --git a/packages/trueforge-ui-sdk/docs/api.md b/packages/trueforge-ui-sdk/docs/api.mdindex 5ce2e81d7..88cc248d9 100644--- a/packages/trueforge-ui-sdk/docs/api.md+++ b/packages/trueforge-ui-sdk/docs/api.md@@ -13,14 +13,14 @@ re-exports override **types** only where needed.## Compose-| Export | Notes |-| -------------------------------------------------------------------- | ------------------------------- |-| `TrueFoundryChatProvider` | Named-agent runtime + toasts |-| `TrueFoundryChatProviderProps` | `client` XOR `apiKey`+`baseUrl` |-| `Thread` | Full thread + composer |-| `ThreadContainer`, `ComposerContainer`, `ThreadListContainer` | Building blocks |-| `ErrorToasterProvider`, `useErrorToaster`, `useErrorToasterOptional` | Error toasts |-| Other `*Container` exports | Advanced message / tool wiring |+| Export | Notes |+| ------------------------------------------------------------- | ------------------------------- |+| `TrueFoundryChatProvider` | Named-agent runtime + toasts |+| `TrueFoundryChatProviderProps` | `client` XOR `apiKey`+`baseUrl` |+| `Thread` | Full thread + composer |+| `ThreadContainer`, `ComposerContainer`, `ThreadListContainer` | Building blocks |+| `ToasterProvider`, `useToaster`, `useToasterOptional` | Success and error toasts |+| Other `*Container` exports | Advanced message / tool wiring |## Slots / themediff --git a/packages/trueforge-ui-sdk/docs/architecture.md b/packages/trueforge-ui-sdk/docs/architecture.mdindex a410c9caa..6d8a65189 100644--- a/packages/trueforge-ui-sdk/docs/architecture.md+++ b/packages/trueforge-ui-sdk/docs/architecture.md@@ -49,7 +49,7 @@ Default atoms use CSS variables from the auto-injected stylesheet (scoped to`.aui-theme-root`). Override colours via `theme.tokens` or host CSS on`.aui-theme-root` / `.aui-theme-root.dark`.-## Errors+## Notifications-`ErrorToasterProvider` shows a single toast (no queue). Descriptions from-gateway errors are truncated for display.+`ToasterProvider` shows success and error toasts. Descriptions from gateway+errors are truncated for display.diff --git a/packages/trueforge-ui-sdk/src/atoms/Toast.tsx b/packages/trueforge-ui-sdk/src/atoms/Toast.tsxindex 6a7c56b52..466bd8547 100644--- a/packages/trueforge-ui-sdk/src/atoms/Toast.tsx+++ b/packages/trueforge-ui-sdk/src/atoms/Toast.tsx@@ -12,10 +12,11 @@ export type ToastProps = {description: string;open: boolean;onOpenChange: (open: boolean) => void;+ variant?: 'error' | 'success';className?: string;};-export function Toast({ title, description, open, onOpenChange, className }: ToastProps) {+export function Toast({ title, description, open, onOpenChange, variant = 'error', className }: ToastProps) {const [copied, setCopied] = useState(false);const handleCopy = useCallback(async () => {@@ -40,11 +41,22 @@ export function Toast({ title, description, open, onOpenChange, className }: ToaclassName,)}>- <Icon name="circle-exclamation" size="1.25em" className="text-failure-bg shrink-0" />+ <Icon+ name={variant === 'success' ? 'circle-check' : 'circle-exclamation'}+ size="1.25em"+ className={cn('shrink-0', variant === 'success' ? 'text-success-bg' : 'text-failure-bg')}+ /><div className="min-w-0 flex-1"><div className="flex items-start justify-between gap-2">- <div className="text-failure-bg text-sm leading-none font-semibold">{title}</div>+ <div+ className={cn(+ 'text-sm leading-none font-semibold',+ variant === 'success' ? 'text-success-bg' : 'text-failure-bg',+ )}+ >+ {title}+ </div><div className="flex shrink-0 items-center gap-1"><buttontype="button"diff --git a/packages/trueforge-ui-sdk/src/containers/AssistantTextContainer.tsx b/packages/trueforge-ui-sdk/src/containers/AssistantTextContainer.tsxindex f98ea3708..ff8387ce5 100644--- a/packages/trueforge-ui-sdk/src/containers/AssistantTextContainer.tsx+++ b/packages/trueforge-ui-sdk/src/containers/AssistantTextContainer.tsx@@ -11,7 +11,7 @@ import { useTrueFoundryDownloadSandboxFile } from '@truefoundry/assistant-ui-runimport { useCallback, useRef } from 'react';import { useSlot } from '../theme/SlotsProvider.js';-import { useErrorToasterOptional } from './ErrorToasterContainer.js';+import { useToasterOptional } from './ToasterContainer.js';function filenameFromPath(path: string): string {return path.split('/').pop() || 'download';@@ -29,12 +29,12 @@ function triggerBrowserDownload(blob: Blob, filename: string) {export function AssistantTextContainer() {const Markdown = useSlot('Markdown');- const errorToaster = useErrorToasterOptional();+ const toaster = useToasterOptional();const downloadSandboxFile = useTrueFoundryDownloadSandboxFile();// The download closure changes as the turn streams; a ref keeps onDownloadArtifact stable so// OpenUI does not remount.- const downloadRef = useRef({ downloadSandboxFile, errorToaster });- downloadRef.current = { downloadSandboxFile, errorToaster };+ const downloadRef = useRef({ downloadSandboxFile, toaster });+ downloadRef.current = { downloadSandboxFile, toaster };const partState = useAuiState(s => s.part as MessagePartState & (TextMessagePart | ReasoningMessagePart));const smoothedPart = useSmooth(partState, {drainMs: 300,@@ -46,12 +46,12 @@ export function AssistantTextContainer() {// true while network stream is active OR while reveal is still catching upconst isStreaming = smoothedPart.status?.type === 'running';const handleDownloadArtifact = useCallback(async (path: string) => {- const { downloadSandboxFile, errorToaster } = downloadRef.current;+ const { downloadSandboxFile, toaster } = downloadRef.current;try {triggerBrowserDownload(await downloadSandboxFile(path), filenameFromPath(path));} catch (error) {- if (errorToaster != null) {- errorToaster.showError(error);+ if (toaster != null) {+ toaster.showError(error);} else {console.error('Failed to download sandbox artifact', error);}diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/AddMcpServerForm.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/AddMcpServerForm.tsxindex aa90ee230..4c5465daf 100644--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/AddMcpServerForm.tsx+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/AddMcpServerForm.tsx@@ -21,6 +21,7 @@ type AddMcpServerFormProps = {onOpenChange: (open: boolean) => void;onAdd: (draft: AddMcpServerDraft) => void | Promise<void>;busy?: boolean;+ error?: string | null;};const AUTH_OPTIONS: Array<{ value: McpAuthType; label: string }> = [@@ -37,7 +38,7 @@ const RequiredMark = () => (</span>);-const AddMcpServerForm = ({ open, onOpenChange, onAdd, busy = false }: AddMcpServerFormProps) => {+const AddMcpServerForm = ({ open, onOpenChange, onAdd, busy = false, error }: AddMcpServerFormProps) => {const [name, setName] = useState('');const [url, setUrl] = useState('');const [authType, setAuthType] = useState<McpAuthType>('dcr');@@ -216,9 +217,12 @@ const AddMcpServerForm = ({ open, onOpenChange, onAdd, busy = false }: AddMcpSer) : null}</div>- <Button type="submit" size="lg" disabled={!isValid || busy} className="mt-6 w-full shrink-0">- Add- </Button>+ <div className="mt-6 space-y-3">+ {error ? <p className="text-failure-bg text-sm">{error}</p> : null}+ <Button type="submit" size="lg" disabled={!isValid || busy} className="w-full shrink-0">+ Add+ </Button>+ </div></form></CenteredModal>);diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConfigureSandboxForm.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConfigureSandboxForm.tsxindex 3d46f0138..1bbba5524 100644--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConfigureSandboxForm.tsx+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConfigureSandboxForm.tsx@@ -25,6 +25,7 @@ type ConfigureSandboxFormProps = {/** When false (updates), empty apiKey means keep the existing key. */requireApiKey?: boolean;busy?: boolean;+ error?: string | null;};/** Sensible defaults so the advanced fields are never blank, even without a catalog preset. */@@ -54,6 +55,7 @@ const ConfigureSandboxForm = ({initialConfig = null,requireApiKey = true,busy = false,+ error,}: ConfigureSandboxFormProps) => {const [snapshotName, setSnapshotName] = useState('');const [execTimeoutMs, setExecTimeoutMs] = useState('');@@ -273,9 +275,12 @@ const ConfigureSandboxForm = ({</Accordion></div>- <Button type="submit" size="lg" disabled={!isValid || busy} className="mt-6 w-full shrink-0">- Save- </Button>+ <div className="mt-6 space-y-3">+ {error ? <p className="text-failure-bg text-sm">{error}</p> : null}+ <Button type="submit" size="lg" disabled={!isValid || busy} className="w-full shrink-0">+ Save+ </Button>+ </div></form></CenteredModal>);diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConnectorSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConnectorSettings.tsxindex aea1c2e37..047019474 100644--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConnectorSettings.tsx+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConnectorSettings.tsx@@ -13,6 +13,7 @@ import { Icon } from '@/icons/Icon.js';import { useCatalogServer } from '@/server/ServerContext.js';import type { ConnectorAuth, ConnectorBase, ConnectorCatalogEntry } from '@/server/types.js';import { getErrorMessage } from '@/utils/getErrorMessage.js';+import { useToasterOptional } from '../ToasterContainer.js';import AddMcpServerForm, { type AddMcpServerDraft } from './AddMcpServerForm.js';import { AUTH_TYPE_LABELS } from './authTypeLabels.js';import ConnectorDetails from './ConnectorDetails.js';@@ -28,6 +29,7 @@ type ConnectorsState = {const ConnectorSettings = () => {const { connectorCatalog } = useCatalogServer();const { handleAuthorize, isOAuthLoading } = useMCPAuth();+ const toaster = useToasterOptional();const [query, setQuery] = useState('');const [connectors, setConnectors] = useState<ConnectorsState>({@@ -36,6 +38,7 @@ const ConnectorSettings = () => {});const [loading, setLoading] = useState(true);const [error, setError] = useState<string | null>(null);+ const [formError, setFormError] = useState<string | null>(null);const [busy, setBusy] = useState(false);const [catalog, setCatalog] = useState<ConnectorCatalogEntry[]>([]);@@ -123,14 +126,14 @@ const ConnectorSettings = () => {return result;}, [matchingConnectors]);- const runMutation = async (fn: () => Promise<void>) => {+ const runMutation = async (fn: () => Promise<void>, setMutationError = setError) => {setBusy(true);setError(null);try {await fn();await refresh();} catch (err) {- setError(getErrorMessage(err, 'Request failed'));+ setMutationError(getErrorMessage(err, 'Request failed'));throw err;} finally {setBusy(false);@@ -140,6 +143,7 @@ const ConnectorSettings = () => {const closeApiKeyModal = () => {setConnectorAwaitingKey(null);setApiKey('');+ setFormError(null);};const authorizeOAuthConnector = async (integrationId: string) => {@@ -185,6 +189,7 @@ const ConnectorSettings = () => {const handleConnect = (entry: ConnectorCatalogEntry) => {if (entry.auth.type === 'header') {setApiKey('');+ setFormError(null);setConnectorAwaitingKey(entry);return;}@@ -199,6 +204,7 @@ const ConnectorSettings = () => {if (!connectorAwaitingKey || !apiKey.trim()) return;const entry = connectorAwaitingKey;+ setFormError(null);void runMutation(async () => {const auth: ConnectorAuth = {type: 'header',@@ -218,10 +224,17 @@ const ConnectorSettings = () => {await createFromCatalog(entry, auth);}closeApiKeyModal();- }).catch(() => {});+ setTimeout(() => {+ toaster?.showSuccess({+ title: existingConnector ? 'Connector updated' : 'Connector connected',+ description: `${entry.name} is ready to use.`,+ });+ }, 100);+ }, setFormError).catch(() => {});};const handleAddMcpServer = async (draft: AddMcpServerDraft) => {+ setFormError(null);await runMutation(async () => {const created = await connectorCatalog.createConnector({name: draft.name,@@ -231,7 +244,13 @@ const ConnectorSettings = () => {if (draft.auth.type === 'dcr') {await authorizeOAuthConnector(created.id);}- });+ }, setFormError);+ setTimeout(() => {+ toaster?.showSuccess({+ title: 'Connector added',+ description: `${draft.name} is ready to use.`,+ });+ }, 0);};const handleDisconnect = (connector: ConnectorBase) => {@@ -414,6 +433,7 @@ const ConnectorSettings = () => {variant="secondary"type="button"onClick={() => {+ setFormError(null);setAddMcpServerFormOpen(true);}}>@@ -505,6 +525,7 @@ const ConnectorSettings = () => {className={auiInputClass('h-11')}/></div>+ {formError ? <p className="text-failure-bg text-sm">{formError}</p> : null}</div><footer className="flex justify-end gap-2 border-t border-border px-5 py-4">@@ -520,9 +541,13 @@ const ConnectorSettings = () => {<AddMcpServerFormopen={addMcpServerFormOpen}- onOpenChange={setAddMcpServerFormOpen}+ onOpenChange={open => {+ setAddMcpServerFormOpen(open);+ if (!open) setFormError(null);+ }}onAdd={handleAddMcpServer}busy={busy || isOAuthLoading}+ error={formError}/></div></div>diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/CustomModelProviderForm.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/CustomModelProviderForm.tsxindex 170a3d3f5..faeff5106 100644--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/CustomModelProviderForm.tsx+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/CustomModelProviderForm.tsx@@ -28,6 +28,7 @@ type CustomModelProviderFormProps = {onAdd: (draft: CustomProviderDraft) => void | Promise<void>;reasoningEffortOptions?: readonly string[];busy?: boolean;+ error?: string | null;};type ModelRow = {@@ -108,6 +109,7 @@ const CustomModelProviderForm = ({onAdd,reasoningEffortOptions,busy = false,+ error,}: CustomModelProviderFormProps) => {const [name, setName] = useState('');const [baseUrl, setBaseUrl] = useState('');@@ -141,7 +143,14 @@ const CustomModelProviderForm = ({const markAllTouched = () => {setNameTouched(true);setBaseUrlTouched(true);- setModels(current => current.map(model => ({ ...model, idTouched: true, contextTouched: true, maxTouched: true })));+ setModels(current =>+ current.map(model => ({+ ...model,+ idTouched: true,+ contextTouched: true,+ maxTouched: true,+ })),+ );};// ── Validation (client-side; do not rely on backend errors) ──@@ -348,7 +357,10 @@ const CustomModelProviderForm = ({onChange={event => {const id = event.target.value;// Keep the model name in sync with the id until the user edits it by hand.- updateModel(index, { id, ...(model.nameDirty ? {} : { name: slugifyModelId(id) }) });+ updateModel(index, {+ id,+ ...(model.nameDirty ? {} : { name: slugifyModelId(id) }),+ });}}onBlur={() => updateModel(index, { idTouched: true })}placeholder="llama3.1:70b"@@ -549,7 +561,8 @@ const CustomModelProviderForm = ({</div>{/* Sticky footer */}- <div className="shrink-0 border-t border-border px-5 py-4">+ <div className="shrink-0 space-y-3 border-t border-border px-5 py-4">+ {error ? <p className="text-failure-bg text-sm">{error}</p> : null}<Button type="submit" size="lg" disabled={!visibleValid || busy} className="w-full">Add provider</Button>diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ImportGithubSkillForm.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ImportGithubSkillForm.tsxindex a17fd959d..b8f98107e 100644--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ImportGithubSkillForm.tsx+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ImportGithubSkillForm.tsx@@ -13,9 +13,10 @@ type ImportGithubSkillFormProps = {onOpenChange: (open: boolean) => void;onImport: (draft: SkillConfigBase) => void | Promise<void>;busy?: boolean;+ error?: string | null;};-const ImportGithubSkillForm = ({ open, onOpenChange, onImport, busy = false }: ImportGithubSkillFormProps) => {+const ImportGithubSkillForm = ({ open, onOpenChange, onImport, busy = false, error }: ImportGithubSkillFormProps) => {const [name, setName] = useState('');const [description, setDescription] = useState('');const [repoURL, setRepoURL] = useState('');@@ -156,9 +157,12 @@ const ImportGithubSkillForm = ({ open, onOpenChange, onImport, busy = false }: I/></div>- <Button type="submit" disabled={!canImport} className="w-full">- Import- </Button>+ <div className="space-y-3">+ {error ? <p className="text-failure-bg text-sm">{error}</p> : null}+ <Button type="submit" disabled={!canImport} className="w-full">+ Import+ </Button>+ </div></div></form></CenteredModal>diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsxindex 9b702fa8d..8df2f62f9 100644--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx@@ -8,10 +8,10 @@ import { Accordion, AccordionDetails, AccordionSummary } from '@/atoms/primitiveimport { Button } from '@/atoms/primitives/Button.js';import { CatalogLogo } from '@/atoms/primitives/CatalogLogo.js';import SearchInput from '@/atoms/primitives/SearchInput.js';-import { useErrorToasterOptional } from '@/containers/ErrorToasterContainer.js';import CustomModelProviderForm, {type CustomProviderDraft,} from '@/containers/SettingsBuilder/CustomModelProviderForm.js';+import { useToasterOptional } from '@/containers/ToasterContainer.js';import { Icon } from '@/icons/Icon.js';import { useCatalogServer } from '@/server/ServerContext.js';import type { ModelEntry, ModelProviderBase, ModelProviderCatalogEntry } from '@/server/types.js';@@ -26,13 +26,14 @@ function catalogBaseUrl(provider: ModelProviderCatalogEntry): string {const ModelSettings = () => {const { modelCatalog } = useCatalogServer();- const toaster = useErrorToasterOptional();+ const toaster = useToasterOptional();const [query, setQuery] = useState('');const [configured, setConfigured] = useState<ModelProviderBase[]>([]);const [catalog, setCatalog] = useState<ModelProviderCatalogEntry[]>([]);const [loading, setLoading] = useState(true);const [error, setError] = useState<string | null>(null);+ const [formError, setFormError] = useState<string | null>(null);const [busy, setBusy] = useState(false);const [editingProviderId, setEditingProviderId] = useState<string | null>(null);@@ -125,7 +126,7 @@ const ModelSettings = () => {setAdvancedOpen(false);};- const runMutation = async (fn: () => Promise<void>) => {+ const runMutation = async (fn: () => Promise<void>, onError?: (error: unknown) => void) => {setBusy(true);setError(null);try {@@ -133,10 +134,12 @@ const ModelSettings = () => {await refresh();closeKeyEditor();} catch (err) {- if (toaster != null) {- toaster.showError(err);- } else {+ if (onError) {+ onError(err);+ } else if (toaster == null) {setError(getErrorMessage(err, 'Request failed'));+ } else {+ toaster.showError(err);}throw err;} finally {@@ -171,7 +174,14 @@ const ModelSettings = () => {apiKey: apiKey.trim(),models: provider.models,});- }).catch(() => {});+ })+ .then(() => {+ toaster?.showSuccess({+ title: 'API key replaced',+ description: `${provider.name} was updated successfully.`,+ });+ })+ .catch(() => {});};const handleRemoveProvider = (provider: ModelProviderBase) => {@@ -197,15 +207,25 @@ const ModelSettings = () => {};const handleAddCustomProvider = async (draft: CustomProviderDraft) => {- await runMutation(async () => {- await modelCatalog.createModelProvider({- type: 'custom',- name: draft.name,- baseUrl: draft.baseUrl,- apiKey: draft.apiKey,- models: draft.models,+ setFormError(null);+ await runMutation(+ async () => {+ await modelCatalog.createModelProvider({+ type: 'custom',+ name: draft.name,+ baseUrl: draft.baseUrl,+ apiKey: draft.apiKey,+ models: draft.models,+ });+ },+ err => setFormError(getErrorMessage(err, 'Request failed')),+ );+ setTimeout(() => {+ toaster?.showSuccess({+ title: 'Model provider added',+ description: `${draft.name} is ready to use.`,});- });+ }, 0);};const renderKeyEditor = (opts: { id: string; submitLabel: string; onSave: () => void; isReplacingKey?: boolean }) => (@@ -303,6 +323,7 @@ const ModelSettings = () => {variant="secondary"type="button"onClick={() => {+ setFormError(null);setCustomProviderOpen(true);}}>@@ -529,10 +550,14 @@ const ModelSettings = () => {<CustomModelProviderFormopen={customProviderOpen}- onOpenChange={setCustomProviderOpen}+ onOpenChange={open => {+ setCustomProviderOpen(open);+ if (!open) setFormError(null);+ }}onAdd={handleAddCustomProvider}reasoningEffortOptions={supportedReasoningEfforts}busy={busy}+ error={formError}/></div></div>diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SandboxSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SandboxSettings.tsxindex ca28d32d9..8a327da47 100644--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SandboxSettings.tsx+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SandboxSettings.tsx@@ -7,6 +7,7 @@ import { Icon } from '../../icons/Icon.js';import { useCatalogServer } from '../../server/ServerContext.js';import type { SandboxProviderBase, SandboxProviderCatalogEntry, SandboxProviderConfig } from '../../server/types.js';import { getErrorMessage } from '../../utils/getErrorMessage.js';+import { useToasterOptional } from '../ToasterContainer.js';import ConfigureSandboxForm, { type SandboxConfigDraft } from './ConfigureSandboxForm.js';const configFrom = ({@@ -25,11 +26,13 @@ const configFrom = ({const SandboxSettings = () => {const { sandboxCatalog } = useCatalogServer();+ const toaster = useToasterOptional();const [providers, setProviders] = useState<SandboxProviderBase[]>([]);const [catalog, setCatalog] = useState<SandboxProviderCatalogEntry[]>([]);const [loading, setLoading] = useState(true);const [error, setError] = useState<string | null>(null);+ const [formError, setFormError] = useState<string | null>(null);const [busy, setBusy] = useState(false);const [createEntry, setCreateEntry] = useState<SandboxProviderCatalogEntry | null>(null);@@ -77,14 +80,14 @@ const SandboxSettings = () => {return <p className="text-sm text-text-secondary">Sandbox provider catalog is not available.</p>;}- const runMutation = async (fn: () => Promise<void>) => {+ const runMutation = async (fn: () => Promise<void>, setMutationError = setError) => {setBusy(true);setError(null);try {await fn();await refresh({ quiet: true });} catch (err) {- setError(getErrorMessage(err, 'Request failed'));+ setMutationError(getErrorMessage(err, 'Request failed'));throw err;} finally {setBusy(false);@@ -93,6 +96,7 @@ const SandboxSettings = () => {const handleCreate = async (draft: SandboxConfigDraft) => {if (!createEntry) return;+ setFormError(null);await runMutation(async () => {await sandboxCatalog.createSandboxProvider({catalogId: createEntry.id,@@ -101,20 +105,33 @@ const SandboxSettings = () => {...configFrom(draft),apiKey: draft.apiKey,});- });+ }, setFormError);setCreateEntry(null);+ setTimeout(() => {+ toaster?.showSuccess({+ title: 'Sandbox provider configured',+ description: `${createEntry.name} is ready to use.`,+ });+ }, 0);};const handleUpdate = async (draft: SandboxConfigDraft) => {if (!updateProvider) return;+ setFormError(null);await runMutation(async () => {await sandboxCatalog.updateSandboxProvider({id: updateProvider.id,...configFrom(draft),...(draft.apiKey ? { apiKey: draft.apiKey } : {}),});- });+ }, setFormError);setUpdateProvider(null);+ setTimeout(() => {+ toaster?.showSuccess({+ title: 'Sandbox provider updated',+ description: `${updateProvider.name} was updated successfully.`,+ });+ }, 0);};const handleRemove = (provider: SandboxProviderBase) => {@@ -188,6 +205,7 @@ const SandboxSettings = () => {type="button"disabled={busy}onClick={() => {+ setFormError(null);setCreateEntry(null);setUpdateProvider(provider);}}@@ -252,6 +270,7 @@ const SandboxSettings = () => {type="button"disabled={busy}onClick={() => {+ setFormError(null);setUpdateProvider(null);setCreateEntry(entry);}}@@ -271,6 +290,7 @@ const SandboxSettings = () => {open={formOpen}onOpenChange={open => {if (!open) {+ setFormError(null);setCreateEntry(null);setUpdateProvider(null);}@@ -285,6 +305,7 @@ const SandboxSettings = () => {initialConfig={formInitialConfig}requireApiKey={!isUpdate}busy={busy}+ error={formError}/></>);diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsxindex 68011fc8a..38d40460c 100644--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx@@ -8,6 +8,7 @@ import { Icon } from '@/icons/Icon.js';import { useCatalogServer } from '../../server/ServerContext.js';import type { RegistrySkill, SkillBase, SkillCatalogEntry, SkillConfigBase } from '../../server/types.js';import { getErrorMessage } from '../../utils/getErrorMessage.js';+import { useToasterOptional } from '../ToasterContainer.js';import ImportGithubSkillForm from './ImportGithubSkillForm.js';const matchesQuery = (query: string, name: string, description: string) =>@@ -17,12 +18,14 @@ const isRegistrySkill = (skill: SkillBase): skill is RegistrySkill => 'catalogIdconst SkillSettings = () => {const { skillCatalog } = useCatalogServer();+ const toaster = useToasterOptional();const [query, setQuery] = useState('');const [skills, setSkills] = useState<SkillBase[]>([]);const [catalog, setCatalog] = useState<SkillCatalogEntry[]>([]);const [loading, setLoading] = useState(true);const [error, setError] = useState<string | null>(null);+ const [formError, setFormError] = useState<string | null>(null);const [busy, setBusy] = useState(false);const [importOpen, setImportOpen] = useState(false);@@ -59,14 +62,14 @@ const SkillSettings = () => {);}, [catalog, skills, normalizedQuery]);- const runMutation = async (fn: () => Promise<void>) => {+ const runMutation = async (fn: () => Promise<void>, setMutationError = setError) => {setBusy(true);setError(null);try {await fn();await refresh();} catch (err) {- setError(getErrorMessage(err, 'Request failed'));+ setMutationError(getErrorMessage(err, 'Request failed'));throw err;} finally {setBusy(false);@@ -99,9 +102,16 @@ const SkillSettings = () => {};const handleImport = async (draft: SkillConfigBase) => {+ setFormError(null);await runMutation(async () => {await skillCatalog.createSkill(draft);- });+ }, setFormError);+ setTimeout(() => {+ toaster?.showSuccess({+ title: 'Skill imported',+ description: `${draft.name} is ready to use.`,+ });+ }, 0);};const renderRow = ({@@ -156,6 +166,7 @@ const SkillSettings = () => {className="shrink-0"disabled={busy}onClick={() => {+ setFormError(null);setImportOpen(true);}}>@@ -243,7 +254,16 @@ const SkillSettings = () => {</div></div>- <ImportGithubSkillForm open={importOpen} onOpenChange={setImportOpen} onImport={handleImport} busy={busy} />+ <ImportGithubSkillForm+ open={importOpen}+ onOpenChange={open => {+ setImportOpen(open);+ if (!open) setFormError(null);+ }}+ onImport={handleImport}+ busy={busy}+ error={formError}+ /></>);};diff --git a/packages/trueforge-ui-sdk/src/containers/ErrorToasterContainer.tsx b/packages/trueforge-ui-sdk/src/containers/ToasterContainer.tsxsimilarity index 60%rename from packages/trueforge-ui-sdk/src/containers/ErrorToasterContainer.tsxrename to packages/trueforge-ui-sdk/src/containers/ToasterContainer.tsxindex 039ba3dc2..3f9e888d0 100644--- a/packages/trueforge-ui-sdk/src/containers/ErrorToasterContainer.tsx+++ b/packages/trueforge-ui-sdk/src/containers/ToasterContainer.tsx@@ -8,20 +8,21 @@ import { getErrorMessage } from '../utils/getErrorMessage.js';const MAX_TOAST_DESCRIPTION_CHARS = 480;const MAX_VISIBLE_TOASTS = 5;-type ErrorToastContent = { title: string; description: string };+type ToastContent = { title: string; description: string };-type ErrorToastItem = ErrorToastContent & { id: string };+type ToastItem = ToastContent & { id: string; variant: 'error' | 'success' };-type ErrorToasterContextValue = {+type ToasterContextValue = {showError: (error: unknown) => void;+ showSuccess: (content: ToastContent) => void;};-const ErrorToasterContext = createContext<ErrorToasterContextValue | null>(null);+const ToasterContext = createContext<ToasterContextValue | null>(null);let toastId = 0;function nextToastId(): string {toastId += 1;- return `error-toast-${toastId}`;+ return `toast-${toastId}`;}function truncateDescription(text: string): string {@@ -33,7 +34,7 @@ function isHttpLikeError(error: unknown): error is Error & { statusCode?: numberreturn error instanceof Error && ('statusCode' in error || 'body' in error);}-function normalizeError(error: unknown): ErrorToastContent {+function normalizeError(error: unknown): ToastContent {if (isHttpLikeError(error)) {const statusCode = error.statusCode;if (statusCode != null || error.body != null) {@@ -49,14 +50,19 @@ function normalizeError(error: unknown): ErrorToastContent {};}-export function ErrorToasterProvider({ children }: { children: ReactNode }) {+export function ToasterProvider({ children }: { children: ReactNode }) {const Toast = useSlot('Toast');const ToastStack = useSlot('ToastStack');- const [toasts, setToasts] = useState<ErrorToastItem[]>([]);+ const [toasts, setToasts] = useState<ToastItem[]>([]);const showError = useCallback((error: unknown) => {console.error('[trueforge-ui]', error);- const item: ErrorToastItem = { id: nextToastId(), ...normalizeError(error) };+ const item: ToastItem = { id: nextToastId(), variant: 'error', ...normalizeError(error) };+ setToasts(prev => [...prev, item].slice(-MAX_VISIBLE_TOASTS));+ }, []);++ const showSuccess = useCallback((content: ToastContent) => {+ const item: ToastItem = { id: nextToastId(), variant: 'success', ...content };setToasts(prev => [...prev, item].slice(-MAX_VISIBLE_TOASTS));}, []);@@ -64,10 +70,10 @@ export function ErrorToasterProvider({ children }: { children: ReactNode }) {setToasts(prev => prev.filter(t => t.id !== id));}, []);- const value = useMemo(() => ({ showError }), [showError]);+ const value = useMemo(() => ({ showError, showSuccess }), [showError, showSuccess]);return (- <ErrorToasterContext.Provider value={value}>+ <ToasterContext.Provider value={value}>{children}<ToastStack>{toasts.map(toast => (@@ -75,6 +81,7 @@ export function ErrorToasterProvider({ children }: { children: ReactNode }) {key={toast.id}title={toast.title}description={toast.description}+ variant={toast.variant}openonOpenChange={open => {if (!open) dismiss(toast.id);@@ -82,19 +89,19 @@ export function ErrorToasterProvider({ children }: { children: ReactNode }) {/>))}</ToastStack>- </ErrorToasterContext.Provider>+ </ToasterContext.Provider>);}-export function useErrorToaster(): ErrorToasterContextValue {- const context = useContext(ErrorToasterContext);+export function useToaster(): ToasterContextValue {+ const context = useContext(ToasterContext);if (context == null) {- throw new Error('useErrorToaster must be used within ErrorToasterProvider');+ throw new Error('useToaster must be used within ToasterProvider');}return context;}-/** Same as `useErrorToaster`, but returns `null` instead of throwing outside `ErrorToasterProvider`. */-export function useErrorToasterOptional(): ErrorToasterContextValue | null {- return useContext(ErrorToasterContext);+/** Same as `useToaster`, but returns `null` instead of throwing outside `ToasterProvider`. */+export function useToasterOptional(): ToasterContextValue | null {+ return useContext(ToasterContext);}diff --git a/packages/trueforge-ui-sdk/src/containers/TrueFoundryChatProvider.tsx b/packages/trueforge-ui-sdk/src/containers/TrueFoundryChatProvider.tsxindex e0f73454d..6ce9d7d4b 100644--- a/packages/trueforge-ui-sdk/src/containers/TrueFoundryChatProvider.tsx+++ b/packages/trueforge-ui-sdk/src/containers/TrueFoundryChatProvider.tsx@@ -11,7 +11,7 @@ import { useCallback, useMemo, type ReactNode } from 'react';import { notifyComposerBusyFailure } from '../hooks/useComposerBusyState.js';import type { AgentUIServer } from '../server/types.js';-import { ErrorToasterProvider, useErrorToaster } from './ErrorToasterContainer.js';+import { ToasterProvider, useToaster } from './ToasterContainer.js';type RuntimeAdapters = NonNullable<UseTrueFoundryAgentRuntimeOptions['adapters']>;@@ -48,7 +48,7 @@ function ChatRuntimeScope({onError?: (error: unknown) => void;children: ReactNode;}) {- const { showError } = useErrorToaster();+ const { showError } = useToaster();const reportError = onError ?? showError;// composer().send() is void and swallows onNew rejections; clear optimistic// busy when the runtime reports a pre-stream failure (e.g. createSession).@@ -86,7 +86,7 @@ export function TrueFoundryChatProvider(props: TrueFoundryChatProviderProps) {const stableServer = useMemo(() => server, [server]);return (- <ErrorToasterProvider>+ <ToasterProvider><ChatRuntimeScopeserver={stableServer}agent={agent}@@ -98,6 +98,6 @@ export function TrueFoundryChatProvider(props: TrueFoundryChatProviderProps) {>{children}</ChatRuntimeScope>- </ErrorToasterProvider>+ </ToasterProvider>);}diff --git a/packages/trueforge-ui-sdk/src/hooks/useMcpAuth.ts b/packages/trueforge-ui-sdk/src/hooks/useMcpAuth.tsindex d55b550ac..9545c2c17 100644--- a/packages/trueforge-ui-sdk/src/hooks/useMcpAuth.ts+++ b/packages/trueforge-ui-sdk/src/hooks/useMcpAuth.ts@@ -1,6 +1,6 @@import { useCallback, useEffect, useMemo, useRef, useState } from 'react';-import { useErrorToasterOptional } from '../containers/ErrorToasterContainer.js';+import { useToasterOptional } from '../containers/ToasterContainer.js';import { useCatalogServer } from '../server/ServerContext.js';export const MCP_AUTH_POPUP_CHANNEL = 'truefoundry-mcp-auth-popup';@@ -26,7 +26,7 @@ const isPopupMessage = (value: unknown): value is McpAuthPopupMessage => {export const useMCPAuth = ({ callbackPath }: UseMCPAuthOptions = {}) => {const { connectorCatalog } = useCatalogServer();- const errorToaster = useErrorToasterOptional();+ const toaster = useToasterOptional();const [isOAuthLoading, setIsOAuthLoading] = useState(false);const popupUid = useMemo(() => generatePopupUid(), []);const listenerCleanupRef = useRef<(() => void) | null>(null);@@ -103,13 +103,13 @@ export const useMCPAuth = ({ callbackPath }: UseMCPAuthOptions = {}) => {openAuthPopup(authorizationEndpoint, callback);} catch (error: unknown) {- errorToaster?.showError(error);+ toaster?.showError(error);callback(false);} finally {setIsOAuthLoading(false);}},- [callbackPath, connectorCatalog, errorToaster, openAuthPopup, popupUid],+ [callbackPath, connectorCatalog, openAuthPopup, popupUid, toaster],);return {diff --git a/packages/trueforge-ui-sdk/src/index.ts b/packages/trueforge-ui-sdk/src/index.tsindex 483f2d9fa..1c568244d 100644--- a/packages/trueforge-ui-sdk/src/index.ts+++ b/packages/trueforge-ui-sdk/src/index.ts@@ -156,7 +156,6 @@ export {} from './containers/AttachmentsContainer.js';export { ComposerContainer } from './containers/ComposerContainer.js';export type { ComposerContainerProps } from './containers/ComposerContainer.js';-export { ErrorToasterProvider, useErrorToaster, useErrorToasterOptional } from './containers/ErrorToasterContainer.js';export { HistoryLoaderContainer } from './containers/HistoryLoaderContainer.js';export { McpAuthContainer } from './containers/McpAuthContainer.js';export { default as PostMcpOauthScreen } from './containers/McpOauthContainer/PostMcpOauthScreen.js';@@ -167,6 +166,7 @@ export { ThreadContainer } from './containers/ThreadContainer.js';export type { ThreadContainerProps } from './containers/ThreadContainer.js';export { ThreadListContainer } from './containers/ThreadListContainer.js';export type { ThreadListContainerProps } from './containers/ThreadListContainer.js';+export { ToasterProvider, useToaster, useToasterOptional } from './containers/ToasterContainer.js';export { ToolApprovalContainer } from './containers/ToolApprovalContainer.js';export type { ToolApprovalOption } from './containers/ToolApprovalContainer.js';export { ToolCallContainer } from './containers/ToolCallContainer.js';diff --git a/packages/trueforge-ui-sdk/test/atoms/Toast.test.tsx b/packages/trueforge-ui-sdk/test/atoms/Toast.test.tsxindex 79edcb42d..68657b752 100644--- a/packages/trueforge-ui-sdk/test/atoms/Toast.test.tsx+++ b/packages/trueforge-ui-sdk/test/atoms/Toast.test.tsx@@ -4,7 +4,9 @@ import { afterEach, describe, expect, it, vi } from 'vitest';import { Toast, ToastStack } from '@/atoms/Toast.js';vi.mock('@/icons/Icon.js', () => ({- Icon: ({ name }: { name: string }) => <span data-testid={`icon-${name}`} />,+ Icon: ({ name, className }: { name: string; className?: string }) => (+ <span className={className} data-testid={`icon-${name}`} />+ ),}));const clipboardDescriptor = Object.getOwnPropertyDescriptor(navigator, 'clipboard');@@ -48,6 +50,23 @@ describe('Toast', () => {expect(screen.queryByText('Hidden')).not.toBeInTheDocument();});+ it('uses semantic status tokens for error and success variants', () => {+ const { container, rerender } = render(+ <Toast title="Request failed" description="Failure detail" open onOpenChange={() => {}} />,+ );++ expect(screen.getByTestId('icon-circle-exclamation')).toHaveClass('text-failure-bg');+ expect(screen.getByText('Request failed')).toHaveClass('text-failure-bg');++ rerender(+ <Toast title="Request succeeded" description="Success detail" open onOpenChange={() => {}} variant="success" />,+ );++ expect(screen.getByTestId('icon-circle-check')).toHaveClass('text-success-bg');+ expect(screen.getByText('Request succeeded')).toHaveClass('text-success-bg');+ expect(container.querySelector('.text-destructive, .text-success')).not.toBeInTheDocument();+ });+it('copies the full error and temporarily exposes copied state', async () => {vi.useFakeTimers();const writeText = vi.fn(async () => {});diff --git a/packages/trueforge-ui-sdk/test/containers/ErrorToasterContainer.test.tsx b/packages/trueforge-ui-sdk/test/containers/ToasterContainer.test.tsxsimilarity index 83%rename from packages/trueforge-ui-sdk/test/containers/ErrorToasterContainer.test.tsxrename to packages/trueforge-ui-sdk/test/containers/ToasterContainer.test.tsxindex 572b92652..366df434e 100644--- a/packages/trueforge-ui-sdk/test/containers/ErrorToasterContainer.test.tsx+++ b/packages/trueforge-ui-sdk/test/containers/ToasterContainer.test.tsx@@ -2,11 +2,11 @@ import { act, fireEvent, render, renderHook, screen, waitFor } from '@testing-liimport { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';import { Toast } from '@/atoms/Toast.js';-import { ErrorToasterProvider, useErrorToaster, useErrorToasterOptional } from '@/containers/ErrorToasterContainer.js';+import { ToasterProvider, useToaster, useToasterOptional } from '@/containers/ToasterContainer.js';import { SlotsProvider } from '@/theme/SlotsProvider.js';function Trigger({ errors }: { errors: unknown[] }) {- const { showError } = useErrorToaster();+ const { showError } = useToaster();return (<buttontype="button"@@ -19,7 +19,7 @@ function Trigger({ errors }: { errors: unknown[] }) {);}-describe('ErrorToasterProvider', () => {+describe('ToasterProvider', () => {beforeEach(() => {vi.spyOn(console, 'error').mockImplementation(() => {});});@@ -28,21 +28,19 @@ describe('ErrorToasterProvider', () => {vi.restoreAllMocks();});- it('requires a provider for useErrorToaster while the optional hook returns null', () => {- expect(() => renderHook(() => useErrorToaster())).toThrow(- 'useErrorToaster must be used within ErrorToasterProvider',- );+ it('requires a provider for useToaster while the optional hook returns null', () => {+ expect(() => renderHook(() => useToaster())).toThrow('useToaster must be used within ToasterProvider');- const { result } = renderHook(() => useErrorToasterOptional());+ const { result } = renderHook(() => useToasterOptional());expect(result.current).toBeNull();});it('stacks multiple error toasts', async () => {render(<SlotsProvider>- <ErrorToasterProvider>+ <ToasterProvider><Trigger errors={[new Error('first'), new Error('second')]} />- </ErrorToasterProvider>+ </ToasterProvider></SlotsProvider>,);@@ -56,9 +54,9 @@ describe('ErrorToasterProvider', () => {it('dismisses one toast without removing the other', async () => {render(<SlotsProvider>- <ErrorToasterProvider>+ <ToasterProvider><Trigger errors={[new Error('keep-me'), new Error('drop-me')]} />- </ErrorToasterProvider>+ </ToasterProvider></SlotsProvider>,);@@ -87,9 +85,9 @@ describe('ErrorToasterProvider', () => {render(<SlotsProvider>- <ErrorToasterProvider>+ <ToasterProvider><Trigger errors={[httpError]} />- </ErrorToasterProvider>+ </ToasterProvider></SlotsProvider>,);@@ -107,9 +105,9 @@ describe('ErrorToasterProvider', () => {render(<SlotsProvider>- <ErrorToasterProvider>+ <ToasterProvider><Trigger errors={[httpError]} />- </ErrorToasterProvider>+ </ToasterProvider></SlotsProvider>,);@@ -124,9 +122,9 @@ describe('ErrorToasterProvider', () => {render(<SlotsProvider>- <ErrorToasterProvider>+ <ToasterProvider><Trigger errors={errors} />- </ErrorToasterProvider>+ </ToasterProvider></SlotsProvider>,);diff --git a/packages/trueforge-ui-sdk/test/hooks/useMcpAuth.test.ts b/packages/trueforge-ui-sdk/test/hooks/useMcpAuth.test.tsindex 1e5b79afc..66120fb79 100644--- a/packages/trueforge-ui-sdk/test/hooks/useMcpAuth.test.ts+++ b/packages/trueforge-ui-sdk/test/hooks/useMcpAuth.test.ts@@ -8,19 +8,19 @@ type CatalogHookValue = {connectorCatalog: Pick<ConnectorCatalogServer, 'authenticateConnector'>;};-type ErrorToasterValue = {+type ToasterValue = {showError: (error: unknown) => void;};const useCatalogServer = vi.hoisted(() => vi.fn<() => CatalogHookValue>());-const useErrorToasterOptional = vi.hoisted(() => vi.fn<() => ErrorToasterValue | null>());+const useToasterOptional = vi.hoisted(() => vi.fn<() => ToasterValue | null>());vi.mock('@/server/ServerContext.js', () => ({useCatalogServer,}));-vi.mock('@/containers/ErrorToasterContainer.js', () => ({- useErrorToasterOptional,+vi.mock('@/containers/ToasterContainer.js', () => ({+ useToasterOptional,}));import { MCP_AUTH_POPUP_CHANNEL, useMCPAuth } from '@/hooks/useMcpAuth.js';@@ -63,11 +63,11 @@ describe('useMCPAuth', () => {authenticateConnector.mockReset();showError.mockReset();useCatalogServer.mockReset();- useErrorToasterOptional.mockReset();+ useToasterOptional.mockReset();useCatalogServer.mockReturnValue({connectorCatalog: { authenticateConnector },});- useErrorToasterOptional.mockReturnValue({ showError });+ useToasterOptional.mockReturnValue({ showError });vi.stubGlobal('BroadcastChannel', BroadcastChannelStub);window.history.replaceState({}, '', '/chat');});diff --git a/packages/trueforge-ui-sdk/test/publicUiExports.test.ts b/packages/trueforge-ui-sdk/test/publicUiExports.test.tsindex 8a82859d2..46c89d093 100644--- a/packages/trueforge-ui-sdk/test/publicUiExports.test.ts+++ b/packages/trueforge-ui-sdk/test/publicUiExports.test.ts@@ -37,7 +37,7 @@ const expectedRuntimeExports: Array<keyof typeof sdk> = ['DraftComposerRightSection','DraftCompositeSelector','DraftModelSelector',- 'ErrorToasterProvider',+ 'ToasterProvider','HistoryLoader','HistoryLoaderContainer','Icon',@@ -120,8 +120,8 @@ const expectedRuntimeExports: Array<keyof typeof sdk> = ['useComposerPauseView','useContentClassNames','useDraftCatalog',- 'useErrorToaster',- 'useErrorToasterOptional',+ 'useToaster',+ 'useToasterOptional','useMCPAuth','useOptionalCatalogServer','useOptionalContentClassNames',