The open-source agent harness - the runtime layer that turns an LLM into a working agent.
feat: default reasoning effort to medium and include provider-level parameter defaults (#1119)
Sujai Kumar Gupta67fc305f0275
diff --git a/.changeset/default-reasoning-medium.md b/.changeset/default-reasoning-medium.mdnew file mode 100644index 000000000..8a4277521--- /dev/null+++ b/.changeset/default-reasoning-medium.md@@ -0,0 +1,6 @@+---+'@truefoundry/trueforge-ui': patch+'@truefoundry/trueforge': patch+---++Default the reasoning effort to `medium` when the selected model offers it (falling back to the lowest real effort otherwise), instead of defaulting to the lowest effort. TrueFoundry model listing now passes `mergeParams` to the provider-integrations API so provider-level parameter defaults are included in each model's advertised parameters.diff --git a/packages/frontend/src/App.tsx b/packages/frontend/src/App.tsxindex 91ee09705..ce48ae468 100644--- a/packages/frontend/src/App.tsx+++ b/packages/frontend/src/App.tsx@@ -144,8 +144,11 @@ export function App() {return;}const reasoningEfforts = first.properties.reasoningEfforts;- // Default to the lowest real effort, not "none" — catalog lists are ordered ascending.- const defaultReasoningEffort = reasoningEfforts?.find(effort => effort !== 'none') ?? reasoningEfforts?.[0];+ // Default to "medium"; catalog lists are ordered ascending, so otherwise the lowest real effort, not "none".+ const defaultReasoningEffort =+ reasoningEfforts?.find(effort => effort === 'medium') ??+ reasoningEfforts?.find(effort => effort !== 'none') ??+ reasoningEfforts?.[0];setBoot({status: 'ready',openSettings: false,diff --git a/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx b/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsxindex f4653a83a..e930498d3 100644--- a/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx+++ b/packages/trueforge-ui/src/atoms/draft/AgentModelSettingsContent.tsx@@ -7,6 +7,7 @@ import { useSlot } from '../../theme/SlotsProvider.js';import { auiButtonClass } from '../lib/buttonClasses.js';import { cn } from '../lib/cn.js';import { auiInputClass } from '../lib/inputClasses.js';+import { resolveReasoningEffort } from './reasoningEffort.js';export type AgentModelSettingsContentProps = {spec: AgentSpec;@@ -117,7 +118,7 @@ export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelSconst maxOutputTokens = model?.properties.maxOutputTokens;const reasoningEfforts = model?.properties.reasoningEfforts ?? [];- const firstReasoningEffort = reasoningEfforts[0];+ const defaultReasoningEffort = resolveReasoningEffort(reasoningEfforts, undefined);const rows: Array<{label: string;@@ -126,12 +127,12 @@ export function AgentModelSettingsContent({ spec, model, onChange }: AgentModelSonToggle: (enabled: boolean) => void;}> = [];- if (firstReasoningEffort !== undefined) {+ if (defaultReasoningEffort !== undefined) {rows.push({label: 'Reasoning Effort',enabled: params.reasoningEffort !== undefined,onToggle: enabled =>- enabled ? setParam('reasoningEffort', firstReasoningEffort) : removeParam('reasoningEffort'),+ enabled ? setParam('reasoningEffort', defaultReasoningEffort) : removeParam('reasoningEffort'),control: (<selectvalue={params.reasoningEffort ?? ''}diff --git a/packages/trueforge-ui/src/atoms/draft/reasoningEffort.ts b/packages/trueforge-ui/src/atoms/draft/reasoningEffort.tsindex 7c0b7fe73..a5276258c 100644--- a/packages/trueforge-ui/src/atoms/draft/reasoningEffort.ts+++ b/packages/trueforge-ui/src/atoms/draft/reasoningEffort.ts@@ -6,11 +6,12 @@ export function hasReasoningEfforts(efforts: ReasoningEfforts): efforts is strinreturn Array.isArray(efforts) && efforts.length > 0;}-/** Keep current if still listed; otherwise the lowest non-"none" effort; none if model has no efforts. */+/** Keep current if still listed; otherwise default to "medium", falling back to the lowest non-"none" effort. */export function resolveReasoningEffort(efforts: ReasoningEfforts, current: string | undefined): string | undefined {if (!hasReasoningEfforts(efforts)) return undefined;if (current && efforts.includes(current)) return current;- // Default to the lowest real effort, not "none" — catalog lists are ordered ascending.+ if (efforts.includes('medium')) return 'medium';+ // Catalog lists are ordered ascending, so the first non-"none" entry is the lowest real effort.return efforts.find(effort => effort !== 'none') ?? efforts[0];}diff --git a/packages/trueforge-ui/test/atoms/draft/reasoningEffort.test.ts b/packages/trueforge-ui/test/atoms/draft/reasoningEffort.test.tsindex f716978c7..0eeb1cc8d 100644--- a/packages/trueforge-ui/test/atoms/draft/reasoningEffort.test.ts+++ b/packages/trueforge-ui/test/atoms/draft/reasoningEffort.test.ts@@ -32,7 +32,12 @@ describe('resolveReasoningEffort', () => {expect(resolveReasoningEffort(['low', 'high'], 'medium')).toBe('low');});- it('defaults to the lowest non-"none" effort, skipping "none"', () => {+ it('defaults to "medium" when the model offers it', () => {+ expect(resolveReasoningEffort(['none', 'low', 'medium', 'high'], undefined)).toBe('medium');+ expect(resolveReasoningEffort(['low', 'medium', 'high'], 'bogus')).toBe('medium');+ });++ it('defaults to the lowest non-"none" effort when "medium" is not offered, skipping "none"', () => {expect(resolveReasoningEffort(['none', 'low', 'high'], undefined)).toBe('low');expect(resolveReasoningEffort(['none', 'minimal', 'low'], 'bogus')).toBe('minimal');});diff --git a/packages/trueforge/src/truefoundry/TrueFoundryServiceFoundryServerClient.ts b/packages/trueforge/src/truefoundry/TrueFoundryServiceFoundryServerClient.tsindex 95cfa0b63..58cf51f57 100644--- a/packages/trueforge/src/truefoundry/TrueFoundryServiceFoundryServerClient.ts+++ b/packages/trueforge/src/truefoundry/TrueFoundryServiceFoundryServerClient.ts@@ -184,6 +184,8 @@ export class TrueFoundryServiceFoundryServerClient {/*** Model integrations. No limit/offset → full match set in one response.* Pass `filter` (account + model name together) for a point lookup.+ * `mergeParams` folds provider defaults into `metadata.params`, which+ * is the only params list the model mapping reads.*/async listProviderIntegrations(input: {accessToken: string;@@ -196,7 +198,7 @@ export class TrueFoundryServiceFoundryServerClient {provider_account_name: input.filter.provider_account_name,name: input.filter.name,};- const query: Record<string, string> = { type: 'model', ...filterQuery };+ const query: Record<string, string> = { type: 'model', mergeParams: 'true', ...filterQuery };const payload = await this.#requestJson({url: this.#url(INTEGRATIONS_PATH, query),accessToken: input.accessToken,