Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

bugfix: show sandbox envs form errors in toast (#1013)

harshil-20966c07afacb39a
diff --git a/.changeset/environment-create-error-toast.md b/.changeset/environment-create-error-toast.md
new file mode 100644
index 000000000..2846a337a
--- /dev/null
+++ b/.changeset/environment-create-error-toast.md
@@ -0,0 +1,5 @@
+---
+'@truefoundry/trueforge-ui': patch
+---
+
+Toast API errors when creating or updating a sandbox environment so failures are visible outside the drawer form.
diff --git a/packages/trueforge-ui/src/atoms/environments/EnvironmentFormDrawer.tsx b/packages/trueforge-ui/src/atoms/environments/EnvironmentFormDrawer.tsx
index 5711e0c01..8bc040ba6 100644
--- a/packages/trueforge-ui/src/atoms/environments/EnvironmentFormDrawer.tsx
+++ b/packages/trueforge-ui/src/atoms/environments/EnvironmentFormDrawer.tsx
@@ -69,6 +69,7 @@ export function EnvironmentFormDrawer({ open, onOpenChange, mode, environment, o
onOpenChange(false);
} catch (caught) {
setError(getErrorMessage(caught, 'Failed to save environment'));
+ toaster?.showError(caught);
} finally {
setSaving(false);
}
diff --git a/packages/trueforge-ui/test/atoms/environments/EnvironmentFormDrawer.test.tsx b/packages/trueforge-ui/test/atoms/environments/EnvironmentFormDrawer.test.tsx
index b9359f496..a9b6ccb1e 100644
--- a/packages/trueforge-ui/test/atoms/environments/EnvironmentFormDrawer.test.tsx
+++ b/packages/trueforge-ui/test/atoms/environments/EnvironmentFormDrawer.test.tsx
@@ -144,4 +144,25 @@ describe('EnvironmentFormDrawer', () => {
expect(createOrUpdateEnvironment.mock.calls[0]?.[0]?.manifest.description).toBe('updated description');
expect(onSaved).toHaveBeenCalled();
});
+
+ it('toasts API errors when create fails', async () => {
+ vi.spyOn(console, 'error').mockImplementation(() => {});
+ const httpError = Object.assign(new Error('Status code: 409'), {
+ statusCode: 409,
+ body: { error: { message: 'Environment name already exists' } },
+ });
+ renderDrawer({
+ environmentOverrides: {
+ createOrUpdateEnvironment: vi.fn(async () => {
+ throw httpError;
+ }),
+ },
+ });
+
+ fireEvent.change(screen.getByPlaceholderText('my-environment'), { target: { value: 'dup-env' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Create' }));
+
+ expect(await screen.findByText('Request failed (409)')).toBeInTheDocument();
+ expect(screen.getAllByText('Environment name already exists').length).toBeGreaterThanOrEqual(1);
+ });
});