The open-source agent harness - the runtime layer that turns an LLM into a working agent.
refactor: update SQLite migration handling to ensure atomicity (#249)
Sujai Kumar Gupta733016dfdf9a
diff --git a/packages/server/src/db/migrateSqlite.ts b/packages/server/src/db/migrateSqlite.tsindex 0bfc98eb2..2ddc04dc6 100644--- a/packages/server/src/db/migrateSqlite.ts+++ b/packages/server/src/db/migrateSqlite.ts@@ -11,6 +11,10 @@ import type { Database } from './sqlite/types';** Used at sqlite startup and by SQLite store tests.* Resolves `…/sqlite/migrations` next to this module (source or `dist/`).+ *+ * Kysely does not wrap SQLite migrations in a transaction (`supportsTransactionalDdl`+ * is false). Migrations that need atomicity open `db.transaction()` themselves;+ * `PRAGMA foreign_keys` must stay outside that txn.*/export async function migrateSqliteToLatest(db: Kysely<Database>): Promise<void> {const migrator = new Migrator({diff --git a/packages/server/src/db/sqlite/AGENTS.md b/packages/server/src/db/sqlite/AGENTS.mdindex 7b9d86997..0c906591c 100644--- a/packages/server/src/db/sqlite/AGENTS.md+++ b/packages/server/src/db/sqlite/AGENTS.md@@ -1 +1,2 @@- JSON projection aliases MUST be listed in `client.ts`'s `JSON_RESULT_COLUMNS`.+- Kysely's SqliteAdapter keeps `supportsTransactionalDdl: false`, so Migrator does not wrap migrations. Every `up`/`down` that touches the schema MUST open `db.transaction()` itself. `PRAGMA foreign_keys` is a no-op inside a transaction — toggle it outside the txn when rebuilding a referenced parent (see kysely#56).diff --git a/packages/server/src/db/sqlite/migrations/20260730_000001_init.ts b/packages/server/src/db/sqlite/migrations/20260730_000001_init.tsindex d7dfc8500..ccb5adfbb 100644--- a/packages/server/src/db/sqlite/migrations/20260730_000001_init.ts+++ b/packages/server/src/db/sqlite/migrations/20260730_000001_init.ts@@ -1,9 +1,13 @@import { type Kysely, sql } from 'kysely';export async function up(db: Kysely<unknown>): Promise<void> {- await sql`SELECT 1`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`SELECT 1`.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`SELECT 1`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`SELECT 1`.execute(trx);+ });}diff --git a/packages/server/src/db/sqlite/migrations/20260730_000002_session_store.ts b/packages/server/src/db/sqlite/migrations/20260730_000002_session_store.tsindex 7d6ffd2b1..3ce19eed4 100644--- a/packages/server/src/db/sqlite/migrations/20260730_000002_session_store.ts+++ b/packages/server/src/db/sqlite/migrations/20260730_000002_session_store.ts@@ -7,123 +7,127 @@ import { type Kysely, sql } from 'kysely';* Timestamps are ISO-8601 TEXT. Context order is turn_thread_context (not an array column).*/export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- CREATE TABLE session (- tenant_id TEXT NOT NULL,- session_id TEXT NOT NULL,- agent_spec BLOB NOT NULL,- title TEXT,- last_turn_id TEXT,- custom BLOB,- last_activity_timestamp_ms INTEGER NOT NULL,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (session_id)- ) STRICT- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`+ CREATE TABLE session (+ tenant_id TEXT NOT NULL,+ session_id TEXT NOT NULL,+ agent_spec BLOB NOT NULL,+ title TEXT,+ last_turn_id TEXT,+ custom BLOB,+ last_activity_timestamp_ms INTEGER NOT NULL,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (session_id)+ ) STRICT+ `.execute(trx);- await sql`- CREATE INDEX session_list_idx- ON session (tenant_id, created_at, session_id)- `.execute(db);+ await sql`+ CREATE INDEX session_list_idx+ ON session (tenant_id, created_at, session_id)+ `.execute(trx);- await sql`- CREATE TABLE turn (- session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,- turn_id TEXT NOT NULL,- first_turn_id TEXT NOT NULL,- previous_turn_id TEXT,- ancestor_ids BLOB NOT NULL,- input BLOB NOT NULL,- state BLOB NOT NULL,- checkpoint BLOB NOT NULL,- custom BLOB,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (session_id, turn_id)- ) STRICT- `.execute(db);+ await sql`+ CREATE TABLE turn (+ session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,+ turn_id TEXT NOT NULL,+ first_turn_id TEXT NOT NULL,+ previous_turn_id TEXT,+ ancestor_ids BLOB NOT NULL,+ input BLOB NOT NULL,+ state BLOB NOT NULL,+ checkpoint BLOB NOT NULL,+ custom BLOB,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (session_id, turn_id)+ ) STRICT+ `.execute(trx);- await sql`- CREATE INDEX turn_list_idx- ON turn (session_id, created_at, turn_id)- `.execute(db);+ await sql`+ CREATE INDEX turn_list_idx+ ON turn (session_id, created_at, turn_id)+ `.execute(trx);- await sql`- CREATE TABLE turn_thread (- session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,- turn_id TEXT NOT NULL,- thread_id TEXT NOT NULL,- checkpoint BLOB NOT NULL,- agent_info BLOB,- current_context_usage BLOB NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (session_id, turn_id, thread_id)- ) STRICT- `.execute(db);+ await sql`+ CREATE TABLE turn_thread (+ session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,+ turn_id TEXT NOT NULL,+ thread_id TEXT NOT NULL,+ checkpoint BLOB NOT NULL,+ agent_info BLOB,+ current_context_usage BLOB NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (session_id, turn_id, thread_id)+ ) STRICT+ `.execute(trx);- await sql`- CREATE TABLE turn_thread_context (- session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,- turn_id TEXT NOT NULL,- thread_id TEXT NOT NULL,- pos INTEGER NOT NULL,- append_id INTEGER NOT NULL,- PRIMARY KEY (session_id, turn_id, thread_id, pos)- ) STRICT- `.execute(db);+ await sql`+ CREATE TABLE turn_thread_context (+ session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,+ turn_id TEXT NOT NULL,+ thread_id TEXT NOT NULL,+ pos INTEGER NOT NULL,+ append_id INTEGER NOT NULL,+ PRIMARY KEY (session_id, turn_id, thread_id, pos)+ ) STRICT+ `.execute(trx);- await sql`- CREATE INDEX turn_thread_context_append_idx- ON turn_thread_context (session_id, thread_id, append_id)- `.execute(db);+ await sql`+ CREATE INDEX turn_thread_context_append_idx+ ON turn_thread_context (session_id, thread_id, append_id)+ `.execute(trx);- await sql`- CREATE TABLE session_event (- session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,- turn_id TEXT NOT NULL,- event_id TEXT NOT NULL,- event BLOB NOT NULL,- created_at TEXT NOT NULL,- PRIMARY KEY (session_id, turn_id, event_id)- ) STRICT- `.execute(db);+ await sql`+ CREATE TABLE session_event (+ session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,+ turn_id TEXT NOT NULL,+ event_id TEXT NOT NULL,+ event BLOB NOT NULL,+ created_at TEXT NOT NULL,+ PRIMARY KEY (session_id, turn_id, event_id)+ ) STRICT+ `.execute(trx);- await sql`- CREATE TABLE thread_context_log (- append_id INTEGER PRIMARY KEY AUTOINCREMENT,- session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,- thread_id TEXT NOT NULL,- turn_id TEXT NOT NULL,- body BLOB NOT NULL,- created_at TEXT NOT NULL- ) STRICT- `.execute(db);+ await sql`+ CREATE TABLE thread_context_log (+ append_id INTEGER PRIMARY KEY AUTOINCREMENT,+ session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,+ thread_id TEXT NOT NULL,+ turn_id TEXT NOT NULL,+ body BLOB NOT NULL,+ created_at TEXT NOT NULL+ ) STRICT+ `.execute(trx);- await sql`- CREATE INDEX thread_context_log_lookup_idx- ON thread_context_log (session_id, thread_id, append_id)- `.execute(db);+ await sql`+ CREATE INDEX thread_context_log_lookup_idx+ ON thread_context_log (session_id, thread_id, append_id)+ `.execute(trx);- await sql`- CREATE TABLE thread_capability_state (- session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,- turn_id TEXT NOT NULL,- thread_id TEXT NOT NULL,- key TEXT NOT NULL,- state BLOB,- updated_at TEXT NOT NULL,- PRIMARY KEY (session_id, turn_id, thread_id, key)- ) STRICT- `.execute(db);+ await sql`+ CREATE TABLE thread_capability_state (+ session_id TEXT NOT NULL REFERENCES session(session_id) ON DELETE CASCADE,+ turn_id TEXT NOT NULL,+ thread_id TEXT NOT NULL,+ key TEXT NOT NULL,+ state BLOB,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (session_id, turn_id, thread_id, key)+ ) STRICT+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`DROP TABLE IF EXISTS thread_capability_state`.execute(db);- await sql`DROP TABLE IF EXISTS thread_context_log`.execute(db);- await sql`DROP TABLE IF EXISTS session_event`.execute(db);- await sql`DROP TABLE IF EXISTS turn_thread_context`.execute(db);- await sql`DROP TABLE IF EXISTS turn_thread`.execute(db);- await sql`DROP TABLE IF EXISTS turn`.execute(db);- await sql`DROP TABLE IF EXISTS session`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`DROP TABLE IF EXISTS thread_capability_state`.execute(trx);+ await sql`DROP TABLE IF EXISTS thread_context_log`.execute(trx);+ await sql`DROP TABLE IF EXISTS session_event`.execute(trx);+ await sql`DROP TABLE IF EXISTS turn_thread_context`.execute(trx);+ await sql`DROP TABLE IF EXISTS turn_thread`.execute(trx);+ await sql`DROP TABLE IF EXISTS turn`.execute(trx);+ await sql`DROP TABLE IF EXISTS session`.execute(trx);+ });}diff --git a/packages/server/src/db/sqlite/migrations/20260803_000001_model_provider.ts b/packages/server/src/db/sqlite/migrations/20260803_000001_model_provider.tsindex 4a70dd91b..ebda7f8fd 100644--- a/packages/server/src/db/sqlite/migrations/20260803_000001_model_provider.ts+++ b/packages/server/src/db/sqlite/migrations/20260803_000001_model_provider.ts@@ -6,18 +6,22 @@ import { sql, type Kysely } from 'kysely';* (via jsonb(...)), timestamps are ISO-8601 TEXT.*/export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- CREATE TABLE model_provider (- tenant_id TEXT NOT NULL,- name TEXT NOT NULL,- manifest BLOB NOT NULL,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (tenant_id, name)- ) STRICT- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`+ CREATE TABLE model_provider (+ tenant_id TEXT NOT NULL,+ name TEXT NOT NULL,+ manifest BLOB NOT NULL,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (tenant_id, name)+ ) STRICT+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`DROP TABLE IF EXISTS model_provider`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`DROP TABLE IF EXISTS model_provider`.execute(trx);+ });}diff --git a/packages/server/src/db/sqlite/migrations/20260807_000001_mcp_oauth.ts b/packages/server/src/db/sqlite/migrations/20260807_000001_mcp_oauth.tsindex 6e707c3dc..3a0b8b097 100644--- a/packages/server/src/db/sqlite/migrations/20260807_000001_mcp_oauth.ts+++ b/packages/server/src/db/sqlite/migrations/20260807_000001_mcp_oauth.ts@@ -6,47 +6,51 @@ import { type Kysely, sql } from 'kysely';* FK target (application-generated ulid) for the two child tables.*/export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- CREATE TABLE mcp_server (- id TEXT NOT NULL,- tenant_id TEXT NOT NULL,- name TEXT NOT NULL,- manifest BLOB NOT NULL,- oauth_server BLOB,- oauth_client BLOB,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (id)- ) STRICT- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`+ CREATE TABLE mcp_server (+ id TEXT NOT NULL,+ tenant_id TEXT NOT NULL,+ name TEXT NOT NULL,+ manifest BLOB NOT NULL,+ oauth_server BLOB,+ oauth_client BLOB,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (id)+ ) STRICT+ `.execute(trx);- await sql`- CREATE UNIQUE INDEX mcp_server_tenant_name_idx- ON mcp_server (tenant_id, name)- `.execute(db);+ await sql`+ CREATE UNIQUE INDEX mcp_server_tenant_name_idx+ ON mcp_server (tenant_id, name)+ `.execute(trx);- await sql`- CREATE TABLE oauth_token (- oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,- token BLOB NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (oauth_server_id)- ) STRICT- `.execute(db);+ await sql`+ CREATE TABLE oauth_token (+ oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,+ token BLOB NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (oauth_server_id)+ ) STRICT+ `.execute(trx);- await sql`- CREATE TABLE oauth_pending_authorization (- id TEXT NOT NULL,- oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,- auth_data BLOB NOT NULL,- created_at TEXT NOT NULL,- PRIMARY KEY (id)- ) STRICT- `.execute(db);+ await sql`+ CREATE TABLE oauth_pending_authorization (+ id TEXT NOT NULL,+ oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,+ auth_data BLOB NOT NULL,+ created_at TEXT NOT NULL,+ PRIMARY KEY (id)+ ) STRICT+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`DROP TABLE IF EXISTS oauth_pending_authorization`.execute(db);- await sql`DROP TABLE IF EXISTS oauth_token`.execute(db);- await sql`DROP TABLE IF EXISTS mcp_server`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`DROP TABLE IF EXISTS oauth_pending_authorization`.execute(trx);+ await sql`DROP TABLE IF EXISTS oauth_token`.execute(trx);+ await sql`DROP TABLE IF EXISTS mcp_server`.execute(trx);+ });}diff --git a/packages/server/src/db/sqlite/migrations/20260808_000001_skill.ts b/packages/server/src/db/sqlite/migrations/20260808_000001_skill.tsindex c089872e1..af3743e5a 100644--- a/packages/server/src/db/sqlite/migrations/20260808_000001_skill.ts+++ b/packages/server/src/db/sqlite/migrations/20260808_000001_skill.ts@@ -6,18 +6,22 @@ import { sql, type Kysely } from 'kysely';* (via jsonb(...)), timestamps are ISO-8601 TEXT.*/export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- CREATE TABLE skill (- tenant_id TEXT NOT NULL,- name TEXT NOT NULL,- manifest BLOB NOT NULL,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (tenant_id, name)- ) STRICT- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`+ CREATE TABLE skill (+ tenant_id TEXT NOT NULL,+ name TEXT NOT NULL,+ manifest BLOB NOT NULL,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (tenant_id, name)+ ) STRICT+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`DROP TABLE IF EXISTS skill`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`DROP TABLE IF EXISTS skill`.execute(trx);+ });}diff --git a/packages/server/src/db/sqlite/migrations/20260809_000001_sandbox_provider.ts b/packages/server/src/db/sqlite/migrations/20260809_000001_sandbox_provider.tsindex 2d2fbff6b..774de12b5 100644--- a/packages/server/src/db/sqlite/migrations/20260809_000001_sandbox_provider.ts+++ b/packages/server/src/db/sqlite/migrations/20260809_000001_sandbox_provider.ts@@ -6,17 +6,21 @@ import { sql, type Kysely } from 'kysely';* Singleton per tenant: PK is `tenant_id` only. Manifest is BLOB JSONB.*/export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- CREATE TABLE sandbox_provider (- tenant_id TEXT NOT NULL,- manifest BLOB NOT NULL,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (tenant_id)- ) STRICT- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`+ CREATE TABLE sandbox_provider (+ tenant_id TEXT NOT NULL,+ manifest BLOB NOT NULL,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (tenant_id)+ ) STRICT+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`DROP TABLE IF EXISTS sandbox_provider`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`DROP TABLE IF EXISTS sandbox_provider`.execute(trx);+ });}diff --git a/packages/server/src/db/sqlite/migrations/20260810_000001_agent.ts b/packages/server/src/db/sqlite/migrations/20260810_000001_agent.tsindex d4e2a1bd6..e8382f5b9 100644--- a/packages/server/src/db/sqlite/migrations/20260810_000001_agent.ts+++ b/packages/server/src/db/sqlite/migrations/20260810_000001_agent.ts@@ -5,143 +5,152 @@ import { sql, type Kysely } from 'kysely';** - `agent`: mirrors Postgres (manifest is BLOB SQLite JSONB; timestamps ISO TEXT).* - `session`: agent_id XOR agent_spec. STRICT cannot drop NOT NULL in place —- * rebuild the session table. Foreign keys are disabled for the swap; child- * rows keep matching session_id values.+ * rebuild the session table. Child rows keep matching session_id values.+ *+ * `DROP TABLE session` needs FKs off (`turn` etc. still REFERENCES it).+ * `PRAGMA foreign_keys` is a no-op inside a transaction, so toggle it around the+ * txn (Kysely Migrator does not wrap SQLite migrations — see kysely#56).*/export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- CREATE TABLE agent (- id TEXT NOT NULL,- tenant_id TEXT NOT NULL,- name TEXT NOT NULL,- manifest BLOB NOT NULL,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (id),- UNIQUE (tenant_id, name)- ) STRICT- `.execute(db);-await sql`PRAGMA foreign_keys = OFF`.execute(db);-- await sql`- CREATE TABLE session_new (- tenant_id TEXT NOT NULL,- session_id TEXT NOT NULL,- agent_id TEXT,- agent_spec BLOB,- title TEXT,- last_turn_id TEXT,- custom BLOB,- last_activity_timestamp_ms INTEGER NOT NULL,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (session_id),- CHECK (- (agent_id IS NOT NULL AND agent_spec IS NULL)- OR (agent_id IS NULL AND agent_spec IS NOT NULL)- )- ) STRICT- `.execute(db);-- await sql`- INSERT INTO session_new (- tenant_id,- session_id,- agent_id,- agent_spec,- title,- last_turn_id,- custom,- last_activity_timestamp_ms,- created_at,- updated_at- )- SELECT- tenant_id,- session_id,- NULL,- agent_spec,- title,- last_turn_id,- custom,- last_activity_timestamp_ms,- created_at,- updated_at- FROM session- `.execute(db);-- await sql`DROP TABLE session`.execute(db);- await sql`ALTER TABLE session_new RENAME TO session`.execute(db);-- await sql`- CREATE INDEX session_list_idx- ON session (tenant_id, created_at, session_id)- `.execute(db);-- await sql`- CREATE INDEX session_agent_id_idx- ON session (tenant_id, agent_id)- WHERE agent_id IS NOT NULL- `.execute(db);-- await sql`PRAGMA foreign_keys = ON`.execute(db);+ try {+ await db.transaction().execute(async trx => {+ await sql`+ CREATE TABLE agent (+ id TEXT NOT NULL,+ tenant_id TEXT NOT NULL,+ name TEXT NOT NULL,+ manifest BLOB NOT NULL,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (id),+ UNIQUE (tenant_id, name)+ ) STRICT+ `.execute(trx);++ await sql`+ CREATE TABLE session_new (+ tenant_id TEXT NOT NULL,+ session_id TEXT NOT NULL,+ agent_id TEXT,+ agent_spec BLOB,+ title TEXT,+ last_turn_id TEXT,+ custom BLOB,+ last_activity_timestamp_ms INTEGER NOT NULL,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (session_id),+ CHECK (+ (agent_id IS NOT NULL AND agent_spec IS NULL)+ OR (agent_id IS NULL AND agent_spec IS NOT NULL)+ )+ ) STRICT+ `.execute(trx);++ await sql`+ INSERT INTO session_new (+ tenant_id,+ session_id,+ agent_id,+ agent_spec,+ title,+ last_turn_id,+ custom,+ last_activity_timestamp_ms,+ created_at,+ updated_at+ )+ SELECT+ tenant_id,+ session_id,+ NULL,+ agent_spec,+ title,+ last_turn_id,+ custom,+ last_activity_timestamp_ms,+ created_at,+ updated_at+ FROM session+ `.execute(trx);++ await sql`DROP TABLE session`.execute(trx);+ await sql`ALTER TABLE session_new RENAME TO session`.execute(trx);++ await sql`+ CREATE INDEX session_list_idx+ ON session (tenant_id, created_at, session_id)+ `.execute(trx);++ await sql`+ CREATE INDEX session_agent_id_idx+ ON session (tenant_id, agent_id)+ WHERE agent_id IS NOT NULL+ `.execute(trx);+ });+ } finally {+ await sql`PRAGMA foreign_keys = ON`.execute(db);+ }}export async function down(db: Kysely<unknown>): Promise<void> {await sql`PRAGMA foreign_keys = OFF`.execute(db);-- await sql`DELETE FROM session WHERE agent_spec IS NULL`.execute(db);-- await sql`- CREATE TABLE session_old (- tenant_id TEXT NOT NULL,- session_id TEXT NOT NULL,- agent_spec BLOB NOT NULL,- title TEXT,- last_turn_id TEXT,- custom BLOB,- last_activity_timestamp_ms INTEGER NOT NULL,- created_at TEXT NOT NULL,- updated_at TEXT NOT NULL,- PRIMARY KEY (session_id)- ) STRICT- `.execute(db);-- await sql`- INSERT INTO session_old (- tenant_id,- session_id,- agent_spec,- title,- last_turn_id,- custom,- last_activity_timestamp_ms,- created_at,- updated_at- )- SELECT- tenant_id,- session_id,- agent_spec,- title,- last_turn_id,- custom,- last_activity_timestamp_ms,- created_at,- updated_at- FROM session- `.execute(db);-- await sql`DROP TABLE session`.execute(db);- await sql`ALTER TABLE session_old RENAME TO session`.execute(db);-- await sql`- CREATE INDEX session_list_idx- ON session (tenant_id, created_at, session_id)- `.execute(db);-- await sql`PRAGMA foreign_keys = ON`.execute(db);-- await sql`DROP TABLE IF EXISTS agent`.execute(db);+ try {+ await db.transaction().execute(async trx => {+ await sql`DELETE FROM session WHERE agent_spec IS NULL`.execute(trx);++ await sql`+ CREATE TABLE session_old (+ tenant_id TEXT NOT NULL,+ session_id TEXT NOT NULL,+ agent_spec BLOB NOT NULL,+ title TEXT,+ last_turn_id TEXT,+ custom BLOB,+ last_activity_timestamp_ms INTEGER NOT NULL,+ created_at TEXT NOT NULL,+ updated_at TEXT NOT NULL,+ PRIMARY KEY (session_id)+ ) STRICT+ `.execute(trx);++ await sql`+ INSERT INTO session_old (+ tenant_id,+ session_id,+ agent_spec,+ title,+ last_turn_id,+ custom,+ last_activity_timestamp_ms,+ created_at,+ updated_at+ )+ SELECT+ tenant_id,+ session_id,+ agent_spec,+ title,+ last_turn_id,+ custom,+ last_activity_timestamp_ms,+ created_at,+ updated_at+ FROM session+ `.execute(trx);++ await sql`DROP TABLE session`.execute(trx);+ await sql`ALTER TABLE session_old RENAME TO session`.execute(trx);++ await sql`+ CREATE INDEX session_list_idx+ ON session (tenant_id, created_at, session_id)+ `.execute(trx);++ await sql`DROP TABLE IF EXISTS agent`.execute(trx);+ });+ } finally {+ await sql`PRAGMA foreign_keys = ON`.execute(db);+ }}diff --git a/packages/server/src/db/sqlite/migrations/20260811_000001_session_created_by.ts b/packages/server/src/db/sqlite/migrations/20260811_000001_session_created_by.tsindex 1f7797241..ad8d41b2c 100644--- a/packages/server/src/db/sqlite/migrations/20260811_000001_session_created_by.ts+++ b/packages/server/src/db/sqlite/migrations/20260811_000001_session_created_by.ts@@ -2,10 +2,12 @@ import { sql, type Kysely } from 'kysely';/** Add immutable `created_by` identity on session. */export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- ALTER TABLE session- ADD COLUMN created_by TEXT NOT NULL DEFAULT ''- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`+ ALTER TABLE session+ ADD COLUMN created_by TEXT NOT NULL DEFAULT ''+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {diff --git a/packages/server/src/db/sqlite/migrations/20260812_000001_session_agent_name.ts b/packages/server/src/db/sqlite/migrations/20260812_000001_session_agent_name.tsindex e6c81fd3c..71e35d5c3 100644--- a/packages/server/src/db/sqlite/migrations/20260812_000001_session_agent_name.ts+++ b/packages/server/src/db/sqlite/migrations/20260812_000001_session_agent_name.ts@@ -6,20 +6,22 @@ import { sql, type Kysely } from 'kysely';* orphan refs stay NULL.*/export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- ALTER TABLE session- ADD COLUMN agent_name TEXT- `.execute(db);- await sql`- UPDATE session- SET agent_name = (- SELECT a.name- FROM agent AS a- WHERE a.id = session.agent_id- AND a.tenant_id = session.tenant_id- )- WHERE agent_id IS NOT NULL- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`+ ALTER TABLE session+ ADD COLUMN agent_name TEXT+ `.execute(trx);+ await sql`+ UPDATE session+ SET agent_name = (+ SELECT a.name+ FROM agent AS a+ WHERE a.id = session.agent_id+ AND a.tenant_id = session.tenant_id+ )+ WHERE agent_id IS NOT NULL+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {diff --git a/packages/server/src/db/sqlite/migrations/20260813_000001_mcp_oauth_user_scoped.ts b/packages/server/src/db/sqlite/migrations/20260813_000001_mcp_oauth_user_scoped.tsindex 8ab94995b..c86764f64 100644--- a/packages/server/src/db/sqlite/migrations/20260813_000001_mcp_oauth_user_scoped.ts+++ b/packages/server/src/db/sqlite/migrations/20260813_000001_mcp_oauth_user_scoped.ts@@ -9,64 +9,69 @@ import { type Kysely, sql } from 'kysely';* rebuilt (empty after the deletes below). Mirrors* db/postgres/migrations/20260813_000001_mcp_oauth_user_scoped.ts.*- * SQLite has no LOCK TABLE / ACCESS EXCLUSIVE. Migrations run in a deferred- * transaction; a no-op UPDATE before each delete escalates to a RESERVED write- * lock so concurrent connections cannot insert until this migration commits.+ * Wrapped in a transaction so drop/create pairs roll back together. SQLite has+ * no LOCK TABLE / ACCESS EXCLUSIVE; a no-op UPDATE before each delete escalates+ * the deferred txn to a RESERVED write lock so concurrent connections cannot+ * insert until this migration commits.*/export async function up(db: Kysely<unknown>): Promise<void> {- // Escalate deferred txn → RESERVED (writer lock) before clearing the table.- await sql`UPDATE oauth_token SET updated_at = updated_at WHERE false`.execute(db);- await sql`DELETE FROM oauth_token`.execute(db);- await sql`DROP TABLE oauth_token`.execute(db);- await sql`- CREATE TABLE oauth_token (- oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,- user_id TEXT NOT NULL,- token BLOB NOT NULL,- updated_at TEXT NOT NULL,- CONSTRAINT oauth_token_pkey PRIMARY KEY (oauth_server_id, user_id)- ) STRICT- `.execute(db);+ await db.transaction().execute(async trx => {+ // Escalate deferred txn → RESERVED (writer lock) before clearing the table.+ await sql`UPDATE oauth_token SET updated_at = updated_at WHERE false`.execute(trx);+ await sql`DELETE FROM oauth_token`.execute(trx);+ await sql`DROP TABLE oauth_token`.execute(trx);+ await sql`+ CREATE TABLE oauth_token (+ oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,+ user_id TEXT NOT NULL,+ token BLOB NOT NULL,+ updated_at TEXT NOT NULL,+ CONSTRAINT oauth_token_pkey PRIMARY KEY (oauth_server_id, user_id)+ ) STRICT+ `.execute(trx);- // In-flight pending rows cannot be attributed to a user; drop them.- await sql`UPDATE oauth_pending_authorization SET created_at = created_at WHERE false`.execute(db);- await sql`DELETE FROM oauth_pending_authorization`.execute(db);- await sql`DROP TABLE oauth_pending_authorization`.execute(db);- await sql`- CREATE TABLE oauth_pending_authorization (- id TEXT NOT NULL,- oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,- user_id TEXT NOT NULL,- auth_data BLOB NOT NULL,- created_at TEXT NOT NULL,- CONSTRAINT oauth_pending_authorization_pkey PRIMARY KEY (id)- ) STRICT- `.execute(db);+ // In-flight pending rows cannot be attributed to a user; drop them.+ await sql`UPDATE oauth_pending_authorization SET created_at = created_at WHERE false`.execute(trx);+ await sql`DELETE FROM oauth_pending_authorization`.execute(trx);+ await sql`DROP TABLE oauth_pending_authorization`.execute(trx);+ await sql`+ CREATE TABLE oauth_pending_authorization (+ id TEXT NOT NULL,+ oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,+ user_id TEXT NOT NULL,+ auth_data BLOB NOT NULL,+ created_at TEXT NOT NULL,+ CONSTRAINT oauth_pending_authorization_pkey PRIMARY KEY (id)+ ) STRICT+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`UPDATE oauth_pending_authorization SET created_at = created_at WHERE false`.execute(db);- await sql`DELETE FROM oauth_pending_authorization`.execute(db);- await sql`DROP TABLE oauth_pending_authorization`.execute(db);- await sql`- CREATE TABLE oauth_pending_authorization (- id TEXT NOT NULL,- oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,- auth_data BLOB NOT NULL,- created_at TEXT NOT NULL,- CONSTRAINT oauth_pending_authorization_pkey PRIMARY KEY (id)- ) STRICT- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`UPDATE oauth_pending_authorization SET created_at = created_at WHERE false`.execute(trx);+ await sql`DELETE FROM oauth_pending_authorization`.execute(trx);+ await sql`DROP TABLE oauth_pending_authorization`.execute(trx);+ await sql`+ CREATE TABLE oauth_pending_authorization (+ id TEXT NOT NULL,+ oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,+ auth_data BLOB NOT NULL,+ created_at TEXT NOT NULL,+ CONSTRAINT oauth_pending_authorization_pkey PRIMARY KEY (id)+ ) STRICT+ `.execute(trx);- await sql`UPDATE oauth_token SET updated_at = updated_at WHERE false`.execute(db);- await sql`DELETE FROM oauth_token`.execute(db);- await sql`DROP TABLE oauth_token`.execute(db);- await sql`- CREATE TABLE oauth_token (- oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,- token BLOB NOT NULL,- updated_at TEXT NOT NULL,- CONSTRAINT oauth_token_pkey PRIMARY KEY (oauth_server_id)- ) STRICT- `.execute(db);+ await sql`UPDATE oauth_token SET updated_at = updated_at WHERE false`.execute(trx);+ await sql`DELETE FROM oauth_token`.execute(trx);+ await sql`DROP TABLE oauth_token`.execute(trx);+ await sql`+ CREATE TABLE oauth_token (+ oauth_server_id TEXT NOT NULL REFERENCES mcp_server (id) ON DELETE CASCADE,+ token BLOB NOT NULL,+ updated_at TEXT NOT NULL,+ CONSTRAINT oauth_token_pkey PRIMARY KEY (oauth_server_id)+ ) STRICT+ `.execute(trx);+ });}diff --git a/packages/server/src/db/sqlite/migrations/20260814_000001_session_list_updated_at_idx.ts b/packages/server/src/db/sqlite/migrations/20260814_000001_session_list_updated_at_idx.tsindex 75b682a34..02eb28005 100644--- a/packages/server/src/db/sqlite/migrations/20260814_000001_session_list_updated_at_idx.ts+++ b/packages/server/src/db/sqlite/migrations/20260814_000001_session_list_updated_at_idx.ts@@ -5,12 +5,16 @@ import { type Kysely, sql } from 'kysely';* `session_list_idx` on `created_at` for start/end timestamp filters.*/export async function up(db: Kysely<unknown>): Promise<void> {- await sql`- CREATE INDEX session_list_updated_at_idx- ON session (tenant_id, updated_at, session_id)- `.execute(db);+ await db.transaction().execute(async trx => {+ await sql`+ CREATE INDEX session_list_updated_at_idx+ ON session (tenant_id, updated_at, session_id)+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`DROP INDEX session_list_updated_at_idx`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`DROP INDEX session_list_updated_at_idx`.execute(trx);+ });}diff --git a/packages/server/src/db/sqlite/migrations/20260815_000001_sandbox_provider_status.ts b/packages/server/src/db/sqlite/migrations/20260815_000001_sandbox_provider_status.tsindex 6c2fbd8d9..314b74f49 100644--- a/packages/server/src/db/sqlite/migrations/20260815_000001_sandbox_provider_status.ts+++ b/packages/server/src/db/sqlite/migrations/20260815_000001_sandbox_provider_status.ts@@ -16,24 +16,28 @@ const RELEASE_IMAGE_URI ='tfy.jfrog.io/tfy-images/truefoundry-utils-core-sandbox:029ea5ff6438cf86b79282e087bfc17528067946';export async function up(db: Kysely<unknown>): Promise<void> {- await sql`ALTER TABLE sandbox_provider ADD COLUMN status TEXT NOT NULL DEFAULT 'pending'`.execute(db);- await sql`ALTER TABLE sandbox_provider ADD COLUMN status_reason TEXT`.execute(db);- // Nullable: SQLite forbids non-constant DEFAULTs on ADD COLUMN when rows exist.- await sql`ALTER TABLE sandbox_provider ADD COLUMN build_metadata BLOB`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`ALTER TABLE sandbox_provider ADD COLUMN status TEXT NOT NULL DEFAULT 'pending'`.execute(trx);+ await sql`ALTER TABLE sandbox_provider ADD COLUMN status_reason TEXT`.execute(trx);+ // Nullable: SQLite forbids non-constant DEFAULTs on ADD COLUMN when rows exist.+ await sql`ALTER TABLE sandbox_provider ADD COLUMN build_metadata BLOB`.execute(trx);- await sql`- UPDATE sandbox_provider- SET status = 'ready',- build_metadata = jsonb(json_object(- 'build_ref', json_extract(json(manifest), '$.snapshot_name'),- 'image_uri', ${RELEASE_IMAGE_URI}- ))- WHERE json_extract(json(manifest), '$.snapshot_name') IS NOT NULL- `.execute(db);+ await sql`+ UPDATE sandbox_provider+ SET status = 'ready',+ build_metadata = jsonb(json_object(+ 'build_ref', json_extract(json(manifest), '$.snapshot_name'),+ 'image_uri', ${RELEASE_IMAGE_URI}+ ))+ WHERE json_extract(json(manifest), '$.snapshot_name') IS NOT NULL+ `.execute(trx);+ });}export async function down(db: Kysely<unknown>): Promise<void> {- await sql`ALTER TABLE sandbox_provider DROP COLUMN build_metadata`.execute(db);- await sql`ALTER TABLE sandbox_provider DROP COLUMN status_reason`.execute(db);- await sql`ALTER TABLE sandbox_provider DROP COLUMN status`.execute(db);+ await db.transaction().execute(async trx => {+ await sql`ALTER TABLE sandbox_provider DROP COLUMN build_metadata`.execute(trx);+ await sql`ALTER TABLE sandbox_provider DROP COLUMN status_reason`.execute(trx);+ await sql`ALTER TABLE sandbox_provider DROP COLUMN status`.execute(trx);+ });}