The open-source agent harness - the runtime layer that turns an LLM into a working agent.
fix: catalog refetching logic (#330)
Vinit7e2e02cc8dd1
diff --git a/.changeset/settings-refresh-on-leave.md b/.changeset/settings-refresh-on-leave.mdnew file mode 100644index 000000000..2da40fad9--- /dev/null+++ b/.changeset/settings-refresh-on-leave.md@@ -0,0 +1,5 @@+---+'@truefoundry/trueforge-ui': patch+---++Refresh composer catalogs whenever settings close, including navigating to a chat or named agent.diff --git a/packages/trueforge-ui/src/containers/SettingsBuilder/index.tsx b/packages/trueforge-ui/src/containers/SettingsBuilder/index.tsxindex 3b0da57e8..a3f27015b 100644--- a/packages/trueforge-ui/src/containers/SettingsBuilder/index.tsx+++ b/packages/trueforge-ui/src/containers/SettingsBuilder/index.tsx@@ -38,9 +38,16 @@ const TruefoundrySettingsBuilder = () => {const closeSettings = useCallback(() => {setSettingsOpen(false);- refreshDraftCatalog();- refreshServerCapabilities?.();- }, [refreshDraftCatalog, refreshServerCapabilities, setSettingsOpen]);+ }, [setSettingsOpen]);++ // Refresh catalogs whenever settings are closed or navigated away from.+ useEffect(() => {+ if (!settingsOpen) return;+ return () => {+ refreshDraftCatalog();+ refreshServerCapabilities?.();+ };+ }, [settingsOpen, refreshDraftCatalog, refreshServerCapabilities]);useEffect(() => {if (!hasSkills && section === 'skills') {diff --git a/packages/trueforge-ui/test/containers/SettingsBuilder/index.test.tsx b/packages/trueforge-ui/test/containers/SettingsBuilder/index.test.tsxindex 38b599c4b..da2e4e0da 100644--- a/packages/trueforge-ui/test/containers/SettingsBuilder/index.test.tsx+++ b/packages/trueforge-ui/test/containers/SettingsBuilder/index.test.tsx@@ -58,9 +58,14 @@ function createServer(options: { catalog?: boolean; skills?: boolean; sandbox?:function SettingsControls() {const { setSettingsOpen } = useShellMode();return (- <button type="button" onClick={() => setSettingsOpen(true)}>- Open settings- </button>+ <>+ <button type="button" onClick={() => setSettingsOpen(true)}>+ Open settings+ </button>+ <button type="button" onClick={() => setSettingsOpen(false)}>+ Switch to agent+ </button>+ </>);}@@ -164,7 +169,7 @@ describe('TruefoundrySettingsBuilder', () => {expect(parentKeyDown).not.toHaveBeenCalled();});- it('refreshes composer catalogs when settings close', async () => {+ async function expectCatalogsRefreshOnClose(close: () => void) {const getModels = vi.fn(async () => []);const getSkills = vi.fn(async () => []);const getMcp = vi.fn(async () => []);@@ -183,13 +188,25 @@ describe('TruefoundrySettingsBuilder', () => {await waitFor(() => expect(getCapabilities).toHaveBeenCalled());const capabilitiesCallsAfterOpen = getCapabilities.mock.calls.length;- fireEvent.click(screen.getByRole('button', { name: 'Back' }));+ close();expect(screen.queryByRole('heading', { name: 'Settings' })).not.toBeInTheDocument();await waitFor(() => expect(getModels).toHaveBeenCalledOnce());expect(getSkills).toHaveBeenCalledOnce();expect(getMcp).toHaveBeenCalledOnce();await waitFor(() => expect(getCapabilities.mock.calls.length).toBeGreaterThan(capabilitiesCallsAfterOpen));+ }++ it('refreshes composer catalogs when settings close', async () => {+ await expectCatalogsRefreshOnClose(() => {+ fireEvent.click(screen.getByRole('button', { name: 'Back' }));+ });+ });++ it('refreshes composer catalogs when leaving settings for a chat or named agent', async () => {+ await expectCatalogsRefreshOnClose(() => {+ fireEvent.click(screen.getByRole('button', { name: 'Switch to agent' }));+ });});it('does not reopen settings when a stale optional section is reset while closed', async () => {