Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

bugfix: avoid multiple list permission api call and fetch create-agent permission only once (#899)

harshil-2096985ad2482faa
diff --git a/.changeset/deep-flies-carry.md b/.changeset/deep-flies-carry.md
new file mode 100644
index 000000000..c07f14172
--- /dev/null
+++ b/.changeset/deep-flies-carry.md
@@ -0,0 +1,5 @@
+---
+"@truefoundry/trueforge-ui": patch
+---
+
+Avoid redundant list-permissions API calls by sharing tenant permission state through CanCreateAgentProvider.
diff --git a/packages/trueforge-ui/src/hooks/useCanCreateAgent.ts b/packages/trueforge-ui/src/hooks/useCanCreateAgent.ts
index fcf96862b..3afd6acb3 100644
--- a/packages/trueforge-ui/src/hooks/useCanCreateAgent.ts
+++ b/packages/trueforge-ui/src/hooks/useCanCreateAgent.ts
@@ -1,8 +1,8 @@
'use client';
-import { useEffect, useState } from 'react';
+import { createContext, createElement, useContext, useEffect, useState, type ReactNode } from 'react';
-import { useOptionalPermissionsServer } from '../server/ServerContext.js';
+import type { PermissionsServer } from '../server/types.js';
export type UseCanCreateAgentResult = {
loading: boolean;
@@ -10,26 +10,38 @@ export type UseCanCreateAgentResult = {
canCreateAgent: boolean;
};
+const CanCreateAgentContext = createContext<UseCanCreateAgentResult>({
+ loading: false,
+ canCreateAgent: true,
+});
+
/**
- * Tenant-scoped create-agent grant via `list-permissions` (`resource_type: tenant`).
- * When no permissions server is configured (standalone without port), allows create.
+ * Fetches the tenant-scoped CREATE grant once for the given permissions server
+ * and broadcasts the result via context. Mount once high in the tree (inside
+ * ServerProvider) so every useCanCreateAgent consumer shares a single
+ * list-permissions call instead of each firing its own.
*/
-export function useCanCreateAgent(): UseCanCreateAgentResult {
- const server = useOptionalPermissionsServer();
- const [state, setState] = useState<{ loading: boolean; canCreateAgent: boolean }>({
- loading: server != null,
- canCreateAgent: server == null,
+export function CanCreateAgentProvider({
+ permissionsServer,
+ children,
+}: {
+ permissionsServer: PermissionsServer | null;
+ children: ReactNode;
+}) {
+ const [state, setState] = useState<UseCanCreateAgentResult>({
+ loading: permissionsServer != null,
+ canCreateAgent: permissionsServer == null,
});
useEffect(() => {
- if (server == null) {
+ if (permissionsServer == null) {
setState({ loading: false, canCreateAgent: true });
return;
}
let cancelled = false;
setState({ loading: true, canCreateAgent: false });
- void server
+ void permissionsServer
.listPermissions({ resourceType: 'tenant', resourceIds: [] })
.then(response => {
if (cancelled) return;
@@ -44,7 +56,15 @@ export function useCanCreateAgent(): UseCanCreateAgentResult {
return () => {
cancelled = true;
};
- }, [server]);
+ }, [permissionsServer]);
+
+ return createElement(CanCreateAgentContext.Provider, { value: state }, children);
+}
- return state;
+/**
+ * Tenant-scoped create-agent grant. Reads from CanCreateAgentProvider (mounted
+ * inside ServerProvider). Falls back to allow-all when no permissions port is configured.
+ */
+export function useCanCreateAgent(): UseCanCreateAgentResult {
+ return useContext(CanCreateAgentContext);
}
diff --git a/packages/trueforge-ui/src/index.ts b/packages/trueforge-ui/src/index.ts
index 8716faa43..04a3ccc6b 100644
--- a/packages/trueforge-ui/src/index.ts
+++ b/packages/trueforge-ui/src/index.ts
@@ -242,7 +242,7 @@ export { UserEditComposerContainer } from './containers/UserEditComposerContaine
export { UserMessageContainer } from './containers/UserMessageContainer.js';
export { useApprovalNav } from './hooks/useApprovalNav.js';
export type { ApprovalNavState } from './hooks/useApprovalNav.js';
-export { useCanCreateAgent } from './hooks/useCanCreateAgent.js';
+export { CanCreateAgentProvider, useCanCreateAgent } from './hooks/useCanCreateAgent.js';
export type { UseCanCreateAgentResult } from './hooks/useCanCreateAgent.js';
export { ComposerBusyProvider, useComposerBusyState } from './hooks/useComposerBusyState.js';
export type { ComposerBusyState } from './hooks/useComposerBusyState.js';
diff --git a/packages/trueforge-ui/src/server/ServerContext.tsx b/packages/trueforge-ui/src/server/ServerContext.tsx
index d41fd67f1..9b69953d8 100644
--- a/packages/trueforge-ui/src/server/ServerContext.tsx
+++ b/packages/trueforge-ui/src/server/ServerContext.tsx
@@ -2,6 +2,7 @@
import { createContext, useCallback, useContext, useEffect, useMemo, useRef, useState, type ReactNode } from 'react';
+import { CanCreateAgentProvider } from '../hooks/useCanCreateAgent.js';
import type {
AgentBuilderCapabilitiesResponse,
AgentMetricsServer,
@@ -58,7 +59,9 @@ export function ServerProvider({ server, children }: { server: AgentUIServer; ch
return (
<ServerContext.Provider value={server}>
- <ServerCapabilitiesContext.Provider value={capabilitiesValue}>{children}</ServerCapabilitiesContext.Provider>
+ <ServerCapabilitiesContext.Provider value={capabilitiesValue}>
+ <CanCreateAgentProvider permissionsServer={server.permissions ?? null}>{children}</CanCreateAgentProvider>
+ </ServerCapabilitiesContext.Provider>
</ServerContext.Provider>
);
}
diff --git a/packages/trueforge-ui/test/hooks/useResourcePermissions.test.tsx b/packages/trueforge-ui/test/hooks/useResourcePermissions.test.tsx
index 13a927d27..0ca95ab0d 100644
--- a/packages/trueforge-ui/test/hooks/useResourcePermissions.test.tsx
+++ b/packages/trueforge-ui/test/hooks/useResourcePermissions.test.tsx
@@ -9,9 +9,23 @@ import {
useResourcePermissions,
} from '@/hooks/useResourcePermissions.js';
import { ServerProvider } from '@/server/ServerContext.js';
-import type { ListPermissionsResponse } from '@/server/types.js';
+import type { ListPermissionsResponse, PermissionResourceType } from '@/server/types.js';
import { createMockAgentUIServer } from '../server/mockServer.js';
+/** ServerProvider mounts CanCreateAgentProvider, which also calls listPermissions for tenant. */
+const TENANT_RESPONSE: ListPermissionsResponse = { data: { type: 'tenant', permissions: {} } };
+
+function listPermissionsMock(
+ impl: (args: { resourceType: PermissionResourceType; resourceIds: string[] }) => Promise<ListPermissionsResponse>,
+) {
+ return vi.fn(
+ async (args: { resourceType: PermissionResourceType; resourceIds: string[] }): Promise<ListPermissionsResponse> => {
+ if (args.resourceType === 'tenant') return TENANT_RESPONSE;
+ return impl(args);
+ },
+ );
+}
+
describe('useResourcePermissions', () => {
it('allows without a permissions port', () => {
const { result } = renderHook(() => useResourcePermissions({ resourceType: 'agent', resourceIds: ['agent-1'] }));
@@ -22,7 +36,7 @@ describe('useResourcePermissions', () => {
it('fails closed until grants load and denies missing ids', async () => {
let resolvePermissions: ((value: ListPermissionsResponse) => void) | undefined;
- const listPermissions = vi.fn(
+ const listPermissions = listPermissionsMock(
() =>
new Promise<ListPermissionsResponse>(resolve => {
resolvePermissions = resolve;
@@ -49,14 +63,12 @@ describe('useResourcePermissions', () => {
});
it('chunks requests at 100 ids and fails closed on errors', async () => {
- const listPermissions = vi.fn(
- async ({ resourceIds }: { resourceIds: string[] }): Promise<ListPermissionsResponse> => ({
- data: {
- type: 'session',
- permissions: Object.fromEntries(resourceIds.map(resourceId => [resourceId, ['DELETE']])),
- },
- }),
- );
+ const listPermissions = listPermissionsMock(async ({ resourceIds }): Promise<ListPermissionsResponse> => ({
+ data: {
+ type: 'session',
+ permissions: Object.fromEntries(resourceIds.map(resourceId => [resourceId, ['DELETE']])),
+ },
+ }));
const server = createMockAgentUIServer({ permissions: { listPermissions } });
const wrapper = ({ children }: { children: ReactNode }) => (
<ServerProvider server={server}>{children}</ServerProvider>
@@ -68,9 +80,12 @@ describe('useResourcePermissions', () => {
);
await waitFor(() => expect(result.current.allows('session-100', 'DELETE')).toBe(true));
- expect(listPermissions).toHaveBeenCalledTimes(2);
+ expect(listPermissions.mock.calls.filter(([req]) => req.resourceType === 'session')).toHaveLength(2);
- listPermissions.mockRejectedValueOnce(new Error('permission service unavailable'));
+ listPermissions.mockImplementationOnce(async args => {
+ if (args.resourceType === 'tenant') return TENANT_RESPONSE;
+ throw new Error('permission service unavailable');
+ });
rerender({ ids: ['session-error'] });
await waitFor(() => expect(result.current.error).toEqual(new Error('permission service unavailable')));
expect(result.current.allows('session-error', 'DELETE')).toBe(false);
@@ -81,15 +96,14 @@ describe('useResourcePermissions', () => {
const knownResponse: ListPermissionsResponse = {
data: { type: 'session', permissions: { known: ['MANAGE'] } },
};
- const listPermissions = vi
- .fn()
- .mockResolvedValueOnce(knownResponse)
- .mockImplementationOnce(
- () =>
- new Promise<ListPermissionsResponse>((_resolve, reject) => {
- rejectExpanded = reject;
- }),
- );
+ let nonTenantCalls = 0;
+ const listPermissions = listPermissionsMock(() => {
+ nonTenantCalls += 1;
+ if (nonTenantCalls === 1) return Promise.resolve(knownResponse);
+ return new Promise<ListPermissionsResponse>((_resolve, reject) => {
+ rejectExpanded = reject;
+ });
+ });
const server = createMockAgentUIServer({ permissions: { listPermissions } });
const wrapper = ({ children }: { children: ReactNode }) => (
<ServerProvider server={server}>{children}</ServerProvider>
diff --git a/packages/trueforge-ui/test/publicUiExports.test.ts b/packages/trueforge-ui/test/publicUiExports.test.ts
index 2fac93335..e0b2752d9 100644
--- a/packages/trueforge-ui/test/publicUiExports.test.ts
+++ b/packages/trueforge-ui/test/publicUiExports.test.ts
@@ -50,6 +50,7 @@ const expectedRuntimeExports: Array<keyof typeof sdk> = [
'BottomSheet',
'BrandLogo',
'Button',
+ 'CanCreateAgentProvider',
'CenteredModal',
'ChatFileDownload',
'ClearChatButton',