Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

Edit panel for configured providers + success-toast polish (#211)

shubhamagarwal-createa3233e042c7f
diff --git a/packages/trueforge-ui-sdk/src/atoms/Toast.tsx b/packages/trueforge-ui-sdk/src/atoms/Toast.tsx
index 466bd8547..695e84b79 100644
--- a/packages/trueforge-ui-sdk/src/atoms/Toast.tsx
+++ b/packages/trueforge-ui-sdk/src/atoms/Toast.tsx
@@ -58,15 +58,17 @@ export function Toast({ title, description, open, onOpenChange, variant = 'error
{title}
</div>
<div className="flex shrink-0 items-center gap-1">
- <button
- type="button"
- aria-label="Copy"
- title="Copy"
- className={auiButtonClass({ variant: 'ghost', size: 'icon' })}
- onClick={handleCopy}
- >
- <Icon name={copied ? 'check' : 'clone'} />
- </button>
+ {variant === 'error' ? (
+ <button
+ type="button"
+ aria-label="Copy"
+ title="Copy"
+ className={auiButtonClass({ variant: 'ghost', size: 'icon' })}
+ onClick={handleCopy}
+ >
+ <Icon name={copied ? 'check' : 'clone'} />
+ </button>
+ ) : null}
<button
type="button"
aria-label="Close"
@@ -78,9 +80,11 @@ export function Toast({ title, description, open, onOpenChange, variant = 'error
</button>
</div>
</div>
- <div className="text-text-secondary mt-1 max-h-24 overflow-y-auto text-sm leading-snug break-words whitespace-pre-wrap">
- {description}
- </div>
+ {description ? (
+ <div className="text-text-secondary mt-1 max-h-24 overflow-y-auto text-sm leading-snug break-words whitespace-pre-wrap">
+ {description}
+ </div>
+ ) : null}
</div>
</div>
);
@@ -107,7 +111,7 @@ export function ToastStack({ children, duration: _duration = Number.POSITIVE_INF
<div
ref={openToastStack}
popover="manual"
- className="pointer-events-none fixed top-auto right-auto bottom-4 left-1/2 z-50 flex w-full max-w-md -translate-x-1/2 flex-col-reverse gap-2 overflow-visible bg-transparent px-4"
+ className="pointer-events-none fixed inset-auto right-4 bottom-4 z-50 m-0 flex w-[calc(100vw-2rem)] max-w-md flex-col-reverse gap-2 overflow-visible bg-transparent"
>
{children}
</div>
diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConnectorSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConnectorSettings.tsx
index 047019474..7f8117f46 100644
--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConnectorSettings.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ConnectorSettings.tsx
@@ -225,10 +225,7 @@ const ConnectorSettings = () => {
}
closeApiKeyModal();
setTimeout(() => {
- toaster?.showSuccess({
- title: existingConnector ? 'Connector updated' : 'Connector connected',
- description: `${entry.name} is ready to use.`,
- });
+ toaster?.showSuccess({ title: `${entry.name} ${existingConnector ? 'updated' : 'connected'}` });
}, 100);
}, setFormError).catch(() => {});
};
@@ -246,10 +243,7 @@ const ConnectorSettings = () => {
}
}, setFormError);
setTimeout(() => {
- toaster?.showSuccess({
- title: 'Connector added',
- description: `${draft.name} is ready to use.`,
- });
+ toaster?.showSuccess({ title: `${draft.name} added` });
}, 0);
};
diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx
index 8df2f62f9..a5d0712f0 100644
--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx
@@ -2,7 +2,6 @@
import { useCallback, useEffect, useMemo, useState } from 'react';
-import { cn } from '@/atoms/lib/cn.js';
import { auiInputClass } from '@/atoms/lib/inputClasses.js';
import { Accordion, AccordionDetails, AccordionSummary } from '@/atoms/primitives/Accordion.js';
import { Button } from '@/atoms/primitives/Button.js';
@@ -163,8 +162,6 @@ const ModelSettings = () => {
};
const handleReplaceKey = (provider: ModelProviderBase) => {
- if (!apiKey.trim()) return;
-
void runMutation(async () => {
await modelCatalog.updateModelProvider({
id: provider.id,
@@ -176,10 +173,7 @@ const ModelSettings = () => {
});
})
.then(() => {
- toaster?.showSuccess({
- title: 'API key replaced',
- description: `${provider.name} was updated successfully.`,
- });
+ toaster?.showSuccess({ title: `${provider.name} updated` });
})
.catch(() => {});
};
@@ -221,16 +215,13 @@ const ModelSettings = () => {
err => setFormError(getErrorMessage(err, 'Request failed')),
);
setTimeout(() => {
- toaster?.showSuccess({
- title: 'Model provider added',
- description: `${draft.name} is ready to use.`,
- });
+ toaster?.showSuccess({ title: `${draft.name} added` });
}, 0);
};
const renderKeyEditor = (opts: { id: string; submitLabel: string; onSave: () => void; isReplacingKey?: boolean }) => (
<form
- className="mt-4 rounded-lg border border-border bg-secondary-bg/40 p-4"
+ className="mt-4 rounded-lg bg-secondary-bg/40 p-4"
onSubmit={event => {
event.preventDefault();
opts.onSave();
@@ -249,10 +240,15 @@ const ModelSettings = () => {
onChange={event => {
setApiKey(event.target.value);
}}
- placeholder={opts.isReplacingKey ? 'Enter a new key to replace the saved one' : 'Enter API Key'}
+ placeholder={opts.isReplacingKey ? 'Enter a new key' : 'Enter API Key'}
autoFocus
className={auiInputClass('h-10')}
/>
+ {opts.isReplacingKey ? (
+ <p className="mt-1.5 text-sm text-text-secondary">
+ Leave blank to keep the current key; enter a new one to replace it.
+ </p>
+ ) : null}
<Accordion expanded={advancedOpen} onChange={(_event, next) => setAdvancedOpen(next)}>
<AccordionSummary className="pt-2 pb-1.5">
<span className="flex items-center gap-1.5 text-xs text-text-secondary">
@@ -286,18 +282,13 @@ const ModelSettings = () => {
</AccordionDetails>
</Accordion>
- <div className={cn('mt-2 flex items-center gap-2', opts.isReplacingKey ? 'justify-between' : 'justify-end')}>
- {opts.isReplacingKey ? (
- <p className="text-sm text-text-secondary">The saved key is hidden. Saving replaces it.</p>
- ) : null}
- <div className="flex gap-2">
- <Button variant="ghost" size="sm" type="button" onClick={closeKeyEditor} disabled={busy}>
- Cancel
- </Button>
- <Button size="sm" type="submit" disabled={!apiKey.trim() || busy}>
- {opts.submitLabel}
- </Button>
- </div>
+ <div className="mt-2 flex items-center justify-end gap-2">
+ <Button variant="ghost" size="sm" type="button" onClick={closeKeyEditor} disabled={busy}>
+ Cancel
+ </Button>
+ <Button size="sm" type="submit" disabled={busy || (!opts.isReplacingKey && !apiKey.trim())}>
+ {opts.submitLabel}
+ </Button>
</div>
</form>
);
@@ -373,23 +364,25 @@ const ModelSettings = () => {
<span className="h-1.5 w-1.5 rounded-full bg-success-bg"></span>
Connected
</span>
- <Button
- variant="secondary"
- size="sm"
- className="text-[0.8125rem]"
- type="button"
- disabled={busy}
- onClick={() => {
- setEditingCatalogType(null);
- setEditingProviderId(provider.id);
- setApiKey('');
- setBaseUrl(provider.baseUrl ?? '');
- setAdvancedOpen(false);
- }}
- >
- <Icon name="wrench" className="size-3.5" />
- Replace key
- </Button>
+ {editingProviderId === provider.id ? null : (
+ <Button
+ variant="secondary"
+ size="sm"
+ className="text-[0.8125rem]"
+ type="button"
+ disabled={busy}
+ onClick={() => {
+ setEditingCatalogType(null);
+ setEditingProviderId(provider.id);
+ setApiKey('');
+ setBaseUrl(provider.baseUrl ?? '');
+ setAdvancedOpen(false);
+ }}
+ >
+ <Icon name="wrench" className="size-3.5" />
+ Edit
+ </Button>
+ )}
{modelCatalog.deleteModelProvider ? (
<Button
variant="outline"
@@ -410,7 +403,7 @@ const ModelSettings = () => {
{editingProviderId === provider.id
? renderKeyEditor({
id: provider.id,
- submitLabel: 'Replace key',
+ submitLabel: 'Save',
isReplacingKey: true,
onSave: () => {
handleReplaceKey(provider);
diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SandboxSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SandboxSettings.tsx
index 8a327da47..f2b365a7e 100644
--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SandboxSettings.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SandboxSettings.tsx
@@ -108,10 +108,7 @@ const SandboxSettings = () => {
}, setFormError);
setCreateEntry(null);
setTimeout(() => {
- toaster?.showSuccess({
- title: 'Sandbox provider configured',
- description: `${createEntry.name} is ready to use.`,
- });
+ toaster?.showSuccess({ title: `${createEntry.name} configured` });
}, 0);
};
@@ -127,10 +124,7 @@ const SandboxSettings = () => {
}, setFormError);
setUpdateProvider(null);
setTimeout(() => {
- toaster?.showSuccess({
- title: 'Sandbox provider updated',
- description: `${updateProvider.name} was updated successfully.`,
- });
+ toaster?.showSuccess({ title: `${updateProvider.name} updated` });
}, 0);
};
diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx
index 38d40460c..378bbf458 100644
--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/SkillSettings.tsx
@@ -107,10 +107,7 @@ const SkillSettings = () => {
await skillCatalog.createSkill(draft);
}, setFormError);
setTimeout(() => {
- toaster?.showSuccess({
- title: 'Skill imported',
- description: `${draft.name} is ready to use.`,
- });
+ toaster?.showSuccess({ title: `${draft.name} imported` });
}, 0);
};
diff --git a/packages/trueforge-ui-sdk/src/containers/ToasterContainer.tsx b/packages/trueforge-ui-sdk/src/containers/ToasterContainer.tsx
index 3f9e888d0..393512fa1 100644
--- a/packages/trueforge-ui-sdk/src/containers/ToasterContainer.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/ToasterContainer.tsx
@@ -7,8 +7,9 @@ import { getErrorMessage } from '../utils/getErrorMessage.js';
const MAX_TOAST_DESCRIPTION_CHARS = 480;
const MAX_VISIBLE_TOASTS = 5;
+const SUCCESS_TOAST_TTL_MS = 3000;
-type ToastContent = { title: string; description: string };
+type ToastContent = { title: string; description?: string };
type ToastItem = ToastContent & { id: string; variant: 'error' | 'success' };
@@ -55,20 +56,29 @@ export function ToasterProvider({ children }: { children: ReactNode }) {
const ToastStack = useSlot('ToastStack');
const [toasts, setToasts] = useState<ToastItem[]>([]);
+ const dismiss = useCallback((id: string) => {
+ setToasts(prev => prev.filter(t => t.id !== id));
+ }, []);
+
const showError = useCallback((error: unknown) => {
console.error('[trueforge-ui]', error);
const item: ToastItem = { id: nextToastId(), variant: 'error', ...normalizeError(error) };
setToasts(prev => [...prev, item].slice(-MAX_VISIBLE_TOASTS));
}, []);
- const showSuccess = useCallback((content: ToastContent) => {
- const item: ToastItem = { id: nextToastId(), variant: 'success', ...content };
- setToasts(prev => [...prev, item].slice(-MAX_VISIBLE_TOASTS));
- }, []);
-
- const dismiss = useCallback((id: string) => {
- setToasts(prev => prev.filter(t => t.id !== id));
- }, []);
+ const showSuccess = useCallback(
+ (content: ToastContent) => {
+ const id = nextToastId();
+ const item: ToastItem = { id, variant: 'success', ...content };
+ setToasts(prev => [...prev, item].slice(-MAX_VISIBLE_TOASTS));
+ // Success is a transient confirmation — auto-dismiss so it doesn't linger. Errors persist
+ // (a dev may need to read or copy them).
+ if (typeof window !== 'undefined') {
+ window.setTimeout(() => dismiss(id), SUCCESS_TOAST_TTL_MS);
+ }
+ },
+ [dismiss],
+ );
const value = useMemo(() => ({ showError, showSuccess }), [showError, showSuccess]);
@@ -80,7 +90,7 @@ export function ToasterProvider({ children }: { children: ReactNode }) {
<Toast
key={toast.id}
title={toast.title}
- description={toast.description}
+ description={toast.description ?? ''}
variant={toast.variant}
open
onOpenChange={open => {