Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

ci: run lint after typecheck so PRs fail faster (#237)

Bhavesh Patela992d95c0adc
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 88554ec96..510438e15 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -101,8 +101,14 @@ jobs:
# Always-on: format + lint cover the whole tree (incl. roots outside packages/*);
# typecheck/build stay always-on. Per-package jobs only run tests.
+
+ # Order matters for fail-fast and lint correctness:
+ # - format first (cheapest signal)
+ # - typecheck next (types + sdk/ui pretypecheck so .d.ts exist)
+ # - lint after typecheck (type-aware eslint resolves workspace packages via dist)
+ # - build last (full emit; not required for lint, still always-on as a ship gate)
typecheck-and-build:
- name: Format, Lint, Typecheck and Build
+ name: Format, Typecheck, Lint and Build
runs-on: ubuntu-latest
timeout-minutes: 20
@@ -128,13 +134,13 @@ jobs:
- name: Typecheck
run: pnpm typecheck
- - name: Build
- run: pnpm build
-
- # After typecheck/build so trueforge-ui and sdk .d.ts exist for type-aware eslint.
+ # After typecheck so trueforge-ui and sdk .d.ts exist for type-aware eslint.
- name: Lint
run: pnpm lint:ci
+ - name: Build
+ run: pnpm build
+
# Path-gated tests only — format/lint are covered by the global job above.
package-checks:
name: Package (${{ matrix.package }})