Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

Fix types on tests

Chirag Jainab9c588dd58e
diff --git a/packages/server/scripts/migrate-legacy-sqlite-path.mjs b/packages/server/scripts/migrate-legacy-sqlite-path.mjs
index 995d2da13..5b12a84d9 100644
--- a/packages/server/scripts/migrate-legacy-sqlite-path.mjs
+++ b/packages/server/scripts/migrate-legacy-sqlite-path.mjs
@@ -53,9 +53,6 @@ for (const name of legacyNames) {
try {
unlinkSync(source);
} catch (error) {
- console.warn(
- `Could not remove legacy ${source}:`,
- error instanceof Error ? error.message : error,
- );
+ console.warn(`Could not remove legacy ${source}:`, error instanceof Error ? error.message : error);
}
}
diff --git a/packages/server/tests/unit/apis/modelProviders.test.ts b/packages/server/tests/unit/apis/modelProviders.test.ts
index 392b4d6cc..6fe93aba8 100644
--- a/packages/server/tests/unit/apis/modelProviders.test.ts
+++ b/packages/server/tests/unit/apis/modelProviders.test.ts
@@ -187,14 +187,14 @@ describe('custom providers may omit auth', () => {
},
])('PUT stores and lists custom provider with $label', async ({ auth, name }) => {
const { settingsRouter } = await createRouters();
- const body = {
+ const base = {
type: 'custom' as const,
name,
base_url: 'http://localhost:11434/v1',
models: [model],
- ...(auth === undefined ? {} : { auth }),
};
- const expectedWire = auth === undefined ? body : withRedactedApiKey(body);
+ const body = auth === undefined ? base : { ...base, auth };
+ const expectedWire = auth === undefined ? body : withRedactedApiKey({ ...base, auth });
const put = await settingsRouter.request('/model-providers', putInit(body));
expect(put.status).toBe(200);
@@ -340,7 +340,7 @@ describe('model-provider secret redaction and strict PUT', () => {
expect(updateBody.data.models).toHaveLength(2);
const stored = await modelProviderStore.getProvider({ tenant_id: TENANT_ID, name: 'anthropic' });
- expect(stored?.manifest.auth.api_key).toBe('sk-ant-secret');
+ expect(stored?.manifest.auth?.api_key).toBe('sk-ant-secret');
});
it('PUT with a real api_key rotates the stored secret', async () => {
@@ -356,7 +356,7 @@ describe('model-provider secret redaction and strict PUT', () => {
});
const stored = await modelProviderStore.getProvider({ tenant_id: TENANT_ID, name: 'anthropic' });
- expect(stored?.manifest.auth.api_key).toBe(rotatedKey);
+ expect(stored?.manifest.auth?.api_key).toBe(rotatedKey);
});
});
diff --git a/packages/server/tests/unit/apis/sandboxProviders.test.ts b/packages/server/tests/unit/apis/sandboxProviders.test.ts
index 092267c72..c9ed628f9 100644
--- a/packages/server/tests/unit/apis/sandboxProviders.test.ts
+++ b/packages/server/tests/unit/apis/sandboxProviders.test.ts
@@ -53,7 +53,8 @@ async function createRouters(): Promise<{
describe('sandboxProviders router', () => {
let settingsRouter: ReturnType<typeof createSandboxProvidersRouter>;
let catalogRouter: ReturnType<typeof createCatalogRouter>;
- let sandboxProviderStore: ISandboxProviderStore;
+ // Concrete store keeps TTransaction as Transaction<Database>; the interface default is `never`.
+ let sandboxProviderStore: SqliteSandboxProviderStore;
beforeAll(async () => {
const db = createSqliteDb(':memory:');
diff --git a/packages/trueforge-ui-sdk/test/atoms/SaveAgentButton.test.tsx b/packages/trueforge-ui-sdk/test/atoms/SaveAgentButton.test.tsx
index f634668cc..07bb5c60b 100644
--- a/packages/trueforge-ui-sdk/test/atoms/SaveAgentButton.test.tsx
+++ b/packages/trueforge-ui-sdk/test/atoms/SaveAgentButton.test.tsx
@@ -6,6 +6,7 @@ import { beforeAll, describe, expect, it, vi } from 'vitest';
import { SaveAgentButton } from '@/atoms/SaveAgentButton.js';
import { ServerProvider } from '@/server/ServerContext.js';
import { ShellModeProvider, useShellMode } from '@/server/ShellModeContext.js';
+import type { SaveAgentResult } from '@/server/types.js';
import { SlotsProvider } from '@/theme/SlotsProvider.js';
import { RuntimeHarness } from '../containers/RuntimeHarness.js';
import { createMockAgentUIServer } from '../server/mockServer.js';
@@ -41,7 +42,9 @@ beforeAll(() => {
const startedMessages = [{ role: 'user' as const, content: 'hello', id: 'm1' }];
-function mockServer(saveAgent = vi.fn(async () => ({ ok: true }))) {
+type SaveAgentMock = ReturnType<typeof vi.fn<(...args: never[]) => Promise<SaveAgentResult>>>;
+
+function mockServer(saveAgent: SaveAgentMock = vi.fn(async () => ({ agentId: 'agt_1' }))) {
return createMockAgentUIServer({ saveAgent });
}
@@ -62,7 +65,7 @@ function renderSaveAgent({
children: ReactNode;
messages?: typeof startedMessages | [];
agentConfig?: Parameters<typeof ShellModeProvider>[0]['agentConfig'];
- saveAgent?: ReturnType<typeof vi.fn>;
+ saveAgent?: SaveAgentMock;
}) {
return render(
<SlotsProvider>
@@ -108,7 +111,7 @@ describe('SaveAgentButton', () => {
});
it('opens a modal with name + system instructions and saves them on agentSpec', async () => {
- const saveAgent = vi.fn(async () => ({ ok: true }));
+ const saveAgent = vi.fn(async () => ({ agentId: 'agt_1' }));
renderSaveAgent({
saveAgent,
@@ -149,7 +152,7 @@ describe('SaveAgentButton', () => {
});
it('binds the same draft chat as editable agent without remounting', async () => {
- const saveAgent = vi.fn(async () => ({ ok: true }));
+ const saveAgent = vi.fn(async () => ({ agentId: 'agt_1' }));
let shellSnap: ReturnType<typeof useShellMode> | undefined;
function Probe() {
diff --git a/packages/trueforge-ui-sdk/test/atoms/draft/DraftCatalogProvider.test.tsx b/packages/trueforge-ui-sdk/test/atoms/draft/DraftCatalogProvider.test.tsx
index fb5c0149a..f5012ddb9 100644
--- a/packages/trueforge-ui-sdk/test/atoms/draft/DraftCatalogProvider.test.tsx
+++ b/packages/trueforge-ui-sdk/test/atoms/draft/DraftCatalogProvider.test.tsx
@@ -167,7 +167,14 @@ describe('DraftCatalogProvider', () => {
});
it('refreshes connectors without reloading models or skills', async () => {
- const getModels = vi.fn(async () => [{ name: 'openai/gpt-4.1', provider: 'OpenAI' }]);
+ const getModels = vi.fn(async (): Promise<ModelSelection[]> => [
+ {
+ id: 'gpt-4.1',
+ name: 'openai/gpt-4.1',
+ provider: { name: 'OpenAI' },
+ properties: {},
+ },
+ ]);
const getSkills = vi.fn(async () => [{ id: 'skill-1', name: 'Release notes' }]);
const getMcp = vi
.fn<() => Promise<ConnectorState[]>>()