Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

feat: allow session rename (#790)

harshil-2096acad1a187873
diff --git a/.changeset/session-rename-ui.md b/.changeset/session-rename-ui.md
new file mode 100644
index 000000000..921ac5967
--- /dev/null
+++ b/.changeset/session-rename-ui.md
@@ -0,0 +1,5 @@
+---
+"@truefoundry/trueforge-ui": patch
+---
+
+Add chat-history rename for servers that implement `renameSession`, including TrueForge harness title updates.
diff --git a/docs/ui-sdk/setup-custom-servers/server-contract.mdx b/docs/ui-sdk/setup-custom-servers/server-contract.mdx
index 252943266..621a90eb3 100644
--- a/docs/ui-sdk/setup-custom-servers/server-contract.mdx
+++ b/docs/ui-sdk/setup-custom-servers/server-contract.mdx
@@ -65,6 +65,7 @@ interface AgentChatServer {
cancelSession(req: { sessionId: string }): Promise<void>;
deleteSession?(req: { sessionId: string }): Promise<void>;
+ renameSession?(req: { sessionId: string; title: string }): Promise<void>;
listTurns(req: {
sessionId: string;
@@ -105,7 +106,7 @@ interface AgentChatServer {
}
```
-Four methods are optional. `deleteSession` gates the delete control in the session list. `listTurnEvents` hydrates the events of a single in-flight turn when your backend can serve them per turn. `subscribeToTurn` lets a reconnecting client resume a stream from `afterSequenceNumber` rather than replaying it — pass the same `abortSignal` you use on `createTurn` to tear it down. `downloadSandboxFile` enables artifact downloads.
+`deleteSession` and `renameSession` are optional. Presence gates Delete and Rename in the session list; `renameSession` persists `{ sessionId, title }`. TrueForge implements both. TrueFoundry Gateway does not persist titles and should omit `renameSession`. `listTurnEvents` hydrates the events of a single in-flight turn when your backend can serve them per turn. `subscribeToTurn` lets a reconnecting client resume a stream from `afterSequenceNumber` rather than replaying it — pass the same `abortSignal` you use on `createTurn` to tear it down. `downloadSandboxFile` enables artifact downloads.
<Note>
`downloadSandboxFile` receives both `turnId` and `sandboxId` because backends address sandboxes differently. If your download route is scoped to a turn, resolve the sandbox from `turnId` and ignore `sandboxId`; if you address sandboxes directly, use `sandboxId`.
@@ -127,9 +128,9 @@ interface Session {
}
```
-`id`, `isMutable`, `createdAt`, and `updatedAt` are required; timestamps are ISO strings. Set `isMutable: true` while the agent spec may still be edited — that is what permits `updateSession`.
+`id`, `isMutable`, `createdAt`, and `updatedAt` are required; timestamps are ISO strings. Set `isMutable: true` while the agent spec may still be edited. `renameSession` must work for named and inline sessions.
-`CreateSessionRequest` is `{ agentName?, agentSpec?, title? }`; `UpdateSessionRequest` is the same plus a required `sessionId`.
+`CreateSessionRequest` is `{ agentName?, agentSpec?, title? }`; `UpdateSessionRequest` is `{ sessionId, agentSpec?, title? }`.
## Pagination
diff --git a/packages/trueforge-ui/src/atoms/RenameSessionModal.tsx b/packages/trueforge-ui/src/atoms/RenameSessionModal.tsx
new file mode 100644
index 000000000..70442fa90
--- /dev/null
+++ b/packages/trueforge-ui/src/atoms/RenameSessionModal.tsx
@@ -0,0 +1,92 @@
+'use client';
+
+import { useEffect, useRef, useState } from 'react';
+
+import { auiInputClass } from './lib/inputClasses.js';
+import { MAX_SESSION_TITLE_LENGTH } from './lib/threadListMeta.js';
+import { Button } from './primitives/Button.js';
+import { CenteredModal } from './primitives/CenteredModal.js';
+
+export type RenameSessionModalProps = {
+ open: boolean;
+ initialTitle: string;
+ saving?: boolean;
+ onOpenChange: (open: boolean) => void;
+ onSave: (title: string) => void;
+};
+
+/** Compact rename dialog: title field + Cancel / Save. */
+export function RenameSessionModal({
+ open,
+ initialTitle,
+ saving = false,
+ onOpenChange,
+ onSave,
+}: RenameSessionModalProps) {
+ const [value, setValue] = useState(initialTitle);
+ const inputRef = useRef<HTMLInputElement>(null);
+
+ useEffect(() => {
+ if (open) setValue(initialTitle);
+ }, [open, initialTitle]);
+
+ useEffect(() => {
+ if (!open) return;
+ const input = inputRef.current;
+ if (input == null) return;
+ input.focus();
+ input.select();
+ }, [open]);
+
+ const trimmed = value.trim();
+ const isValid = trimmed.length > 0 && trimmed.length <= MAX_SESSION_TITLE_LENGTH;
+ const canSave = isValid && !saving;
+
+ const handleSave = () => {
+ if (!canSave) return;
+ onSave(trimmed);
+ };
+
+ const handleOpenChange = (next: boolean) => {
+ if (saving) return;
+ onOpenChange(next);
+ };
+
+ return (
+ <CenteredModal
+ open={open}
+ onOpenChange={handleOpenChange}
+ title="Rename session"
+ contentSized
+ aria-label="Rename session"
+ footer={
+ <div className="flex items-center justify-end gap-2">
+ <Button.Secondary type="button" disabled={saving} onClick={() => handleOpenChange(false)}>
+ Cancel
+ </Button.Secondary>
+ <Button.Primary type="button" disabled={!canSave} onClick={handleSave}>
+ Save
+ </Button.Primary>
+ </div>
+ }
+ >
+ <div className="px-5 py-4">
+ <input
+ ref={inputRef}
+ aria-label="Session title"
+ value={value}
+ readOnly={saving}
+ maxLength={MAX_SESSION_TITLE_LENGTH}
+ className={auiInputClass('h-9')}
+ onChange={event => setValue(event.target.value)}
+ onKeyDown={event => {
+ if (event.key === 'Enter') {
+ event.preventDefault();
+ handleSave();
+ }
+ }}
+ />
+ </div>
+ </CenteredModal>
+ );
+}
diff --git a/packages/trueforge-ui/src/atoms/ThreadListRow.tsx b/packages/trueforge-ui/src/atoms/ThreadListRow.tsx
index 1af8c1c61..3adb78638 100644
--- a/packages/trueforge-ui/src/atoms/ThreadListRow.tsx
+++ b/packages/trueforge-ui/src/atoms/ThreadListRow.tsx
@@ -15,11 +15,20 @@ export type ThreadListRowProps = {
agentName?: string;
/** Shown as compact relative time on the right. */
lastMessageAt?: Date;
- /** Overflow actions (e.g. delete menu) — rendered as a sibling of the title button. */
+ /** Overflow actions (e.g. rename / delete menu) — rendered as a sibling of the title button. */
actions?: ReactNode;
className?: string;
};
+function ThreadListAgentName({ agentName }: { agentName: string }) {
+ return (
+ <span className="mt-0.5 flex min-w-0 items-center gap-1 text-[0.75rem] text-text-secondary">
+ <Icon name="bot" className="shrink-0" />
+ <span className="truncate">{agentName}</span>
+ </span>
+ );
+}
+
export function ThreadListRow({
title,
active,
@@ -59,12 +68,7 @@ export function ThreadListRow({
>
<span className="min-w-0 flex-1">
<span className="block truncate text-sm font-normal text-text-primary">{title}</span>
- {agentName != null ? (
- <span className="mt-0.5 flex min-w-0 items-center gap-1 text-[0.75rem] text-text-secondary">
- <Icon name="bot" className="shrink-0" />
- <span className="truncate">{agentName}</span>
- </span>
- ) : null}
+ {agentName != null ? <ThreadListAgentName agentName={agentName} /> : null}
</span>
</button>
{hasTrailing ? (
diff --git a/packages/trueforge-ui/src/atoms/lib/threadListMeta.ts b/packages/trueforge-ui/src/atoms/lib/threadListMeta.ts
index 50d8329ef..b567335e1 100644
--- a/packages/trueforge-ui/src/atoms/lib/threadListMeta.ts
+++ b/packages/trueforge-ui/src/atoms/lib/threadListMeta.ts
@@ -1,3 +1,6 @@
+/** Matches TrueForge `PATCH /sessions/{id}` title max. */
+export const MAX_SESSION_TITLE_LENGTH = 50;
+
/** Compact relative age for sidebar session rows (e.g. 30m, 22h, 1d). */
export function formatRelativeShort(date: Date, now: Date = new Date()): string {
const diffMs = Math.max(0, now.getTime() - date.getTime());
diff --git a/packages/trueforge-ui/src/containers/ThreadListContainer.tsx b/packages/trueforge-ui/src/containers/ThreadListContainer.tsx
index a96b7da03..b5f12634b 100644
--- a/packages/trueforge-ui/src/containers/ThreadListContainer.tsx
+++ b/packages/trueforge-ui/src/containers/ThreadListContainer.tsx
@@ -22,18 +22,22 @@ import {
} from '../atoms/lib/threadListMeta.js';
import { useIsMobile } from '../atoms/lib/useIsMobile.js';
import { BottomSheet } from '../atoms/primitives/BottomSheet.js';
+import { RenameSessionModal } from '../atoms/RenameSessionModal.js';
import { useResourcePermissions } from '../hooks/useResourcePermissions.js';
import { Icon } from '../icons/Icon.js';
import { useOptionalServer } from '../server/ServerContext.js';
import { useOptionalShellMode } from '../server/ShellModeContext.js';
import { useSlot } from '../theme/SlotsProvider.js';
+import { useToasterOptional } from './ToasterContainer.js';
/**
* Simplified relative to the reference: renders threads in a single flat list
* rather than grouping them by Today/Yesterday/Earlier.
*
* Delete uses assistant-ui ThreadListItemPrimitive.Delete / ThreadListItemMorePrimitive
- * (adapter.delete → server.deleteSession). Mobile/compact keeps a BottomSheet chrome.
+ * (adapter.delete → server.deleteSession). Rename opens RenameSessionModal via
+ * aui.threadListItem().rename (adapter.rename → server.renameSession) when
+ * `renameSession` is implemented. Mobile/compact keeps a BottomSheet chrome.
*/
export type ThreadListContainerProps = {
/** Called after New chat or selecting a row — used by stack/drawer chrome. */
@@ -42,10 +46,25 @@ export type ThreadListContainerProps = {
variant?: 'default' | 'recent-history';
};
+const actionItemClass =
+ 'flex w-full cursor-pointer select-none items-center gap-2 rounded-md px-2 py-1.5 text-sm font-medium outline-none transition-colors hover:bg-ghost-button-hover focus:bg-ghost-button-hover data-[highlighted]:bg-ghost-button-hover';
+
const deleteItemClass =
'flex w-full cursor-pointer select-none items-center gap-2 rounded-md px-2 py-1.5 text-sm font-medium text-failure-bg outline-none transition-colors hover:bg-failure-bg/12 hover:text-failure-bg focus:bg-failure-bg/12 focus:text-failure-bg data-[highlighted]:bg-failure-bg/12 data-[highlighted]:text-failure-bg';
-function ThreadListItemDeleteMenu({ disabled }: { disabled: boolean }) {
+function ThreadListItemActionsMenu({
+ canRename,
+ renameDisabled,
+ canDelete,
+ deleteDisabled,
+ onRename,
+}: {
+ canRename: boolean;
+ renameDisabled: boolean;
+ canDelete: boolean;
+ deleteDisabled: boolean;
+ onRename: () => void;
+}) {
const PermissionGuard = useSlot('PermissionGuard');
const compact = useCompactLayout();
const isMobile = useIsMobile();
@@ -63,6 +82,38 @@ function ThreadListItemDeleteMenu({ disabled }: { disabled: boolean }) {
className: 'size-7 shrink-0 text-text-secondary hover:bg-transparent hover:text-text-primary',
});
+ const renameButton = canRename ? (
+ <PermissionGuard allowed={!renameDisabled}>
+ <button
+ type="button"
+ className={actionItemClass}
+ disabled={renameDisabled}
+ onClick={() => {
+ if (renameDisabled) return;
+ setSheetOpen(false);
+ onRename();
+ }}
+ >
+ <Icon name="pencil" className="size-3.5" />
+ Rename
+ </button>
+ </PermissionGuard>
+ ) : null;
+
+ const deleteButton = canDelete ? (
+ <PermissionGuard allowed={!deleteDisabled}>
+ <ThreadListItemPrimitive.Delete
+ className={deleteItemClass}
+ onClick={() => {
+ if (!deleteDisabled) setSheetOpen(false);
+ }}
+ >
+ <Icon name="trash" className="size-3.5" />
+ Delete
+ </ThreadListItemPrimitive.Delete>
+ </PermissionGuard>
+ ) : null;
+
if (useSheet) {
return (
<>
@@ -80,17 +131,8 @@ function ThreadListItemDeleteMenu({ disabled }: { disabled: boolean }) {
{sheetOpen ? (
<BottomSheet open onOpenChange={setSheetOpen} aria-label="Session actions">
<div className="flex flex-col gap-1 p-2 *:w-full" role="menu">
- <PermissionGuard allowed={!disabled}>
- <ThreadListItemPrimitive.Delete
- className={deleteItemClass}
- onClick={() => {
- if (!disabled) setSheetOpen(false);
- }}
- >
- <Icon name="trash" className="size-3.5" />
- Delete
- </ThreadListItemPrimitive.Delete>
- </PermissionGuard>
+ {renameButton}
+ {deleteButton}
</div>
</BottomSheet>
) : null}
@@ -112,14 +154,10 @@ function ThreadListItemDeleteMenu({ disabled }: { disabled: boolean }) {
portalProps={{ container: portalContainer }}
align="end"
sideOffset={4}
- className="aui-popup-enter font-sans-flex z-50 min-w-[8rem] rounded-md border border-border bg-card-bg p-1 text-text-primary shadow-md *:w-full"
+ className="aui-popup-enter font-sans-flex z-50 min-w-32 rounded-md border border-border bg-card-bg p-1 text-text-primary shadow-md *:w-full"
>
- <PermissionGuard allowed={!disabled}>
- <ThreadListItemPrimitive.Delete className={deleteItemClass}>
- <Icon name="trash" className="size-3.5" />
- Delete
- </ThreadListItemPrimitive.Delete>
- </PermissionGuard>
+ {renameButton}
+ {deleteButton}
</ThreadListItemMorePrimitive.Content>
</ThreadListItemMorePrimitive.Root>
);
@@ -127,15 +165,20 @@ function ThreadListItemDeleteMenu({ disabled }: { disabled: boolean }) {
function ThreadListItemRow({
onThreadOpen,
+ canRenameSession,
canDeleteSession,
+ canManageResource,
canDeleteResource,
}: {
onThreadOpen?: () => void;
+ canRenameSession: boolean;
canDeleteSession: boolean;
+ canManageResource: (sessionId: string) => boolean;
canDeleteResource: (sessionId: string) => boolean;
}) {
const aui = useAui();
const shell = useOptionalShellMode();
+ const toaster = useToasterOptional();
const ThreadListRow = useSlot('ThreadListRow');
const id = useAuiState(s => s.threadListItem.id);
const remoteId = useAuiState(s => s.threadListItem.remoteId);
@@ -144,14 +187,37 @@ function ThreadListItemRow({
const custom = useAuiState(s => s.threadListItem.custom);
const mainThreadId = useAuiState(s => s.threads.mainThreadId);
const agentName = readThreadAgentName(custom);
+ const showRename = canRenameSession && remoteId != null;
const showDelete = canDeleteSession && remoteId != null;
+ const showActions = showRename || showDelete;
+ const renameDisabled = remoteId != null && !canManageResource(remoteId);
const deleteDisabled = remoteId != null && !canDeleteResource(remoteId);
const sidebarNavOpen = shell?.libraryOpen === true || shell?.sessionsOpen === true || shell?.schedulesOpen === true;
+ const [renameOpen, setRenameOpen] = useState(false);
+ const [renameSaving, setRenameSaving] = useState(false);
+
+ const displayTitle = title ?? 'New Chat';
+
+ const persistRename = async (trimmed: string) => {
+ if (trimmed === (title ?? '').trim()) {
+ setRenameOpen(false);
+ return;
+ }
+ setRenameSaving(true);
+ try {
+ await aui.threadListItem().rename(trimmed);
+ setRenameOpen(false);
+ } catch (caught) {
+ toaster?.showError(caught);
+ } finally {
+ setRenameSaving(false);
+ }
+ };
return (
<ThreadListItemPrimitive.Root className="min-w-0">
<ThreadListRow
- title={title ?? 'New Chat'}
+ title={displayTitle}
active={id === mainThreadId && !sidebarNavOpen}
agentName={agentName}
lastMessageAt={lastMessageAt}
@@ -195,7 +261,26 @@ function ThreadListItemRow({
}
void Promise.resolve(aui.threads().switchToThread(id)).catch(() => undefined);
}}
- actions={showDelete ? <ThreadListItemDeleteMenu disabled={deleteDisabled} /> : undefined}
+ actions={
+ showActions ? (
+ <ThreadListItemActionsMenu
+ canRename={showRename}
+ renameDisabled={renameDisabled}
+ canDelete={showDelete}
+ deleteDisabled={deleteDisabled}
+ onRename={() => setRenameOpen(true)}
+ />
+ ) : undefined
+ }
+ />
+ <RenameSessionModal
+ open={renameOpen}
+ initialTitle={title ?? ''}
+ saving={renameSaving}
+ onOpenChange={setRenameOpen}
+ onSave={nextTitle => {
+ void persistRename(nextTitle);
+ }}
/>
</ThreadListItemPrimitive.Root>
);
@@ -227,12 +312,16 @@ function useThreadListIndicesByRecency(variant: NonNullable<ThreadListContainerP
function ThreadListItemsByRecency({
indices,
onThreadOpen,
+ canRenameSession,
canDeleteSession,
+ canManageResource,
canDeleteResource,
}: {
indices: number[];
onThreadOpen?: () => void;
+ canRenameSession: boolean;
canDeleteSession: boolean;
+ canManageResource: (sessionId: string) => boolean;
canDeleteResource: (sessionId: string) => boolean;
}) {
// Newest-first: remount/switchToThread can append the active session to threadIds.
@@ -246,7 +335,9 @@ function ThreadListItemsByRecency({
<ThreadListItemByIndexProvider key={key} index={index} archived={false}>
<ThreadListItemRow
onThreadOpen={onThreadOpen}
+ canRenameSession={canRenameSession}
canDeleteSession={canDeleteSession}
+ canManageResource={canManageResource}
canDeleteResource={canDeleteResource}
/>
</ThreadListItemByIndexProvider>
@@ -328,6 +419,7 @@ export function ThreadListContainer({ onThreadOpen, variant = 'default' }: Threa
const showNewChat = shell?.isNewChatEnabled !== false;
const isIdle = shell?.mode.status === 'idle';
const isRecentHistory = variant === 'recent-history';
+ const canRenameSession = typeof server?.renameSession === 'function';
const canDeleteSession = typeof server?.deleteSession === 'function';
const remoteSessionIds = useMemo(
() => threadItems.flatMap(item => (item.remoteId == null ? [] : [item.remoteId])),
@@ -401,7 +493,9 @@ export function ThreadListContainer({ onThreadOpen, variant = 'default' }: Threa
<ThreadListItemsByRecency
indices={indices}
onThreadOpen={onThreadOpen}
+ canRenameSession={canRenameSession}
canDeleteSession={canDeleteSession}
+ canManageResource={sessionId => allows(sessionId, 'MANAGE')}
canDeleteResource={sessionId => allows(sessionId, 'DELETE')}
/>
</ThreadListPrimitive.Root>
diff --git a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/chatServer.ts b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/chatServer.ts
index f2839e3e6..efae83936 100644
--- a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/chatServer.ts
+++ b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/chatServer.ts
@@ -218,10 +218,15 @@ export function createHarnessChatServer(
await client.sessions.delete(sessionId);
},
- async updateSession({ sessionId, agentSpec }) {
+ async renameSession({ sessionId, title }) {
+ await client.sessions.update(sessionId, { title });
+ },
+
+ async updateSession({ sessionId, agentSpec, title }) {
// Named (reference) sessions reject agent updates server-side.
const response = await client.sessions.update(sessionId, {
...(agentSpec === undefined ? {} : { agent: { spec: toHarnessAgentSpec(agentSpec) } }),
+ ...(title === undefined ? {} : { title }),
});
return toUiSession(response.data);
},
diff --git a/packages/trueforge-ui/src/server/sessionListCache.ts b/packages/trueforge-ui/src/server/sessionListCache.ts
index d0b0df790..7053df1aa 100644
--- a/packages/trueforge-ui/src/server/sessionListCache.ts
+++ b/packages/trueforge-ui/src/server/sessionListCache.ts
@@ -29,7 +29,7 @@ export function withSessionListCache({
server: AgentUIServer;
cache: SessionListCache;
}): AgentUIServer {
- const { deleteSession } = server;
+ const { deleteSession, renameSession } = server;
return {
...server,
listSessions(request) {
@@ -63,5 +63,13 @@ export function withSessionListCache({
},
}
: {}),
+ ...(renameSession != null
+ ? {
+ renameSession: async (request: { sessionId: string; title: string }) => {
+ await renameSession.call(server, request);
+ cache.clear();
+ },
+ }
+ : {}),
};
}
diff --git a/packages/trueforge-ui/test/atoms/RenameSessionModal.test.tsx b/packages/trueforge-ui/test/atoms/RenameSessionModal.test.tsx
new file mode 100644
index 000000000..72cc3f127
--- /dev/null
+++ b/packages/trueforge-ui/test/atoms/RenameSessionModal.test.tsx
@@ -0,0 +1,62 @@
+// @vitest-environment jsdom
+import { fireEvent, render, screen } from '@testing-library/react';
+import { beforeAll, describe, expect, it, vi } from 'vitest';
+
+import { RenameSessionModal } from '@/atoms/RenameSessionModal.js';
+import { SlotsProvider } from '@/theme/SlotsProvider.js';
+
+beforeAll(() => {
+ HTMLDialogElement.prototype.showModal = function showModal() {
+ this.setAttribute('open', '');
+ };
+ HTMLDialogElement.prototype.close = function close() {
+ this.removeAttribute('open');
+ this.dispatchEvent(new Event('close'));
+ };
+});
+
+describe('RenameSessionModal', () => {
+ it('focuses and selects the title when opened', () => {
+ render(
+ <SlotsProvider>
+ <RenameSessionModal open initialTitle="Laptop sleep issue" onOpenChange={() => {}} onSave={() => {}} />
+ </SlotsProvider>,
+ );
+
+ const input = screen.getByRole('textbox', { name: 'Session title' });
+ expect(input).toHaveFocus();
+ expect(input).toHaveValue('Laptop sleep issue');
+ expect(screen.getByRole('heading', { name: 'Rename session' })).toBeInTheDocument();
+ });
+
+ it('disables Save for blank titles and calls onSave with trimmed text', () => {
+ const onSave = vi.fn();
+ render(
+ <SlotsProvider>
+ <RenameSessionModal open initialTitle="Old" onOpenChange={() => {}} onSave={onSave} />
+ </SlotsProvider>,
+ );
+
+ const input = screen.getByRole('textbox', { name: 'Session title' });
+ fireEvent.change(input, { target: { value: ' ' } });
+ expect(screen.getByRole('button', { name: 'Save' })).toBeDisabled();
+
+ fireEvent.change(input, { target: { value: ' New title ' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
+ expect(onSave).toHaveBeenCalledWith('New title');
+ });
+
+ it('Cancel closes without saving', () => {
+ const onOpenChange = vi.fn();
+ const onSave = vi.fn();
+ render(
+ <SlotsProvider>
+ <RenameSessionModal open initialTitle="Old" onOpenChange={onOpenChange} onSave={onSave} />
+ </SlotsProvider>,
+ );
+
+ fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
+ expect(onOpenChange).toHaveBeenCalledWith(false);
+ expect(onSave).not.toHaveBeenCalled();
+ });
+});
diff --git a/packages/trueforge-ui/test/atoms/ThreadListRow.test.tsx b/packages/trueforge-ui/test/atoms/ThreadListRow.test.tsx
index 6d6433c63..284ce83b1 100644
--- a/packages/trueforge-ui/test/atoms/ThreadListRow.test.tsx
+++ b/packages/trueforge-ui/test/atoms/ThreadListRow.test.tsx
@@ -7,6 +7,16 @@ import { DropdownMenuItem } from '@/atoms/primitives/DropdownMenu.js';
import { SlotsProvider } from '@/theme/SlotsProvider.js';
describe('ThreadListRow', () => {
+ it('renders the title button when not renaming', () => {
+ render(
+ <SlotsProvider>
+ <ThreadListRow title="Session A" active onSelect={() => {}} />
+ </SlotsProvider>,
+ );
+ expect(screen.getByRole('button', { name: 'Session A' })).toBeInTheDocument();
+ expect(screen.queryByRole('textbox', { name: 'Session title' })).not.toBeInTheDocument();
+ });
+
it('hides actions when omitted', () => {
render(
<SlotsProvider>
diff --git a/packages/trueforge-ui/test/containers/ThreadListContainer.test.tsx b/packages/trueforge-ui/test/containers/ThreadListContainer.test.tsx
index 7cb6a7e31..33b308c3d 100644
--- a/packages/trueforge-ui/test/containers/ThreadListContainer.test.tsx
+++ b/packages/trueforge-ui/test/containers/ThreadListContainer.test.tsx
@@ -12,8 +12,10 @@ import { beforeAll, describe, expect, it, vi } from 'vitest';
import type { ThreadListRowProps } from '@/atoms/ThreadListRow.js';
import { CompactLayoutProvider } from '@/atoms/lib/CompactLayoutContext.js';
import { ThreadListContainer, type ThreadListContainerProps } from '@/containers/ThreadListContainer.js';
+import { ToasterProvider } from '@/containers/ToasterContainer.js';
import { ServerProvider } from '@/server/ServerContext.js';
import { ShellModeProvider, useShellMode } from '@/server/ShellModeContext.js';
+import type { ListPermissionsResponse } from '@/server/types.js';
import { SlotsProvider } from '@/theme/SlotsProvider.js';
import { createMockAgentUIServer } from '../server/mockServer.js';
@@ -108,29 +110,45 @@ function renderThreadList({
adapter,
onThreadOpen,
canDelete = false,
+ canRename = false,
+ permissions,
variant,
}: {
adapter: ExternalStoreThreadListAdapter;
onThreadOpen?: () => void;
canDelete?: boolean;
+ canRename?: boolean;
+ permissions?: {
+ listPermissions: (req: { resourceType: string; resourceIds: string[] }) => Promise<ListPermissionsResponse>;
+ };
variant?: ThreadListContainerProps['variant'];
}) {
const list = (
<SlotsProvider overrides={{ ThreadListRow: ThreadListRowOverride }}>
- <ThreadListRuntimeHarness threadList={adapter}>
- <CompactLayoutProvider>
- <ThreadListContainer onThreadOpen={onThreadOpen} variant={variant} />
- </CompactLayoutProvider>
- </ThreadListRuntimeHarness>
+ <ToasterProvider>
+ <ThreadListRuntimeHarness threadList={adapter}>
+ <CompactLayoutProvider>
+ <ThreadListContainer onThreadOpen={onThreadOpen} variant={variant} />
+ </CompactLayoutProvider>
+ </ThreadListRuntimeHarness>
+ </ToasterProvider>
</SlotsProvider>
);
- if (!canDelete) {
+ if (!canDelete && !canRename) {
return render(list);
}
return render(
- <ServerProvider server={createMockAgentUIServer({ deleteSession: async () => {} })}>{list}</ServerProvider>,
+ <ServerProvider
+ server={createMockAgentUIServer({
+ ...(canDelete ? { deleteSession: async () => {} } : {}),
+ ...(canRename ? { renameSession: async () => {} } : {}),
+ ...(permissions === undefined ? {} : { permissions }),
+ })}
+ >
+ {list}
+ </ServerProvider>,
);
}
@@ -367,6 +385,213 @@ describe('ThreadListContainer', () => {
});
});
+ it('hides rename when the server does not opt in', () => {
+ renderThreadList({
+ adapter: {
+ threads: [
+ {
+ status: 'regular',
+ id: 'thread-1',
+ remoteId: 'session-1',
+ title: 'Remote session',
+ },
+ ],
+ },
+ canDelete: true,
+ });
+
+ fireEvent.click(screen.getByRole('button', { name: 'Session actions' }));
+ expect(screen.queryByRole('button', { name: 'Rename' })).not.toBeInTheDocument();
+ expect(screen.getByRole('button', { name: 'Delete' })).toBeInTheDocument();
+ });
+
+ it('renames a remote session from the modal after validating the title', async () => {
+ const onRename = vi.fn(async () => {});
+
+ renderThreadList({
+ adapter: {
+ threadId: 'thread-1',
+ threads: [
+ {
+ status: 'regular',
+ id: 'thread-1',
+ remoteId: 'session-1',
+ title: 'Remote session',
+ },
+ {
+ status: 'regular',
+ id: 'thread-local',
+ title: 'Local draft',
+ },
+ ],
+ onRename,
+ },
+ canRename: true,
+ });
+
+ const actionButtons = screen.getAllByRole('button', { name: 'Session actions' });
+ expect(actionButtons).toHaveLength(1);
+ fireEvent.click(actionButtons[0]!);
+ fireEvent.click(screen.getByRole('button', { name: 'Rename' }));
+
+ const dialog = screen.getByRole('dialog', { name: 'Rename session' });
+ expect(dialog).toBeInTheDocument();
+ const titleInput = screen.getByRole('textbox', { name: 'Session title' });
+ expect(titleInput).toHaveValue('Remote session');
+
+ fireEvent.change(titleInput, { target: { value: ' ' } });
+ expect(screen.getByRole('button', { name: 'Save' })).toBeDisabled();
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
+ expect(onRename).not.toHaveBeenCalled();
+
+ fireEvent.change(titleInput, { target: { value: ' Acme onboarding ' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
+
+ await waitFor(() => {
+ expect(onRename).toHaveBeenCalledWith('thread-1', 'Acme onboarding');
+ });
+ await waitFor(() => {
+ expect(screen.queryByRole('dialog', { name: 'Rename session' })).not.toBeInTheDocument();
+ });
+ });
+
+ it('cancels rename from the modal without persisting', async () => {
+ const onRename = vi.fn(async () => {});
+
+ renderThreadList({
+ adapter: {
+ threadId: 'thread-1',
+ threads: [
+ {
+ status: 'regular',
+ id: 'thread-1',
+ remoteId: 'session-1',
+ title: 'Remote session',
+ },
+ ],
+ onRename,
+ },
+ canRename: true,
+ });
+
+ fireEvent.click(screen.getByRole('button', { name: 'Session actions' }));
+ fireEvent.click(screen.getByRole('button', { name: 'Rename' }));
+ const titleInput = screen.getByRole('textbox', { name: 'Session title' });
+ fireEvent.change(titleInput, { target: { value: 'Scratch' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
+
+ await waitFor(() => {
+ expect(screen.queryByRole('dialog', { name: 'Rename session' })).not.toBeInTheDocument();
+ });
+ expect(onRename).not.toHaveBeenCalled();
+ expect(screen.getByText('Remote session')).toBeInTheDocument();
+ });
+
+ it('keeps the modal open and disables Cancel while rename is saving', async () => {
+ let resolveRename: (() => void) | undefined;
+ const onRename = vi.fn(
+ () =>
+ new Promise<void>(resolve => {
+ resolveRename = resolve;
+ }),
+ );
+
+ renderThreadList({
+ adapter: {
+ threadId: 'thread-1',
+ threads: [
+ {
+ status: 'regular',
+ id: 'thread-1',
+ remoteId: 'session-1',
+ title: 'Remote session',
+ },
+ ],
+ onRename,
+ },
+ canRename: true,
+ });
+
+ fireEvent.click(screen.getByRole('button', { name: 'Session actions' }));
+ fireEvent.click(screen.getByRole('button', { name: 'Rename' }));
+ const titleInput = screen.getByRole('textbox', { name: 'Session title' });
+ fireEvent.change(titleInput, { target: { value: 'Updated title' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
+
+ await waitFor(() => {
+ expect(titleInput).toHaveAttribute('readonly');
+ });
+ expect(screen.getByRole('button', { name: 'Cancel' })).toBeDisabled();
+ fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
+ expect(screen.getByRole('dialog', { name: 'Rename session' })).toBeInTheDocument();
+
+ resolveRename?.();
+ await waitFor(() => {
+ expect(screen.queryByRole('dialog', { name: 'Rename session' })).not.toBeInTheDocument();
+ });
+ });
+
+ it('toasts when rename fails and keeps the modal open', async () => {
+ const onRename = vi.fn(async () => {
+ throw new Error('rename failed');
+ });
+
+ renderThreadList({
+ adapter: {
+ threadId: 'thread-1',
+ threads: [
+ {
+ status: 'regular',
+ id: 'thread-1',
+ remoteId: 'session-1',
+ title: 'Remote session',
+ },
+ ],
+ onRename,
+ },
+ canRename: true,
+ });
+
+ fireEvent.click(screen.getByRole('button', { name: 'Session actions' }));
+ fireEvent.click(screen.getByRole('button', { name: 'Rename' }));
+ const titleInput = screen.getByRole('textbox', { name: 'Session title' });
+ fireEvent.change(titleInput, { target: { value: 'Updated title' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
+
+ await waitFor(() => {
+ expect(screen.getByText('rename failed')).toBeInTheDocument();
+ });
+ expect(screen.getByRole('dialog', { name: 'Rename session' })).toBeInTheDocument();
+ expect(onRename).toHaveBeenCalledOnce();
+ });
+
+ it('disables rename when the caller lacks MANAGE', async () => {
+ renderThreadList({
+ adapter: {
+ threads: [
+ {
+ status: 'regular',
+ id: 'thread-1',
+ remoteId: 'session-1',
+ title: 'Remote session',
+ },
+ ],
+ },
+ canRename: true,
+ canDelete: true,
+ permissions: {
+ listPermissions: vi.fn(async (): Promise<ListPermissionsResponse> => ({
+ data: { type: 'session', permissions: { 'session-1': ['DELETE'] } },
+ })),
+ },
+ });
+
+ await waitFor(() => expect(screen.getByRole('button', { name: 'Session actions' })).toBeInTheDocument());
+ fireEvent.click(screen.getByRole('button', { name: 'Session actions' }));
+ await waitFor(() => expect(screen.getByRole('button', { name: 'Rename' })).toBeDisabled());
+ expect(screen.getByRole('button', { name: 'Delete' })).not.toBeDisabled();
+ });
+
it('clears chat selection highlight while a sidebar top nav tab is open', () => {
function OpenSchedulesButton() {
const shell = useShellMode();
diff --git a/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/harnessServer.test.ts b/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/harnessServer.test.ts
index 81ca6582b..7c65ed767 100644
--- a/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/harnessServer.test.ts
+++ b/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/harnessServer.test.ts
@@ -42,6 +42,15 @@ const fetchMock: typeof fetch = async (input, init) => {
}
return Response.json({ data: session });
}
+ if (url.endsWith('/api/v1/sessions/ses_1') && method === 'PATCH') {
+ const body: unknown = typeof init?.body === 'string' ? JSON.parse(init.body) : undefined;
+ sessionRequests.push(body);
+ const title =
+ body !== null && typeof body === 'object' && 'title' in body && typeof body.title === 'string'
+ ? body.title
+ : session.title;
+ return Response.json({ data: { ...session, title } });
+ }
if (url.endsWith('/api/v1/sessions/ses_1') && method === 'DELETE') {
deletedSessions.push('ses_1');
return new Response(null, { status: 204 });
@@ -224,6 +233,18 @@ describe('createHarnessChatServer', () => {
assert.equal(new URL(listUrl, 'http://test.local').searchParams.get('created_by_me'), 'true');
});
+ it('PATCHes session title and returns the updated UI session', async () => {
+ sessionRequests.length = 0;
+ const server = createHarnessChatServer({ fetch: fetchMock });
+ assert.equal(typeof server.renameSession, 'function');
+ await server.renameSession?.({ sessionId: 'ses_1', title: 'Acme onboarding' });
+ assert.deepEqual(sessionRequests.at(-1), { title: 'Acme onboarding' });
+
+ const updated = await server.updateSession({ sessionId: 'ses_1', title: 'Acme onboarding' });
+ assert.deepEqual(sessionRequests.at(-1), { title: 'Acme onboarding' });
+ assert.equal(updated.title, 'Acme onboarding');
+ });
+
it('listSessions forwards an unknown agentId to the API (empty page from the server)', async () => {
let listUrl: string | undefined;
const fetchNamed: typeof fetch = async input => {
diff --git a/packages/trueforge-ui/test/server/sessionListCache.test.ts b/packages/trueforge-ui/test/server/sessionListCache.test.ts
index 5636d481e..a4981c207 100644
--- a/packages/trueforge-ui/test/server/sessionListCache.test.ts
+++ b/packages/trueforge-ui/test/server/sessionListCache.test.ts
@@ -39,13 +39,14 @@ describe('withSessionListCache', () => {
expect(listSessions).toHaveBeenCalledTimes(3);
});
- it('clears the cache after createSession, updateSession, and deleteSession', async () => {
+ it('clears the cache after createSession, updateSession, renameSession, and deleteSession', async () => {
const listSessions = vi.fn().mockResolvedValue(emptyPage);
const session = { id: 's1' };
const server = cachedServer({
listSessions,
createSession: vi.fn().mockResolvedValue(session),
updateSession: vi.fn().mockResolvedValue(session),
+ renameSession: vi.fn().mockResolvedValue(undefined),
deleteSession: vi.fn().mockResolvedValue(undefined),
});
@@ -54,10 +55,12 @@ describe('withSessionListCache', () => {
await server.listSessions({ limit: 20 });
await server.updateSession({ sessionId: 's1' });
await server.listSessions({ limit: 20 });
+ await server.renameSession?.({ sessionId: 's1', title: 'Renamed' });
+ await server.listSessions({ limit: 20 });
await server.deleteSession?.({ sessionId: 's1' });
await server.listSessions({ limit: 20 });
- expect(listSessions).toHaveBeenCalledTimes(4);
+ expect(listSessions).toHaveBeenCalledTimes(5);
});
it('retries after a failed page instead of replaying the rejection', async () => {
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index c8ad9525b..40134d3e8 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -17,7 +17,7 @@ allowBuilds:
# Silence peer mismatches between trueforge-ui peers and the versions we pin.
peerDependencyRules:
allowedVersions:
- '@truefoundry/assistant-ui-runtime': '0.1.39'
+ '@truefoundry/assistant-ui-runtime': '0.1.42'
# One Context module for assistant-ui (avoids "requires an AuiProvider").
overrides: