The open-source agent harness - the runtime layer that turns an LLM into a working agent.
fix: compare the service API key in constant time (#1086)
Am I Satoshib575b9a8a616
diff --git a/.changeset/service-key-constant-time-compare.md b/.changeset/service-key-constant-time-compare.mdnew file mode 100644index 000000000..9e3f4d23c--- /dev/null+++ b/.changeset/service-key-constant-time-compare.md@@ -0,0 +1,5 @@+---+'@truefoundry/trueforge': patch+---++Compare the service API key with `crypto.timingSafeEqual` so a rejected credential does not leak how much of the key matched.diff --git a/packages/trueforge/src/auth/middleware.ts b/packages/trueforge/src/auth/middleware.tsindex aaa1aa159..803e9a7cd 100644--- a/packages/trueforge/src/auth/middleware.ts+++ b/packages/trueforge/src/auth/middleware.ts@@ -1,3 +1,5 @@+import { timingSafeEqual } from 'node:crypto';+import type { Context, MiddlewareHandler } from 'hono';import { HTTPException } from 'hono/http-exception';import { jwtVerify } from 'jose';@@ -35,11 +37,21 @@ export function createAdminAuthMiddleware(authenticator: Authenticator): Middlew};}+/** Constant-time compare so a rejection does not leak how much of the key matched. */+function matchesServiceKey({ provided, expected }: { provided: string; expected: string }): boolean {+ const providedBytes = Buffer.from(provided, 'utf8');+ const expectedBytes = Buffer.from(expected, 'utf8');+ if (providedBytes.length !== expectedBytes.length) {+ return false;+ }+ return timingSafeEqual(providedBytes, expectedBytes);+}+/** Bearer API-key gate for service-only routes. */export function createApiKeyAuthMiddleware(apiKey: string): MiddlewareHandler {return async (c, next) => {const token = readBearerToken(c);- if (token === undefined || token !== apiKey) {+ if (token === undefined || !matchesServiceKey({ provided: token, expected: apiKey })) {throw new HTTPException(401, { message: 'Invalid service credential' });}return next();diff --git a/packages/trueforge/tests/unit/auth/middleware.test.ts b/packages/trueforge/tests/unit/auth/middleware.test.tsindex 9dd1764eb..4aa0767bc 100644--- a/packages/trueforge/tests/unit/auth/middleware.test.ts+++ b/packages/trueforge/tests/unit/auth/middleware.test.ts@@ -422,6 +422,7 @@ describe('createApiKeyAuthMiddleware', () => {it.each([['missing header', undefined],['wrong key', 'Bearer wrong-key'],+ ['wrong key of the same length', 'Bearer service-kez'],])('rejects %s', async (_name, authorization) => {const response = await createServiceApp('service-key').request('/', {method: 'POST',