Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

chore: setup partial json parsing for sandbox pretty view (#168)

sayan-truefoundrybe721ec4ef26
diff --git a/packages/trueforge-ui-sdk/package.json b/packages/trueforge-ui-sdk/package.json
index 76e692985..f0ebeb741 100644
--- a/packages/trueforge-ui-sdk/package.json
+++ b/packages/trueforge-ui-sdk/package.json
@@ -89,6 +89,7 @@
"clsx": "^2.1.1",
"lucide-react": "^0.562.0",
"monaco-editor": "^0.56.0",
+ "partial-json": "^0.1.7",
"react-markdown": "^10.1.0",
"react-syntax-highlighter": "^16.1.1",
"remark-gfm": "^4.0.1",
diff --git a/packages/trueforge-ui-sdk/src/utils/toolCallParsing.ts b/packages/trueforge-ui-sdk/src/utils/toolCallParsing.ts
index dbc84bbda..8cbf0f5ff 100644
--- a/packages/trueforge-ui-sdk/src/utils/toolCallParsing.ts
+++ b/packages/trueforge-ui-sdk/src/utils/toolCallParsing.ts
@@ -1,4 +1,5 @@
import type { ToolApprovalOption as AuiToolApprovalOption, ToolCallMessagePartProps } from '@assistant-ui/react';
+import { parse as parsePartialJson } from 'partial-json';
import type { ToolCallStatus } from '../atoms/ToolCallCard.js';
@@ -28,6 +29,27 @@ const APPROVAL_OPTION_DEFAULT_LABELS: Record<string, string> = {
const isAllowKind = (kind: string) => kind === 'allow-once' || kind === 'allow-always';
+type JsonParseResult = { success: true; value: unknown; isPartial: boolean } | { success: false };
+
+function parseJsonIncrementally(content: string): JsonParseResult {
+ try {
+ return { success: true, value: JSON.parse(content), isPartial: false };
+ } catch {
+ const trimmed = content.trim();
+ if (trimmed[0] !== '{' && trimmed[0] !== '[') return { success: false };
+
+ try {
+ return { success: true, value: parsePartialJson(content), isPartial: true };
+ } catch {
+ return { success: false };
+ }
+ }
+}
+
+function isUnknownRecord(value: unknown): value is Record<string, unknown> {
+ return value != null && typeof value === 'object' && !Array.isArray(value);
+}
+
export function parseAskUserQuestionArgs(argsText: string | undefined): {
question?: string;
options?: string[];
@@ -117,19 +139,14 @@ export function parseSandboxArgs(argsText: string | undefined): {
argsJson?: string;
} {
if (!argsText) return {};
- try {
- const parsed = JSON.parse(argsText) as {
- command?: string;
- intent?: string;
- };
- return {
- command: parsed.command,
- intent: parsed.intent,
- argsJson: JSON.stringify(parsed, null, 2),
- };
- } catch {
- return { argsJson: argsText };
- }
+ const parsed = parseJsonIncrementally(argsText);
+ if (!parsed.success || !isUnknownRecord(parsed.value)) return { argsJson: argsText };
+
+ return {
+ command: typeof parsed.value.command === 'string' ? parsed.value.command : undefined,
+ intent: typeof parsed.value.intent === 'string' ? parsed.value.intent : undefined,
+ argsJson: parsed.isPartial ? argsText : JSON.stringify(parsed.value, null, 2),
+ };
}
export function parseSandboxResult(result: string | undefined): {
@@ -138,20 +155,17 @@ export function parseSandboxResult(result: string | undefined): {
resultJson?: string;
} {
if (result === undefined) return {};
- try {
- const parsed = JSON.parse(result) as {
- response?: { exitCode?: number; result?: string };
- };
- const exitCode = parsed.response?.exitCode ?? null;
- const resultText = parsed.response?.result;
- return {
- exitCode,
- resultText,
- resultJson: JSON.stringify(parsed, null, 2),
- };
- } catch {
- return { resultText: result };
- }
+ const parsed = parseJsonIncrementally(result);
+ if (!parsed.success || !isUnknownRecord(parsed.value)) return { resultText: result };
+
+ const response = isUnknownRecord(parsed.value.response) ? parsed.value.response : undefined;
+ const exitCode = typeof response?.exitCode === 'number' ? response.exitCode : null;
+ const resultText = typeof response?.result === 'string' ? response.result : undefined;
+ return {
+ exitCode,
+ resultText,
+ resultJson: parsed.isPartial ? result : JSON.stringify(parsed.value, null, 2),
+ };
}
export function parseMcpToolArgs(argsText: string | undefined): {
@@ -186,7 +200,7 @@ export function getJsonDisplayValue(content: string | undefined): {
return { value: content, isJson: false };
}
try {
- const parsed = JSON.parse(content);
+ const parsed: unknown = JSON.parse(content);
return { value: JSON.stringify(parsed, null, 2), isJson: true };
} catch {
return { value: content, isJson: false };
diff --git a/packages/trueforge-ui-sdk/test/utils/toolCallParsing.test.ts b/packages/trueforge-ui-sdk/test/utils/toolCallParsing.test.ts
index 539ed5e7d..1653bd54b 100644
--- a/packages/trueforge-ui-sdk/test/utils/toolCallParsing.test.ts
+++ b/packages/trueforge-ui-sdk/test/utils/toolCallParsing.test.ts
@@ -47,10 +47,20 @@ describe('toolCallParsing', () => {
command: 'ls',
intent: 'list',
});
+ expect(parseSandboxArgs('{"command":"pnpm test","intent":"still stream')).toEqual({
+ command: 'pnpm test',
+ intent: 'still stream',
+ argsJson: '{"command":"pnpm test","intent":"still stream',
+ });
expect(parseSandboxResult(JSON.stringify({ response: { exitCode: 0, result: 'ok' } }))).toMatchObject({
exitCode: 0,
resultText: 'ok',
});
+ expect(parseSandboxResult('{"response":{"exitCode":0,"result":"streamed output"')).toEqual({
+ exitCode: 0,
+ resultText: 'streamed output',
+ resultJson: '{"response":{"exitCode":0,"result":"streamed output"',
+ });
expect(parseSandboxResult('plain')).toEqual({ resultText: 'plain' });
});
@@ -76,6 +86,10 @@ describe('toolCallParsing', () => {
value: '{\n "a": 1\n}',
isJson: true,
});
+ expect(getJsonDisplayValue('{"a":1,"streaming":"unfinished')).toEqual({
+ value: '{"a":1,"streaming":"unfinished',
+ isJson: false,
+ });
expect(getJsonDisplayValue('hello')).toEqual({
value: 'hello',
isJson: false,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 949d7771f..26c8cbaed 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -318,6 +318,9 @@ importers:
monaco-editor:
specifier: ^0.56.0
version: 0.56.0
+ partial-json:
+ specifier: ^0.1.7
+ version: 0.1.7
react-markdown:
specifier: ^10.1.0
@@ -5705,6 +5708,9 @@ packages:
resolution: {integrity: sha512-CiyeOxFT/JZyN5m0z9PfXw4SCBJ6Sygz1Dpl0wqjlhDEGGBP1GnsUVEL0p63hoG1fcj3fHynXi9NYO4nWOL+qQ==}
engines: {node: '>= 0.8'}
+ resolution: {integrity: sha512-Njv/59hHaokb/hRUjce3Hdv12wd60MtM9Z5Olmn+nehe0QDAsRtRbJPvJ0Z91TusF0SuZRIvnM+S4l6EIP8leA==}
+
resolution: {integrity: sha512-ak9Qy5Q7jYb2Wwcey5Fpvg2KoAc/ZIhLSLOSBmRmygPsGwkVVt0fZa0qrtMz+m6tJTAHfZQ8FnmB4MG4LWy7/w==}
engines: {node: '>=8'}
@@ -12915,6 +12921,8 @@ snapshots:
+