The open-source agent harness - the runtime layer that turns an LLM into a working agent.
Fix: strip trailing slash from agent code-snippet base_url (#679)
Govinda Vashishthac0359cab3897
diff --git a/.changeset/code-snippets-trim-base-url-slash.md b/.changeset/code-snippets-trim-base-url-slash.mdnew file mode 100644index 000000000..63a5de968--- /dev/null+++ b/.changeset/code-snippets-trim-base-url-slash.md@@ -0,0 +1,5 @@+---+"@truefoundry/trueforge-ui": patch+---++Strip a trailing slash from the `base_url` passed to agent code-snippets.diff --git a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/agentSessionsServer.ts b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/agentSessionsServer.tsindex db8a19d65..cf9c827e4 100644--- a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/agentSessionsServer.ts+++ b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/agentSessionsServer.ts@@ -56,7 +56,8 @@ export function createHarnessAgentSessionsServer(};},async getCodeSnippets({ agentId }) {- const absoluteBaseUrl = resolveTrueForgeBaseUrl(options.baseUrl ?? '/');+ // Snippet SDK `baseUrl` should not end with `/` (hosts often pass a trailing path slash).+ const absoluteBaseUrl = resolveTrueForgeBaseUrl(options.baseUrl ?? '/').replace(/\/$/, '');const { data } = await client.internal.agents.getCodeSnippets(agentId,/^https?:\/\//i.test(absoluteBaseUrl) ? { baseUrl: absoluteBaseUrl } : undefined,diff --git a/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/agentSessionsServer.test.ts b/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/agentSessionsServer.test.tsindex 10e7568a0..8a9b72f48 100644--- a/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/agentSessionsServer.test.ts+++ b/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/agentSessionsServer.test.ts@@ -48,7 +48,10 @@ describe('createHarnessAgentSessionsServer', () => {},]);assert.deepEqual(get.mock.calls[0], ['agent-1']);- assert.deepEqual(getCodeSnippets.mock.calls[0], ['agent-1', { baseUrl: resolveTrueForgeBaseUrl('/') }]);+ assert.deepEqual(getCodeSnippets.mock.calls[0], [+ 'agent-1',+ { baseUrl: resolveTrueForgeBaseUrl('/').replace(/\/$/, '') },+ ]);});it('maps listSessions and listSessionEvents onto the UI contract', async () => {