The open-source agent harness - the runtime layer that turns an LLM into a working agent.
bugfix: show session metrics data from session details response instead turn by turn calculation (#934)
harshil-2096c0cd17bffe14
diff --git a/.changeset/session-detail-strip-metrics.md b/.changeset/session-detail-strip-metrics.mdnew file mode 100644index 000000000..20255d562--- /dev/null+++ b/.changeset/session-detail-strip-metrics.md@@ -0,0 +1,6 @@+---+'@truefoundry/trueforge-assistant-ui-runtime': patch+'@truefoundry/trueforge-ui': patch+---++Use session detail API metrics for the agent session strip Turns/Duration/Cost instead of list-row hints or turn-by-turn aggregation. Include optional totalCostInUsd on TurnDoneMetrics so turn.done cost matches the wire contract.diff --git a/packages/assistant-ui-runtime/src/server/types.ts b/packages/assistant-ui-runtime/src/server/types.tsindex 83f6ed405..251ac2cc5 100644--- a/packages/assistant-ui-runtime/src/server/types.ts+++ b/packages/assistant-ui-runtime/src/server/types.ts@@ -183,6 +183,8 @@ export interface Session<TSpec extends AgentSpec = AgentSpec> {isMutable: boolean;/** When true, any subject in the tenant may read this session and its turns/events by id. */shared?: boolean;+ /** Rolled-up turns/duration/cost from the session detail API when the host provides it. */+ metrics?: SessionListMetrics;createdAt: string;updatedAt: string;}@@ -280,6 +282,8 @@ export interface TurnDoneMetrics {totalCacheReadTokens: number;totalCacheWriteTokens: number;totalReasoningTokens: number;+ /** Estimated total cost in USD for this turn when the host reports it. */+ totalCostInUsd?: number;}export interface TurnStateDone {diff --git a/packages/trueforge-ui/src/atoms/agent-details/AgentSessions.tsx b/packages/trueforge-ui/src/atoms/agent-details/AgentSessions.tsxindex 3cd72793e..f23132172 100644--- a/packages/trueforge-ui/src/atoms/agent-details/AgentSessions.tsx+++ b/packages/trueforge-ui/src/atoms/agent-details/AgentSessions.tsx@@ -334,7 +334,7 @@ export function AgentSessions({<AgentSessionTimelineContainersessionId={selectedSessionId}events={detailEvents}- listMetrics={selectedEntry?.metrics}+ sessionMetrics={detailSession?.metrics}{...(detailOnly ? { contentMaxWidth: '60rem' } : {})}/>)}diff --git a/packages/trueforge-ui/src/containers/AgentSessionTimelineContainer.tsx b/packages/trueforge-ui/src/containers/AgentSessionTimelineContainer.tsxindex 021a75e8e..79421f582 100644--- a/packages/trueforge-ui/src/containers/AgentSessionTimelineContainer.tsx+++ b/packages/trueforge-ui/src/containers/AgentSessionTimelineContainer.tsx@@ -140,7 +140,7 @@ export type AgentSessionTimelineContainerProps = {sessionId: string;events: SessionEventItem[];contentMaxWidth?: string;- listMetrics?: {+ sessionMetrics?: {totalTurns: number;totalCostInUsd?: number;totalDurationMs: number;@@ -151,7 +151,7 @@ export function AgentSessionTimelineContainer({sessionId,events,contentMaxWidth,- listMetrics,+ sessionMetrics: sessionMetricsHint,}: AgentSessionTimelineContainerProps) {const server = useServer();const AgentSessionTurnHeader = useSlot('AgentSessionTurnHeader');@@ -168,8 +168,8 @@ export function AgentSessionTimelineContainer({const projectionEvents = useMemo(() => buildProjectionEvents(events, turnViews), [events, turnViews]);const timelineSegments = useMemo(() => buildSessionTimelineSegments(turnViews), [turnViews]);const sessionMetrics = useMemo(- () => buildSessionMetrics({ turns: turnViews, segments: timelineSegments, listMetrics }),- [listMetrics, timelineSegments, turnViews],+ () => buildSessionMetrics({ turns: turnViews, segments: timelineSegments, sessionMetrics: sessionMetricsHint }),+ [sessionMetricsHint, timelineSegments, turnViews],);const handleSelectTurn = useCallback((index: number) => {diff --git a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/chatServer.ts b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/chatServer.tsindex 5ad82436f..5e6262398 100644--- a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/chatServer.ts+++ b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/chatServer.ts@@ -91,6 +91,11 @@ function toUiSession(session: TrueForgeApi.Session): HarnessUiSession {shared: session.shared,createdAt: session.createdAt,updatedAt: session.updatedAt,+ metrics: {+ totalTurns: session.metrics.totalTurns,+ totalDurationMs: session.metrics.totalDurationMs,+ ...(session.metrics.totalCostInUsd == null ? {} : { totalCostInUsd: session.metrics.totalCostInUsd }),+ },...(session.title === null ? {} : { title: session.title }),// `name` is a create-time snapshot, so references whose agent predates it stay// unlabelled; `isMutable` alone keeps them out of the composer.diff --git a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/toUiTurnState.ts b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/toUiTurnState.tsindex b097525d2..82e493e3e 100644--- a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/toUiTurnState.ts+++ b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/toUiTurnState.ts@@ -2,7 +2,7 @@ import type { TrueForgeApi } from '@truefoundry/trueforge-sdk';import type { SessionEventItem, TurnDoneMetrics, TurnState, TurnStreamingEvent } from '../../server/types.js';/** SDK token fields are optional; the UI contract requires numbers. Keep cost for session tiles. */-export function toUiTurnDoneMetrics(metrics: TrueForgeApi.TurnMetrics): TurnDoneMetrics & { totalCostInUsd?: number } {+export function toUiTurnDoneMetrics(metrics: TrueForgeApi.TurnMetrics): TurnDoneMetrics {return {totalInputTokens: metrics.totalInputTokens ?? 0,totalOutputTokens: metrics.totalOutputTokens ?? 0,diff --git a/packages/trueforge-ui/src/utils/buildSessionMetrics.ts b/packages/trueforge-ui/src/utils/buildSessionMetrics.tsindex e777120ff..8dc202785 100644--- a/packages/trueforge-ui/src/utils/buildSessionMetrics.ts+++ b/packages/trueforge-ui/src/utils/buildSessionMetrics.ts@@ -23,7 +23,7 @@ export type SessionMetrics = {toolCallFrequency: SessionMetricBarDatum[];};-export type SessionListMetricsHint = {+export type SessionMetricsHint = {totalTurns: number;totalCostInUsd?: number;totalDurationMs: number;@@ -33,10 +33,6 @@ function segmentDurationMs(segment: SessionEventTimelineSegment): number {return Math.max(0, segment.endMs - segment.startMs);}-function hintHasValues(hint?: SessionListMetricsHint): boolean {- return hint != null && (hint.totalTurns > 0 || hint.totalCostInUsd != null || hint.totalDurationMs > 0);-}-function turnHasMetrics(turn: SessionTurnView): boolean {return (turn.totalTokens != null ||@@ -50,11 +46,11 @@ function turnHasMetrics(turn: SessionTurnView): boolean {export function buildSessionMetrics({turns,segments,- listMetrics,+ sessionMetrics,}: {turns: SessionTurnView[];segments: SessionEventTimelineSegment[];- listMetrics?: SessionListMetricsHint;+ sessionMetrics?: SessionMetricsHint;}): SessionMetrics {let derivedWallTimeMs = 0;let derivedCostUsd = 0;@@ -105,9 +101,8 @@ export function buildSessionMetrics({const waitingTimeMs = segments.filter(segment => segment.type === 'waiting_on_human' || segment.type === 'approval').reduce((sum, segment) => sum + segmentDurationMs(segment), 0);- const wallTimeMs = hintHasValues(listMetrics)- ? (listMetrics?.totalDurationMs ?? derivedWallTimeMs)- : derivedWallTimeMs;+ // Detail/list session metrics own wall time, cost, and turn count when present.+ const wallTimeMs = sessionMetrics != null ? sessionMetrics.totalDurationMs : derivedWallTimeMs;const overheadTimeMs = Math.max(0, wallTimeMs - modelTimeMs - toolTimeMs - waitingTimeMs);const toolCallCounts = new Map<string, number>();@@ -121,10 +116,11 @@ export function buildSessionMetrics({color: getSessionEventColor('tool_call'),})).sort((left, right) => right.value - left.value);- const totalCostUsd = listMetrics?.totalCostInUsd ?? (hasDerivedCost ? derivedCostUsd : undefined);+ const totalCostUsd =+ sessionMetrics != null ? sessionMetrics.totalCostInUsd : hasDerivedCost ? derivedCostUsd : undefined;return {- totalTurns: hintHasValues(listMetrics) ? (listMetrics?.totalTurns ?? turns.length) : turns.length,+ totalTurns: sessionMetrics != null ? sessionMetrics.totalTurns : turns.length,wallTimeMs,...(totalCostUsd == null ? {} : { totalCostUsd }),totalTokens,diff --git a/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx b/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsxindex 8b48d7d1f..52b90450a 100644--- a/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx+++ b/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx@@ -142,6 +142,8 @@ function renderPage({isMutable: false,createdAt: '2026-01-01T00:00:00.000Z',updatedAt: '2026-01-02T00:00:00.000Z',+ // Distinct from list-row metrics so the strip proves it uses getSession.+ metrics: { totalTurns: 4, totalCostInUsd: 1.25, totalDurationMs: 90_000 },})),withSessions = true,metrics,@@ -604,11 +606,11 @@ describe('AgentDetailsPage', () => {expect(screen.getByText('timeline-body')).toBeInTheDocument();});- it('passes session API metrics into the selected session detail', async () => {+ it('passes getSession metrics into the selected session detail', async () => {renderPage({overrides: {- AgentSessionTimelineContainer: ({ listMetrics }) => (- <div>{`${String(listMetrics?.totalTurns)} turns, ${String(listMetrics?.totalDurationMs)}ms, $${String(listMetrics?.totalCostInUsd)}`}</div>+ AgentSessionTimelineContainer: ({ sessionMetrics }) => (+ <div>{`${String(sessionMetrics?.totalTurns)} turns, ${String(sessionMetrics?.totalDurationMs)}ms, $${String(sessionMetrics?.totalCostInUsd)}`}</div>),},});@@ -616,7 +618,7 @@ describe('AgentDetailsPage', () => {fireEvent.click(screen.getByRole('tab', { name: 'Sessions' }));fireEvent.click(await screen.findByText('Release notes draft'));- expect(await screen.findByText('2 turns, 120000ms, $0.5')).toBeInTheDocument();+ expect(await screen.findByText('4 turns, 90000ms, $1.25')).toBeInTheDocument();});it('shows the shared unavailable state without the optional server', () => {diff --git a/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/harnessServer.test.ts b/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/harnessServer.test.tsindex 7c65ed767..e9a4b68cf 100644--- a/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/harnessServer.test.ts+++ b/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/harnessServer.test.ts@@ -22,6 +22,11 @@ const session = {created_by: 'trueforge-default',created_at: '2026-08-03T00:00:00.000Z',updated_at: '2026-08-03T00:00:00.000Z',+ metrics: {+ total_turns: 1,+ total_duration_ms: 12_000,+ total_cost_in_usd: 0.42,+ },};const turnRequests: unknown[] = [];@@ -285,6 +290,11 @@ describe('createHarnessChatServer', () => {assert.equal(listedAgents, false);assert.equal(found.agentName, 'reviewer');assert.equal(found.isMutable, false);+ assert.deepEqual(found.metrics, {+ totalTurns: 1,+ totalDurationMs: 12_000,+ totalCostInUsd: 0.42,+ });});it('getSession leaves a ref session unlabelled when it carries no name snapshot', async () => {diff --git a/packages/trueforge-ui/test/utils/sessionEventTimeline.test.ts b/packages/trueforge-ui/test/utils/sessionEventTimeline.test.tsindex 8bd0f4990..79887eeb6 100644--- a/packages/trueforge-ui/test/utils/sessionEventTimeline.test.ts+++ b/packages/trueforge-ui/test/utils/sessionEventTimeline.test.ts@@ -583,4 +583,43 @@ describe('buildSessionMetrics', () => {const metrics = buildSessionMetrics({ turns, segments: buildSessionTimelineSegments(turns) });assert.equal(metrics.totalCostUsd, undefined);});++ it('uses sessionMetrics exclusively for turns, duration, and cost', () => {+ const turns = buildSessionTurnViews([+ created({ turnId: 't1', createdAt: '2026-01-01T00:00:00.000Z' }),+ {+ turnId: 't1',+ event: {+ type: 'turn.done',+ id: 't1-done',+ state: {+ status: 'done',+ completedAt: '2026-01-01T00:00:02.000Z',+ output: null,+ requiredActions: [],+ metrics: {+ totalTokens: 80,+ totalCostInUsd: 0.5,+ totalInputTokens: 50,+ totalOutputTokens: 30,+ totalCacheReadTokens: 0,+ totalCacheWriteTokens: 0,+ totalReasoningTokens: 0,+ },+ },+ createdAt: '2026-01-01T00:00:02.000Z',+ threadId: null,+ },+ },+ ]);+ const metrics = buildSessionMetrics({+ turns,+ segments: buildSessionTimelineSegments(turns),+ sessionMetrics: { totalTurns: 3, totalDurationMs: 81_715, totalCostInUsd: 0.3106 },+ });+ assert.equal(metrics.totalTurns, 3);+ assert.equal(metrics.wallTimeMs, 81_715);+ assert.equal(metrics.totalCostUsd, 0.3106);+ assert.equal(metrics.totalTokens, 80);+ });});