Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

chore [toast]: handle error toast on model provider form submission (#109)

sayan-truefoundryc10981eecfe1
diff --git a/packages/trueforge-ui-sdk/src/atoms/Toast.tsx b/packages/trueforge-ui-sdk/src/atoms/Toast.tsx
index e21a26d85..eee97f35c 100644
--- a/packages/trueforge-ui-sdk/src/atoms/Toast.tsx
+++ b/packages/trueforge-ui-sdk/src/atoms/Toast.tsx
@@ -1,6 +1,7 @@
'use client';
import { useCallback, useState, type ReactNode } from 'react';
+import { createPortal } from 'react-dom';
import { Icon } from '../icons/Icon.js';
import { auiButtonClass } from './lib/buttonClasses.js';
@@ -78,12 +79,27 @@ export type ToastStackProps = {
duration?: number;
};
+const openToastStack = (element: HTMLDivElement | null): void => {
+ if (element === null || typeof element.showPopover !== 'function') return;
+ if (element.matches(':popover-open')) element.hidePopover();
+ element.showPopover();
+};
+
export function ToastStack({ children, duration: _duration = Number.POSITIVE_INFINITY }: ToastStackProps) {
- return (
- <div className="pointer-events-none fixed bottom-4 left-1/2 z-50 flex w-full max-w-md -translate-x-1/2 flex-col-reverse gap-2 px-4">
+ const stack = (
+ <div
+ ref={openToastStack}
+ popover="manual"
+ className="pointer-events-none fixed top-auto right-auto bottom-4 left-1/2 z-50 flex w-full max-w-md -translate-x-1/2 flex-col-reverse gap-2 overflow-visible bg-transparent px-4"
+ >
{children}
</div>
);
+
+ if (typeof document === 'undefined') return stack;
+ const dialogs = document.querySelectorAll<HTMLDialogElement>('dialog[open]');
+ const activeDialog = dialogs.item(dialogs.length - 1);
+ return activeDialog === null ? stack : createPortal(stack, activeDialog);
}
declare module '../theme/SlotsProvider.js' {
diff --git a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx
index dfd267c93..bb9d8e516 100644
--- a/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/SettingsBuilder/ModelSettings.tsx
@@ -7,10 +7,12 @@ import SearchInput from '../../atoms/primitives/SearchInput.js';
import { Icon } from '../../icons/Icon.js';
import { useCatalogServer } from '../../server/ServerContext.js';
import type { ModelEntry, ModelProviderBase, ModelProviderCatalogEntry } from '../../server/types.js';
+import { useErrorToasterOptional } from '../ErrorToasterContainer.js';
import CustomModelProviderForm, { type CustomProviderDraft } from './CustomModelProviderForm.js';
const ModelSettings = () => {
const { modelCatalog } = useCatalogServer();
+ const toaster = useErrorToasterOptional();
const [query, setQuery] = useState('');
const [configured, setConfigured] = useState<ModelProviderBase[]>([]);
@@ -113,7 +115,11 @@ const ModelSettings = () => {
await refresh();
closeKeyEditor();
} catch (err) {
- setError(err instanceof Error ? err.message : 'Request failed');
+ if (toaster != null) {
+ toaster.showError(err);
+ } else {
+ setError(err instanceof Error ? err.message : 'Request failed');
+ }
throw err;
} finally {
setBusy(false);