Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

Stop describing chart_version as the parent chart's own version (#955)

Raman Tehlanc30bfe269744
diff --git a/.github/workflows/release-chart.yml b/.github/workflows/release-chart.yml
index 7f0cc4fcd..61c9f3635 100644
--- a/.github/workflows/release-chart.yml
+++ b/.github/workflows/release-chart.yml
@@ -5,9 +5,10 @@ name: Publish Helm chart
# calls this workflow with (branch, chart_version, app_version, image_tag).
# branch is the release-vX.Y.Z branch release.yml is running on.
#
-# chart_version is the parent chart version, verbatim. Nothing in this repo
-# computes it: one field, one owner. appVersion follows the npm package and
-# image.tag follows the image release.yml built.
+# chart_version is published verbatim. Nothing in this repo computes it: one
+# field, one owner, and the caller decides the number - it need not match the
+# parent chart's own version. appVersion follows the npm package and image.tag
+# follows the image release.yml built.
#
# Order matters. Metadata commit and tag come before `helm push`, so a failed
# push leaves a recoverable branch state rather than an orphan chart in OCI.
@@ -239,31 +240,30 @@ jobs:
# content: the version has to move instead.
#
# charts/trueforge@<V> this chart's own record. ANNOTATED, because
- # helm-charts' resolve_ref_sha already does the
- # /git/tags/{sha} dereference hop for it.
+ # its only consumer dereferences tag objects
+ # (/git/tags/{sha}) when resolving a ref.
# v<V> the release-line marker every other
- # sibling repo publishes. Under verbatim
- # versioning <V> is the parent chart
- # version, so release-app's hotfixBranchPlan
- # (git/matching-refs/tags/v<major>.<minor>.)
- # and helm-charts' compute_release both resolve
- # this repo with no TrueForge-specific code.
+ # sibling repo publishes. It is what lets the
+ # callers resolve this repo's release line
+ # generically - by listing
+ # git/matching-refs/tags/v<major>.<minor>. -
+ # with no code specific to this repo. Publish
+ # it on every release or the line develops
+ # holes and a later hotfix resolves the wrong
+ # commit.
# LIGHTWEIGHT on purpose: release-app's
- # getRefSha returns object.sha with NO
- # annotated-tag dereference and hands it
- # straight to createBranchFromSha, so an
- # annotated v-tag would hand create-ref a
- # tag-object sha. helm-charts creates every
- # service v-tag the same way (publish_releases
- # POSTs git/refs with a commit sha). Do not
- # add -a here.
+ # consumers resolve it with no annotated-tag
+ # dereference hop and hand the sha straight to
+ # create-ref, which rejects a tag-object sha.
+ # Sibling repos' v-tags are created the same
+ # way. Do not add -a here.
#
# This repo still carries dead v0.1.x tags from an abandoned scheme
# (highest final v0.1.9, 2026-08-09; plus a stray v0.1.10-rc.1 from
# 2026-08-13). They cannot collide: consumers query
- # git/matching-refs/tags/v<major>.<minor>. and the umbrella is on 0.17x
- # and up. Never dispatch a chart_version on the 0.1 line - it would
- # revive that line underneath a live consumer.
+ # git/matching-refs/tags/v<major>.<minor>. and live release lines are
+ # on 0.17x and up. Never dispatch a chart_version on the 0.1 line - it
+ # would revive that line underneath a live consumer.
push_tag() {
local name=$1 kind=$2 head existing
head=$(git rev-parse HEAD)
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index eec49392d..f57f93bf6 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -6,9 +6,10 @@
# Do not rename it without updating every package on npmjs.com and PyPI.
#
# Releases run on release-vX.Y.Z, never on main. main only collects changesets.
-# helm-charts dispatches this workflow with tfy_chart_version (X.Y.Z or
-# X.Y.Z-rc.N) on ref release-vX.Y.Z. There is no push trigger: the orchestrator
-# is the only entry point, so a run's conclusion is the release outcome.
+# The parent chart's release dispatches this workflow with tfy_chart_version
+# (X.Y.Z or X.Y.Z-rc.N) on ref release-vX.Y.Z. There is no push trigger: that
+# dispatch is the only entry point, so a run's conclusion is the release
+# outcome.
#
# version-release prepares pre mode and any 0.0.0 packages, runs
# `changeset version`, and commits the result straight to the release branch.
@@ -38,7 +39,7 @@ on:
workflow_dispatch:
inputs:
tfy_chart_version:
- description: 'TrueFoundry chart version: X.Y.Z or X.Y.Z-rc.N'
+ description: 'Chart version to publish: X.Y.Z or X.Y.Z-rc.N'
required: true
type: string
# DRY-RUN (temporary): exercise the whole pipeline without publishing
@@ -60,7 +61,7 @@ permissions: {}
jobs:
version-release:
- name: Version packages for TrueFoundry release
+ name: Version packages for the release
runs-on: ubuntu-latest
timeout-minutes: 30
outputs:
@@ -507,8 +508,8 @@ jobs:
# them is what keeps this conflict-free.
#
# continue-on-error: this job runs after release-chart has already pushed to
- # OCI, inside the run helm-charts gates its helm phase on. A changelog drain
- # must never fail a release whose chart is live and correct. A failure is
+ # OCI, inside the run the caller gates its own chart phase on. A changelog
+ # drain must never fail a release whose chart is live and correct. A failure is
# reported as a ::error:: annotation and recovered by re-dispatching.
back-merge-main:
name: Back-merge changelogs to main
diff --git a/RELEASING.md b/RELEASING.md
index d6c48e8d3..5541670a7 100644
--- a/RELEASING.md
+++ b/RELEASING.md
@@ -21,7 +21,7 @@ sandbox image.
| Chart `appVersion` | `packages/trueforge/package.json` version at the build commit |
| Prod image | Root [`Dockerfile`](Dockerfile): from-source workspace build |
| Prod image tag | `{packageVersion}-{shortSha}` |
-| Chart `version` | The dispatching chart version, verbatim (`tfy_chart_version`). Nothing in this repo computes it |
+| Chart `version` | The `tfy_chart_version` input, verbatim. Nothing in this repo computes it |
| Sandbox image | [`sandbox.Dockerfile`](packages/trueforge-core/scripts/sandbox/sandbox.Dockerfile); tag = full commit SHA |
Install a published chart:
@@ -54,10 +54,13 @@ does not publish.
`pnpm change --bump patch --summary "…" <pkg>`). SDK regen already adds
`@truefoundry/trueforge-sdk` via `pnpm changeset:sdk-regen`.
2. Merge to `main`.
-3. A parent chart release of `V` (`X.Y.Z` or `X.Y.Z-rc.N`) creates
- `release-vX.Y.Z` in this repo (`X.Y.Z` is `V` with any `-rc.N` removed) and
- dispatches this workflow with `tfy_chart_version=V`. The first cut of a minor
- line is from `main`; a hotfix line is cut from `refs/tags/v<base>` so
+3. The dispatching workflow picks the version `V` (`X.Y.Z` or `X.Y.Z-rc.N`) it
+ wants published, creates `release-vX.Y.Z` in this repo (`X.Y.Z` is `V` with
+ any `-rc.N` removed) and dispatches this workflow with
+ `tfy_chart_version=V`. `V` is the caller's choice and need not match the
+ parent chart's own version - this repo publishes what it is handed. The
+ first cut of a minor line is from `main`; a hotfix line is cut from
+ `refs/tags/v<base>` so
unreleased work on `main` cannot enter a patch. An existing branch is kept as
is and **never** has `main` merged into it: only the **first** RC of a minor
line fails when `main` has commits the branch is missing, because from `rc.2`
@@ -230,11 +233,11 @@ gh workflow run release-chart.yml --ref main \
-f image_tag=0.3.0-rc.0-abcdef1
```
-The chart version is the `chart_version` input, verbatim - the same value as the
-parent chart release that dispatched it. Nothing in this repo derives it, so
-`oci://tfy.jfrog.io/tfy-helm/trueforge:<V>` and `charts/trueforge@<V>` are known
-before the release starts. `appVersion` tracks `@truefoundry/trueforge` and the
-image tag prefix; those are separate fields with separate owners.
+The chart version is the `chart_version` input, verbatim. Nothing in this repo
+derives it, so `oci://tfy.jfrog.io/tfy-helm/trueforge:<V>` and
+`charts/trueforge@<V>` are known to the caller before the release starts.
+`appVersion` tracks `@truefoundry/trueforge` and the image tag prefix; those are
+separate fields with separate owners.
## Devtest
diff --git a/charts/trueforge/Chart.yaml b/charts/trueforge/Chart.yaml
index 90b52f829..5919b4770 100644
--- a/charts/trueforge/Chart.yaml
+++ b/charts/trueforge/Chart.yaml
@@ -2,8 +2,9 @@ apiVersion: v2
name: trueforge
description: TrueForge server (API + UI) served from a single container image.
type: application
-# version is the parent chart version, written verbatim from
-# release-chart.yml's chart_version input; nothing in this repo computes it.
+# version is written verbatim from release-chart.yml's chart_version input;
+# nothing in this repo computes it. The caller decides the number, and it need
+# not match the parent chart's own version.
# appVersion follows packages/trueforge/package.json and image.tag follows the
# image release.yml built. All three are written on the release-vX.Y.Z branch,
# which is then tagged charts/trueforge@<version> on that commit.