The open-source agent harness - the runtime layer that turns an LLM into a working agent.
chore: show task details and failure reasons in schedule (#870)
harshil-2096c783700861e2
diff --git a/.changeset/bright-schedules-display.md b/.changeset/bright-schedules-display.mdnew file mode 100644index 000000000..84f63cfdb--- /dev/null+++ b/.changeset/bright-schedules-display.md@@ -0,0 +1,6 @@+---+'@truefoundry/trueforge-assistant-ui-runtime': patch+'@truefoundry/trueforge-ui': patch+---++Show schedule tasks, agent context, and failed run reasons in the schedules table.diff --git a/packages/assistant-ui-runtime/src/server/types.ts b/packages/assistant-ui-runtime/src/server/types.tsindex 55328d7ef..da137743f 100644--- a/packages/assistant-ui-runtime/src/server/types.ts+++ b/packages/assistant-ui-runtime/src/server/types.ts@@ -1000,6 +1000,8 @@ export interface ScheduleRun {name: string;scheduledFor: string;status: ScheduleRunStatus;+ /** Failure reason supplied by the scheduler, when available. */+ reason?: string | null;triggeredAt: string | null;triggeredBy: string;}diff --git a/packages/trueforge-ui/src/atoms/schedules/ScheduleRunChip.tsx b/packages/trueforge-ui/src/atoms/schedules/ScheduleRunChip.tsxindex fd9c1acdb..28ab05152 100644--- a/packages/trueforge-ui/src/atoms/schedules/ScheduleRunChip.tsx+++ b/packages/trueforge-ui/src/atoms/schedules/ScheduleRunChip.tsx@@ -17,7 +17,7 @@ export function ScheduleRunChip({ run }: { run: ScheduleRun }) {const kind = runChipKind(run.status);const when = formatScheduleRunInstant(run.triggeredAt ?? run.scheduledFor);return (- <Tooltip content={<ScheduleRunTooltip run={run} />} side="top">+ <Tooltip content={<ScheduleRunTooltip run={run} />} className="max-w-sm whitespace-normal" side="top"><spanclassName={cn('inline-flex size-6 shrink-0 items-center justify-center rounded-md border', CHIP_STYLES[kind])}aria-label={`${runStatusLabel(run.status)} run at ${when}`}diff --git a/packages/trueforge-ui/src/atoms/schedules/ScheduleRunTooltip.tsx b/packages/trueforge-ui/src/atoms/schedules/ScheduleRunTooltip.tsxindex 2aee776e8..9766e8adb 100644--- a/packages/trueforge-ui/src/atoms/schedules/ScheduleRunTooltip.tsx+++ b/packages/trueforge-ui/src/atoms/schedules/ScheduleRunTooltip.tsx@@ -13,6 +13,7 @@ export function ScheduleRunTooltip({ run }: { run: ScheduleRun }) {<p className="text-text-secondary">Triggered at: {formatScheduleRunInstant(run.triggeredAt)}</p>) : null}<p className="text-text-secondary">Triggered by: {run.triggeredBy}</p>+ {run.status === 'failed' && run.reason ? <p className="text-text-secondary">Reason: {run.reason}</p> : null}</div>);}diff --git a/packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsx b/packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsxindex 847f657ee..a1d38f420 100644--- a/packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsx+++ b/packages/trueforge-ui/src/atoms/schedules/SchedulesPage.tsx@@ -33,6 +33,7 @@ import {TableRow,TableTokenPagination,} from '../primitives/Table.js';+import { Tooltip } from '../primitives/Tooltip.js';import { formatCadenceSummary } from './cadence.js';import { ScheduleFormDrawer } from './ScheduleFormDrawer.js';import { ScheduleLastRunsCell } from './ScheduleLastRunsCell.js';@@ -382,7 +383,7 @@ export function SchedulesPage({ agentId }: SchedulesPageProps) {return (<div className="flex h-full min-h-0 flex-col bg-primary-bg"><PageHeader- title={agentId === undefined ? 'Scheduled Agents' : undefined}+ title={agentId === undefined ? 'Agent Schedules' : undefined}end={<><div className="w-full sm:w-60">@@ -468,11 +469,11 @@ export function SchedulesPage({ agentId }: SchedulesPageProps) {</div>) : (<div className="overflow-hidden rounded-lg border border-border">- <Table className="min-w-[48rem]">+ <Table className="min-w-240"><TableHeader><TableRow className="hover:bg-transparent">- <TableHead>Name</TableHead>- <TableHead>Agent</TableHead>+ <TableHead>Schedule Name</TableHead>+ <TableHead>Task</TableHead>{showCreatedByColumn ? <TableHead>Created by</TableHead> : null}<TableHead>Frequency</TableHead><TableHead>Status</TableHead>@@ -488,10 +489,22 @@ export function SchedulesPage({ agentId }: SchedulesPageProps) {const agentLabel = schedule.agentName ?? agentLabelById[schedule.agentId] ?? schedule.agentId;return (<TableRow key={schedule.id}>- <TableCell className="text-text-primary font-medium">- <span className="text-left !no-underline">{schedule.name}</span>+ <TableCell className="w-48 max-w-48">+ <span className="text-text-primary block truncate font-medium">{schedule.name}</span>+ <span className="mt-1 flex min-w-0 items-center gap-1 text-xs">+ <Icon name="agent-2" className="size-3 shrink-0" />+ <span className="truncate">{agentLabel}</span>+ </span>+ </TableCell>+ <TableCell className="w-64 max-w-64">+ <Tooltip+ content={schedule.task}+ className="max-w-sm whitespace-normal text-left"+ triggerClassName="block min-w-0 w-full max-w-full"+ >+ <span className="block truncate">{schedule.task}</span>+ </Tooltip></TableCell>- <TableCell>{agentLabel}</TableCell>{showCreatedByColumn ? (<TableCell><CreatedByCell subject={schedule.createdBySubject} />diff --git a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/schedules/scheduleServer.ts b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/schedules/scheduleServer.tsindex 5e38d2370..9d02b73ed 100644--- a/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/schedules/scheduleServer.ts+++ b/packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/schedules/scheduleServer.ts@@ -99,6 +99,7 @@ function toUiScheduleRun(wire: TrueForgeApi.ScheduleRun): ScheduleRun {name: wire.name,scheduledFor: toIsoInstant(wire.scheduledFor),status: wire.status,+ reason: wire.reason,triggeredAt: wire.triggeredAt == null ? null : toIsoInstant(wire.triggeredAt),triggeredBy: wire.createdBySubject.subjectDisplayName || wire.createdBySubject.subjectId,};diff --git a/packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsx b/packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsxindex 0ddc50053..3e3b70cde 100644--- a/packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsx+++ b/packages/trueforge-ui/test/atoms/schedules/SchedulesPage.test.tsx@@ -1,5 +1,5 @@// @vitest-environment jsdom-import { act, fireEvent, render, screen, waitFor } from '@testing-library/react';+import { act, fireEvent, render, screen, waitFor, within } from '@testing-library/react';import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';import { SchedulesPage } from '@/atoms/schedules/SchedulesPage.js';@@ -103,11 +103,18 @@ function renderPage(describe('SchedulesPage', () => {it('lists schedules in the table', async () => {const { scheduleServer, searchAgents } = renderPage();- expect(await screen.findByRole('heading', { name: 'Scheduled Agents' })).toBeInTheDocument();+ expect(await screen.findByRole('heading', { name: 'Agent Schedules' })).toBeInTheDocument();await waitFor(() => {expect(screen.getByText('daily-digest')).toBeInTheDocument();});- expect(screen.getAllByText('demo-agent').length).toBeGreaterThan(0);+ expect(screen.getByRole('columnheader', { name: 'Schedule Name' })).toBeInTheDocument();+ expect(screen.getByRole('columnheader', { name: 'Task' })).toBeInTheDocument();+ const task = screen.getByText('summarize');+ fireEvent.mouseEnter(task);+ expect(await screen.findByRole('tooltip', { name: 'summarize' })).toBeInTheDocument();+ const scheduleNameCell = screen.getByText('daily-digest').closest('td');+ if (scheduleNameCell == null) throw new Error('expected schedule name table cell');+ expect(within(scheduleNameCell).getByText('demo-agent')).toBeInTheDocument();expect(screen.getByText('—')).toBeInTheDocument();expect(screen.getByText('Showing 1')).toBeInTheDocument();expect(scheduleServer.listSchedules).toHaveBeenCalledWith(expect.objectContaining({ limit: 10 }));@@ -192,7 +199,7 @@ describe('SchedulesPage', () => {expect.objectContaining({ agentIds: ['demo-agent'], limit: 10 }),);});- expect(screen.queryByRole('heading', { name: 'Scheduled Agents' })).not.toBeInTheDocument();+ expect(screen.queryByRole('heading', { name: 'Agent Schedules' })).not.toBeInTheDocument();expect(screen.queryByRole('combobox', { name: 'Filter by agent' })).not.toBeInTheDocument();});@@ -320,6 +327,7 @@ describe('SchedulesPage', () => {name: 'sched-123',scheduledFor: '2024-06-01T10:00:00.000Z',status: 'failed',+ reason: 'The agent service rejected the scheduled run.',triggeredAt: '2024-06-01T10:00:01.000Z',triggeredBy: 'alice',},@@ -348,6 +356,8 @@ describe('SchedulesPage', () => {expect(screen.getByLabelText(/Failed run at/i)).toBeInTheDocument();expect(screen.getByLabelText(/Triggered run at/i)).toBeInTheDocument();});+ fireEvent.mouseEnter(screen.getByLabelText(/Failed run at/i));+ expect(await screen.findByText('Reason: The agent service rejected the scheduled run.')).toBeInTheDocument();});it('runs a schedule now from the table actions', async () => {diff --git a/packages/trueforge-ui/test/containers/TrueForgeUI.test.tsx b/packages/trueforge-ui/test/containers/TrueForgeUI.test.tsxindex e112e0f86..777e7b68b 100644--- a/packages/trueforge-ui/test/containers/TrueForgeUI.test.tsx+++ b/packages/trueforge-ui/test/containers/TrueForgeUI.test.tsx@@ -405,11 +405,11 @@ describe('StackChatPanel', () => {);fireEvent.click(screen.getByRole('button', { name: 'Open schedules' }));- expect(await screen.findByRole('heading', { name: 'Scheduled Agents' })).toBeInTheDocument();+ expect(await screen.findByRole('heading', { name: 'Agent Schedules' })).toBeInTheDocument();fireEvent.click(screen.getByRole('button', { name: 'Back to chat' }));await waitFor(() => {- expect(screen.queryByRole('heading', { name: 'Scheduled Agents' })).not.toBeInTheDocument();+ expect(screen.queryByRole('heading', { name: 'Agent Schedules' })).not.toBeInTheDocument();});});});diff --git a/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/scheduleServer.test.ts b/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/scheduleServer.test.tsindex fc2d0e884..36486fe39 100644--- a/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/scheduleServer.test.ts+++ b/packages/trueforge-ui/test/plugins/trueforge-agent-server-adapter/scheduleServer.test.ts@@ -131,6 +131,7 @@ describe('createScheduleServer schedule runs', () => {name: 'manual-abc',scheduledFor: new Date('2024-06-01T12:00:00.000Z'),status: 'triggered' as const,+ reason: 'The agent service rejected the scheduled run.',triggeredAt: new Date('2024-06-01T12:00:01.000Z'),createdBySubject: {subjectId: 'alice',@@ -153,6 +154,7 @@ describe('createScheduleServer schedule runs', () => {name: 'manual-abc',scheduledFor: '2024-06-01T12:00:00.000Z',status: 'triggered',+ reason: 'The agent service rejected the scheduled run.',triggeredAt: '2024-06-01T12:00:01.000Z',triggeredBy: 'alice',},