The open-source agent harness - the runtime layer that turns an LLM into a working agent.
fix(models): default reasoning effort to the lowest real level, not "none" (#151)
shubhamagarwal-createc99bba783138
diff --git a/packages/frontend/src/App.tsx b/packages/frontend/src/App.tsxindex cba81477a..088f57816 100644--- a/packages/frontend/src/App.tsx+++ b/packages/frontend/src/App.tsx@@ -77,7 +77,9 @@ export function App() {});return;}- const defaultReasoningEffort = first.properties.reasoningEfforts?.[0];+ const reasoningEfforts = first.properties.reasoningEfforts;+ // Default to the lowest real effort, not "none" — catalog lists are ordered ascending.+ const defaultReasoningEffort = reasoningEfforts?.find(effort => effort !== 'none') ?? reasoningEfforts?.[0];setBoot({status: 'ready',openSettings: false,diff --git a/packages/trueforge-ui-sdk/src/atoms/draft/reasoningEffort.ts b/packages/trueforge-ui-sdk/src/atoms/draft/reasoningEffort.tsindex 15346aecd..9b4afda70 100644--- a/packages/trueforge-ui-sdk/src/atoms/draft/reasoningEffort.ts+++ b/packages/trueforge-ui-sdk/src/atoms/draft/reasoningEffort.ts@@ -4,14 +4,15 @@ export function hasReasoningEfforts(efforts: ModelSelection['reasoningEfforts'])return Array.isArray(efforts) && efforts.length > 0;}-/** Keep current if still listed; otherwise first effort; none if model has no efforts. */+/** Keep current if still listed; otherwise the lowest non-"none" effort; none if model has no efforts. */export function resolveReasoningEffort(efforts: ModelSelection['reasoningEfforts'],current: string | undefined,): string | undefined {if (!hasReasoningEfforts(efforts)) return undefined;if (current && efforts.includes(current)) return current;- return efforts[0];+ // Default to the lowest real effort, not "none" — catalog lists are ordered ascending.+ return efforts.find(effort => effort !== 'none') ?? efforts[0];}/**diff --git a/packages/trueforge-ui-sdk/test/atoms/draft/reasoningEffort.test.ts b/packages/trueforge-ui-sdk/test/atoms/draft/reasoningEffort.test.tsindex 547ce5c49..f716978c7 100644--- a/packages/trueforge-ui-sdk/test/atoms/draft/reasoningEffort.test.ts+++ b/packages/trueforge-ui-sdk/test/atoms/draft/reasoningEffort.test.ts@@ -31,6 +31,19 @@ describe('resolveReasoningEffort', () => {expect(resolveReasoningEffort(['low', 'high'], undefined)).toBe('low');expect(resolveReasoningEffort(['low', 'high'], 'medium')).toBe('low');});++ it('defaults to the lowest non-"none" effort, skipping "none"', () => {+ expect(resolveReasoningEffort(['none', 'low', 'high'], undefined)).toBe('low');+ expect(resolveReasoningEffort(['none', 'minimal', 'low'], 'bogus')).toBe('minimal');+ });++ it('still honors an explicit "none" selection', () => {+ expect(resolveReasoningEffort(['none', 'low', 'high'], 'none')).toBe('none');+ });++ it('falls back to "none" only when it is the sole effort', () => {+ expect(resolveReasoningEffort(['none'], undefined)).toBe('none');+ });});describe('modelPatchWithReasoningEffort', () => {