Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

pin sandbox version once installed (#251)

Heer Ambavie9e587114424
diff --git a/packages/server/src/apis/sandboxProviders.ts b/packages/server/src/apis/sandboxProviders.ts
index 03a45e7a5..c833c7856 100644
--- a/packages/server/src/apis/sandboxProviders.ts
+++ b/packages/server/src/apis/sandboxProviders.ts
@@ -71,7 +71,14 @@ export function createSandboxProvidersRouter<TTransaction>(deps: SandboxProvider
const { manifest, status } = await deps.withTransaction(async transaction => {
const locked = await deps.sandboxProviderStore.getSandboxProviderForUpdate(TENANT_ID, transaction);
const resolved = resolveManifest(locked);
- const provider = toDaytonaSandboxProvider({ manifest: resolved, tenant_id: TENANT_ID, logger: deps.logger });
+ // Pass persisted build_metadata so a settings re-save does not start a new snapshot for a
+ // bumped SANDBOX_IMAGE_URI (upgrades are unsupported — first configure has no metadata).
+ const provider = toDaytonaSandboxProvider({
+ manifest: resolved,
+ tenant_id: TENANT_ID,
+ logger: deps.logger,
+ ...(locked ? { build_metadata: locked.build_metadata } : {}),
+ });
const built = toSandboxStatus(
await withTimeout(provider.buildImage(), BUILD_REQUEST_TIMEOUT_MS, 'sandbox buildImage'),
);
diff --git a/packages/server/src/sandbox/providerUtils.ts b/packages/server/src/sandbox/providerUtils.ts
index cf4a879ce..2770bf9cd 100644
--- a/packages/server/src/sandbox/providerUtils.ts
+++ b/packages/server/src/sandbox/providerUtils.ts
@@ -16,7 +16,14 @@ export function isDaytonaAuthError(error: unknown): boolean {
return error instanceof DaytonaError && (error.statusCode === 401 || error.statusCode === 403);
}
-/** Builds the runtime provider for a stored manifest. No network I/O until a method is called. */
+/**
+ * Builds the runtime provider for a stored manifest. No network I/O until a method is called.
+ *
+ * When `build_metadata` is present, pin both `sandboxImage` and `buildRef` to what was actually
+ * built — image bumps in the running binary must not rewrite an existing tenant onto a new
+ * snapshot (upgrades are not supported yet). First-time configure omits metadata and uses
+ * {@link SANDBOX_IMAGE_URI}.
+ */
export function toDaytonaSandboxProvider({
manifest,
tenant_id,
@@ -33,7 +40,7 @@ export function toDaytonaSandboxProvider({
client: new Daytona({ apiKey }),
...settings,
tenantName: tenant_id,
- sandboxImage: SANDBOX_IMAGE_URI,
+ sandboxImage: build_metadata?.['image_uri'] ?? SANDBOX_IMAGE_URI,
buildRef: build_metadata?.['build_ref'],
fileMaxBytesForDownload: configuration.SANDBOX_FILE_MAX_BYTES_FOR_DOWNLOAD,
logger,
diff --git a/packages/server/tests/unit/apis/sandboxProviders.test.ts b/packages/server/tests/unit/apis/sandboxProviders.test.ts
index 6d14e38ab..346e2ade0 100644
--- a/packages/server/tests/unit/apis/sandboxProviders.test.ts
+++ b/packages/server/tests/unit/apis/sandboxProviders.test.ts
@@ -247,4 +247,18 @@ describe('sandbox-provider secret redaction and strict PUT', () => {
const stored = await sandboxProviderStore.getSandboxProvider(TENANT_ID);
expect(stored?.manifest.auth.api_key).toBe(rotatedKey);
});
+
+ it('PUT update reuses persisted build_metadata (no image upgrade on re-save)', async () => {
+ const { settingsRouter } = await createRouters();
+ expect((await settingsRouter.request('/', putInit(putBody))).status).toBe(200);
+ expect(mockProviderFactory.mock.calls[0]?.[0]).not.toHaveProperty('build_metadata');
+
+ mockProviderFactory.mockClear();
+ expect((await settingsRouter.request('/', putInit(putBody))).status).toBe(200);
+ expect(mockProviderFactory).toHaveBeenCalledWith(
+ expect.objectContaining({
+ build_metadata: readyBuild.metadata,
+ }),
+ );
+ });
});