Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

Chore: metrics time range filter into the active Metrics tab row and ui feedbacks (#690)

harshil-2096ea8685308285
diff --git a/.changeset/move-metrics-filter.md b/.changeset/move-metrics-filter.md
new file mode 100644
index 000000000..2a013de26
--- /dev/null
+++ b/.changeset/move-metrics-filter.md
@@ -0,0 +1,5 @@
+---
+'@truefoundry/trueforge-ui': patch
+---
+
+Move the agent metrics time range filter into the active Metrics tab row.
diff --git a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsPage.tsx b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsPage.tsx
index a140e1498..93a269108 100644
--- a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsPage.tsx
+++ b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsPage.tsx
@@ -11,7 +11,7 @@ import { useShellMode } from '../../server/ShellModeContext.js';
import { isMetricsChromeEnabled, isSchedulesChromeEnabled } from '../../server/serverChrome.js';
import type { AgentDetail, CodeSnippet } from '../../server/types.js';
import { useSlot } from '../../theme/SlotsProvider.js';
-import { libraryAgentTabFromSearch } from '../../utils/sessionShareUrl.js';
+import { defaultMetricsTimeRange, libraryAgentTabFromSearch } from '../../utils/sessionShareUrl.js';
import { Skeleton } from '../primitives/Skeleton.js';
import type { AgentDetailsPageProps } from './types.js';
@@ -36,11 +36,13 @@ export function AgentDetailsPage({ agentId }: AgentDetailsPageProps) {
const AgentSessions = useSlot('AgentSessions');
const SchedulesPage = useSlot('SchedulesPage');
const AgentMetrics = useSlot('AgentMetrics');
+ const AgentMetricsTimeRangeFilter = useSlot('AgentMetricsTimeRangeFilter');
const AgentCodeSnippets = useSlot('AgentCodeSnippets');
const [detail, setDetail] = useState<AgentDetail>();
const [detailFailed, setDetailFailed] = useState(false);
const [snippets, setSnippets] = useState<CodeSnippet[]>();
const [snippetsFailed, setSnippetsFailed] = useState(false);
+ const [metricsTimeRange, setMetricsTimeRange] = useState(defaultMetricsTimeRange);
const goBack = useCallback(() => {
updateShareSearch({
@@ -127,7 +129,14 @@ export function AgentDetailsPage({ agentId }: AgentDetailsPageProps) {
} else if (activeTab === 'schedules') {
content = <SchedulesPage agentId={agentId} />;
} else if (activeTab === 'metrics') {
- content = <AgentMetrics agentId={agentId} />;
+ content = (
+ <AgentMetrics
+ agentId={agentId}
+ timeRange={metricsTimeRange}
+ onTimeRangeChange={setMetricsTimeRange}
+ showTimeRangeFilter={false}
+ />
+ );
} else if (snippetsFailed) {
content = <AgentDetailsUnavailable onBack={goBack} reason="Code samples for this agent could not be loaded." />;
} else if (snippets === undefined) {
@@ -149,6 +158,11 @@ export function AgentDetailsPage({ agentId }: AgentDetailsPageProps) {
activeTab={activeTab}
showMetrics={showMetrics}
showSchedules={showSchedules}
+ end={
+ activeTab === 'metrics' ? (
+ <AgentMetricsTimeRangeFilter timeRange={metricsTimeRange} onTimeRangeChange={setMetricsTimeRange} />
+ ) : null
+ }
onTabChange={tab =>
updateShareSearch({
agentId,
diff --git a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsTabs.tsx b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsTabs.tsx
index e3bc4dd00..b4a066ac7 100644
--- a/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsTabs.tsx
+++ b/packages/trueforge-ui/src/atoms/agent-details/AgentDetailsTabs.tsx
@@ -17,34 +17,34 @@ export function AgentDetailsTabs({
onTabChange,
showMetrics = false,
showSchedules = false,
+ end,
}: AgentDetailsTabsProps) {
return (
- <div
- role="tablist"
- aria-label="Agent details"
- className="flex shrink-0 gap-1 overflow-x-auto border-b border-border bg-primary-bg px-3"
- >
- {tabs
- .filter(tab => (tab.id !== 'metrics' || showMetrics) && (tab.id !== 'schedules' || showSchedules))
- .map(tab => (
- <button
- key={tab.id}
- type="button"
- role="tab"
- aria-selected={activeTab === tab.id}
- aria-current={activeTab === tab.id ? 'page' : undefined}
- className={cn(
- 'relative flex h-10 shrink-0 cursor-pointer items-center gap-1.5 px-2 text-xs font-medium text-text-secondary',
- 'focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-focus-ring',
- activeTab === tab.id &&
- 'text-primary-button-bg after:absolute after:inset-x-0 after:bottom-0 after:h-0.5 after:bg-primary-button-bg',
- )}
- onClick={() => onTabChange(tab.id)}
- >
- <Icon name={tab.icon} className="size-3.5" />
- {tab.label}
- </button>
- ))}
+ <div className="flex shrink-0 items-center border-b border-border bg-primary-bg px-3">
+ <div role="tablist" aria-label="Agent details" className="flex min-w-0 flex-1 gap-1 overflow-x-auto">
+ {tabs
+ .filter(tab => (tab.id !== 'metrics' || showMetrics) && (tab.id !== 'schedules' || showSchedules))
+ .map(tab => (
+ <button
+ key={tab.id}
+ type="button"
+ role="tab"
+ aria-selected={activeTab === tab.id}
+ aria-current={activeTab === tab.id ? 'page' : undefined}
+ className={cn(
+ 'relative flex h-10 shrink-0 cursor-pointer items-center gap-1.5 px-2 text-xs font-medium text-text-secondary',
+ 'focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-focus-ring',
+ activeTab === tab.id &&
+ 'text-primary-button-bg after:absolute after:inset-x-0 after:bottom-0 after:h-0.5 after:bg-primary-button-bg',
+ )}
+ onClick={() => onTabChange(tab.id)}
+ >
+ <Icon name={tab.icon} className="size-3.5" />
+ {tab.label}
+ </button>
+ ))}
+ </div>
+ {end != null ? <div className="ml-auto shrink-0 pl-2">{end}</div> : null}
</div>
);
}
diff --git a/packages/trueforge-ui/src/atoms/agent-details/AgentMetricsView.tsx b/packages/trueforge-ui/src/atoms/agent-details/AgentMetricsView.tsx
index 7f50e1216..8baeac64f 100644
--- a/packages/trueforge-ui/src/atoms/agent-details/AgentMetricsView.tsx
+++ b/packages/trueforge-ui/src/atoms/agent-details/AgentMetricsView.tsx
@@ -84,11 +84,14 @@ export function AgentMetricStatistics({ meters }: AgentMetricStatisticsProps) {
durationInSeconds: section.durationInSeconds,
});
return (
- <div key={item.label} className="min-w-0 px-3 first:pl-0 last:pr-0">
- <dt className="truncate text-xs font-medium text-text-secondary">{item.label}</dt>
+ <div
+ key={item.label}
+ className={`min-w-0 px-3 first:pl-0 last:pr-0 ${item.prominent ? '' : 'text-center'}`}
+ >
+ <dt className="truncate text-sm font-medium text-text-secondary">{item.label}</dt>
<dd
- className={`mt-1 truncate font-semibold tabular-nums ${
- item.prominent ? 'text-xl' : 'text-base'
+ className={`truncate font-bold tabular-nums ${
+ item.prominent ? 'text-3xl' : 'text-base mt-1.5'
} ${item.highlighted ? 'text-primary-button-bg' : 'text-text-primary'}`}
title={value}
>
@@ -112,6 +115,7 @@ export function AgentMetricsView({
chartsError,
timeRange,
onTimeRangeChange,
+ showTimeRangeFilter = true,
}: AgentMetricsViewProps) {
const AgentMetricCard = useSlot('AgentMetricCard');
const AgentMetricChart = useSlot('AgentMetricChart');
@@ -128,9 +132,11 @@ export function AgentMetricsView({
return (
<div className="min-h-0 flex-1 overflow-auto bg-secondary-bg/40 p-4" data-slot="agent-metrics-view">
- <div className="mb-4 flex justify-end">
- <AgentMetricsTimeRangeFilter timeRange={timeRange} onTimeRangeChange={onTimeRangeChange} />
- </div>
+ {showTimeRangeFilter ? (
+ <div className="mb-4 flex justify-end">
+ <AgentMetricsTimeRangeFilter timeRange={timeRange} onTimeRangeChange={onTimeRangeChange} />
+ </div>
+ ) : null}
{meterError != null ? (
<div className="mb-4 rounded-lg border border-failure-bg/30 bg-failure-bg/10 p-3 text-sm text-failure-bg">
@@ -154,7 +160,7 @@ export function AgentMetricsView({
No aggregate metrics
</div>
) : (
- <div className="mb-4 grid gap-4">
+ <div className="mb-3 grid gap-3">
{featuredMeters != null && featuredMeters.length > 0 ? (
<div className="grid grid-cols-2 gap-3 md:grid-cols-4">
{featuredMeters.map(meter => (
diff --git a/packages/trueforge-ui/src/atoms/agent-details/types.ts b/packages/trueforge-ui/src/atoms/agent-details/types.ts
index 215e6225a..147d5c6ec 100644
--- a/packages/trueforge-ui/src/atoms/agent-details/types.ts
+++ b/packages/trueforge-ui/src/atoms/agent-details/types.ts
@@ -98,11 +98,22 @@ export type AgentDetailsTabsProps = {
onTabChange: (tab: AgentDetailsTab) => void;
showMetrics?: boolean;
showSchedules?: boolean;
+ end?: ReactNode;
};
export type AgentMetricsProps = {
agentId: string;
-};
+ showTimeRangeFilter?: boolean;
+} & (
+ | {
+ timeRange: SessionTimeRange;
+ onTimeRangeChange: (range: SessionTimeRange) => void;
+ }
+ | {
+ timeRange?: undefined;
+ onTimeRangeChange?: undefined;
+ }
+);
export type AgentMetricChartResult = {
definition: AgentMetricChartDefinition;
@@ -118,6 +129,7 @@ export type AgentMetricsViewProps = {
chartsError?: string;
timeRange: SessionTimeRange;
onTimeRangeChange: (range: SessionTimeRange) => void;
+ showTimeRangeFilter?: boolean;
};
export type AgentMetricStatisticsProps = {
diff --git a/packages/trueforge-ui/src/containers/AgentMetricsContainer.tsx b/packages/trueforge-ui/src/containers/AgentMetricsContainer.tsx
index a1026dd75..fb60ef419 100644
--- a/packages/trueforge-ui/src/containers/AgentMetricsContainer.tsx
+++ b/packages/trueforge-ui/src/containers/AgentMetricsContainer.tsx
@@ -7,21 +7,19 @@ import { useAgentMetricsServer } from '../server/ServerContext.js';
import type { AgentMetricChartDefinition, AgentMetricMeter } from '../server/types.js';
import { useSlot } from '../theme/SlotsProvider.js';
import { getErrorMessage } from '../utils/getErrorMessage.js';
-import { resolveSessionTimeRange, type SessionTimeRange } from '../utils/sessionShareUrl.js';
+import { defaultMetricsTimeRange, resolveSessionTimeRange } from '../utils/sessionShareUrl.js';
-const DEFAULT_METRICS_WINDOW_MS = 24 * 60 * 60 * 1000;
-
-export function AgentMetricsContainer({ agentId }: AgentMetricsProps) {
+export function AgentMetricsContainer({
+ agentId,
+ timeRange: controlledTimeRange,
+ onTimeRangeChange,
+ showTimeRangeFilter = true,
+}: AgentMetricsProps) {
const metricsServer = useAgentMetricsServer();
const AgentMetricsView = useSlot('AgentMetricsView');
- const [timeRange, setTimeRange] = useState<SessionTimeRange>(() => {
- const endTs = Date.now();
- return {
- startTs: endTs - DEFAULT_METRICS_WINDOW_MS,
- endTs,
- timeWindowMs: DEFAULT_METRICS_WINDOW_MS,
- };
- });
+ const [internalTimeRange, setInternalTimeRange] = useState(defaultMetricsTimeRange);
+ const timeRange = controlledTimeRange ?? internalTimeRange;
+ const setTimeRange = onTimeRangeChange ?? setInternalTimeRange;
const [definitions, setDefinitions] = useState<AgentMetricChartDefinition[]>();
const [chartsError, setChartsError] = useState<string>();
const [meters, setMeters] = useState<AgentMetricMeter[]>();
@@ -110,6 +108,7 @@ export function AgentMetricsContainer({ agentId }: AgentMetricsProps) {
chartsError={chartsError}
timeRange={timeRange}
onTimeRangeChange={setTimeRange}
+ showTimeRangeFilter={showTimeRangeFilter}
/>
);
}
diff --git a/packages/trueforge-ui/src/utils/sessionShareUrl.ts b/packages/trueforge-ui/src/utils/sessionShareUrl.ts
index 2198ab256..edf4e212a 100644
--- a/packages/trueforge-ui/src/utils/sessionShareUrl.ts
+++ b/packages/trueforge-ui/src/utils/sessionShareUrl.ts
@@ -9,6 +9,7 @@ export const SESSION_TIME_WINDOW_QUERY = 's_tw';
export const SESSION_TIME_BUFFER_MS = 5 * 60 * 1000;
export const SESSION_CUSTOM_RANGE_MAX_DAYS = 70;
export const DEFAULT_SESSION_TIME_WINDOW_MS = 30 * 24 * 60 * 60 * 1000;
+export const DEFAULT_METRICS_TIME_WINDOW_MS = 24 * 60 * 60 * 1000;
export type LibraryAgentTab = 'overview' | 'sessions' | 'schedules' | 'code' | 'metrics';
@@ -65,6 +66,14 @@ export function defaultSessionTimeRange(now = Date.now()): SessionTimeRange {
};
}
+export function defaultMetricsTimeRange(now = Date.now()): SessionTimeRange {
+ return {
+ startTs: now - DEFAULT_METRICS_TIME_WINDOW_MS,
+ endTs: now,
+ timeWindowMs: DEFAULT_METRICS_TIME_WINDOW_MS,
+ };
+}
+
export function sessionTimeRangeFromCreatedAt(createdAt: string): SessionTimeRange | null {
const createdAtMs = new Date(createdAt).getTime();
if (Number.isNaN(createdAtMs)) return null;
diff --git a/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx b/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx
index 150eddc0a..8d7f31bd8 100644
--- a/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx
+++ b/packages/trueforge-ui/test/atoms/AgentDetailsPage.test.tsx
@@ -256,6 +256,53 @@ describe('AgentDetailsPage', () => {
expect(new URL(window.location.href).searchParams.get('tab')).toBe('metrics');
});
+ it('shows the metrics time range at the end of the active tab row and reloads metrics', async () => {
+ const getMeters = vi.fn(async () => []);
+ renderPage({
+ metrics: {
+ getCharts: vi.fn(async () => []),
+ getMeters,
+ getChartData: vi.fn(async () => ({ step: '3600', graphs: [] })),
+ },
+ overrides: {
+ AgentMetricsTimeRangeFilter: ({ onTimeRangeChange }) => (
+ <button
+ type="button"
+ onClick={() =>
+ onTimeRangeChange({
+ startTs: Date.parse('2026-08-20T00:00:00.000Z'),
+ endTs: Date.parse('2026-08-21T00:00:00.000Z'),
+ })
+ }
+ >
+ Set metrics range
+ </button>
+ ),
+ },
+ });
+
+ expect(screen.queryByRole('button', { name: 'Set metrics range' })).not.toBeInTheDocument();
+ fireEvent.click(await screen.findByRole('tab', { name: 'Metrics' }));
+
+ const filter = screen.getByRole('button', { name: 'Set metrics range' });
+ const tablist = screen.getByRole('tablist', { name: 'Agent details' });
+ expect(tablist).not.toContainElement(filter);
+ expect(tablist.parentElement).toContainElement(filter);
+ expect(filter.parentElement).toHaveClass('ml-auto');
+
+ fireEvent.click(filter);
+ await waitFor(() =>
+ expect(getMeters).toHaveBeenLastCalledWith({
+ agentId: 'agent-1',
+ startTimestamp: '2026-08-20T00:00:00.000Z',
+ endTimestamp: '2026-08-21T00:00:00.000Z',
+ }),
+ );
+
+ fireEvent.click(screen.getByRole('tab', { name: 'Overview' }));
+ expect(screen.queryByRole('button', { name: 'Set metrics range' })).not.toBeInTheDocument();
+ });
+
it('honors tab=metrics when the metrics port is available', async () => {
window.history.replaceState(null, '', '/library/agent-1?tab=metrics');
renderPage({