The open-source agent harness - the runtime layer that turns an LLM into a working agent.
chore: sandbox environments ui changes (#960)
harshil-2096ef9b204a29d2
diff --git a/.changeset/environments-ui-polish.md b/.changeset/environments-ui-polish.mdnew file mode 100644index 000000000..d2b6e6eb0--- /dev/null+++ b/.changeset/environments-ui-polish.md@@ -0,0 +1,5 @@+---+'@truefoundry/trueforge-ui': patch+---++Polish Environments UI: hyphen for default Updated, Building status label, form-only create drawer, secrets docs link and allowed-hosts copy, hide Manage Environments when sandbox is off.diff --git a/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx b/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsxindex 0f9c7baf0..915836a06 100644--- a/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx+++ b/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx@@ -251,7 +251,7 @@ export function AgentRuntimeConfigFields({<p className="text-text-secondary mt-0.5 text-xs leading-snug">Image, resources, network and secrets the sandbox starts with. Stored by name.</p>- {shell ? (+ {shell && sandboxEnabled ? (<buttontype="button"onClick={() => shell.setEnvironmentsOpen(true)}diff --git a/packages/trueforge-ui/src/atoms/environments/EnvironmentFormDrawer.tsx b/packages/trueforge-ui/src/atoms/environments/EnvironmentFormDrawer.tsxindex 1511b0b24..5a5a120e0 100644--- a/packages/trueforge-ui/src/atoms/environments/EnvironmentFormDrawer.tsx+++ b/packages/trueforge-ui/src/atoms/environments/EnvironmentFormDrawer.tsx@@ -143,35 +143,41 @@ export function EnvironmentFormDrawer({ open, onOpenChange, mode, environment, oopen={open}onOpenChange={onOpenChange}title={title}- description="Configure the environment as a form or edit its manifest directly."+ description={+ mode === 'create'+ ? 'Configure the environment.'+ : 'Configure the environment as a form or edit its manifest directly.'+ }size="xl"headerActions={- <div className="inline-flex shrink-0 rounded-md bg-secondary-bg p-0.5 border border-border">- <button- type="button"- className={cn(- 'rounded-sm px-2.5 py-1 text-xs font-medium transition-colors',- editorMode === 'form'- ? 'bg-primary-bg text-text-primary shadow-xs'- : 'text-text-secondary hover:text-text-primary',- )}- onClick={() => requestSwitch('form')}- >- UI Form- </button>- <button- type="button"- className={cn(- 'rounded-sm px-2.5 py-1 text-xs font-medium transition-colors',- editorMode === 'yaml'- ? 'bg-primary-bg text-text-primary shadow-xs'- : 'text-text-secondary hover:text-text-primary',- )}- onClick={() => requestSwitch('yaml')}- >- YAML- </button>- </div>+ mode === 'edit' ? (+ <div className="inline-flex shrink-0 rounded-md bg-secondary-bg p-0.5 border border-border">+ <button+ type="button"+ className={cn(+ 'rounded-sm px-2.5 py-1 text-xs font-medium transition-colors',+ editorMode === 'form'+ ? 'bg-primary-bg text-text-primary shadow-xs'+ : 'text-text-secondary hover:text-text-primary',+ )}+ onClick={() => requestSwitch('form')}+ >+ UI Form+ </button>+ <button+ type="button"+ className={cn(+ 'rounded-sm px-2.5 py-1 text-xs font-medium transition-colors',+ editorMode === 'yaml'+ ? 'bg-primary-bg text-text-primary shadow-xs'+ : 'text-text-secondary hover:text-text-primary',+ )}+ onClick={() => requestSwitch('yaml')}+ >+ YAML+ </button>+ </div>+ ) : undefined}footer={<div className="flex justify-end gap-2">diff --git a/packages/trueforge-ui/src/atoms/environments/EnvironmentFormFields.tsx b/packages/trueforge-ui/src/atoms/environments/EnvironmentFormFields.tsxindex 0f5b32f8a..65ed9e9e6 100644--- a/packages/trueforge-ui/src/atoms/environments/EnvironmentFormFields.tsx+++ b/packages/trueforge-ui/src/atoms/environments/EnvironmentFormFields.tsx@@ -277,7 +277,18 @@ export function EnvironmentFormFields({<div className="flex items-center justify-between"><div className="flex flex-col"><h3 className="text-sm font-medium text-text-primary">Secrets</h3>- <span className="text-xs text-text-secondary">Synced immediately with existing sandboxes</span>+ <span className="text-xs text-text-secondary">+ Synced immediately with existing sandboxes.{' '}+ <a+ href="https://trueforge.dev/introduction"+ target="_blank"+ rel="noreferrer"+ className="text-primary-button-bg inline-flex items-center gap-1 hover:underline"+ >+ Learn more+ <Icon name="external-link" className="size-3" />+ </a>+ </span></div><buttontype="button"@@ -324,16 +335,19 @@ export function EnvironmentFormFields({<Icon name="trash" className="size-3.5 text-failure-bg" /></button></div>- <input- className={fieldClassName}- value={secret.hosts.join(',')}- placeholder="Allowed hosts (comma-separated)"- onChange={event => {- const hosts = event.target.value.split(',').map(part => part.trim());- const secrets = values.secrets.map((row, i) => (i === index ? { ...row, hosts } : row));- update({ secrets });- }}- />+ <div className="flex flex-col gap-1">+ <input+ className={fieldClassName}+ value={secret.hosts.join(',')}+ placeholder="api.github.com,api.openai.com"+ onChange={event => {+ const hosts = event.target.value.split(',').map(part => part.trim());+ const secrets = values.secrets.map((row, i) => (i === index ? { ...row, hosts } : row));+ update({ secrets });+ }}+ />+ <span className="text-xs text-text-secondary">Hosts allowed to resolve secret (comma-separated).</span>+ </div></div>))}</div>diff --git a/packages/trueforge-ui/src/atoms/environments/EnvironmentStatusBadge.tsx b/packages/trueforge-ui/src/atoms/environments/EnvironmentStatusBadge.tsxindex 34bc95e8e..0f3155d5e 100644--- a/packages/trueforge-ui/src/atoms/environments/EnvironmentStatusBadge.tsx+++ b/packages/trueforge-ui/src/atoms/environments/EnvironmentStatusBadge.tsx@@ -3,7 +3,7 @@ import { Badge, type BadgeVariant } from '../primitives/Badge.js';import { Tooltip } from '../primitives/Tooltip.js';const STATUS_CONFIG: Record<SandboxEnvironmentStatus, { label: string; variant: BadgeVariant }> = {- pending: { label: 'Pending', variant: 'info' },+ pending: { label: 'Building', variant: 'info' },ready: { label: 'Ready', variant: 'success' },failed: { label: 'Failed', variant: 'destructive' },};diff --git a/packages/trueforge-ui/src/atoms/environments/EnvironmentsPage.tsx b/packages/trueforge-ui/src/atoms/environments/EnvironmentsPage.tsxindex 3ebb8b041..de5475e02 100644--- a/packages/trueforge-ui/src/atoms/environments/EnvironmentsPage.tsx+++ b/packages/trueforge-ui/src/atoms/environments/EnvironmentsPage.tsx@@ -294,7 +294,9 @@ export function EnvironmentsPage(_props: EnvironmentsPageProps) {<TableCell className="text-sm text-text-secondary">{formatNetworkingSummary(env.manifest.networking)}</TableCell>- <TableCell className="text-sm text-text-secondary">{formatRelativeTime(env.updatedAt)}</TableCell>+ <TableCell className="text-sm text-text-secondary">+ {readOnly ? '—' : formatRelativeTime(env.updatedAt)}+ </TableCell><TableCell>{!readOnly ? (<buttondiff --git a/packages/trueforge-ui/test/atoms/draft/AgentRuntimeConfigFields.test.tsx b/packages/trueforge-ui/test/atoms/draft/AgentRuntimeConfigFields.test.tsxindex 0eee126f4..d7e62c1cb 100644--- a/packages/trueforge-ui/test/atoms/draft/AgentRuntimeConfigFields.test.tsx+++ b/packages/trueforge-ui/test/atoms/draft/AgentRuntimeConfigFields.test.tsx@@ -105,6 +105,13 @@ describe('AgentRuntimeConfigFields', () => {expect(setEnvironmentsOpen).toHaveBeenCalledWith(true);});+ it('hides Manage Environments link when sandbox is off', () => {+ renderRuntimeFields({ value: { sandbox: { enabled: false } } });++ expect(screen.getByText('Environment')).toBeInTheDocument();+ expect(screen.queryByRole('button', { name: /Manage Environments/ })).not.toBeInTheDocument();+ });+it('populates environment dropdown with default and ready environments only', async () => {const onChange = vi.fn();renderRuntimeFields({ onChange });diff --git a/packages/trueforge-ui/test/atoms/environments/EnvironmentFormDrawer.test.tsx b/packages/trueforge-ui/test/atoms/environments/EnvironmentFormDrawer.test.tsxindex dbecd4893..77664c3c8 100644--- a/packages/trueforge-ui/test/atoms/environments/EnvironmentFormDrawer.test.tsx+++ b/packages/trueforge-ui/test/atoms/environments/EnvironmentFormDrawer.test.tsx@@ -5,7 +5,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';import { EnvironmentFormDrawer } from '@/atoms/environments/EnvironmentFormDrawer.js';import { ToasterProvider } from '@/containers/ToasterContainer.js';import { ServerProvider } from '@/server/ServerContext.js';-import type { SandboxEnvironmentServer } from '@/server/types.js';+import type { SandboxEnvironment, SandboxEnvironmentServer } from '@/server/types.js';import { createMockAgentUIServer, createMockSandboxEnvironmentServer } from '../../server/mockServer.js';const originalShowModal = Object.getOwnPropertyDescriptor(HTMLDialogElement.prototype, 'showModal');@@ -40,10 +40,30 @@ afterEach(() => {}});+const editEnvironment: SandboxEnvironment = {+ id: 'e1',+ name: 'node-web',+ description: '',+ status: 'ready',+ statusReason: null,+ manifest: { name: 'node-web', description: '' },+ createdBySubject: {+ subjectId: 'user-1',+ subjectType: 'user',+ subjectDisplayName: 'alice',+ },+ createdAt: '2024-01-01T00:00:00.000Z',+ updatedAt: '2024-01-01T00:00:00.000Z',+};+function renderDrawer({+ mode = 'create',+ environment,environmentOverrides = {},onSaved = vi.fn(),}: {+ mode?: 'create' | 'edit';+ environment?: SandboxEnvironment;environmentOverrides?: Partial<SandboxEnvironmentServer>;onSaved?: () => void;} = {}) {@@ -72,7 +92,13 @@ function renderDrawer({render(<ServerProvider server={server}><ToasterProvider>- <EnvironmentFormDrawer open mode="create" onOpenChange={onOpenChange} onSaved={onSaved} />+ <EnvironmentFormDrawer+ open+ mode={mode}+ environment={environment}+ onOpenChange={onOpenChange}+ onSaved={onSaved}+ /></ToasterProvider></ServerProvider>,);@@ -83,6 +109,7 @@ function renderDrawer({describe('EnvironmentFormDrawer', () => {it('saves UI form values', async () => {const { createOrUpdateEnvironment, onSaved } = renderDrawer();+ expect(screen.queryByRole('button', { name: 'YAML' })).not.toBeInTheDocument();const nameInput = screen.getByPlaceholderText('my-environment');fireEvent.change(nameInput, { target: { value: 'node-web' } });fireEvent.click(screen.getByRole('button', { name: 'Create' }));@@ -93,14 +120,16 @@ describe('EnvironmentFormDrawer', () => {expect(onSaved).toHaveBeenCalled();});- it('confirms when switching modes while dirty', async () => {- renderDrawer();- fireEvent.change(screen.getByPlaceholderText('my-environment'), { target: { value: 'dirty-env' } });+ it('confirms when switching modes while dirty in edit', async () => {+ renderDrawer({ mode: 'edit', environment: editEnvironment });+ fireEvent.change(screen.getByPlaceholderText('write description ...'), {+ target: { value: 'dirty description' },+ });fireEvent.click(screen.getByRole('button', { name: 'YAML' }));expect(await screen.findByRole('button', { name: 'Yes' })).toBeInTheDocument();fireEvent.click(screen.getByRole('button', { name: 'Yes' }));await waitFor(() => {- expect(screen.queryByPlaceholderText('my-environment')).not.toBeInTheDocument();+ expect(screen.queryByPlaceholderText('write description ...')).not.toBeInTheDocument();});expect(screen.queryByRole('button', { name: 'Yes' })).not.toBeInTheDocument();});