Find, verify, and analyze leaked credentials
Go credentialsdevsecopsdynamic-analysisprecommitscanningsecretsecret-managementsecretssecuritysecurity-toolstrufflehogverification
always close aws response body (#1758)
Cody Rose2c32b14df1ba
diff --git a/pkg/detectors/aws/aws.go b/pkg/detectors/aws/aws.goindex fa6702e07..ab0a3a93a 100644--- a/pkg/detectors/aws/aws.go+++ b/pkg/detectors/aws/aws.go@@ -208,11 +208,10 @@ func (s scanner) verifyMatch(ctx context.Context, resIDMatch, resSecretMatch strres, err := client.Do(req)if err == nil {-+ defer res.Body.Close()if res.StatusCode >= 200 && res.StatusCode < 300 {identityInfo := identityRes{}err := json.NewDecoder(res.Body).Decode(&identityInfo)- res.Body.Close()if err == nil {extraData := map[string]string{"account": identityInfo.GetCallerIdentityResponse.GetCallerIdentityResult.Account,@@ -244,7 +243,6 @@ func (s scanner) verifyMatch(ctx context.Context, resIDMatch, resSecretMatch str}var body awsErrorResponseBodyerr = json.NewDecoder(res.Body).Decode(&body)- res.Body.Close()if err == nil {// All instances of the code I've seen in the wild are PascalCased but this check is// case-insensitive out of an abundance of caution