Skip to content

Find, verify, and analyze leaked credentials

fix: add missing error check in archive handler (#1770)

martinohmann31d17c4f930f
diff --git a/pkg/handlers/archive.go b/pkg/handlers/archive.go
index 629be3c6d..d46016656 100644
--- a/pkg/handlers/archive.go
+++ b/pkg/handlers/archive.go
@@ -102,6 +102,10 @@ func (a *Archive) openArchive(ctx context.Context, depth int, reader io.Reader,
return a.handleNonArchiveContent(ctx, arReader, archiveChan)
}
+ if err != nil {
+ return err
+ }
+
switch archive := format.(type) {
case archiver.Decompressor:
info := decompressorInfo{depth: depth, reader: arReader, archiveChan: archiveChan, archiver: archive}
diff --git a/pkg/handlers/archive_test.go b/pkg/handlers/archive_test.go
index c6fbcf90c..f70eab293 100644
--- a/pkg/handlers/archive_test.go
+++ b/pkg/handlers/archive_test.go
@@ -236,3 +236,15 @@ func TestExtractRPMContent(t *testing.T) {
expectedLength := 1822720
assert.Equal(t, expectedLength, len(string(content)))
}
+
+func TestOpenInvalidArchive(t *testing.T) {
+ reader := strings.NewReader("invalid archive")
+
+ ctx := logContext.AddLogger(context.Background())
+ a := &Archive{}
+
+ archiveChan := make(chan []byte)
+
+ err := a.openArchive(ctx, 0, reader, archiveChan)
+ assert.Error(t, err)
+}