Skip to content

Find, verify, and analyze leaked credentials

add line to link for azure repos. (#1801)

ahrav6affc903e1dc
diff --git a/pkg/engine/engine.go b/pkg/engine/engine.go
index 19bb8a00d..aae5e4536 100644
--- a/pkg/engine/engine.go
+++ b/pkg/engine/engine.go
@@ -605,7 +605,8 @@ func SupportsLineNumbers(sourceType sourcespb.SourceType) bool {
sourcespb.SourceType_SOURCE_TYPE_GERRIT,
sourcespb.SourceType_SOURCE_TYPE_GITHUB_UNAUTHENTICATED_ORG,
sourcespb.SourceType_SOURCE_TYPE_PUBLIC_GIT,
- sourcespb.SourceType_SOURCE_TYPE_FILESYSTEM:
+ sourcespb.SourceType_SOURCE_TYPE_FILESYSTEM,
+ sourcespb.SourceType_SOURCE_TYPE_AZURE_REPOS:
return true
default:
return false
@@ -662,6 +663,9 @@ func FragmentFirstLineAndLink(chunk *sources.Chunk) (int64, *int64, string) {
case *source_metadatapb.MetaData_Filesystem:
fragmentStart = &metadata.Filesystem.Line
link = metadata.Filesystem.Link
+ case *source_metadatapb.MetaData_AzureRepos:
+ fragmentStart = &metadata.AzureRepos.Line
+ link = metadata.AzureRepos.Link
default:
return 0, nil, ""
}
@@ -697,6 +701,8 @@ func UpdateLink(ctx context.Context, metadata *source_metadatapb.MetaData, link
meta.Bitbucket.Link = newLink
case *source_metadatapb.MetaData_Filesystem:
meta.Filesystem.Link = newLink
+ case *source_metadatapb.MetaData_AzureRepos:
+ meta.AzureRepos.Link = newLink
default:
return fmt.Errorf("unsupported metadata type")
}
diff --git a/pkg/engine/engine_test.go b/pkg/engine/engine_test.go
index 78b80181d..4e9b2eda5 100644
--- a/pkg/engine/engine_test.go
+++ b/pkg/engine/engine_test.go
@@ -152,21 +152,27 @@ func TestDefaultDecoders(t *testing.T) {
}
func TestSupportsLineNumbers(t *testing.T) {
- testCases := []struct {
- name string
- input sourcespb.SourceType
- expected bool
+ tests := []struct {
+ name string
+ sourceType sourcespb.SourceType
+ expectedValue bool
}{
- {"Git source type", sourcespb.SourceType_SOURCE_TYPE_GIT, true},
- {"Github source type", sourcespb.SourceType_SOURCE_TYPE_GITHUB, true},
- {"Gitlab source type", sourcespb.SourceType_SOURCE_TYPE_GITLAB, true},
+ {"Git source", sourcespb.SourceType_SOURCE_TYPE_GIT, true},
+ {"Github source", sourcespb.SourceType_SOURCE_TYPE_GITHUB, true},
+ {"Gitlab source", sourcespb.SourceType_SOURCE_TYPE_GITLAB, true},
+ {"Bitbucket source", sourcespb.SourceType_SOURCE_TYPE_BITBUCKET, true},
+ {"Gerrit source", sourcespb.SourceType_SOURCE_TYPE_GERRIT, true},
+ {"Github unauthenticated org source", sourcespb.SourceType_SOURCE_TYPE_GITHUB_UNAUTHENTICATED_ORG, true},
+ {"Public Git source", sourcespb.SourceType_SOURCE_TYPE_PUBLIC_GIT, true},
+ {"Filesystem source", sourcespb.SourceType_SOURCE_TYPE_FILESYSTEM, true},
+ {"Azure Repos source", sourcespb.SourceType_SOURCE_TYPE_AZURE_REPOS, true},
+ {"Unsupported type", sourcespb.SourceType_SOURCE_TYPE_BUILDKITE, false},
}
- for _, tc := range testCases {
- t.Run(tc.name, func(t *testing.T) {
- if result := SupportsLineNumbers(tc.input); result != tc.expected {
- t.Errorf("Expected %v for input %v, got %v", tc.expected, tc.input, result)
- }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ result := SupportsLineNumbers(tt.sourceType)
+ assert.Equal(t, tt.expectedValue, result)
})
}
}
@@ -243,6 +249,21 @@ func TestFragmentFirstLineAndLink(t *testing.T) {
expectedLine: 5,
expectedLink: "https://example.github.com",
},
+ {
+ name: "Test Azure Repos Metadata",
+ chunk: &sources.Chunk{
+ SourceMetadata: &source_metadatapb.MetaData{
+ Data: &source_metadatapb.MetaData_AzureRepos{
+ AzureRepos: &source_metadatapb.AzureRepos{
+ Line: 5,
+ Link: "https://example.azure.com",
+ },
+ },
+ },
+ },
+ expectedLine: 5,
+ expectedLink: "https://example.azure.com",
+ },
{
name: "Unsupported Type",
chunk: &sources.Chunk{},
@@ -317,6 +338,17 @@ func TestSetLink(t *testing.T) {
line: 3,
wantLink: "file:///path/to/example#L3",
},
+ {
+ name: "Azure Repos link set",
+ input: &source_metadatapb.MetaData{
+ Data: &source_metadatapb.MetaData_AzureRepos{
+ AzureRepos: &source_metadatapb.AzureRepos{},
+ },
+ },
+ link: "https://dev.azure.com/example",
+ line: 3,
+ wantLink: "https://dev.azure.com/example?line=3",
+ },
{
name: "Unsupported metadata type",
input: &source_metadatapb.MetaData{
@@ -359,6 +391,8 @@ func TestSetLink(t *testing.T) {
assert.Equal(t, tt.wantLink, data.Bitbucket.Link, "Bitbucket link mismatch")
case *source_metadatapb.MetaData_Filesystem:
assert.Equal(t, tt.wantLink, data.Filesystem.Link, "Filesystem link mismatch")
+ case *source_metadatapb.MetaData_AzureRepos:
+ assert.Equal(t, tt.wantLink, data.AzureRepos.Link, "Azure Repos link mismatch")
}
})
}