Skip to content

Find, verify, and analyze leaked credentials

[chore] - Update loop to switch. (#1487)

ahrava9213a11039f
diff --git a/pkg/engine/engine.go b/pkg/engine/engine.go
index d01ccde8c..9c95ba745 100644
--- a/pkg/engine/engine.go
+++ b/pkg/engine/engine.go
@@ -378,29 +378,21 @@ func (e *Engine) detectorWorker(ctx context.Context) {
}
}
-// lineNumberSupportedSources is a list of sources that support line numbers.
-// It is stored this way because slice consts are not supported.
-func lineNumberSupportedSources() []sourcespb.SourceType {
- return []sourcespb.SourceType{
- sourcespb.SourceType_SOURCE_TYPE_GIT,
+// SupportsLineNumbers determines if a line number can be found for a source type.
+func SupportsLineNumbers(sourceType sourcespb.SourceType) bool {
+ switch sourceType {
+ case sourcespb.SourceType_SOURCE_TYPE_GIT,
sourcespb.SourceType_SOURCE_TYPE_GITHUB,
sourcespb.SourceType_SOURCE_TYPE_GITLAB,
sourcespb.SourceType_SOURCE_TYPE_BITBUCKET,
sourcespb.SourceType_SOURCE_TYPE_GERRIT,
sourcespb.SourceType_SOURCE_TYPE_GITHUB_UNAUTHENTICATED_ORG,
sourcespb.SourceType_SOURCE_TYPE_PUBLIC_GIT,
- sourcespb.SourceType_SOURCE_TYPE_FILESYSTEM,
- }
-}
-
-// SupportsLineNumbers determines if a line number can be found for a source type.
-func SupportsLineNumbers(sourceType sourcespb.SourceType) bool {
- for _, i := range lineNumberSupportedSources() {
- if i == sourceType {
- return true
- }
+ sourcespb.SourceType_SOURCE_TYPE_FILESYSTEM:
+ return true
+ default:
+ return false
}
- return false
}
// FragmentLineOffset sets the line number for a provided source chunk with a given detector result.
diff --git a/pkg/engine/engine_test.go b/pkg/engine/engine_test.go
index 34924cdc4..e6a0a5b8a 100644
--- a/pkg/engine/engine_test.go
+++ b/pkg/engine/engine_test.go
@@ -5,6 +5,7 @@ import (
"github.com/trufflesecurity/trufflehog/v3/pkg/decoders"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
+ "github.com/trufflesecurity/trufflehog/v3/pkg/pb/sourcespb"
"github.com/trufflesecurity/trufflehog/v3/pkg/sources"
)
@@ -72,3 +73,30 @@ func TestDefaultDecoders(t *testing.T) {
t.Errorf("DefaultDecoders() = %v, expected UTF8 decoder to be first", ds)
}
}
+
+func TestSupportsLineNumbers(t *testing.T) {
+ testCases := []struct {
+ name string
+ input sourcespb.SourceType
+ expected bool
+ }{
+ {"Git source type", sourcespb.SourceType_SOURCE_TYPE_GIT, true},
+ {"Github source type", sourcespb.SourceType_SOURCE_TYPE_GITHUB, true},
+ {"Gitlab source type", sourcespb.SourceType_SOURCE_TYPE_GITLAB, true},
+ }
+
+ for _, tc := range testCases {
+ t.Run(tc.name, func(t *testing.T) {
+ if result := SupportsLineNumbers(tc.input); result != tc.expected {
+ t.Errorf("Expected %v for input %v, got %v", tc.expected, tc.input, result)
+ }
+ })
+ }
+}
+
+func BenchmarkSupportsLineNumbersLoop(b *testing.B) {
+ sourceType := sourcespb.SourceType_SOURCE_TYPE_GITHUB
+ for i := 0; i < b.N; i++ {
+ _ = SupportsLineNumbers(sourceType)
+ }
+}