Skip to content

Find, verify, and analyze leaked credentials

[INS-307] Added unspecified(0.0.0.0) check to DetectorHttpClientWithNoLocalAddresses (#4726)

Muneeb Ullah Khanef3bf34ddc7f
diff --git a/pkg/detectors/http.go b/pkg/detectors/http.go
index 43ad5052c..28f121e32 100644
--- a/pkg/detectors/http.go
+++ b/pkg/detectors/http.go
@@ -94,7 +94,7 @@ func NewDetectorTransport(T http.RoundTripper) http.RoundTripper {
}
func isLocalIP(ip net.IP) bool {
- if ip.IsLoopback() || ip.IsLinkLocalUnicast() || ip.IsLinkLocalMulticast() || ip.IsPrivate() {
+ if ip.IsLoopback() || ip.IsLinkLocalUnicast() || ip.IsLinkLocalMulticast() || ip.IsPrivate() || ip.IsUnspecified() {
return true
}
diff --git a/pkg/detectors/http_test.go b/pkg/detectors/http_test.go
index bbe6b9dfe..7210a837f 100644
--- a/pkg/detectors/http_test.go
+++ b/pkg/detectors/http_test.go
@@ -22,6 +22,30 @@ func TestWithNoLocalIP(t *testing.T) {
assert.ErrorIs(t, err, ErrNoLocalIP)
})
+ t.Run("Prevents dialing wildcard IP", func(t *testing.T) {
+ client := &http.Client{}
+ WithNoLocalIP()(client)
+
+ transport, ok := client.Transport.(*http.Transport)
+ assert.True(t, ok, "Expected transport to be *http.Transport")
+
+ _, err := transport.DialContext(context.Background(), "tcp", "0.0.0.0:8080")
+ assert.Error(t, err)
+ assert.ErrorIs(t, err, ErrNoLocalIP)
+ })
+
+ t.Run("Prevents dialing IPv6 wildcard IP", func(t *testing.T) {
+ client := &http.Client{}
+ WithNoLocalIP()(client)
+
+ transport, ok := client.Transport.(*http.Transport)
+ assert.True(t, ok, "Expected transport to be *http.Transport")
+
+ _, err := transport.DialContext(context.Background(), "tcp", "[::]:8080")
+ assert.Error(t, err)
+ assert.ErrorIs(t, err, ErrNoLocalIP)
+ })
+
t.Run("Allows dialing non-local host", func(t *testing.T) {
client := &http.Client{}
WithNoLocalIP()(client)
@@ -81,6 +105,8 @@ func TestIsLocalIP(t *testing.T) {
{"Loopback IPv6", net.ParseIP("::1"), true},
{"Private IPv4", net.ParseIP("192.168.1.1"), true},
{"Private IPv6", net.ParseIP("fd00::1"), true},
+ {"Unspecified IPv4", net.ParseIP("0.0.0.0"), true},
+ {"Unspecified IPv6", net.ParseIP("::"), true},
{"Public IPv4", net.ParseIP("8.8.8.8"), false},
{"Public IPv6", net.ParseIP("2001:4860:4860::8888"), false},
}