Skip to content

The open alternative to Salesforce, designed for AI.

Require a user session to change application registration ownership (#26684)

Paul Rastoin07e34cde98a3
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration.resolver.ts b/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration.resolver.ts
index c20198f281b..edead16ed63 100644
--- a/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration.resolver.ts
+++ b/packages/twenty-server/src/engine/core-modules/application/application-registration/application-registration.resolver.ts
@@ -53,7 +53,9 @@ import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorat
import { AdminPanelGuard } from 'src/engine/guards/admin-panel-guard';
import { NoPermissionGuard } from 'src/engine/guards/no-permission.guard';
import { PublicEndpointGuard } from 'src/engine/guards/public-endpoint.guard';
+import { RequireUserSessionGuard } from 'src/engine/guards/require-user-session.guard';
import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.guard';
+import { UserAuthGuard } from 'src/engine/guards/user-auth.guard';
import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
import { StreamSizeExceededError } from 'src/utils/stream-size-exceeded-error';
@@ -393,6 +395,8 @@ export class ApplicationRegistrationResolver {
@UseGuards(
WorkspaceAuthGuard,
+ UserAuthGuard,
+ RequireUserSessionGuard,
AdminPanelGuard,
SettingsPermissionGuard(PermissionFlagType.APPLICATIONS),
)
@@ -438,6 +442,8 @@ export class ApplicationRegistrationResolver {
@UseGuards(
WorkspaceAuthGuard,
+ UserAuthGuard,
+ RequireUserSessionGuard,
SettingsPermissionGuard(PermissionFlagType.APPLICATIONS),
)
@Mutation(() => ApplicationRegistrationEntity)
diff --git a/packages/twenty-server/test/integration/metadata/suites/application-registration/__snapshots__/failing-application-registration-ownership-change.integration-spec.ts.snap b/packages/twenty-server/test/integration/metadata/suites/application-registration/__snapshots__/failing-application-registration-ownership-change.integration-spec.ts.snap
new file mode 100644
index 00000000000..bea979b7760
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application-registration/__snapshots__/failing-application-registration-ownership-change.integration-spec.ts.snap
@@ -0,0 +1,65 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Application registration ownership change without a user session should fail with a user-bound application token should refuse claimApplicationRegistrationOwnership and keep the owner 1`] = `
+{
+ "extensions": {
+ "code": "FORBIDDEN",
+ "subCode": "FORBIDDEN_EXCEPTION",
+ "userFriendlyMessage": "You do not have permission to perform this action.",
+ },
+ "message": "This endpoint requires a user session",
+ "name": "ForbiddenError",
+}
+`;
+
+exports[`Application registration ownership change without a user session should fail with a user-bound application token should refuse transferApplicationRegistrationOwnership and keep the owner 1`] = `
+{
+ "extensions": {
+ "code": "FORBIDDEN",
+ "subCode": "FORBIDDEN_EXCEPTION",
+ "userFriendlyMessage": "You do not have permission to perform this action.",
+ },
+ "message": "This endpoint requires a user session",
+ "name": "ForbiddenError",
+}
+`;
+
+exports[`Application registration ownership change without a user session should fail with an API key should refuse claimApplicationRegistrationOwnership and keep the owner 1`] = `
+{
+ "extensions": {
+ "code": "FORBIDDEN",
+ "userFriendlyMessage": "An error occurred.",
+ },
+ "message": "Forbidden resource",
+}
+`;
+
+exports[`Application registration ownership change without a user session should fail with an API key should refuse transferApplicationRegistrationOwnership and keep the owner 1`] = `
+{
+ "extensions": {
+ "code": "FORBIDDEN",
+ "userFriendlyMessage": "An error occurred.",
+ },
+ "message": "Forbidden resource",
+}
+`;
+
+exports[`Application registration ownership change without a user session should fail with an application token without user binding should refuse claimApplicationRegistrationOwnership and keep the owner 1`] = `
+{
+ "extensions": {
+ "code": "FORBIDDEN",
+ "userFriendlyMessage": "An error occurred.",
+ },
+ "message": "Forbidden resource",
+}
+`;
+
+exports[`Application registration ownership change without a user session should fail with an application token without user binding should refuse transferApplicationRegistrationOwnership and keep the owner 1`] = `
+{
+ "extensions": {
+ "code": "FORBIDDEN",
+ "userFriendlyMessage": "An error occurred.",
+ },
+ "message": "Forbidden resource",
+}
+`;
diff --git a/packages/twenty-server/test/integration/metadata/suites/application-registration/failing-application-registration-ownership-change.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/application-registration/failing-application-registration-ownership-change.integration-spec.ts
new file mode 100644
index 00000000000..ed04a7546fe
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application-registration/failing-application-registration-ownership-change.integration-spec.ts
@@ -0,0 +1,166 @@
+import { randomUUID } from 'crypto';
+
+import { claimApplicationRegistrationOwnership } from 'test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership.util';
+import { transferApplicationRegistrationOwnership } from 'test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership.util';
+import { cleanupApplicationAndAppRegistration } from 'test/integration/metadata/suites/application/utils/cleanup-application-and-app-registration.util';
+import { insertCatalogApplicationRegistration } from 'test/integration/metadata/suites/application/utils/insert-catalog-application-registration.util';
+import {
+ type ApplicationWithResources,
+ setupApplicationWithResources,
+} from 'test/integration/metadata/suites/application/utils/setup-application-with-resources.util';
+import { expectOneNotInternalServerErrorSnapshot } from 'test/integration/graphql/utils/expect-one-not-internal-server-error-snapshot.util';
+import { generateAppleAdminApplicationTokenPair } from 'test/integration/utils/generate-apple-admin-application-token-pair.util';
+import { generateApplicationTokenPair } from 'test/integration/utils/generate-application-token-pair.util';
+import {
+ type EachTestingContext,
+ eachTestingContextFilter,
+} from 'twenty-shared/testing';
+
+import { type BaseGraphQLError } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
+import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';
+
+type GlobalTestContext = {
+ callingApplication: ApplicationWithResources;
+ userBoundToken: string;
+ unboundToken: string;
+};
+
+type TokenTestContext = {
+ token: (globalContext: GlobalTestContext) => string;
+};
+
+type OwnershipChangeTestContext = {
+ initialOwnerWorkspaceId: string | null;
+ request: (params: {
+ applicationRegistrationId: string;
+ token: string;
+ }) => Promise<{ errors: BaseGraphQLError[] }>;
+};
+
+const tokenTestCases: EachTestingContext<TokenTestContext>[] = [
+ {
+ title: 'with a user-bound application token',
+ context: { token: (globalContext) => globalContext.userBoundToken },
+ },
+ {
+ title: 'with an application token without user binding',
+ context: { token: (globalContext) => globalContext.unboundToken },
+ },
+ {
+ title: 'with an API key',
+ context: { token: () => API_KEY_ACCESS_TOKEN },
+ },
+];
+
+const ownershipChangeTestCases: EachTestingContext<OwnershipChangeTestContext>[] =
+ [
+ {
+ title: 'transferApplicationRegistrationOwnership',
+ context: {
+ initialOwnerWorkspaceId: SEED_APPLE_WORKSPACE_ID,
+ request: ({ applicationRegistrationId, token }) =>
+ transferApplicationRegistrationOwnership({
+ input: {
+ applicationRegistrationId,
+ targetWorkspaceSubdomain: 'yc',
+ },
+ token,
+ expectToFail: true,
+ }),
+ },
+ },
+ {
+ title: 'claimApplicationRegistrationOwnership',
+ context: {
+ initialOwnerWorkspaceId: null,
+ request: ({ applicationRegistrationId, token }) =>
+ claimApplicationRegistrationOwnership({
+ input: { applicationRegistrationId },
+ token,
+ expectToFail: true,
+ }),
+ },
+ },
+ ];
+
+const findOwnerWorkspaceId = async (
+ applicationRegistrationId: string,
+): Promise<string | null> => {
+ const [row] = await globalThis.testDataSource.query(
+ `SELECT "workspaceId" FROM core."applicationRegistration" WHERE id = $1`,
+ [applicationRegistrationId],
+ );
+
+ return row.workspaceId;
+};
+
+describe('Application registration ownership change without a user session should fail', () => {
+ let globalTestContext: GlobalTestContext;
+ let targetRegistrationUniversalIdentifier: string;
+
+ beforeAll(async () => {
+ const callingApplication = await setupApplicationWithResources({
+ name: 'Ownership Change Calling Application',
+ });
+
+ const [userBoundTokenPair, unboundTokenPair] = await Promise.all([
+ generateAppleAdminApplicationTokenPair({
+ applicationId: callingApplication.id,
+ }),
+ generateApplicationTokenPair({
+ workspaceId: SEED_APPLE_WORKSPACE_ID,
+ applicationId: callingApplication.id,
+ }),
+ ]);
+
+ globalTestContext = {
+ callingApplication,
+ userBoundToken: userBoundTokenPair.applicationAccessToken.token,
+ unboundToken: unboundTokenPair.applicationAccessToken.token,
+ };
+ }, 120000);
+
+ afterEach(async () => {
+ await globalThis.testDataSource.query(
+ `DELETE FROM core."applicationRegistration" WHERE "universalIdentifier" = $1`,
+ [targetRegistrationUniversalIdentifier],
+ );
+ });
+
+ afterAll(async () => {
+ await cleanupApplicationAndAppRegistration({
+ applicationUniversalIdentifier:
+ globalTestContext.callingApplication.universalIdentifier,
+ });
+ });
+
+ describe.each(eachTestingContextFilter(tokenTestCases))(
+ '$title',
+ ({ context: tokenContext }) => {
+ it.each(eachTestingContextFilter(ownershipChangeTestCases))(
+ 'should refuse $title and keep the owner',
+ async ({ context }) => {
+ targetRegistrationUniversalIdentifier = randomUUID();
+
+ const applicationRegistrationId =
+ await insertCatalogApplicationRegistration({
+ universalIdentifier: targetRegistrationUniversalIdentifier,
+ name: 'Ownership Change Target',
+ sourcePackage: `ownership-change-target-${targetRegistrationUniversalIdentifier}`,
+ workspaceId: context.initialOwnerWorkspaceId,
+ });
+
+ const { errors } = await context.request({
+ applicationRegistrationId,
+ token: tokenContext.token(globalTestContext),
+ });
+
+ expectOneNotInternalServerErrorSnapshot({ errors });
+ expect(await findOwnerWorkspaceId(applicationRegistrationId)).toBe(
+ context.initialOwnerWorkspaceId,
+ );
+ },
+ );
+ },
+ );
+});
diff --git a/packages/twenty-server/test/integration/metadata/suites/application-registration/successful-application-registration-ownership-change.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/application-registration/successful-application-registration-ownership-change.integration-spec.ts
new file mode 100644
index 00000000000..fb222d53816
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application-registration/successful-application-registration-ownership-change.integration-spec.ts
@@ -0,0 +1,68 @@
+import { randomUUID } from 'crypto';
+
+import { claimApplicationRegistrationOwnership } from 'test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership.util';
+import { transferApplicationRegistrationOwnership } from 'test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership.util';
+import { insertCatalogApplicationRegistration } from 'test/integration/metadata/suites/application/utils/insert-catalog-application-registration.util';
+
+import {
+ SEED_APPLE_WORKSPACE_ID,
+ SEED_YCOMBINATOR_WORKSPACE_ID,
+} from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';
+
+describe('Application registration ownership change with a user session', () => {
+ let targetRegistrationUniversalIdentifier: string;
+
+ beforeEach(() => {
+ targetRegistrationUniversalIdentifier = randomUUID();
+ });
+
+ afterEach(async () => {
+ await globalThis.testDataSource.query(
+ `DELETE FROM core."applicationRegistration" WHERE "universalIdentifier" = $1`,
+ [targetRegistrationUniversalIdentifier],
+ );
+ });
+
+ it('should transfer a registration to another workspace', async () => {
+ const applicationRegistrationId =
+ await insertCatalogApplicationRegistration({
+ universalIdentifier: targetRegistrationUniversalIdentifier,
+ name: 'Ownership Change Target',
+ sourcePackage: `ownership-change-target-${targetRegistrationUniversalIdentifier}`,
+ workspaceId: SEED_APPLE_WORKSPACE_ID,
+ });
+
+ const { data } = await transferApplicationRegistrationOwnership({
+ input: {
+ applicationRegistrationId,
+ targetWorkspaceSubdomain: 'yc',
+ },
+ expectToFail: false,
+ });
+
+ expect(data.transferApplicationRegistrationOwnership).toEqual({
+ id: applicationRegistrationId,
+ ownerWorkspaceId: SEED_YCOMBINATOR_WORKSPACE_ID,
+ });
+ });
+
+ it('should claim a registration owned by no workspace', async () => {
+ const applicationRegistrationId =
+ await insertCatalogApplicationRegistration({
+ universalIdentifier: targetRegistrationUniversalIdentifier,
+ name: 'Ownership Change Target',
+ sourcePackage: `ownership-change-target-${targetRegistrationUniversalIdentifier}`,
+ workspaceId: null,
+ });
+
+ const { data } = await claimApplicationRegistrationOwnership({
+ input: { applicationRegistrationId },
+ expectToFail: false,
+ });
+
+ expect(data.claimApplicationRegistrationOwnership).toEqual({
+ id: applicationRegistrationId,
+ ownerWorkspaceId: SEED_APPLE_WORKSPACE_ID,
+ });
+ });
+});
diff --git a/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership-query-factory.util.ts b/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership-query-factory.util.ts
new file mode 100644
index 00000000000..59cf5b47a28
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership-query-factory.util.ts
@@ -0,0 +1,31 @@
+import gql from 'graphql-tag';
+import { type PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+
+export type ClaimApplicationRegistrationOwnershipFactoryInput = {
+ applicationRegistrationId: string;
+};
+
+const DEFAULT_CLAIM_APPLICATION_REGISTRATION_OWNERSHIP_GQL_FIELDS = `
+ id
+ ownerWorkspaceId
+`;
+
+export const claimApplicationRegistrationOwnershipQueryFactory = ({
+ input,
+ gqlFields = DEFAULT_CLAIM_APPLICATION_REGISTRATION_OWNERSHIP_GQL_FIELDS,
+}: PerformMetadataQueryParams<ClaimApplicationRegistrationOwnershipFactoryInput>) => ({
+ query: gql`
+ mutation ClaimApplicationRegistrationOwnership(
+ $applicationRegistrationId: String!
+ ) {
+ claimApplicationRegistrationOwnership(
+ applicationRegistrationId: $applicationRegistrationId
+ ) {
+ ${gqlFields}
+ }
+ }
+ `,
+ variables: {
+ applicationRegistrationId: input.applicationRegistrationId,
+ },
+});
diff --git a/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership.util.ts b/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership.util.ts
new file mode 100644
index 00000000000..c798aff188c
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership.util.ts
@@ -0,0 +1,45 @@
+import {
+ type ClaimApplicationRegistrationOwnershipFactoryInput,
+ claimApplicationRegistrationOwnershipQueryFactory,
+} from 'test/integration/metadata/suites/application-registration/utils/claim-application-registration-ownership-query-factory.util';
+import { makeMetadataApiRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
+import { type CommonResponseBody } from 'test/integration/metadata/types/common-response-body.type';
+import { type PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+import { warnIfErrorButNotExpectedToFail } from 'test/integration/metadata/utils/warn-if-error-but-not-expected-to-fail.util';
+import { warnIfNoErrorButExpectedToFail } from 'test/integration/metadata/utils/warn-if-no-error-but-expected-to-fail.util';
+
+import { type ApplicationRegistrationEntity } from 'src/engine/core-modules/application/application-registration/application-registration.entity';
+
+export const claimApplicationRegistrationOwnership = async ({
+ input,
+ gqlFields,
+ expectToFail = false,
+ token,
+}: PerformMetadataQueryParams<ClaimApplicationRegistrationOwnershipFactoryInput>): CommonResponseBody<{
+ claimApplicationRegistrationOwnership: ApplicationRegistrationEntity;
+}> => {
+ const graphqlOperation = claimApplicationRegistrationOwnershipQueryFactory({
+ input,
+ gqlFields,
+ });
+
+ const response = await makeMetadataApiRequest(graphqlOperation, token);
+
+ if (expectToFail === true) {
+ warnIfNoErrorButExpectedToFail({
+ response,
+ errorMessage:
+ 'Claiming application registration ownership should have failed but did not',
+ });
+ }
+
+ if (expectToFail === false) {
+ warnIfErrorButNotExpectedToFail({
+ response,
+ errorMessage:
+ 'Claiming application registration ownership has failed but should not',
+ });
+ }
+
+ return { data: response.body.data, errors: response.body.errors };
+};
diff --git a/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership-query-factory.util.ts b/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership-query-factory.util.ts
new file mode 100644
index 00000000000..2d9239ae999
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership-query-factory.util.ts
@@ -0,0 +1,35 @@
+import gql from 'graphql-tag';
+import { type PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+
+export type TransferApplicationRegistrationOwnershipFactoryInput = {
+ applicationRegistrationId: string;
+ targetWorkspaceSubdomain: string;
+};
+
+const DEFAULT_TRANSFER_APPLICATION_REGISTRATION_OWNERSHIP_GQL_FIELDS = `
+ id
+ ownerWorkspaceId
+`;
+
+export const transferApplicationRegistrationOwnershipQueryFactory = ({
+ input,
+ gqlFields = DEFAULT_TRANSFER_APPLICATION_REGISTRATION_OWNERSHIP_GQL_FIELDS,
+}: PerformMetadataQueryParams<TransferApplicationRegistrationOwnershipFactoryInput>) => ({
+ query: gql`
+ mutation TransferApplicationRegistrationOwnership(
+ $applicationRegistrationId: String!
+ $targetWorkspaceSubdomain: String!
+ ) {
+ transferApplicationRegistrationOwnership(
+ applicationRegistrationId: $applicationRegistrationId
+ targetWorkspaceSubdomain: $targetWorkspaceSubdomain
+ ) {
+ ${gqlFields}
+ }
+ }
+ `,
+ variables: {
+ applicationRegistrationId: input.applicationRegistrationId,
+ targetWorkspaceSubdomain: input.targetWorkspaceSubdomain,
+ },
+});
diff --git a/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership.util.ts b/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership.util.ts
new file mode 100644
index 00000000000..a561b241b46
--- /dev/null
+++ b/packages/twenty-server/test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership.util.ts
@@ -0,0 +1,47 @@
+import {
+ type TransferApplicationRegistrationOwnershipFactoryInput,
+ transferApplicationRegistrationOwnershipQueryFactory,
+} from 'test/integration/metadata/suites/application-registration/utils/transfer-application-registration-ownership-query-factory.util';
+import { makeMetadataApiRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
+import { type CommonResponseBody } from 'test/integration/metadata/types/common-response-body.type';
+import { type PerformMetadataQueryParams } from 'test/integration/metadata/types/perform-metadata-query.type';
+import { warnIfErrorButNotExpectedToFail } from 'test/integration/metadata/utils/warn-if-error-but-not-expected-to-fail.util';
+import { warnIfNoErrorButExpectedToFail } from 'test/integration/metadata/utils/warn-if-no-error-but-expected-to-fail.util';
+
+import { type ApplicationRegistrationEntity } from 'src/engine/core-modules/application/application-registration/application-registration.entity';
+
+export const transferApplicationRegistrationOwnership = async ({
+ input,
+ gqlFields,
+ expectToFail = false,
+ token,
+}: PerformMetadataQueryParams<TransferApplicationRegistrationOwnershipFactoryInput>): CommonResponseBody<{
+ transferApplicationRegistrationOwnership: ApplicationRegistrationEntity;
+}> => {
+ const graphqlOperation = transferApplicationRegistrationOwnershipQueryFactory(
+ {
+ input,
+ gqlFields,
+ },
+ );
+
+ const response = await makeMetadataApiRequest(graphqlOperation, token);
+
+ if (expectToFail === true) {
+ warnIfNoErrorButExpectedToFail({
+ response,
+ errorMessage:
+ 'Transferring application registration ownership should have failed but did not',
+ });
+ }
+
+ if (expectToFail === false) {
+ warnIfErrorButNotExpectedToFail({
+ response,
+ errorMessage:
+ 'Transferring application registration ownership has failed but should not',
+ });
+ }
+
+ return { data: response.body.data, errors: response.body.errors };
+};