The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Show contact auto-creation and sync options on shared mailboxes (#26059)
neo7730805587b89f0
diff --git a/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelDetails.tsx b/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelDetails.tsxindex 17602b25e79..4d0d64a3b2d 100644--- a/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelDetails.tsx+++ b/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelDetails.tsx@@ -105,31 +105,16 @@ export const SettingsAccountsMessageChannelDetails = ({)}{!isGroupMailbox && (<Section>- <Card rounded>- <SettingsOptionCardContentSwitch- Icon={IconUsers}- title={t`Exclude group emails`}- description={t`Don't sync emails from team@ support@ noreply@...`}- checked={messageChannel.excludeGroupEmails}- onChange={() =>- handleIsGroupEmailExcludedToggle(- !messageChannel.excludeGroupEmails,- )- }- />- </Card>+ <H2Title+ title={t`Visibility`}+ description={t`Define what will be visible to other users in your workspace`}+ />+ <SettingsAccountsMessageVisibilityCard+ value={messageChannel.visibility}+ onChange={handleVisibilityChange}+ /></Section>)}- <Section>- <H2Title- title={t`Visibility`}- description={t`Define what will be visible to other users in your workspace`}- />- <SettingsAccountsMessageVisibilityCard- value={messageChannel.visibility}- onChange={handleVisibilityChange}- />- </Section><Section><H2Titletitle={t`Contact auto-creation`}@@ -141,7 +126,23 @@ export const SettingsAccountsMessageChannelDetails = ({/></Section><Section>+ <H2Title+ title={t`Options`}+ description={t`Configure what emails should get synced`}+ /><Card rounded>+ <SettingsOptionCardContentSwitch+ Icon={IconUsers}+ title={t`Exclude group emails`}+ description={t`Don't import emails from team@ support@ noreply@...`}+ divider+ checked={messageChannel.excludeGroupEmails}+ onChange={() =>+ handleIsGroupEmailExcludedToggle(+ !messageChannel.excludeGroupEmails,+ )+ }+ /><SettingsOptionCardContentSwitchIcon={IconBriefcase}title={t`Exclude non-professional emails`}diff --git a/packages/twenty-front/src/modules/settings/accounts/components/__stories__/SettingsAccountsMessageChannelDetails.stories.tsx b/packages/twenty-front/src/modules/settings/accounts/components/__stories__/SettingsAccountsMessageChannelDetails.stories.tsxindex c37feb2c5ba..750d5c7a9b8 100644--- a/packages/twenty-front/src/modules/settings/accounts/components/__stories__/SettingsAccountsMessageChannelDetails.stories.tsx+++ b/packages/twenty-front/src/modules/settings/accounts/components/__stories__/SettingsAccountsMessageChannelDetails.stories.tsx@@ -1,4 +1,5 @@import { type Meta, type StoryObj } from '@storybook/react-vite';+import { expect, within } from 'storybook/test';import {MessageChannelContactAutoCreationPolicy,@@ -11,6 +12,17 @@ import { MessageChannelVisibility } from '~/generated/graphql';import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';+const mockedMessageChannel = {+ id: '20202020-ef5a-4822-9e08-ce6e6a4dcb6a',+ type: MessageChannelType.EMAIL,+ contactAutoCreationPolicy: MessageChannelContactAutoCreationPolicy.SENT,+ excludeNonProfessionalEmails: true,+ excludeGroupEmails: false,+ isSyncEnabled: true,+ visibility: MessageChannelVisibility.SHARE_EVERYTHING,+ messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,+};+const meta: Meta<typeof SettingsAccountsMessageChannelDetails> = {title:'Modules/Settings/Accounts/MessageChannels/SettingsAccountsMessageChannelDetails',@@ -21,16 +33,7 @@ const meta: Meta<typeof SettingsAccountsMessageChannelDetails> = {SnackBarDecorator,],args: {- messageChannel: {- id: '20202020-ef5a-4822-9e08-ce6e6a4dcb6a',- type: MessageChannelType.EMAIL,- contactAutoCreationPolicy: MessageChannelContactAutoCreationPolicy.SENT,- excludeNonProfessionalEmails: true,- excludeGroupEmails: false,- isSyncEnabled: true,- visibility: MessageChannelVisibility.SHARE_EVERYTHING,- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,- },+ messageChannel: mockedMessageChannel,},argTypes: {messageChannel: { control: false },@@ -43,3 +46,25 @@ type Story = StoryObj<typeof SettingsAccountsMessageChannelDetails>;export const Default: Story = {play: async () => {},};++export const EmailGroup: Story = {+ args: {+ messageChannel: {+ ...mockedMessageChannel,+ type: MessageChannelType.EMAIL_GROUP,+ },+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);++ expect(+ await canvas.findByText('Contact auto-creation'),+ ).toBeInTheDocument();+ expect(canvas.getByText('Exclude group emails')).toBeInTheDocument();+ expect(+ canvas.getByText('Exclude non-professional emails'),+ ).toBeInTheDocument();+ expect(canvas.queryByText('Visibility')).not.toBeInTheDocument();+ expect(canvas.queryByText('Import')).not.toBeInTheDocument();+ },+};diff --git a/packages/twenty-front/src/pages/settings/communications/SettingsWorkspaceCommunicationGroupChannelDetail.tsx b/packages/twenty-front/src/pages/settings/communications/SettingsWorkspaceCommunicationGroupChannelDetail.tsxindex a984aa2ceb4..201f459cce7 100644--- a/packages/twenty-front/src/pages/settings/communications/SettingsWorkspaceCommunicationGroupChannelDetail.tsx+++ b/packages/twenty-front/src/pages/settings/communications/SettingsWorkspaceCommunicationGroupChannelDetail.tsx@@ -4,6 +4,7 @@ import { useLingui } from '@lingui/react/macro';import { useState } from 'react';import { useParams } from 'react-router-dom';+import { SettingsAccountsMessageChannelDetails } from '@/settings/accounts/components/SettingsAccountsMessageChannelDetails';import { useDeleteEmailGroupChannel } from '@/settings/accounts/hooks/useDeleteEmailGroupChannel';import { useMyMessageChannels } from '@/settings/accounts/hooks/useMyMessageChannels';import { useUpdateEmailGroupChannel } from '@/settings/accounts/hooks/useUpdateEmailGroupChannel';@@ -243,6 +244,7 @@ export const SettingsWorkspaceCommunicationGroupChannelDetail = () => {</StyledSendingDomainColumn></Section>)}+ <SettingsAccountsMessageChannelDetails messageChannel={channel} /></SettingsPageContainer><ConfirmationModalmodalInstanceId={DELETE_EMAIL_GROUP_MODAL_ID}