The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
v1.6.3 — Remove the ranking field from the partner model (#24414)
Rashad Karanouh0890bcba70c6
diff --git a/packages/twenty-apps/internal/twenty-partners/package.json b/packages/twenty-apps/internal/twenty-partners/package.jsonindex 000f8cc9c3f..14bd45b712e 100644--- a/packages/twenty-apps/internal/twenty-partners/package.json+++ b/packages/twenty-apps/internal/twenty-partners/package.json@@ -1,6 +1,6 @@{"name": "twenty-partners",- "version": "1.6.2",+ "version": "1.6.3","license": "MIT","engines": {"node": "^24.5.0",diff --git a/packages/twenty-apps/internal/twenty-partners/src/modules/partner/application-intake/__tests__/submit-partner-application.integration-test.ts b/packages/twenty-apps/internal/twenty-partners/src/modules/partner/application-intake/__tests__/submit-partner-application.integration-test.tsindex 14f359eb395..307071d2015 100644--- a/packages/twenty-apps/internal/twenty-partners/src/modules/partner/application-intake/__tests__/submit-partner-application.integration-test.ts+++ b/packages/twenty-apps/internal/twenty-partners/src/modules/partner/application-intake/__tests__/submit-partner-application.integration-test.ts@@ -207,7 +207,7 @@ describe('submit-partner-application handler — upsert', () => {expect(node?.hourlyRate).toEqual({ amountMicros: 175_000_000, currencyCode: 'USD' });});- it('preserves staff-owned columns (validationStage, ranking, reviewed) on resubmission', async () => {+ it('preserves staff-owned columns (validationStage, reviewed) on resubmission', async () => {const first = await handler(authedEvent(baseInput({ email: '[email protected]' })));await trackCreated(first);expect(first.ok).toBe(true);@@ -217,7 +217,7 @@ describe('submit-partner-application handler — upsert', () => {updatePartner: {__args: {id: first.partnerId,- data: { validationStage: 'VALIDATED', reviewed: true, ranking: 'RATING_4' },+ data: { validationStage: 'VALIDATED', reviewed: true },},id: true,},@@ -232,14 +232,12 @@ describe('submit-partner-application handler — upsert', () => {__args: { filter: { id: { eq: second.partnerId } } },validationStage: true,reviewed: true,- ranking: true,city: true,},});const node = partner.partner;expect(node?.validationStage).toBe('VALIDATED');expect(node?.reviewed).toBe(true);- expect(node?.ranking).toBe('RATING_4');expect(node?.city).toBe('Berlin');});diff --git a/packages/twenty-apps/internal/twenty-partners/src/modules/partner/objects/partner.object.ts b/packages/twenty-apps/internal/twenty-partners/src/modules/partner/objects/partner.object.tsindex faddc27754a..9482bc79a96 100644--- a/packages/twenty-apps/internal/twenty-partners/src/modules/partner/objects/partner.object.ts+++ b/packages/twenty-apps/internal/twenty-partners/src/modules/partner/objects/partner.object.ts@@ -52,21 +52,6 @@ export default defineObject({icon: 'IconChecks',isNullable: true,},- {- universalIdentifier: '5412e4ca-cc96-4be8-8652-b73dace7673b',- type: FieldType.RATING,- name: 'ranking',- label: 'Ranking',- icon: 'IconStar',- isNullable: true,- options: [- { id: 'e4c784f0-7e2b-4eca-94dc-fc447266f252', value: 'RATING_1', label: '1', position: 0 },- { id: '79d033bd-4189-4f69-a9d1-a54d7cbbc5bc', value: 'RATING_2', label: '2', position: 1 },- { id: '1206bdcc-a804-4649-a3ce-bd001a3abc2c', value: 'RATING_3', label: '3', position: 2 },- { id: '1c195738-d823-415e-b4db-44a6cdc09ec5', value: 'RATING_4', label: '4', position: 3 },- { id: '92cd3a72-8d5b-4077-a369-ddfe429aa2aa', value: 'RATING_5', label: '5', position: 4 },- ],- },{universalIdentifier: 'd4fa6461-37b6-49ee-9181-dd482e74a70b',type: FieldType.SELECT,diff --git a/packages/twenty-apps/internal/twenty-partners/src/roles/partner.role.ts b/packages/twenty-apps/internal/twenty-partners/src/roles/partner.role.tsindex f87f4fcc06f..738b244d155 100644--- a/packages/twenty-apps/internal/twenty-partners/src/roles/partner.role.ts+++ b/packages/twenty-apps/internal/twenty-partners/src/roles/partner.role.ts@@ -311,11 +311,6 @@ export default defineRole({fieldUniversalIdentifier: '5af4e57e-7fa7-4c4f-b40f-37549361459a',canUpdateFieldValue: false,},- {- objectUniversalIdentifier: PARTNER_OBJECT_UNIVERSAL_IDENTIFIER,- fieldUniversalIdentifier: '5412e4ca-cc96-4be8-8652-b73dace7673b',- canUpdateFieldValue: false,- },{// Partner Tier — read-locked too: admin-only on the record page, hidden from partners.objectUniversalIdentifier: PARTNER_OBJECT_UNIVERSAL_IDENTIFIER,diff --git a/packages/twenty-apps/internal/twenty-partners/src/skills/_shared/partner-api.md b/packages/twenty-apps/internal/twenty-partners/src/skills/_shared/partner-api.mdindex d4c986f6b16..764da655604 100644--- a/packages/twenty-apps/internal/twenty-partners/src/skills/_shared/partner-api.md+++ b/packages/twenty-apps/internal/twenty-partners/src/skills/_shared/partner-api.md@@ -70,7 +70,7 @@ query ListPartners($after: String) {id name slug introductionlanguagesSpoken country region citydeploymentExpertise partnerScope skills typeOfTeam- partnerTier ranking+ partnerTiertwentyExperience twentyExperienceNoteshourlyRate { amountMicros currencyCode }projectBudgetMin { amountMicros currencyCode }diff --git a/packages/twenty-apps/internal/twenty-partners/src/skills/twenty-partner-shortlist/SKILL.md b/packages/twenty-apps/internal/twenty-partners/src/skills/twenty-partner-shortlist/SKILL.mdindex 7e955072803..8922345aa96 100644--- a/packages/twenty-apps/internal/twenty-partners/src/skills/twenty-partner-shortlist/SKILL.md+++ b/packages/twenty-apps/internal/twenty-partners/src/skills/twenty-partner-shortlist/SKILL.md@@ -116,8 +116,8 @@ Rules:- Read the partner's **notes** (`noteTargets` filtered by `targetPartnerId`) when there areany. A `Partner call recap:` note carries what was actually said on a call, which beatsself-written copy. About 5 partners have one.-- `partnerTier` and `ranking` are the user's own past judgements. Report them where set;- never let them reorder the list.+- `partnerTier` is the user's own past judgement. Report it where set; never let it+ reorder the list.Head the output with the lead's budget line from the criteria file, usually "not stated".Show each partner's rate next to it. Do not compute a verdict from the comparison.diff --git a/packages/twenty-apps/internal/twenty-partners/src/skills/twenty-partner-triage/SKILL.md b/packages/twenty-apps/internal/twenty-partners/src/skills/twenty-partner-triage/SKILL.mdindex 7f83185a777..05ca72d08f0 100644--- a/packages/twenty-apps/internal/twenty-partners/src/skills/twenty-partner-triage/SKILL.md+++ b/packages/twenty-apps/internal/twenty-partners/src/skills/twenty-partner-triage/SKILL.md@@ -102,11 +102,8 @@ Rules:- **Not a gate.** It never moves anyone to `REJECTED` or out of the funnel.- **Not a writer.** It never edits a record. Surfacing only.-- **Not the production cron.** This is the dev surface for the ranking. Once the chase-list is- trustworthy, `rank.py` is what gets ported to a daily logic-function cron that writes- `ranking` and a tier onto each record so the workspace view sorts itself. The judgment pass- stays here, for the runs where a human is in the loop. Build the skill, trust it, port the- cheap part. Don't build both.+- **Not a background job.** Nothing here is scheduled. The judgment pass stays here, for+ the runs where a human is in the loop.## Self-check