The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Show the member count on message list record pages (#27952)
neo7730963016d86de
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-upgrade-version-command.module.tsnew file mode 100644index 00000000000..e15c347df12--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-upgrade-version-command.module.ts@@ -0,0 +1,16 @@+import { Module } from '@nestjs/common';++import { WorkspaceIteratorModule } from 'src/database/commands/command-runners/workspace-iterator.module';+import { CountMessageListMembersCommand } from 'src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1791977057418-count-message-list-members.command';+import { WorkspaceCacheModule } from 'src/engine/workspace-cache/workspace-cache.module';+import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspace-migration/workspace-migration.module';++@Module({+ imports: [+ WorkspaceCacheModule,+ WorkspaceIteratorModule,+ WorkspaceMigrationModule,+ ],+ providers: [CountMessageListMembersCommand],+})+export class V2_48_UpgradeVersionCommandModule {}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1791977057418-count-message-list-members.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1791977057418-count-message-list-members.command.tsnew file mode 100644index 00000000000..5f4d524835c--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1791977057418-count-message-list-members.command.ts@@ -0,0 +1,115 @@+import { Command } from 'nest-commander';+import { TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER } from 'twenty-shared/application';+import { STANDARD_OBJECTS } from 'twenty-shared/metadata';+import { AggregateOperations } from 'twenty-shared/types';+import { isDefined } from 'twenty-shared/utils';++import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';+import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';++const MEMBERS_NAME_VIEW_FIELD_UNIVERSAL_IDENTIFIER =+ STANDARD_OBJECTS.person.views.messageListRecordPageMembers.viewFields.name+ .universalIdentifier;++@RegisteredWorkspaceCommand('2.48.0', 1791977057418)+@Command({+ name: 'upgrade:2-48:count-message-list-members',+ description:+ 'Show the member count under the members table of message list record pages',+})+export class CountMessageListMembersCommand extends ProvisionedWorkspaceCommandRunner {+ constructor(+ protected readonly workspaceIteratorService: WorkspaceIteratorService,+ private readonly workspaceCacheService: WorkspaceCacheService,+ private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,+ ) {+ super(workspaceIteratorService);+ }++ override async runOnWorkspace(args: RunOnWorkspaceArgs): Promise<void> {+ await this.up(args);+ }++ async up(args: RunOnWorkspaceArgs): Promise<void> {+ await this.setMembersAggregateOperation({+ ...args,+ from: null,+ to: AggregateOperations.COUNT,+ });+ }++ async down(args: RunOnWorkspaceArgs): Promise<void> {+ await this.setMembersAggregateOperation({+ ...args,+ from: AggregateOperations.COUNT,+ to: null,+ });+ }++ private async setMembersAggregateOperation({+ workspaceId,+ options,+ from,+ to,+ }: RunOnWorkspaceArgs & {+ from: AggregateOperations | null;+ to: AggregateOperations | null;+ }): Promise<void> {+ const { flatViewFieldMaps } =+ await this.workspaceCacheService.getOrRecompute(workspaceId, [+ 'flatViewFieldMaps',+ ]);++ const membersNameViewField =+ flatViewFieldMaps.byUniversalIdentifier[+ MEMBERS_NAME_VIEW_FIELD_UNIVERSAL_IDENTIFIER+ ];++ if (+ !isDefined(membersNameViewField) ||+ membersNameViewField.aggregateOperation !== from+ ) {+ return;+ }++ this.logger.log(+ `${options.dryRun ? '[DRY RUN] ' : ''}Workspace ${workspaceId}: setting the message list members aggregate to ${to ?? 'none'}`,+ );++ if (options.dryRun) {+ return;+ }++ const result =+ await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunLegacyWorkspaceMigration(+ {+ workspaceId,+ isSystemBuild: true,+ applicationUniversalIdentifier:+ TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER,+ allFlatEntityOperationByMetadataName: {+ viewField: {+ flatEntityToCreate: [],+ flatEntityToDelete: [],+ flatEntityToUpdate: [+ {+ ...membersNameViewField,+ aggregateOperation: to,+ updatedAt: new Date().toISOString(),+ },+ ],+ },+ },+ },+ );++ if (result.status === 'fail') {+ throw new WorkspaceMigrationBuilderException(result);+ }+ }+}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.tsindex debe2a5d4f3..c8227465cce 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts@@ -40,6 +40,7 @@ import { V2_44_UpgradeVersionCommandModule } from 'src/database/commands/upgradeimport { V2_45_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-45/2-45-upgrade-version-command.module';import { V2_46_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-46/2-46-upgrade-version-command.module';import { V2_47_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-47/2-47-upgrade-version-command.module';+import { V2_48_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-48/2-48-upgrade-version-command.module';import { V2_4_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-4/2-4-upgrade-version-command.module';import { V2_5_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-5/2-5-upgrade-version-command.module';import { V2_7_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-7/2-7-upgrade-version-command.module';@@ -93,6 +94,7 @@ import { V2_9_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-V2_45_UpgradeVersionCommandModule,V2_46_UpgradeVersionCommandModule,V2_47_UpgradeVersionCommandModule,+ V2_48_UpgradeVersionCommandModule,],})export class WorkspaceCommandProviderModule {}diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.tsindex 6a2edda7f27..79aed79a767 100644--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/view-field/compute-standard-person-view-fields.util.ts@@ -359,6 +359,7 @@ export const computeStandardPersonViewFields = (position: 0,isVisible: true,size: 210,+ aggregateOperation: AggregateOperations.COUNT,},}),messageListRecordPageMembersEmails: createStandardViewFieldFlatMetadata({diff --git a/packages/twenty-server/test/integration/upgrade/suites/2-48-workspace-command-1791977057418-count-message-list-members.integration-spec.ts b/packages/twenty-server/test/integration/upgrade/suites/2-48-workspace-command-1791977057418-count-message-list-members.integration-spec.tsnew file mode 100644index 00000000000..8f432205aeb--- /dev/null+++ b/packages/twenty-server/test/integration/upgrade/suites/2-48-workspace-command-1791977057418-count-message-list-members.integration-spec.ts@@ -0,0 +1,93 @@+import { getAppProviderByClassName } from 'test/integration/utils/get-app-provider-by-class-name.util';+import { STANDARD_OBJECTS } from 'twenty-shared/metadata';+import { AggregateOperations } from 'twenty-shared/types';++import { type CountMessageListMembersCommand } from 'src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1791977057418-count-message-list-members.command';+import { type WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';+import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';++const RUN_ON_WORKSPACE_ARGS = {+ workspaceId: SEED_APPLE_WORKSPACE_ID,+ options: {},+ index: 0,+ total: 1,+};++const MEMBERS_NAME_VIEW_FIELD_UNIVERSAL_IDENTIFIER =+ STANDARD_OBJECTS.person.views.messageListRecordPageMembers.viewFields.name+ .universalIdentifier;++const readMembersAggregateOperation = async () => {+ const [viewField]: { aggregateOperation: AggregateOperations | null }[] =+ await global.testDataSource.query(+ `SELECT "aggregateOperation"+ FROM core."viewField"+ WHERE "workspaceId" = $1 AND "universalIdentifier" = $2`,+ [SEED_APPLE_WORKSPACE_ID, MEMBERS_NAME_VIEW_FIELD_UNIVERSAL_IDENTIFIER],+ );++ return viewField.aggregateOperation;+};++describe('2-48 workspace command - count message list members (integration)', () => {+ let command: CountMessageListMembersCommand;+ let workspaceCacheService: WorkspaceCacheService;++ const setMembersAggregateOperation = async (+ aggregateOperation: AggregateOperations | null,+ ) => {+ await global.testDataSource.query(+ `UPDATE core."viewField"+ SET "aggregateOperation" = $3+ WHERE "workspaceId" = $1 AND "universalIdentifier" = $2`,+ [+ SEED_APPLE_WORKSPACE_ID,+ MEMBERS_NAME_VIEW_FIELD_UNIVERSAL_IDENTIFIER,+ aggregateOperation,+ ],+ );+ await workspaceCacheService.invalidateAndRecompute(+ SEED_APPLE_WORKSPACE_ID,+ ['flatViewFieldMaps'],+ );+ };++ beforeAll(() => {+ command = getAppProviderByClassName<CountMessageListMembersCommand>(+ 'CountMessageListMembersCommand',+ );+ workspaceCacheService = getAppProviderByClassName<WorkspaceCacheService>(+ 'WorkspaceCacheService',+ );+ });++ afterAll(async () => {+ await setMembersAggregateOperation(AggregateOperations.COUNT);+ });++ it('removes the members count on down, and adds it back on up', async () => {+ await command.down(RUN_ON_WORKSPACE_ARGS);++ expect(await readMembersAggregateOperation()).toBeNull();++ await command.up(RUN_ON_WORKSPACE_ARGS);++ expect(await readMembersAggregateOperation()).toBe(+ AggregateOperations.COUNT,+ );+ });++ it('keeps an aggregate the workspace changed', async () => {+ await setMembersAggregateOperation(AggregateOperations.COUNT_EMPTY);++ await command.down(RUN_ON_WORKSPACE_ARGS);+ expect(await readMembersAggregateOperation()).toBe(+ AggregateOperations.COUNT_EMPTY,+ );++ await command.up(RUN_ON_WORKSPACE_ARGS);+ expect(await readMembersAggregateOperation()).toBe(+ AggregateOperations.COUNT_EMPTY,+ );+ });+});