Skip to content

The open alternative to Salesforce, designed for AI.

Remove the IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED feature flag (#28271)

Charles Bochet0aa32ee7cfab
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
index 3d7c2b5722b..f9f9353a026 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
@@ -2133,7 +2133,6 @@ enum FeatureFlagKey {
IS_MESSAGE_CAMPAIGN_ENABLED
IS_RECORD_CREATION_FORM_ENABLED
IS_RECORD_LEVEL_SHARING_ENABLED
- IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED
IS_REST_METADATA_API_NEW_FORMAT_DIRECT
}
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
index 2e74741b9ab..6d67f869be9 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
@@ -1374,7 +1374,7 @@ export interface FeatureFlag {
__typename: 'FeatureFlag'
}
-export type FeatureFlagKey = 'IS_AI_CHAT_INBOX_ENABLED' | 'IS_APP_PREFERENCES_ENABLED' | 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_LOGS_SETTINGS_SECTION_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED' | 'IS_RECORD_LEVEL_SHARING_ENABLED' | 'IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT'
+export type FeatureFlagKey = 'IS_AI_CHAT_INBOX_ENABLED' | 'IS_APP_PREFERENCES_ENABLED' | 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_LOGS_SETTINGS_SECTION_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED' | 'IS_RECORD_LEVEL_SHARING_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT'
export interface Field {
applicationId: Scalars['UUID']
@@ -11660,7 +11660,6 @@ export const enumFeatureFlagKey = {
IS_MESSAGE_CAMPAIGN_ENABLED: 'IS_MESSAGE_CAMPAIGN_ENABLED' as const,
IS_RECORD_CREATION_FORM_ENABLED: 'IS_RECORD_CREATION_FORM_ENABLED' as const,
IS_RECORD_LEVEL_SHARING_ENABLED: 'IS_RECORD_LEVEL_SHARING_ENABLED' as const,
- IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED: 'IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED' as const,
IS_REST_METADATA_API_NEW_FORMAT_DIRECT: 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT' as const
}
diff --git a/packages/twenty-front/src/generated-admin/graphql.ts b/packages/twenty-front/src/generated-admin/graphql.ts
index c66f272158e..306020c5bc8 100644
--- a/packages/twenty-front/src/generated-admin/graphql.ts
+++ b/packages/twenty-front/src/generated-admin/graphql.ts
@@ -468,7 +468,6 @@ export enum FeatureFlagKey {
IS_MESSAGE_CAMPAIGN_ENABLED = 'IS_MESSAGE_CAMPAIGN_ENABLED',
IS_RECORD_CREATION_FORM_ENABLED = 'IS_RECORD_CREATION_FORM_ENABLED',
IS_RECORD_LEVEL_SHARING_ENABLED = 'IS_RECORD_LEVEL_SHARING_ENABLED',
- IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED = 'IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED',
IS_REST_METADATA_API_NEW_FORMAT_DIRECT = 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT'
}
diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.ts
index fb971c42370..9799c2e9a66 100644
--- a/packages/twenty-front/src/generated-metadata/graphql.ts
+++ b/packages/twenty-front/src/generated-metadata/graphql.ts
@@ -2256,7 +2256,6 @@ export enum FeatureFlagKey {
IS_MESSAGE_CAMPAIGN_ENABLED = 'IS_MESSAGE_CAMPAIGN_ENABLED',
IS_RECORD_CREATION_FORM_ENABLED = 'IS_RECORD_CREATION_FORM_ENABLED',
IS_RECORD_LEVEL_SHARING_ENABLED = 'IS_RECORD_LEVEL_SHARING_ENABLED',
- IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED = 'IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED',
IS_REST_METADATA_API_NEW_FORMAT_DIRECT = 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT'
}
diff --git a/packages/twenty-front/src/modules/object-record/record-sharing/hooks/__tests__/useCanReadObjectRecordsOrSharedRecords.test.ts b/packages/twenty-front/src/modules/object-record/record-sharing/hooks/__tests__/useCanReadObjectRecordsOrSharedRecords.test.ts
index fdc56a60291..e4e81f6914e 100644
--- a/packages/twenty-front/src/modules/object-record/record-sharing/hooks/__tests__/useCanReadObjectRecordsOrSharedRecords.test.ts
+++ b/packages/twenty-front/src/modules/object-record/record-sharing/hooks/__tests__/useCanReadObjectRecordsOrSharedRecords.test.ts
@@ -2,21 +2,16 @@ import { renderHook } from '@testing-library/react';
import { useCanReadObjectRecordsOrSharedRecords } from '@/object-record/record-sharing/hooks/useCanReadObjectRecordsOrSharedRecords';
import {
- FeatureFlagKey,
MetadataReadability,
ObjectSharingReach,
} from '~/generated-metadata/graphql';
const mockIsRecordLevelSharingEnabled = jest.fn();
-const mockWorkspaceFeatureFlags = jest.fn();
const mockCanReadObjectRecords = jest.fn();
jest.mock('@/workspace/hooks/useIsFeatureEnabled', () => ({
useIsFeatureEnabled: () => mockIsRecordLevelSharingEnabled(),
}));
-jest.mock('@/ui/utilities/state/jotai/hooks/useAtomStateValue', () => ({
- useAtomStateValue: () => ({ featureFlags: mockWorkspaceFeatureFlags() }),
-}));
jest.mock('@/object-record/hooks/useObjectPermissionsForObject', () => ({
useObjectPermissionsForObject: () => ({
canReadObjectRecords: mockCanReadObjectRecords(),
@@ -43,7 +38,6 @@ const renderCanRead = (
describe('useCanReadObjectRecordsOrSharedRecords', () => {
beforeEach(() => {
mockIsRecordLevelSharingEnabled.mockReturnValue(true);
- mockWorkspaceFeatureFlags.mockReturnValue([]);
mockCanReadObjectRecords.mockReturnValue(false);
});
@@ -87,42 +81,4 @@ describe('useCanReadObjectRecordsOrSharedRecords', () => {
expect(renderCanRead()).toBe(false);
});
-
- it('keeps shared records readable when the workspace has no visibility gating flag', () => {
- expect(renderCanRead()).toBe(true);
- });
-
- it('keeps shared records readable when visibility gating is explicitly on', () => {
- mockWorkspaceFeatureFlags.mockReturnValue([
- {
- key: FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED,
- value: true,
- },
- ]);
-
- expect(renderCanRead()).toBe(true);
- });
-
- it('denies shared records when visibility gating is explicitly off', () => {
- mockWorkspaceFeatureFlags.mockReturnValue([
- {
- key: FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED,
- value: false,
- },
- ]);
-
- expect(renderCanRead()).toBe(false);
- });
-
- it('still allows reading through the role when visibility gating is explicitly off', () => {
- mockWorkspaceFeatureFlags.mockReturnValue([
- {
- key: FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED,
- value: false,
- },
- ]);
- mockCanReadObjectRecords.mockReturnValue(true);
-
- expect(renderCanRead()).toBe(true);
- });
});
diff --git a/packages/twenty-front/src/modules/object-record/record-sharing/hooks/useCanReadObjectRecordsOrSharedRecords.ts b/packages/twenty-front/src/modules/object-record/record-sharing/hooks/useCanReadObjectRecordsOrSharedRecords.ts
index 03e523eb6ed..8cd48ef241b 100644
--- a/packages/twenty-front/src/modules/object-record/record-sharing/hooks/useCanReadObjectRecordsOrSharedRecords.ts
+++ b/packages/twenty-front/src/modules/object-record/record-sharing/hooks/useCanReadObjectRecordsOrSharedRecords.ts
@@ -1,9 +1,7 @@
-import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';
import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPermissionsForObject';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
import { isShareableObjectMetadataItem } from '@/object-record/record-sharing/utils/isShareableObjectMetadataItem';
-import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';
import {
FeatureFlagKey,
ObjectSharingReach,
@@ -24,18 +22,10 @@ export const useCanReadObjectRecordsOrSharedRecords = (
const isRecordLevelSharingEnabled = useIsFeatureEnabled(
FeatureFlagKey.IS_RECORD_LEVEL_SHARING_ENABLED,
);
- const currentWorkspace = useAtomStateValue(currentWorkspaceState);
- const isRecordShareVisibilityGatingEnabled =
- currentWorkspace?.featureFlags?.find(
- (featureFlag) =>
- featureFlag.key ===
- FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED,
- )?.value !== false;
return (
objectPermissions.canReadObjectRecords ||
(isRecordLevelSharingEnabled &&
- isRecordShareVisibilityGatingEnabled &&
isShareableObjectMetadataItem(objectMetadataItem) &&
objectMetadataItem.sharingReach === ObjectSharingReach.WORKSPACE)
);
diff --git a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
index 94c2d559bb0..b9dcf17d243 100644
--- a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
+++ b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
@@ -32,10 +32,6 @@ export const SETTINGS_ADMIN_FEATURE_FLAG_METADATA: Record<
label: msg`Record sharing`,
description: msg`Let people restrict and share individual records.`,
},
- [FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED]: {
- label: msg`Record sharing visibility`,
- description: msg`Apply record sharing visibility rules when accessing records.`,
- },
[FeatureFlagKey.IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED]: {
label: msg`Deferred workspace migration actions`,
description: msg`Run the slow parts of data model changes in the background after they are saved.`,
diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/evaluate-row-access-policy.util.spec.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/evaluate-row-access-policy.util.spec.ts
index 9fd4cb74899..bef301516bf 100644
--- a/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/evaluate-row-access-policy.util.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/evaluate-row-access-policy.util.spec.ts
@@ -1,12 +1,7 @@
/* @license Enterprise */
import { EVERYONE_PRINCIPAL_ID } from 'twenty-shared/constants';
-import {
- FeatureFlagKey,
- FieldMetadataType,
- MetadataReadability,
- RecordShareAccessLevel,
-} from 'twenty-shared/types';
+import { FieldMetadataType, RecordShareAccessLevel } from 'twenty-shared/types';
import { type RecordShareGrant } from 'src/engine/core-modules/record-share/types/record-share-grant.type';
import {
@@ -23,9 +18,7 @@ import { COMPANY_FLAT_OBJECT_MOCK } from 'src/engine/metadata-modules/flat-objec
import {
type RecordShareExpressionTarget,
type RowAccessExpression,
- type RowAccessPolicySubject,
} from 'src/engine/twenty-orm/types/row-access-policy.type';
-import { buildRowAccessPolicy } from 'src/engine/twenty-orm/utils/build-row-access-policy.util';
const MEMBER_ID = 'member-1';
@@ -219,58 +212,4 @@ describe('evaluateRowAccessPolicy', () => {
}),
);
});
-
- describe('with record share visibility gating turned off for the workspace', () => {
- const privateObject = {
- ...flatObjectMetadata,
- readability: MetadataReadability.PRIVATE,
- };
- const buildUngatedPolicy = (
- objectsPermissions: RowAccessPolicySubject['objectsPermissions'],
- ) =>
- buildRowAccessPolicy({
- subject: {
- isSystemContext: false,
- objectsPermissions,
- principalIds: [MEMBER_ID],
- canAccessAllRecords: false,
- isOwningApplication: () => false,
- resolveRowLevelPermissionRecordFilter: () => null,
- },
- environment: {
- flatFieldMetadataMaps,
- flatObjectMetadataMaps: createEmptyFlatEntityMaps(),
- featureFlagsMap: {
- [FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED]: false,
- },
- },
- tableAlias: 'company',
- flatObjectMetadata: privateObject,
- operationType: 'select',
- depth: 0,
- });
-
- it('admits every PRIVATE record to a role that can read the object, without reading shares', async () => {
- const context = buildContext();
-
- expect(
- await evaluateRowAccessPolicy({
- policy: buildUngatedPolicy(undefined),
- records,
- context,
- }),
- ).toEqual(new Set(records.map((record) => record.id)));
- expect(context.fetchRecordShares).not.toHaveBeenCalled();
- });
-
- it('still denies a role that cannot read the object', async () => {
- expect(
- await evaluateRowAccessPolicy({
- policy: buildUngatedPolicy({}),
- records,
- context: buildContext(),
- }),
- ).toEqual(new Set());
- });
- });
});
diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/resolve-object-sharing.util.spec.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/resolve-object-sharing.util.spec.ts
index 9e7de8ebd72..e39dc3b571f 100644
--- a/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/resolve-object-sharing.util.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/resolve-object-sharing.util.spec.ts
@@ -40,7 +40,7 @@ describe('resolveObjectSharing', () => {
},
);
- it('should keep visibility gating on for a workspace without flag rows', () => {
+ it('should keep an open object role-only for a workspace without flag rows', () => {
expect(
resolveObjectSharing({
flatObjectMetadata: OPEN_OBJECT,
@@ -48,7 +48,6 @@ describe('resolveObjectSharing', () => {
}),
).toEqual({
sharingMode: RecordSharingMode.ROLE_ONLY,
- isVisibilityGatingEnabled: true,
canShareBeyondRole: false,
operationTypesGrantedBeyondRole: [],
});
@@ -90,21 +89,4 @@ describe('resolveObjectSharing', () => {
operationTypesGrantedBeyondRole: [],
});
});
-
- it('should keep sharing but grant nothing beyond the role once gating is turned off', () => {
- expect(
- resolveObjectSharing({
- flatObjectMetadata: OPEN_OBJECT,
- featureFlagsMap: {
- ...RECORD_SHARING,
- [FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED]: false,
- },
- }),
- ).toEqual({
- sharingMode: RecordSharingMode.OPEN_BY_DEFAULT,
- isVisibilityGatingEnabled: false,
- canShareBeyondRole: true,
- operationTypesGrantedBeyondRole: [],
- });
- });
});
diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/build-record-share-gate.util.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/build-record-share-gate.util.ts
index 5057f1e7207..7118b26cef2 100644
--- a/packages/twenty-server/src/engine/core-modules/record-share/utils/build-record-share-gate.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/build-record-share-gate.util.ts
@@ -39,15 +39,14 @@ export const buildRecordShareGate = ({
readability: target.flatObjectMetadata.readability,
isOwningApplication,
});
- const { sharingMode, isVisibilityGatingEnabled } = resolveObjectSharing({
+ const { sharingMode } = resolveObjectSharing({
flatObjectMetadata: target.flatObjectMetadata,
featureFlagsMap: context.environment.featureFlagsMap,
});
switch (gateKind) {
case 'open':
- return isVisibilityGatingEnabled &&
- sharingMode === RecordSharingMode.OPEN_BY_DEFAULT &&
+ return sharingMode === RecordSharingMode.OPEN_BY_DEFAULT &&
!context.subject.canAccessAllRecords
? buildRecordShareExceptionGate(context, target)
: { kind: 'open' };
@@ -58,12 +57,9 @@ export const buildRecordShareGate = ({
context,
target,
buildParentPolicy,
- isVisibilityGatingEnabled,
});
case 'private':
- return isVisibilityGatingEnabled
- ? buildOwnRecordShareGate(context, target)
- : { kind: 'open' };
+ return buildOwnRecordShareGate(context, target);
default:
return assertUnreachable(gateKind);
}
@@ -134,10 +130,7 @@ const buildInheritedReadabilityGate = ({
context,
target,
buildParentPolicy,
- isVisibilityGatingEnabled,
-}: RecordShareGateArgs & {
- isVisibilityGatingEnabled: boolean;
-}): RowAccessPolicy => {
+}: RecordShareGateArgs): RowAccessPolicy => {
const { tableAlias, flatObjectMetadata, depth, joinParentRelationShape } =
target;
@@ -166,7 +159,7 @@ const buildInheritedReadabilityGate = ({
const isOpenWhenDetached = isOpenWhenDetachedObject(flatObjectMetadata);
if (parents.length === 0) {
- return isOpenWhenDetached || !isVisibilityGatingEnabled
+ return isOpenWhenDetached
? { kind: 'open' }
: buildOwnRecordShareGate(context, target);
}
@@ -186,15 +179,6 @@ const buildInheritedReadabilityGate = ({
}),
);
- if (
- !isVisibilityGatingEnabled &&
- parentExpressions.every(
- (parentExpression) => parentExpression.policy.kind === 'open',
- )
- ) {
- return { kind: 'open' };
- }
-
return {
kind: 'gated',
expression: {
diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/resolve-object-sharing.util.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/resolve-object-sharing.util.ts
index 7cdaeae0dd9..46e113907e6 100644
--- a/packages/twenty-server/src/engine/core-modules/record-share/utils/resolve-object-sharing.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/resolve-object-sharing.util.ts
@@ -19,13 +19,8 @@ const OPERATION_TYPES_GRANTABLE_BEYOND_ROLE: OperationType[] = [
'update',
];
-// Visibility gating is an operator switch on reads only: with it off, shares
-// keep being written but grant nothing, so sharingMode and canShareBeyondRole
-// ignore it while isVisibilityGatingEnabled and
-// operationTypesGrantedBeyondRole follow it
export type ObjectSharing = {
sharingMode: RecordSharingMode;
- isVisibilityGatingEnabled: boolean;
canShareBeyondRole: boolean;
operationTypesGrantedBeyondRole: OperationType[];
};
@@ -62,11 +57,6 @@ export const resolveObjectSharing = ({
}): ObjectSharing => {
const isRecordSharingEnabled =
featureFlagsMap[FeatureFlagKey.IS_RECORD_LEVEL_SHARING_ENABLED] ?? false;
- // A workspace without a row for this flag keeps gating on
- const isVisibilityGatingEnabled =
- featureFlagsMap[
- FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED
- ] !== false;
const sharingMode = resolveSharingMode({
flatObjectMetadata,
isRecordSharingEnabled,
@@ -79,11 +69,9 @@ export const resolveObjectSharing = ({
return {
sharingMode,
- isVisibilityGatingEnabled,
canShareBeyondRole,
- operationTypesGrantedBeyondRole:
- isVisibilityGatingEnabled && canShareBeyondRole
- ? OPERATION_TYPES_GRANTABLE_BEYOND_ROLE
- : [],
+ operationTypesGrantedBeyondRole: canShareBeyondRole
+ ? OPERATION_TYPES_GRANTABLE_BEYOND_ROLE
+ : [],
};
};
diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/build-row-access-policy.util.spec.ts b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/build-row-access-policy.util.spec.ts
index ce6fa22eb65..125d8e83613 100644
--- a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/build-row-access-policy.util.spec.ts
+++ b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/build-row-access-policy.util.spec.ts
@@ -7,7 +7,6 @@ import {
RecordShareAccessLevel,
} from 'twenty-shared/types';
-import { MAX_INHERITED_READABILITY_DEPTH } from 'src/engine/core-modules/record-share/constants/max-inherited-readability-depth.constant';
import { getFlatObjectMetadataMock } from 'src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock';
import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
import {
@@ -445,145 +444,6 @@ describe('buildRowAccessPolicy', () => {
},
);
- describe('with record share visibility gating off', () => {
- const ungatedEnvironment = {
- ...environment,
- featureFlagsMap: {
- [FeatureFlagKey.IS_RECORD_LEVEL_SHARING_ENABLED]: true,
- [FeatureFlagKey.IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED]: false,
- },
- };
- const buildBypassed = (
- subject: RowAccessPolicySubject,
- flatObjectMetadata: FlatObjectMetadata,
- depth = 0,
- ) =>
- buildCompiledRowAccessPolicy({
- subject,
- environment: ungatedEnvironment,
- tableAlias: flatObjectMetadata.nameSingular,
- flatObjectMetadata,
- operationType: 'select',
- depth,
- });
-
- it.each([person, attachment, note])(
- 'opens $readability records without any share check',
- (flatObjectMetadata) => {
- expect(buildBypassed(readEverything, flatObjectMetadata)).toEqual({
- kind: 'open',
- });
- },
- );
-
- it('keeps the role predicate on a PRIVATE object', () => {
- expect(
- buildBypassed(
- {
- ...readEverything,
- resolveRowLevelPermissionRecordFilter: () => NOTE_FILTER,
- },
- person,
- ),
- ).toEqual({
- kind: 'gated',
- condition: {
- sql: '("person"."title" = :restricted)',
- parameters: { restricted: 'restricted' },
- },
- });
- });
-
- it.each([MetadataReadability.SYSTEM, MetadataReadability.APPLICATION])(
- 'keeps %s records denied',
- (readability) => {
- expect(buildBypassed(readEverything, { ...note, readability })).toEqual(
- { kind: 'denied' },
- );
- },
- );
-
- it('opens a detached INHERITED record to the role instead of requiring its own share', () => {
- jest.mocked(resolveInheritedReadabilityParents).mockReturnValue([]);
-
- expect(buildBypassed(readEverything, attachment)).toEqual({
- kind: 'open',
- });
- expect(gatedSql(readEverything, attachment)).toContain(
- '"attachment_recordShare"."recordId" = "attachment"."id"',
- );
- });
-
- it('opens an INHERITED record whose OPEN and PRIVATE parents are open', () => {
- expect(buildBypassed(readEverything, attachment)).toEqual({
- kind: 'open',
- });
- });
-
- it('keeps an INHERITED record behind a parent the subject is denied', () => {
- jest.mocked(resolveInheritedReadabilityParents).mockReturnValue([
- {
- kind: 'column',
- fieldMetadataId: 'target-note-field-id',
- joinColumnName: 'targetNoteId',
- parentFlatObjectMetadata: {
- ...note,
- readability: MetadataReadability.APPLICATION,
- },
- },
- ]);
-
- const policy = buildBypassed(readEverything, attachment);
-
- expect(policy.kind).toBe('gated');
- if (policy.kind !== 'gated') throw new Error('Expected a gate');
- expect(policy.condition.sql).not.toContain('targetNoteId');
- });
-
- it('keeps the role predicate of a parent and drops its share check', () => {
- const policy = buildBypassed(
- {
- ...readEverything,
- resolveRowLevelPermissionRecordFilter: (objectMetadata) =>
- objectMetadata.id === note.id ? NOTE_FILTER : null,
- },
- attachment,
- );
-
- expect(policy.kind).toBe('gated');
- if (policy.kind !== 'gated') throw new Error('Expected a gate');
- expect(policy.condition.sql).toContain(
- '"attachment_targetNoteId"."title" = :restricted',
- );
- expect(policy.condition.sql).not.toContain(
- 'attachment_targetPersonId_recordShare',
- );
- });
-
- it('denies an INHERITED record past the maximum inheritance depth', () => {
- expect(
- buildBypassed(
- readEverything,
- attachment,
- MAX_INHERITED_READABILITY_DEPTH + 1,
- ),
- ).toEqual({ kind: 'denied' });
- });
-
- it('denies an object the role cannot read instead of admitting named grants', () => {
- expect(
- buildBypassed(
- {
- ...readEverything,
- principalIds: ['member-1'],
- objectsPermissions: {},
- },
- buildObject({ id: 'company', readability: MetadataReadability.OPEN }),
- ),
- ).toEqual({ kind: 'denied' });
- });
- });
-
it('keeps private records gated regardless of the sharing UI flag', () => {
const policy = buildCompiledRowAccessPolicy({
subject: readEverything,
diff --git a/packages/twenty-shared/src/types/FeatureFlagKey.ts b/packages/twenty-shared/src/types/FeatureFlagKey.ts
index 29c53e641f4..75da3018cce 100644
--- a/packages/twenty-shared/src/types/FeatureFlagKey.ts
+++ b/packages/twenty-shared/src/types/FeatureFlagKey.ts
@@ -9,7 +9,6 @@ export enum FeatureFlagKey {
IS_LOGS_SETTINGS_SECTION_ENABLED = 'IS_LOGS_SETTINGS_SECTION_ENABLED',
IS_RECORD_LEVEL_SHARING_ENABLED = 'IS_RECORD_LEVEL_SHARING_ENABLED',
IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED = 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED',
- IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED = 'IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED',
IS_AI_CHAT_INBOX_ENABLED = 'IS_AI_CHAT_INBOX_ENABLED',
IS_APP_PREFERENCES_ENABLED = 'IS_APP_PREFERENCES_ENABLED',
}