Skip to content

The open alternative to Salesforce, designed for AI.

fix(tools): report tool crashes to Sentry once, from dispatch (#27038)

Etienne0d01203e876a
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/interfaces/tool-retrieval-options.type.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/interfaces/tool-retrieval-options.type.ts
index a6639fbf44d..65e205093fa 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/interfaces/tool-retrieval-options.type.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/interfaces/tool-retrieval-options.type.ts
@@ -3,7 +3,6 @@ import { type ToolCategory } from 'twenty-shared/ai';
export type ToolRetrievalOptions = {
categories?: ToolCategory[];
excludeTools?: string[];
- wrapWithErrorContext?: boolean;
// Apply output compaction (strip nulls/empty values) to dispatch results
// before returning. Chat enables this to reduce token usage in the
// conversation context; MCP and workflow agents leave raw output intact.
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/services/__tests__/tool-executor.service.sender.spec.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/services/__tests__/tool-executor.service.sender.spec.ts
deleted file mode 100644
index 4f2b642384f..00000000000
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/services/__tests__/tool-executor.service.sender.spec.ts
+++ /dev/null
@@ -1,81 +0,0 @@
-import { ToolCategory } from 'twenty-shared/ai';
-import { ToolExecutorService } from 'src/engine/core-modules/tool-provider/services/tool-executor.service';
-import { type ToolProviderContext } from 'src/engine/core-modules/tool-provider/interfaces/tool-provider-context.type';
-import { type ToolIndexEntry } from 'src/engine/core-modules/tool-provider/types/tool-index-entry.type';
-
-const descriptor = {
- name: 'find_people',
- label: 'Find people',
- description: '',
- category: ToolCategory.DATABASE_CRUD,
- executionRef: {
- kind: 'database_crud',
- operation: 'find_many',
- objectNameSingular: 'person',
- },
-} as ToolIndexEntry;
-
-const build = () => {
- const findRecords = {
- execute: jest.fn().mockResolvedValue({ success: true }),
- };
- const service = new ToolExecutorService(
- [],
- findRecords as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- );
- const current = {
- workspaceId: 'workspace',
- roleId: 'current-role',
- rolePermissionConfig: { intersectionOf: ['current-role', 'app-role'] },
- authContext: {
- type: 'user',
- workspace: { id: 'workspace' },
- userWorkspaceId: 'sender',
- },
- } as ToolProviderContext;
- const resolveExecutionContext = jest.fn().mockResolvedValue(current);
- const context = {
- ...current,
- roleId: 'old-role',
- rolePermissionConfig: { unionOf: ['old-role'] },
- resolveExecutionContext,
- };
- return { service, findRecords, context, current, resolveExecutionContext };
-};
-
-describe('Tool execution sender permissions', () => {
- it('uses the sender’s current role and application intersection for an already loaded tool', async () => {
- const { service, findRecords, context, current } = build();
- await service.dispatch(descriptor, {}, context);
- expect(findRecords.execute).toHaveBeenCalledWith(
- expect.objectContaining({
- authContext: current.authContext,
- rolePermissionConfig: current.rolePermissionConfig,
- }),
- );
- });
-
- it('does not invoke the tool after the sender loses access during a turn', async () => {
- const { service, findRecords, context, resolveExecutionContext } = build();
- await service.dispatch(descriptor, {}, context);
- resolveExecutionContext.mockRejectedValue(
- new Error('Sender access revoked'),
- );
- await expect(service.dispatch(descriptor, {}, context)).rejects.toThrow(
- 'Sender access revoked',
- );
- expect(findRecords.execute).toHaveBeenCalledTimes(1);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-executor.service.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-executor.service.ts
index a857bbf75eb..4be2c30b1eb 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-executor.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-executor.service.ts
@@ -1,4 +1,4 @@
-import { Inject, Injectable, Logger } from '@nestjs/common';
+import { Inject, Injectable } from '@nestjs/common';
import { InjectRepository } from '@nestjs/typeorm';
import { type AggregateOperations } from 'twenty-shared/types';
@@ -9,6 +9,7 @@ import { type ObjectRecordGroupBy } from 'src/engine/api/graphql/workspace-query
import { type ToolProviderContext } from 'src/engine/core-modules/tool-provider/interfaces/tool-provider-context.type';
+import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
import { LogicFunctionExecutorService } from 'src/engine/core-modules/logic-function/logic-function-executor/logic-function-executor.service';
import { CreateManyRecordsService } from 'src/engine/core-modules/record-crud/services/create-many-records.service';
import { CreateRecordService } from 'src/engine/core-modules/record-crud/services/create-record.service';
@@ -27,6 +28,7 @@ import { type ToolDescriptor } from 'src/engine/core-modules/tool-provider/types
import { type ToolExecutionRef } from 'src/engine/core-modules/tool-provider/types/tool-execution-ref.type';
import { type ToolIndexEntry } from 'src/engine/core-modules/tool-provider/types/tool-index-entry.type';
import { buildRequiredToolAuthContext } from 'src/engine/core-modules/tool-provider/utils/build-required-tool-auth-context.util';
+import { buildToolExecutionFailure } from 'src/engine/core-modules/tool-provider/utils/build-tool-execution-failure.util';
import { withResolvedToolAuthContext } from 'src/engine/core-modules/tool-provider/utils/with-resolved-tool-auth-context.util';
import { type ToolOutput } from 'src/engine/core-modules/tool/types/tool-output.type';
import { UserEntity } from 'src/engine/core-modules/user/user.entity';
@@ -34,8 +36,6 @@ import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/works
@Injectable()
export class ToolExecutorService {
- private readonly logger = new Logger(ToolExecutorService.name);
-
constructor(
@Inject(TOOL_PROVIDERS)
private readonly providers: ToolProvider[],
@@ -53,6 +53,7 @@ export class ToolExecutorService {
private readonly workspaceCacheService: WorkspaceCacheService,
@InjectRepository(UserEntity)
private readonly userRepository: Repository<UserEntity>,
+ private readonly exceptionHandlerService: ExceptionHandlerService,
) {}
async dispatch(
@@ -60,19 +61,33 @@ export class ToolExecutorService {
args: Record<string, unknown> | undefined,
context: ToolProviderContext,
): Promise<ToolOutput> {
- const safeArgs = args ?? {};
- const executionContext = await (context.resolveExecutionContext?.() ??
- context);
+ try {
+ const executionContext = await (context.resolveExecutionContext?.() ??
+ context);
+
+ return await withResolvedToolAuthContext(
+ {
+ context: executionContext,
+ userRepository: this.userRepository,
+ workspaceCacheService: this.workspaceCacheService,
+ },
+ (contextWithAuth) =>
+ this.dispatchByExecutionRef(descriptor, args ?? {}, contextWithAuth),
+ );
+ } catch (error) {
+ const { output, shouldCapture } = buildToolExecutionFailure({
+ error,
+ toolName: descriptor.name,
+ });
+
+ if (shouldCapture) {
+ this.exceptionHandlerService.captureExceptions([error], {
+ workspace: { id: context.workspaceId },
+ });
+ }
- return withResolvedToolAuthContext(
- {
- context: executionContext,
- userRepository: this.userRepository,
- workspaceCacheService: this.workspaceCacheService,
- },
- (contextWithAuth) =>
- this.dispatchByExecutionRef(descriptor, safeArgs, contextWithAuth),
- );
+ return output;
+ }
}
private async dispatchByExecutionRef(
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-registry.service.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-registry.service.ts
index d6e6c9aee48..15576f53f17 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-registry.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/services/tool-registry.service.ts
@@ -9,6 +9,7 @@ import { type ToolProviderContext } from 'src/engine/core-modules/tool-provider/
import { type ToolProvider } from 'src/engine/core-modules/tool-provider/interfaces/tool-provider.interface';
import { type ToolRetrievalOptions } from 'src/engine/core-modules/tool-provider/interfaces/tool-retrieval-options.type';
+import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
import { TOOL_PROVIDERS } from 'src/engine/core-modules/tool-provider/constants/tool-providers.token';
import { compactToolOutput } from 'src/engine/core-modules/tool-provider/output-transforms/compact-tool-output.util';
import { normalizeToolOutputToJsonValues } from 'src/engine/core-modules/tool-provider/output-transforms/normalize-tool-output-to-json-values.util';
@@ -17,8 +18,8 @@ import { type LearnToolsAspect } from 'src/engine/core-modules/tool-provider/too
import { type ToolContext } from 'src/engine/core-modules/tool-provider/types/tool-context.type';
import { type ToolDescriptor } from 'src/engine/core-modules/tool-provider/types/tool-descriptor.type';
import { type ToolIndexEntry } from 'src/engine/core-modules/tool-provider/types/tool-index-entry.type';
+import { buildToolExecutionFailure } from 'src/engine/core-modules/tool-provider/utils/build-tool-execution-failure.util';
import { findSimilarToolNames } from 'src/engine/core-modules/tool-provider/utils/find-similar-tool-names.util';
-import { wrapWithErrorHandler } from 'src/engine/core-modules/tool-provider/utils/tool-error.util';
import { ToolOutputSpillService } from 'src/engine/core-modules/tool/services/tool-output-spill.service';
import { type ToolOutput } from 'src/engine/core-modules/tool/types/tool-output.type';
import { type RolePermissionConfig } from 'src/engine/twenty-orm/types/role-permission-config.type';
@@ -32,6 +33,7 @@ export class ToolRegistryService {
private readonly providers: ToolProvider[],
private readonly toolExecutorService: ToolExecutorService,
private readonly toolOutputSpillService: ToolOutputSpillService,
+ private readonly exceptionHandlerService: ExceptionHandlerService,
) {}
async getCatalog(
@@ -126,7 +128,6 @@ export class ToolRegistryService {
descriptors: ToolDescriptor[],
context: ToolProviderContext,
options?: {
- wrapWithErrorContext?: boolean;
compactOutput?: boolean;
spillLargeOutput?: boolean;
},
@@ -165,9 +166,7 @@ export class ToolRegistryService {
toolSet[descriptor.name] = {
description: descriptor.description,
inputSchema: jsonSchema(schema),
- execute: options?.wrapWithErrorContext
- ? wrapWithErrorHandler(descriptor.name, executeFn)
- : executeFn,
+ execute: executeFn,
};
}
@@ -356,16 +355,22 @@ export class ToolRegistryService {
return normalizeToolOutputToJsonValues(inlined);
} catch (error) {
- const errorMessage =
- error instanceof Error ? error.message : String(error);
+ const { output, shouldCapture } = buildToolExecutionFailure({
+ error,
+ toolName,
+ });
- this.logger.error(`Error executing tool "${toolName}": ${errorMessage}`);
+ if (shouldCapture) {
+ this.exceptionHandlerService.captureExceptions([error], {
+ workspace: { id: context.workspaceId },
+ });
+ }
- return {
- success: false,
- message: `Failed to execute ${toolName}`,
- error: errorMessage,
- };
+ this.logger.error(
+ `Error executing tool "${toolName}" in workspace ${context.workspaceId}: ${output.error}`,
+ );
+
+ return output;
}
}
@@ -386,13 +391,8 @@ export class ToolRegistryService {
context: ToolProviderContext,
options: ToolRetrievalOptions = {},
): Promise<ToolSet> {
- const {
- categories,
- excludeTools,
- wrapWithErrorContext,
- compactOutput,
- spillLargeOutput,
- } = options;
+ const { categories, excludeTools, compactOutput, spillLargeOutput } =
+ options;
const categorySet = categories ? new Set(categories) : undefined;
const results = await Promise.all(
@@ -424,7 +424,6 @@ export class ToolRegistryService {
}
const toolSet = this.hydrateToolSet(filteredDescriptors, context, {
- wrapWithErrorContext,
compactOutput,
spillLargeOutput,
});
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/tools/__tests__/execute-tool.tool.spec.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/tools/__tests__/execute-tool.tool.spec.ts
index 501a18fd60d..61e95ae28a2 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/tools/__tests__/execute-tool.tool.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/tools/__tests__/execute-tool.tool.spec.ts
@@ -44,6 +44,17 @@ describe('createExecuteToolTool', () => {
expect(result.success).toBe(false);
});
+ it('refuses a call without a tool name without touching the registry', async () => {
+ const toolRegistry = buildRegistry();
+
+ const executeTool = createExecuteToolTool(toolRegistry, context);
+
+ const result = await executeTool.execute({ arguments: {} } as never);
+
+ expect(toolRegistry.resolveAndExecute).not.toHaveBeenCalled();
+ expect(result.success).toBe(false);
+ });
+
it('executes any tool when no predicate is provided', async () => {
const toolRegistry = buildRegistry();
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/tools/execute-tool.tool.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/tools/execute-tool.tool.ts
index e6325f205db..10e239fe367 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/tools/execute-tool.tool.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/tools/execute-tool.tool.ts
@@ -1,3 +1,4 @@
+import { isNonEmptyString } from '@sniptt/guards';
import { jsonSchema } from 'ai';
import { type JSONSchema7 } from 'json-schema';
import { z } from 'zod';
@@ -55,6 +56,15 @@ export const createExecuteToolTool = (
'Execute a tool by name with arguments. Call learn_tools first to discover the required input schema.',
inputSchema: executeToolInputSchema,
execute: async (parameters: ExecuteToolInput): Promise<ToolOutput> => {
+ if (!isNonEmptyString(parameters?.toolName)) {
+ return {
+ success: false,
+ message: 'Tool name is required',
+ error:
+ 'Tool name is required. Pass the tool name confirmed by learn_tools as toolName.',
+ };
+ }
+
const { toolName, arguments: args = {} } = parameters;
if (options?.isToolAllowed?.(toolName) === false) {
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/build-tool-execution-failure.util.spec.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/build-tool-execution-failure.util.spec.ts
new file mode 100644
index 00000000000..4edaf6d19aa
--- /dev/null
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/build-tool-execution-failure.util.spec.ts
@@ -0,0 +1,60 @@
+import { buildToolExecutionFailure } from 'src/engine/core-modules/tool-provider/utils/build-tool-execution-failure.util';
+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
+
+describe('buildToolExecutionFailure', () => {
+ it('should report a crash and return its message', () => {
+ expect(
+ buildToolExecutionFailure({
+ error: new TypeError(
+ "Cannot read properties of undefined (reading 'id')",
+ ),
+ toolName: 'find_people',
+ }),
+ ).toEqual({
+ output: {
+ success: false,
+ message: 'Failed to execute find_people',
+ error: "Cannot read properties of undefined (reading 'id')",
+ },
+ shouldCapture: true,
+ });
+ });
+
+ it('should return validation errors without reporting them', () => {
+ const error = new WorkspaceMigrationBuilderException({
+ status: 'fail',
+ report: {
+ view: [
+ {
+ errors: [{ code: 'INVALID_NAME', message: 'Name is required' }],
+ flatEntityMinimalInformation: { name: 'All people' },
+ },
+ ],
+ },
+ } as never);
+
+ expect(
+ buildToolExecutionFailure({ error, toolName: 'create_view' }),
+ ).toEqual({
+ output: {
+ success: false,
+ message: 'Failed to execute create_view',
+ error: 'Validation errors:\n[view] Name is required (All people)',
+ },
+ shouldCapture: false,
+ });
+ });
+
+ it('should report a thrown value that is not an Error', () => {
+ expect(
+ buildToolExecutionFailure({ error: 'boom', toolName: 'find_people' }),
+ ).toEqual({
+ output: {
+ success: false,
+ message: 'Failed to execute find_people',
+ error: 'boom',
+ },
+ shouldCapture: true,
+ });
+ });
+});
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/is-failed-tool-output.util.spec.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/is-failed-tool-output.util.spec.ts
new file mode 100644
index 00000000000..756b6f979b7
--- /dev/null
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/is-failed-tool-output.util.spec.ts
@@ -0,0 +1,21 @@
+import { isFailedToolOutput } from 'src/engine/core-modules/tool-provider/utils/is-failed-tool-output.util';
+
+describe('isFailedToolOutput', () => {
+ it.each([
+ [
+ 'a tool output reporting a failure',
+ { success: false, message: 'Failed to execute find_people' },
+ true,
+ ],
+ [
+ 'a tool output reporting a success',
+ { success: true, message: 'Found 2 people' },
+ false,
+ ],
+ ['a factory result without a success flag', { id: 'view-id' }, false],
+ ['a result that is not an object', true, false],
+ ['a missing result', undefined, false],
+ ])('should classify %s', (_, output, isFailed) => {
+ expect(isFailedToolOutput(output)).toBe(isFailed);
+ });
+});
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/is-user-facing-tool-execution-error.util.spec.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/is-user-facing-tool-execution-error.util.spec.ts
new file mode 100644
index 00000000000..c85ed59ef57
--- /dev/null
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/__tests__/is-user-facing-tool-execution-error.util.spec.ts
@@ -0,0 +1,172 @@
+import { WorkspaceMigrationV2ExceptionCode } from 'twenty-shared/metadata';
+
+import {
+ AuthException,
+ AuthExceptionCode,
+} from 'src/engine/core-modules/auth/auth.exception';
+import { isUserFacingToolExecutionError } from 'src/engine/core-modules/tool-provider/utils/is-user-facing-tool-execution-error.util';
+import {
+ AiException,
+ AiExceptionCode,
+} from 'src/engine/metadata-modules/ai/ai.exception';
+import {
+ FieldMetadataException,
+ FieldMetadataExceptionCode,
+} from 'src/engine/metadata-modules/field-metadata/field-metadata.exception';
+import {
+ FlatEntityMapsException,
+ FlatEntityMapsExceptionCode,
+} from 'src/engine/metadata-modules/flat-entity/exceptions/flat-entity-maps.exception';
+import {
+ LogicFunctionException,
+ LogicFunctionExceptionCode,
+} from 'src/engine/metadata-modules/logic-function/logic-function.exception';
+import {
+ ObjectMetadataException,
+ ObjectMetadataExceptionCode,
+} from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';
+import {
+ ViewException,
+ ViewExceptionCode,
+} from 'src/engine/metadata-modules/view/exceptions/view.exception';
+import {
+ TwentyOrmException,
+ TwentyOrmExceptionCode,
+} from 'src/engine/twenty-orm/exceptions/twenty-orm.exception';
+import { WorkspaceMigrationV2Exception } from 'src/engine/workspace-manager/workspace-migration.exception';
+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
+import {
+ WorkspaceMigrationRunnerException,
+ WorkspaceMigrationRunnerExceptionCode,
+} from 'src/engine/workspace-manager/workspace-migration/workspace-migration-runner/exceptions/workspace-migration-runner.exception';
+
+describe('isUserFacingToolExecutionError', () => {
+ it.each([
+ [
+ 'a metadata validation failure',
+ new WorkspaceMigrationBuilderException({} as never),
+ true,
+ ],
+ [
+ 'a view the model referenced that does not exist',
+ new ViewException('View not found', ViewExceptionCode.VIEW_NOT_FOUND),
+ true,
+ ],
+ [
+ 'a view missing right after its own upsert',
+ new ViewException(
+ 'View not found after upsert',
+ ViewExceptionCode.INTERNAL_SERVER_ERROR,
+ ),
+ false,
+ ],
+ [
+ 'a migration blocked during a hot upgrade',
+ new WorkspaceMigrationRunnerException({
+ message: 'Workspace schema DDL changes are locked',
+ code: WorkspaceMigrationRunnerExceptionCode.DDL_LOCKED,
+ }),
+ true,
+ ],
+ [
+ 'a migration whose application is missing from the cache',
+ new WorkspaceMigrationRunnerException({
+ message: 'Could not find application',
+ code: WorkspaceMigrationRunnerExceptionCode.APPLICATION_NOT_FOUND,
+ }),
+ false,
+ ],
+ [
+ 'a database input error',
+ new TwentyOrmException(
+ 'Unknown column',
+ TwentyOrmExceptionCode.UNKNOWN_COLUMN,
+ ),
+ true,
+ ],
+ [
+ 'a database read timeout',
+ new TwentyOrmException(
+ 'Query read timeout',
+ TwentyOrmExceptionCode.QUERY_READ_TIMEOUT,
+ ),
+ false,
+ ],
+ [
+ 'a disabled logic function',
+ new LogicFunctionException(
+ 'Disabled',
+ LogicFunctionExceptionCode.LOGIC_FUNCTION_DISABLED,
+ ),
+ true,
+ ],
+ [
+ 'a logic function build timing out on the platform',
+ new LogicFunctionException(
+ 'Lambda timed out during BUILD',
+ LogicFunctionExceptionCode.LOGIC_FUNCTION_EXECUTION_TIMEOUT,
+ ),
+ false,
+ ],
+ [
+ 'an object the model referenced that does not exist',
+ new ObjectMetadataException(
+ 'Object not found',
+ ObjectMetadataExceptionCode.OBJECT_METADATA_NOT_FOUND,
+ ),
+ true,
+ ],
+ [
+ 'a field the model referenced that does not exist',
+ new FieldMetadataException(
+ 'Field not found',
+ FieldMetadataExceptionCode.FIELD_METADATA_NOT_FOUND,
+ ),
+ true,
+ ],
+ [
+ 'a relation id the model passed that does not exist',
+ new FlatEntityMapsException(
+ 'Could not find fieldMetadata for given fieldMetadataId',
+ FlatEntityMapsExceptionCode.RELATION_UNIVERSAL_IDENTIFIER_NOT_FOUND,
+ ),
+ true,
+ ],
+ [
+ 'an entity missing from the cache after a migration',
+ new FlatEntityMapsException(
+ 'Could not find flat entity in maps',
+ FlatEntityMapsExceptionCode.ENTITY_NOT_FOUND,
+ ),
+ false,
+ ],
+ [
+ 'a chat thread deleted during the turn',
+ new AiException('Thread is deleted', AiExceptionCode.THREAD_NOT_FOUND),
+ true,
+ ],
+ [
+ 'a sender removed from the workspace during the turn',
+ new AuthException(
+ 'User workspace not found',
+ AuthExceptionCode.UNAUTHENTICATED,
+ ),
+ true,
+ ],
+ [
+ 'a validator crash wrapped by the migration builder',
+ new WorkspaceMigrationV2Exception(
+ 'Could not find flat entity with universal identifier',
+ WorkspaceMigrationV2ExceptionCode.BUILDER_INTERNAL_SERVER_ERROR,
+ ),
+ false,
+ ],
+ [
+ 'a plain runtime error',
+ new TypeError("Cannot read properties of undefined (reading 'id')"),
+ false,
+ ],
+ ])('should classify %s', (_, error, isUserFacing) => {
+ expect(isUserFacingToolExecutionError(error)).toBe(isUserFacing);
+ });
+});
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/build-tool-execution-failure.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/build-tool-execution-failure.util.ts
new file mode 100644
index 00000000000..3439f3d303c
--- /dev/null
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/build-tool-execution-failure.util.ts
@@ -0,0 +1,30 @@
+import { formatValidationErrors } from 'src/engine/core-modules/tool-provider/utils/format-validation-errors.util';
+import { isUserFacingToolExecutionError } from 'src/engine/core-modules/tool-provider/utils/is-user-facing-tool-execution-error.util';
+import { type ToolOutput } from 'src/engine/core-modules/tool/types/tool-output.type';
+import { shouldCaptureException } from 'src/engine/utils/global-exception-handler.util';
+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
+
+const getToolExecutionErrorMessage = (error: unknown): string => {
+ if (error instanceof WorkspaceMigrationBuilderException) {
+ return formatValidationErrors(error);
+ }
+
+ return error instanceof Error ? error.message : String(error);
+};
+
+export const buildToolExecutionFailure = ({
+ error,
+ toolName,
+}: {
+ error: unknown;
+ toolName: string;
+}): { output: ToolOutput; shouldCapture: boolean } => ({
+ output: {
+ success: false,
+ message: `Failed to execute ${toolName}`,
+ error: getToolExecutionErrorMessage(error),
+ },
+ shouldCapture:
+ !(error instanceof Error) ||
+ (!isUserFacingToolExecutionError(error) && shouldCaptureException(error)),
+});
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-failed-tool-output.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-failed-tool-output.util.ts
new file mode 100644
index 00000000000..a1cfbedf35e
--- /dev/null
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-failed-tool-output.util.ts
@@ -0,0 +1,6 @@
+import { isObject } from '@sniptt/guards';
+
+export const isFailedToolOutput = (
+ output: unknown,
+): output is { success: false; error?: unknown; message?: unknown } =>
+ isObject(output) && 'success' in output && output.success === false;
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-tool-output-successful.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-tool-output-successful.util.ts
index ed8cf5d16bc..678ec14b4e8 100644
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-tool-output-successful.util.ts
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-tool-output-successful.util.ts
@@ -1,8 +1,4 @@
-import { isObject } from '@sniptt/guards';
+import { isFailedToolOutput } from 'src/engine/core-modules/tool-provider/utils/is-failed-tool-output.util';
-export const isToolOutputSuccessful = (output: unknown): boolean => {
- const isFailure =
- isObject(output) && 'success' in output && output.success === false;
-
- return !isFailure;
-};
+export const isToolOutputSuccessful = (output: unknown): boolean =>
+ !isFailedToolOutput(output);
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-user-facing-tool-execution-error.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-user-facing-tool-execution-error.util.ts
new file mode 100644
index 00000000000..4677c441192
--- /dev/null
+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/is-user-facing-tool-execution-error.util.ts
@@ -0,0 +1,122 @@
+import {
+ AuthException,
+ AuthExceptionCode,
+} from 'src/engine/core-modules/auth/auth.exception';
+import { isUsageRefusedError } from 'src/engine/core-modules/billing/utils/is-usage-refused-error.util';
+import {
+ AiException,
+ AiExceptionCode,
+} from 'src/engine/metadata-modules/ai/ai.exception';
+import {
+ FieldMetadataException,
+ FieldMetadataExceptionCode,
+} from 'src/engine/metadata-modules/field-metadata/field-metadata.exception';
+import {
+ FlatEntityMapsException,
+ FlatEntityMapsExceptionCode,
+} from 'src/engine/metadata-modules/flat-entity/exceptions/flat-entity-maps.exception';
+import {
+ LogicFunctionException,
+ LogicFunctionExceptionCode,
+} from 'src/engine/metadata-modules/logic-function/logic-function.exception';
+import {
+ ObjectMetadataException,
+ ObjectMetadataExceptionCode,
+} from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';
+import { ViewFieldException } from 'src/engine/metadata-modules/view-field/exceptions/view-field.exception';
+import { ViewFilterException } from 'src/engine/metadata-modules/view-filter/exceptions/view-filter.exception';
+import { ViewSortException } from 'src/engine/metadata-modules/view-sort/exceptions/view-sort.exception';
+import {
+ ViewException,
+ ViewExceptionCode,
+} from 'src/engine/metadata-modules/view/exceptions/view.exception';
+import { TwentyOrmException } from 'src/engine/twenty-orm/exceptions/twenty-orm.exception';
+import { isTwentyOrmUserInputError } from 'src/engine/twenty-orm/utils/is-twenty-orm-user-input-error.util';
+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
+import {
+ WorkspaceMigrationRunnerException,
+ WorkspaceMigrationRunnerExceptionCode,
+} from 'src/engine/workspace-manager/workspace-migration/workspace-migration-runner/exceptions/workspace-migration-runner.exception';
+
+const USER_FACING_WORKSPACE_MIGRATION_RUNNER_EXCEPTION_CODES: (keyof typeof WorkspaceMigrationRunnerExceptionCode)[] =
+ [
+ WorkspaceMigrationRunnerExceptionCode.DEFERRED_WORKSPACE_MIGRATION_ACTIONS_IN_PROGRESS,
+ WorkspaceMigrationRunnerExceptionCode.DDL_LOCKED,
+ ];
+
+const USER_FACING_LOGIC_FUNCTION_EXCEPTION_CODES = [
+ LogicFunctionExceptionCode.LOGIC_FUNCTION_DISABLED,
+ LogicFunctionExceptionCode.LOGIC_FUNCTION_COMPILATION_FAILED,
+ LogicFunctionExceptionCode.LOGIC_FUNCTION_DEPENDENCIES_SIZE_EXCEEDED,
+ LogicFunctionExceptionCode.INVALID_LOGIC_FUNCTION_INPUT,
+];
+
+const USER_FACING_OBJECT_METADATA_EXCEPTION_CODES = [
+ ObjectMetadataExceptionCode.OBJECT_METADATA_NOT_FOUND,
+ ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,
+];
+
+const USER_FACING_FIELD_METADATA_EXCEPTION_CODES: FieldMetadataExceptionCode[] =
+ [
+ FieldMetadataExceptionCode.FIELD_METADATA_NOT_FOUND,
+ FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
+ FieldMetadataExceptionCode.FIELD_MUTATION_NOT_ALLOWED,
+ ];
+
+// TODO: this allowlist duplicates the per-domain classification already done by the REST
+// and GraphQL exception filters. Refactor their code-to-status
+// mapping into shared utils and rely on them here, capturing only 5xx.
+export const isUserFacingToolExecutionError = (error: unknown): boolean => {
+ if (
+ error instanceof WorkspaceMigrationBuilderException ||
+ error instanceof ViewFieldException ||
+ error instanceof ViewFilterException ||
+ error instanceof ViewSortException ||
+ isUsageRefusedError(error)
+ ) {
+ return true;
+ }
+
+ if (error instanceof ViewException) {
+ return error.code !== ViewExceptionCode.INTERNAL_SERVER_ERROR;
+ }
+
+ if (error instanceof WorkspaceMigrationRunnerException) {
+ return USER_FACING_WORKSPACE_MIGRATION_RUNNER_EXCEPTION_CODES.includes(
+ error.code,
+ );
+ }
+
+ if (error instanceof TwentyOrmException) {
+ return isTwentyOrmUserInputError(error);
+ }
+
+ if (error instanceof LogicFunctionException) {
+ return USER_FACING_LOGIC_FUNCTION_EXCEPTION_CODES.includes(error.code);
+ }
+
+ if (error instanceof ObjectMetadataException) {
+ return USER_FACING_OBJECT_METADATA_EXCEPTION_CODES.includes(error.code);
+ }
+
+ if (error instanceof FieldMetadataException) {
+ return USER_FACING_FIELD_METADATA_EXCEPTION_CODES.includes(error.code);
+ }
+
+ if (error instanceof FlatEntityMapsException) {
+ return (
+ error.code ===
+ FlatEntityMapsExceptionCode.RELATION_UNIVERSAL_IDENTIFIER_NOT_FOUND
+ );
+ }
+
+ if (error instanceof AiException) {
+ return error.code === AiExceptionCode.THREAD_NOT_FOUND;
+ }
+
+ if (error instanceof AuthException) {
+ return error.code === AuthExceptionCode.UNAUTHENTICATED;
+ }
+
+ return false;
+};
diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/tool-error.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/tool-error.util.ts
deleted file mode 100644
index 1d0a22c97e6..00000000000
--- a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/tool-error.util.ts
+++ /dev/null
@@ -1,21 +0,0 @@
-import { type ToolOutput } from 'src/engine/core-modules/tool/types/tool-output.type';
-
-export const wrapWithErrorHandler = (
- toolName: string,
- executeFn: (args: Record<string, unknown>) => Promise<ToolOutput>,
-): ((args: Record<string, unknown>) => Promise<ToolOutput>) => {
- return async (args: Record<string, unknown>) => {
- try {
- return await executeFn(args);
- } catch (error) {
- const errorMessage =
- error instanceof Error ? error.message : String(error);
-
- return {
- success: false,
- message: `Failed to execute ${toolName}`,
- error: errorMessage,
- };
- }
- };
-};
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-async-executor.service.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-async-executor.service.ts
index 3233b58a93b..6173ba70b44 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-async-executor.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-async-executor.service.ts
@@ -178,7 +178,6 @@ export class AgentAsyncExecutorService {
...OUTPUT_NAVIGATION_TOOL_NAMES,
...WORKFLOW_AGENT_EXCLUDED_TOOL_NAMES,
],
- wrapWithErrorContext: false,
});
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/__tests__/map-ai-steps-to-tool-call-logs.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/__tests__/map-ai-steps-to-tool-call-logs.util.spec.ts
index 20f39bfc302..708e9f114d3 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/__tests__/map-ai-steps-to-tool-call-logs.util.spec.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/__tests__/map-ai-steps-to-tool-call-logs.util.spec.ts
@@ -68,6 +68,37 @@ describe('mapAiStepsToToolCallLogs', () => {
expect(result[0].errorMessage).toContain('Validation failed');
});
+ it('marks a tool-result whose output reports a failure as error', () => {
+ const output = {
+ success: false,
+ message: 'Failed to execute create_view',
+ error: 'View not found',
+ };
+ const steps = [
+ buildStep([
+ {
+ type: 'tool-call',
+ toolName: 'create_view',
+ toolCallId: 'call_3',
+ input: {},
+ } as StepContentPart,
+ {
+ type: 'tool-result',
+ toolName: 'create_view',
+ toolCallId: 'call_3',
+ input: {},
+ output,
+ } as StepContentPart,
+ ]),
+ ];
+
+ expect(mapAiStepsToToolCallLogs(steps)[0]).toMatchObject({
+ state: 'error',
+ errorMessage: 'View not found',
+ output,
+ });
+ });
+
it('truncates oversized tool input and output', () => {
const longString = 'x'.repeat(50_000);
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/map-ai-steps-to-tool-call-logs.util.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/map-ai-steps-to-tool-call-logs.util.ts
index fb68ec44f6f..b66e8c25c6c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/map-ai-steps-to-tool-call-logs.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/map-ai-steps-to-tool-call-logs.util.ts
@@ -2,6 +2,7 @@ import { type StepResult, type ToolSet } from 'ai';
import { type AiToolCallLog } from 'twenty-shared/workflow';
+import { isFailedToolOutput } from 'src/engine/core-modules/tool-provider/utils/is-failed-tool-output.util';
import {
TRUNCATION_SENTINEL,
truncateStringToUtf8ByteBudget,
@@ -118,7 +119,15 @@ export const mapAiStepsToToolCallLogs = (
stripNoisyKeysDeep(part.output),
maxToolOutputBytes,
);
- entry.state = 'success';
+
+ if (isFailedToolOutput(part.output)) {
+ entry.errorMessage = String(
+ part.output.error ?? part.output.message,
+ ).slice(0, MAX_ERROR_MESSAGE_LENGTH);
+ entry.state = 'error';
+ } else {
+ entry.state = 'success';
+ }
}
continue;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/field-metadata/tools/field-metadata-tools.factory.ts b/packages/twenty-server/src/engine/metadata-modules/field-metadata/tools/field-metadata-tools.factory.ts
index b89ef6d9c88..8ec992c06cc 100644
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/tools/field-metadata-tools.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/tools/field-metadata-tools.factory.ts
@@ -9,14 +9,16 @@ import {
import { FieldMetadataType, RelationType } from 'twenty-shared/types';
import { z } from 'zod';
+import {
+ ObjectMetadataException,
+ ObjectMetadataExceptionCode,
+} from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';
import { METADATA_TOOL_EXCLUDED_FIELD_NAMES } from 'src/engine/core-modules/tool-provider/constants/metadata-tool-excluded-field-names.constant';
import { compactMetadataOutput } from 'src/engine/core-modules/tool-provider/utils/compact-metadata-output.util';
-import { formatValidationErrors } from 'src/engine/core-modules/tool-provider/utils/format-validation-errors.util';
import { normalizeIconName } from 'src/engine/core-modules/tool-provider/utils/normalize-icon-name.util';
import { FieldMetadataService } from 'src/engine/metadata-modules/field-metadata/services/field-metadata.service';
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
import { getObjectMetadataIdByName } from 'src/engine/metadata-modules/flat-object-metadata/utils/get-object-metadata-id-by-name.util';
-import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
import { isDefined } from 'twenty-shared/utils';
const FIELD_STRIP_WHEN_NULLISH = [
@@ -223,8 +225,9 @@ export class FieldMetadataToolsFactory {
});
if (!isDefined(objectMetadataId)) {
- throw new Error(
+ throw new ObjectMetadataException(
`Object "${objectName}" not found. Use get_object_metadata to list available objects.`,
+ ObjectMetadataExceptionCode.OBJECT_METADATA_NOT_FOUND,
);
}
@@ -309,39 +312,32 @@ export class FieldMetadataToolsFactory {
isRemoteCreation?: boolean;
relationCreationPayload?: unknown;
}) => {
- try {
- const { icon, relationCreationPayload, ...createFieldInput } =
- parameters;
-
- const flatFieldMetadata =
- await this.fieldMetadataService.createOneField({
- createFieldInput: {
- ...createFieldInput,
- icon:
- normalizeIconName(icon) ??
- FIELD_TYPE_DEFAULT_ICONS[parameters.type],
- relationCreationPayload: normalizeRelationCreationPayloadIcon(
- relationCreationPayload,
- ),
- } as Parameters<
- typeof this.fieldMetadataService.createOneField
- >[0]['createFieldInput'],
- workspaceId,
- });
+ const { icon, relationCreationPayload, ...createFieldInput } =
+ parameters;
- return {
- id: flatFieldMetadata.id,
- name: flatFieldMetadata.name,
- label: flatFieldMetadata.label,
- type: flatFieldMetadata.type,
- objectMetadataId: flatFieldMetadata.objectMetadataId,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ const flatFieldMetadata =
+ await this.fieldMetadataService.createOneField({
+ createFieldInput: {
+ ...createFieldInput,
+ icon:
+ normalizeIconName(icon) ??
+ FIELD_TYPE_DEFAULT_ICONS[parameters.type],
+ relationCreationPayload: normalizeRelationCreationPayloadIcon(
+ relationCreationPayload,
+ ),
+ } as Parameters<
+ typeof this.fieldMetadataService.createOneField
+ >[0]['createFieldInput'],
+ workspaceId,
+ });
+
+ return {
+ id: flatFieldMetadata.id,
+ name: flatFieldMetadata.name,
+ label: flatFieldMetadata.label,
+ type: flatFieldMetadata.type,
+ objectMetadataId: flatFieldMetadata.objectMetadataId,
+ };
},
},
update_field_metadata: {
@@ -362,56 +358,40 @@ export class FieldMetadataToolsFactory {
settings?: unknown;
isLabelSyncedWithName?: boolean;
}) => {
- try {
- const { id, icon, ...update } = parameters;
- const normalizedIcon = normalizeIconName(icon);
-
- const flatFieldMetadata =
- await this.fieldMetadataService.updateOneField({
- updateFieldInput: {
- id,
- ...update,
- ...(isDefined(normalizedIcon)
- ? { icon: normalizedIcon }
- : {}),
- } as Parameters<
- typeof this.fieldMetadataService.updateOneField
- >[0]['updateFieldInput'],
- workspaceId,
- });
+ const { id, icon, ...update } = parameters;
+ const normalizedIcon = normalizeIconName(icon);
+
+ const flatFieldMetadata =
+ await this.fieldMetadataService.updateOneField({
+ updateFieldInput: {
+ id,
+ ...update,
+ ...(isDefined(normalizedIcon) ? { icon: normalizedIcon } : {}),
+ } as Parameters<
+ typeof this.fieldMetadataService.updateOneField
+ >[0]['updateFieldInput'],
+ workspaceId,
+ });
- return {
- id: flatFieldMetadata.id,
- name: flatFieldMetadata.name,
- label: flatFieldMetadata.label,
- type: flatFieldMetadata.type,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return {
+ id: flatFieldMetadata.id,
+ name: flatFieldMetadata.name,
+ label: flatFieldMetadata.label,
+ type: flatFieldMetadata.type,
+ };
},
},
delete_field_metadata: {
description: 'Delete a field by ID.',
inputSchema: DeleteFieldMetadataInputSchema,
execute: async (parameters: { id: string }) => {
- try {
- const flatFieldMetadata =
- await this.fieldMetadataService.deleteOneField({
- deleteOneFieldInput: { id: parameters.id },
- workspaceId,
- });
+ const flatFieldMetadata =
+ await this.fieldMetadataService.deleteOneField({
+ deleteOneFieldInput: { id: parameters.id },
+ workspaceId,
+ });
- return { id: flatFieldMetadata.id, success: true };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return { id: flatFieldMetadata.id, success: true };
},
},
create_many_field_metadata: {
@@ -436,31 +416,24 @@ export class FieldMetadataToolsFactory {
relationCreationPayload?: unknown;
}>;
}) => {
- try {
- await this.fieldMetadataService.createManyFields({
- createFieldInputs: parameters.fields.map(
- ({ icon, relationCreationPayload, ...createFieldInput }) => ({
- ...createFieldInput,
- icon:
- normalizeIconName(icon) ??
- FIELD_TYPE_DEFAULT_ICONS[createFieldInput.type],
- relationCreationPayload: normalizeRelationCreationPayloadIcon(
- relationCreationPayload,
- ),
- }),
- ) as Parameters<
- typeof this.fieldMetadataService.createManyFields
- >[0]['createFieldInputs'],
- workspaceId,
- });
+ await this.fieldMetadataService.createManyFields({
+ createFieldInputs: parameters.fields.map(
+ ({ icon, relationCreationPayload, ...createFieldInput }) => ({
+ ...createFieldInput,
+ icon:
+ normalizeIconName(icon) ??
+ FIELD_TYPE_DEFAULT_ICONS[createFieldInput.type],
+ relationCreationPayload: normalizeRelationCreationPayloadIcon(
+ relationCreationPayload,
+ ),
+ }),
+ ) as Parameters<
+ typeof this.fieldMetadataService.createManyFields
+ >[0]['createFieldInputs'],
+ workspaceId,
+ });
- return true;
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return true;
},
},
update_many_field_metadata: {
@@ -483,33 +456,26 @@ export class FieldMetadataToolsFactory {
isLabelSyncedWithName?: boolean;
}>;
}) => {
- try {
- await Promise.all(
- parameters.fields.map(async ({ id, icon, ...update }) => {
- const normalizedIcon = normalizeIconName(icon);
-
- await this.fieldMetadataService.updateOneField({
- updateFieldInput: {
- id,
- ...update,
- ...(isDefined(normalizedIcon)
- ? { icon: normalizedIcon }
- : {}),
- } as Parameters<
- typeof this.fieldMetadataService.updateOneField
- >[0]['updateFieldInput'],
- workspaceId,
- });
- }),
- );
-
- return true;
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ await Promise.all(
+ parameters.fields.map(async ({ id, icon, ...update }) => {
+ const normalizedIcon = normalizeIconName(icon);
+
+ await this.fieldMetadataService.updateOneField({
+ updateFieldInput: {
+ id,
+ ...update,
+ ...(isDefined(normalizedIcon)
+ ? { icon: normalizedIcon }
+ : {}),
+ } as Parameters<
+ typeof this.fieldMetadataService.updateOneField
+ >[0]['updateFieldInput'],
+ workspaceId,
+ });
+ }),
+ );
+
+ return true;
},
},
create_many_relation_fields: {
@@ -528,38 +494,31 @@ export class FieldMetadataToolsFactory {
targetFieldIcon: string;
}>;
}) => {
- try {
- await this.fieldMetadataService.createManyFields({
- createFieldInputs: parameters.relations.map((relation) => ({
- objectMetadataId: relation.objectMetadataId,
- type: FieldMetadataType.RELATION,
- name: relation.name,
- label: relation.label,
- description: relation.description,
- icon:
- normalizeIconName(relation.icon) ??
+ await this.fieldMetadataService.createManyFields({
+ createFieldInputs: parameters.relations.map((relation) => ({
+ objectMetadataId: relation.objectMetadataId,
+ type: FieldMetadataType.RELATION,
+ name: relation.name,
+ label: relation.label,
+ description: relation.description,
+ icon:
+ normalizeIconName(relation.icon) ??
+ FIELD_TYPE_DEFAULT_ICONS[FieldMetadataType.RELATION],
+ relationCreationPayload: {
+ type: relation.type,
+ targetObjectMetadataId: relation.targetObjectMetadataId,
+ targetFieldLabel: relation.targetFieldLabel,
+ targetFieldIcon:
+ normalizeIconName(relation.targetFieldIcon) ??
FIELD_TYPE_DEFAULT_ICONS[FieldMetadataType.RELATION],
- relationCreationPayload: {
- type: relation.type,
- targetObjectMetadataId: relation.targetObjectMetadataId,
- targetFieldLabel: relation.targetFieldLabel,
- targetFieldIcon:
- normalizeIconName(relation.targetFieldIcon) ??
- FIELD_TYPE_DEFAULT_ICONS[FieldMetadataType.RELATION],
- },
- })) as Parameters<
- typeof this.fieldMetadataService.createManyFields
- >[0]['createFieldInputs'],
- workspaceId,
- });
-
- return true;
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ },
+ })) as Parameters<
+ typeof this.fieldMetadataService.createManyFields
+ >[0]['createFieldInputs'],
+ workspaceId,
+ });
+
+ return true;
},
},
};
diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts
index 807673bacfc..c02f71e48fd 100644
--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts
@@ -593,7 +593,7 @@ export class ObjectMetadataService {
if (!isDefined(createdFlatObjectMetadata)) {
throw new ObjectMetadataException(
'Created object metadata not found in recomputed cache',
- ObjectMetadataExceptionCode.OBJECT_METADATA_NOT_FOUND,
+ ObjectMetadataExceptionCode.INTERNAL_SERVER_ERROR,
);
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/tools/object-metadata-tools.factory.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/tools/object-metadata-tools.factory.ts
index af42cd912d3..7e14e548044 100644
--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/tools/object-metadata-tools.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/tools/object-metadata-tools.factory.ts
@@ -7,12 +7,10 @@ import { z } from 'zod';
import { METADATA_TOOL_EXCLUDED_FIELD_NAMES } from 'src/engine/core-modules/tool-provider/constants/metadata-tool-excluded-field-names.constant';
import { compactMetadataOutput } from 'src/engine/core-modules/tool-provider/utils/compact-metadata-output.util';
-import { formatValidationErrors } from 'src/engine/core-modules/tool-provider/utils/format-validation-errors.util';
import { normalizeIconName } from 'src/engine/core-modules/tool-provider/utils/normalize-icon-name.util';
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
import { fromFlatObjectMetadataToObjectMetadataDto } from 'src/engine/metadata-modules/flat-object-metadata/utils/from-flat-object-metadata-to-object-metadata-dto.util';
import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
-import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
type InlinedObjectFieldSummary = {
id: string;
@@ -248,31 +246,24 @@ export class ObjectMetadataToolsFactory {
isRemote?: boolean;
isLabelSyncedWithName?: boolean;
}) => {
- try {
- const { icon, ...createObjectInput } = parameters;
+ const { icon, ...createObjectInput } = parameters;
- const flatObjectMetadata =
- await this.objectMetadataService.createOneObject({
- createObjectInput: {
- ...createObjectInput,
- icon: normalizeIconName(icon),
- } as Parameters<
- typeof this.objectMetadataService.createOneObject
- >[0]['createObjectInput'],
- workspaceId,
- });
+ const flatObjectMetadata =
+ await this.objectMetadataService.createOneObject({
+ createObjectInput: {
+ ...createObjectInput,
+ icon: normalizeIconName(icon),
+ } as Parameters<
+ typeof this.objectMetadataService.createOneObject
+ >[0]['createObjectInput'],
+ workspaceId,
+ });
- return {
- id: flatObjectMetadata.id,
- nameSingular: flatObjectMetadata.nameSingular,
- labelSingular: flatObjectMetadata.labelSingular,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return {
+ id: flatObjectMetadata.id,
+ nameSingular: flatObjectMetadata.nameSingular,
+ labelSingular: flatObjectMetadata.labelSingular,
+ };
},
},
update_object_metadata: {
@@ -293,55 +284,41 @@ export class ObjectMetadataToolsFactory {
imageIdentifierFieldMetadataId?: string;
isLabelSyncedWithName?: boolean;
}) => {
- try {
- const { id, icon, ...update } = parameters;
- const normalizedIcon = normalizeIconName(icon);
+ const { id, icon, ...update } = parameters;
+ const normalizedIcon = normalizeIconName(icon);
- const flatObjectMetadata =
- await this.objectMetadataService.updateOneObject({
- updateObjectInput: {
- id,
- update: {
- ...update,
- ...(isDefined(normalizedIcon)
- ? { icon: normalizedIcon }
- : {}),
- },
+ const flatObjectMetadata =
+ await this.objectMetadataService.updateOneObject({
+ updateObjectInput: {
+ id,
+ update: {
+ ...update,
+ ...(isDefined(normalizedIcon)
+ ? { icon: normalizedIcon }
+ : {}),
},
- workspaceId,
- });
+ },
+ workspaceId,
+ });
- return {
- id: flatObjectMetadata.id,
- nameSingular: flatObjectMetadata.nameSingular,
- labelSingular: flatObjectMetadata.labelSingular,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return {
+ id: flatObjectMetadata.id,
+ nameSingular: flatObjectMetadata.nameSingular,
+ labelSingular: flatObjectMetadata.labelSingular,
+ };
},
},
delete_object_metadata: {
description: 'Delete an object by ID. Also deletes associated fields.',
inputSchema: DeleteObjectMetadataInputSchema,
execute: async (parameters: { id: string }) => {
- try {
- const flatObjectMetadata =
- await this.objectMetadataService.deleteOneObject({
- deleteObjectInput: { id: parameters.id },
- workspaceId,
- });
+ const flatObjectMetadata =
+ await this.objectMetadataService.deleteOneObject({
+ deleteObjectInput: { id: parameters.id },
+ workspaceId,
+ });
- return { id: flatObjectMetadata.id, success: true };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return { id: flatObjectMetadata.id, success: true };
},
},
create_many_object_metadata: {
@@ -361,28 +338,21 @@ export class ObjectMetadataToolsFactory {
isLabelSyncedWithName?: boolean;
}>;
}) => {
- try {
- await Promise.all(
- parameters.objects.map(async ({ icon, ...createObjectInput }) => {
- await this.objectMetadataService.createOneObject({
- createObjectInput: {
- ...createObjectInput,
- icon: normalizeIconName(icon),
- } as Parameters<
- typeof this.objectMetadataService.createOneObject
- >[0]['createObjectInput'],
- workspaceId,
- });
- }),
- );
+ await Promise.all(
+ parameters.objects.map(async ({ icon, ...createObjectInput }) => {
+ await this.objectMetadataService.createOneObject({
+ createObjectInput: {
+ ...createObjectInput,
+ icon: normalizeIconName(icon),
+ } as Parameters<
+ typeof this.objectMetadataService.createOneObject
+ >[0]['createObjectInput'],
+ workspaceId,
+ });
+ }),
+ );
- return true;
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return true;
},
},
update_many_object_metadata: {
@@ -405,33 +375,26 @@ export class ObjectMetadataToolsFactory {
isLabelSyncedWithName?: boolean;
}>;
}) => {
- try {
- await this.objectMetadataService.updateManyObjects({
- updateObjectInputs: parameters.objects.map(
- ({ id, icon, ...update }) => {
- const normalizedIcon = normalizeIconName(icon);
+ await this.objectMetadataService.updateManyObjects({
+ updateObjectInputs: parameters.objects.map(
+ ({ id, icon, ...update }) => {
+ const normalizedIcon = normalizeIconName(icon);
- return {
- id,
- update: {
- ...update,
- ...(isDefined(normalizedIcon)
- ? { icon: normalizedIcon }
- : {}),
- },
- };
- },
- ),
- workspaceId,
- });
+ return {
+ id,
+ update: {
+ ...update,
+ ...(isDefined(normalizedIcon)
+ ? { icon: normalizedIcon }
+ : {}),
+ },
+ };
+ },
+ ),
+ workspaceId,
+ });
- return true;
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return true;
},
},
};
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-field/tools/view-field-tools.factory.ts b/packages/twenty-server/src/engine/metadata-modules/view-field/tools/view-field-tools.factory.ts
index b0c8fbb981f..a2026efce13 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-field/tools/view-field-tools.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-field/tools/view-field-tools.factory.ts
@@ -4,10 +4,8 @@ import { type ToolSet } from 'ai';
import { AggregateOperations } from 'twenty-shared/types';
import { z } from 'zod';
-import { formatValidationErrors } from 'src/engine/core-modules/tool-provider/utils/format-validation-errors.util';
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
import { ViewFieldService } from 'src/engine/metadata-modules/view-field/services/view-field.service';
-import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
const GetViewFieldsInputSchema = z.object({
viewId: z
@@ -174,35 +172,28 @@ export class ViewFieldToolsFactory {
position?: number;
aggregateOperation?: string;
}) => {
- try {
- const viewField = await this.viewFieldService.createOne({
- createViewFieldInput: {
- viewId: parameters.viewId,
- fieldMetadataId: parameters.fieldMetadataId,
- isVisible: parameters.isVisible ?? true,
- size: parameters.size ?? 150,
- position: parameters.position ?? 0,
- aggregateOperation:
- parameters.aggregateOperation as AggregateOperations,
- },
- workspaceId,
- });
+ const viewField = await this.viewFieldService.createOne({
+ createViewFieldInput: {
+ viewId: parameters.viewId,
+ fieldMetadataId: parameters.fieldMetadataId,
+ isVisible: parameters.isVisible ?? true,
+ size: parameters.size ?? 150,
+ position: parameters.position ?? 0,
+ aggregateOperation:
+ parameters.aggregateOperation as AggregateOperations,
+ },
+ workspaceId,
+ });
- return {
- id: viewField.id,
- fieldMetadataId: viewField.fieldMetadataId,
- viewId: viewField.viewId,
- isVisible: viewField.isVisible,
- size: viewField.size,
- position: viewField.position,
- aggregateOperation: viewField.aggregateOperation,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return {
+ id: viewField.id,
+ fieldMetadataId: viewField.fieldMetadataId,
+ viewId: viewField.viewId,
+ isVisible: viewField.isVisible,
+ size: viewField.size,
+ position: viewField.position,
+ aggregateOperation: viewField.aggregateOperation,
+ };
},
},
update_view_field: {
@@ -217,36 +208,29 @@ export class ViewFieldToolsFactory {
position?: number;
aggregateOperation?: string;
}) => {
- try {
- const viewField = await this.viewFieldService.updateOne({
- updateViewFieldInput: {
- id: parameters.id,
- update: {
- isVisible: parameters.isVisible,
- size: parameters.size,
- position: parameters.position,
- aggregateOperation:
- parameters.aggregateOperation as AggregateOperations,
- },
+ const viewField = await this.viewFieldService.updateOne({
+ updateViewFieldInput: {
+ id: parameters.id,
+ update: {
+ isVisible: parameters.isVisible,
+ size: parameters.size,
+ position: parameters.position,
+ aggregateOperation:
+ parameters.aggregateOperation as AggregateOperations,
},
- workspaceId,
- });
+ },
+ workspaceId,
+ });
- return {
- id: viewField.id,
- fieldMetadataId: viewField.fieldMetadataId,
- viewId: viewField.viewId,
- isVisible: viewField.isVisible,
- size: viewField.size,
- position: viewField.position,
- aggregateOperation: viewField.aggregateOperation,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return {
+ id: viewField.id,
+ fieldMetadataId: viewField.fieldMetadataId,
+ viewId: viewField.viewId,
+ isVisible: viewField.isVisible,
+ size: viewField.size,
+ position: viewField.position,
+ aggregateOperation: viewField.aggregateOperation,
+ };
},
},
delete_view_field: {
@@ -255,22 +239,15 @@ export class ViewFieldToolsFactory {
inputSchema: DeleteViewFieldInputSchema,
execute: async (parameters: { id: string }) => {
- try {
- const viewField = await this.viewFieldService.deleteOne({
- deleteViewFieldInput: { id: parameters.id },
- workspaceId,
- });
+ const viewField = await this.viewFieldService.deleteOne({
+ deleteViewFieldInput: { id: parameters.id },
+ workspaceId,
+ });
- return {
- id: viewField.id,
- deleted: true,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return {
+ id: viewField.id,
+ deleted: true,
+ };
},
},
create_many_view_fields: {
@@ -287,27 +264,20 @@ export class ViewFieldToolsFactory {
aggregateOperation?: string;
}>;
}) => {
- try {
- await this.viewFieldService.createMany({
- createViewFieldInputs: parameters.viewFields.map((viewField) => ({
- viewId: viewField.viewId,
- fieldMetadataId: viewField.fieldMetadataId,
- isVisible: viewField.isVisible ?? true,
- size: viewField.size ?? 150,
- position: viewField.position ?? 0,
- aggregateOperation:
- viewField.aggregateOperation as AggregateOperations,
- })),
- workspaceId,
- });
+ await this.viewFieldService.createMany({
+ createViewFieldInputs: parameters.viewFields.map((viewField) => ({
+ viewId: viewField.viewId,
+ fieldMetadataId: viewField.fieldMetadataId,
+ isVisible: viewField.isVisible ?? true,
+ size: viewField.size ?? 150,
+ position: viewField.position ?? 0,
+ aggregateOperation:
+ viewField.aggregateOperation as AggregateOperations,
+ })),
+ workspaceId,
+ });
- return true;
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return true;
},
},
update_many_view_fields: {
@@ -323,32 +293,25 @@ export class ViewFieldToolsFactory {
aggregateOperation?: string;
}>;
}) => {
- try {
- await Promise.all(
- parameters.viewFields.map(async (viewField) => {
- await this.viewFieldService.updateOne({
- updateViewFieldInput: {
- id: viewField.id,
- update: {
- isVisible: viewField.isVisible,
- size: viewField.size,
- position: viewField.position,
- aggregateOperation:
- viewField.aggregateOperation as AggregateOperations,
- },
+ await Promise.all(
+ parameters.viewFields.map(async (viewField) => {
+ await this.viewFieldService.updateOne({
+ updateViewFieldInput: {
+ id: viewField.id,
+ update: {
+ isVisible: viewField.isVisible,
+ size: viewField.size,
+ position: viewField.position,
+ aggregateOperation:
+ viewField.aggregateOperation as AggregateOperations,
},
- workspaceId,
- });
- }),
- );
+ },
+ workspaceId,
+ });
+ }),
+ );
- return true;
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return true;
},
},
};
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-filter/tools/view-filter-tools.factory.ts b/packages/twenty-server/src/engine/metadata-modules/view-filter/tools/view-filter-tools.factory.ts
index 75e6da8a674..370e6a6dd22 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-filter/tools/view-filter-tools.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-filter/tools/view-filter-tools.factory.ts
@@ -4,10 +4,8 @@ import { type ToolSet } from 'ai';
import { ViewFilterOperand } from 'twenty-shared/types';
import { z } from 'zod';
-import { formatValidationErrors } from 'src/engine/core-modules/tool-provider/utils/format-validation-errors.util';
import { ViewFilterService } from 'src/engine/metadata-modules/view-filter/services/view-filter.service';
import { type ViewFilterValue } from 'src/engine/metadata-modules/view-filter/types/view-filter-value.type';
-import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
const VIEW_FILTER_OPERAND_OPTIONS = Object.values(ViewFilterOperand);
@@ -131,32 +129,24 @@ export class ViewFilterToolsFactory {
value: unknown;
subFieldName?: string;
}) => {
- try {
- const filter = await this.viewFilterService.createOne({
- createViewFilterInput: {
- viewId: parameters.viewId,
- fieldMetadataId: parameters.fieldMetadataId,
- operand: parameters.operand,
- value: parameters.value as ViewFilterValue,
- subFieldName: parameters.subFieldName,
- },
- workspaceId,
- });
-
- return {
- id: filter.id,
- viewId: filter.viewId,
- fieldMetadataId: filter.fieldMetadataId,
- operand: filter.operand,
- value: filter.value,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
+ const filter = await this.viewFilterService.createOne({
+ createViewFilterInput: {
+ viewId: parameters.viewId,
+ fieldMetadataId: parameters.fieldMetadataId,
+ operand: parameters.operand,
+ value: parameters.value as ViewFilterValue,
+ subFieldName: parameters.subFieldName,
+ },
+ workspaceId,
+ });
- throw error;
- }
+ return {
+ id: filter.id,
+ viewId: filter.viewId,
+ fieldMetadataId: filter.fieldMetadataId,
+ operand: filter.operand,
+ value: filter.value,
+ };
},
},
create_many_view_filters: {
@@ -175,31 +165,23 @@ export class ViewFilterToolsFactory {
const results = [];
for (const filterInput of parameters.filters) {
- try {
- const filter = await this.viewFilterService.createOne({
- createViewFilterInput: {
- viewId: filterInput.viewId,
- fieldMetadataId: filterInput.fieldMetadataId,
- operand: filterInput.operand,
- value: filterInput.value as ViewFilterValue,
- subFieldName: filterInput.subFieldName,
- },
- workspaceId,
- });
-
- results.push({
- id: filter.id,
- viewId: filter.viewId,
- fieldMetadataId: filter.fieldMetadataId,
- operand: filter.operand,
- });
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
+ const filter = await this.viewFilterService.createOne({
+ createViewFilterInput: {
+ viewId: filterInput.viewId,
+ fieldMetadataId: filterInput.fieldMetadataId,
+ operand: filterInput.operand,
+ value: filterInput.value as ViewFilterValue,
+ subFieldName: filterInput.subFieldName,
+ },
+ workspaceId,
+ });
- throw error;
- }
+ results.push({
+ id: filter.id,
+ viewId: filter.viewId,
+ fieldMetadataId: filter.fieldMetadataId,
+ operand: filter.operand,
+ });
}
return { created: results };
@@ -215,33 +197,25 @@ export class ViewFilterToolsFactory {
value?: unknown;
subFieldName?: string;
}) => {
- try {
- const filter = await this.viewFilterService.updateOne({
- updateViewFilterInput: {
- id: parameters.id,
- update: {
- operand: parameters.operand,
- value: parameters.value as ViewFilterValue,
- subFieldName: parameters.subFieldName,
- },
+ const filter = await this.viewFilterService.updateOne({
+ updateViewFilterInput: {
+ id: parameters.id,
+ update: {
+ operand: parameters.operand,
+ value: parameters.value as ViewFilterValue,
+ subFieldName: parameters.subFieldName,
},
- workspaceId,
- });
-
- return {
- id: filter.id,
- viewId: filter.viewId,
- fieldMetadataId: filter.fieldMetadataId,
- operand: filter.operand,
- value: filter.value,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
+ },
+ workspaceId,
+ });
- throw error;
- }
+ return {
+ id: filter.id,
+ viewId: filter.viewId,
+ fieldMetadataId: filter.fieldMetadataId,
+ operand: filter.operand,
+ value: filter.value,
+ };
},
},
delete_view_filter: {
@@ -249,23 +223,15 @@ export class ViewFilterToolsFactory {
'Remove a filter from a view. Use get_view_filters to find the filter ID.',
inputSchema: DeleteViewFilterInputSchema,
execute: async (parameters: { id: string }) => {
- try {
- const filter = await this.viewFilterService.deleteOne({
- deleteViewFilterInput: { id: parameters.id },
- workspaceId,
- });
-
- return {
- id: filter.id,
- deleted: true,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
+ const filter = await this.viewFilterService.deleteOne({
+ deleteViewFilterInput: { id: parameters.id },
+ workspaceId,
+ });
- throw error;
- }
+ return {
+ id: filter.id,
+ deleted: true,
+ };
},
},
};
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-sort/tools/view-sort-tools.factory.ts b/packages/twenty-server/src/engine/metadata-modules/view-sort/tools/view-sort-tools.factory.ts
index 13444c75c8d..d695c9e2e2e 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view-sort/tools/view-sort-tools.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view-sort/tools/view-sort-tools.factory.ts
@@ -3,10 +3,8 @@ import { Injectable } from '@nestjs/common';
import { type ToolSet } from 'ai';
import { z } from 'zod';
-import { formatValidationErrors } from 'src/engine/core-modules/tool-provider/utils/format-validation-errors.util';
import { ViewSortDirection } from 'twenty-shared/types';
import { ViewSortService } from 'src/engine/metadata-modules/view-sort/services/view-sort.service';
-import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
const VIEW_SORT_DIRECTION_OPTIONS = Object.values(ViewSortDirection);
@@ -88,29 +86,21 @@ export class ViewSortToolsFactory {
fieldMetadataId: string;
direction: ViewSortDirection;
}) => {
- try {
- const sort = await this.viewSortService.createOne({
- createViewSortInput: {
- viewId: parameters.viewId,
- fieldMetadataId: parameters.fieldMetadataId,
- direction: parameters.direction,
- },
- workspaceId,
- });
-
- return {
- id: sort.id,
- viewId: sort.viewId,
- fieldMetadataId: sort.fieldMetadataId,
- direction: sort.direction,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
+ const sort = await this.viewSortService.createOne({
+ createViewSortInput: {
+ viewId: parameters.viewId,
+ fieldMetadataId: parameters.fieldMetadataId,
+ direction: parameters.direction,
+ },
+ workspaceId,
+ });
- throw error;
- }
+ return {
+ id: sort.id,
+ viewId: sort.viewId,
+ fieldMetadataId: sort.fieldMetadataId,
+ direction: sort.direction,
+ };
},
},
create_many_view_sorts: {
@@ -127,29 +117,21 @@ export class ViewSortToolsFactory {
const results = [];
for (const sortInput of parameters.sorts) {
- try {
- const sort = await this.viewSortService.createOne({
- createViewSortInput: {
- viewId: sortInput.viewId,
- fieldMetadataId: sortInput.fieldMetadataId,
- direction: sortInput.direction,
- },
- workspaceId,
- });
-
- results.push({
- id: sort.id,
- viewId: sort.viewId,
- fieldMetadataId: sort.fieldMetadataId,
- direction: sort.direction,
- });
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
-
- throw error;
- }
+ const sort = await this.viewSortService.createOne({
+ createViewSortInput: {
+ viewId: sortInput.viewId,
+ fieldMetadataId: sortInput.fieldMetadataId,
+ direction: sortInput.direction,
+ },
+ workspaceId,
+ });
+
+ results.push({
+ id: sort.id,
+ viewId: sort.viewId,
+ fieldMetadataId: sort.fieldMetadataId,
+ direction: sort.direction,
+ });
}
return { created: results };
@@ -163,30 +145,22 @@ export class ViewSortToolsFactory {
id: string;
direction?: ViewSortDirection;
}) => {
- try {
- const sort = await this.viewSortService.updateOne({
- updateViewSortInput: {
- id: parameters.id,
- update: {
- direction: parameters.direction,
- },
+ const sort = await this.viewSortService.updateOne({
+ updateViewSortInput: {
+ id: parameters.id,
+ update: {
+ direction: parameters.direction,
},
- workspaceId,
- });
-
- return {
- id: sort.id,
- viewId: sort.viewId,
- fieldMetadataId: sort.fieldMetadataId,
- direction: sort.direction,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
+ },
+ workspaceId,
+ });
- throw error;
- }
+ return {
+ id: sort.id,
+ viewId: sort.viewId,
+ fieldMetadataId: sort.fieldMetadataId,
+ direction: sort.direction,
+ };
},
},
delete_view_sort: {
@@ -194,23 +168,15 @@ export class ViewSortToolsFactory {
'Remove a sort from a view. Use get_view_sorts to find the sort ID.',
inputSchema: DeleteViewSortInputSchema,
execute: async (parameters: { id: string }) => {
- try {
- const sort = await this.viewSortService.deleteOne({
- deleteViewSortInput: { id: parameters.id },
- workspaceId,
- });
+ const sort = await this.viewSortService.deleteOne({
+ deleteViewSortInput: { id: parameters.id },
+ workspaceId,
+ });
- return {
- id: sort.id,
- deleted: true,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
-
- throw error;
- }
+ return {
+ id: sort.id,
+ deleted: true,
+ };
},
},
};
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/exceptions/view.exception.ts b/packages/twenty-server/src/engine/metadata-modules/view/exceptions/view.exception.ts
index d289a50c133..707ba715385 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/exceptions/view.exception.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/exceptions/view.exception.ts
@@ -22,6 +22,7 @@ export enum ViewExceptionCode {
VIEW_CREATE_PERMISSION_DENIED = 'VIEW_CREATE_PERMISSION_DENIED',
VIEW_MODIFY_PERMISSION_DENIED = 'VIEW_MODIFY_PERMISSION_DENIED',
VIEW_WIDGET_NOT_FOUND = 'VIEW_WIDGET_NOT_FOUND',
+ INTERNAL_SERVER_ERROR = 'INTERNAL_SERVER_ERROR',
}
export enum ViewExceptionMessageKey {
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/filters/view-rest-api-exception.filter.ts b/packages/twenty-server/src/engine/metadata-modules/view/filters/view-rest-api-exception.filter.ts
index 564b35a3847..6233a6bf2f5 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/filters/view-rest-api-exception.filter.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/filters/view-rest-api-exception.filter.ts
@@ -65,6 +65,12 @@ export class ViewRestApiExceptionFilter implements ExceptionFilter {
response,
403,
);
+ case ViewExceptionCode.INTERNAL_SERVER_ERROR:
+ return this.httpExceptionHandlerService.handleError(
+ exception as CustomException,
+ response,
+ 500,
+ );
default:
// TODO: change to 500 when we have input validation
return this.httpExceptionHandlerService.handleError(
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/tools/services/complete-view-upsert.service.ts b/packages/twenty-server/src/engine/metadata-modules/view/tools/services/complete-view-upsert.service.ts
index 5544c6ff1c9..b07a2404707 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/tools/services/complete-view-upsert.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/tools/services/complete-view-upsert.service.ts
@@ -237,7 +237,7 @@ export class CompleteViewUpsertService {
if (!isDefined(view)) {
throw new ViewException(
t`View not found after upsert`,
- ViewExceptionCode.VIEW_NOT_FOUND,
+ ViewExceptionCode.INTERNAL_SERVER_ERROR,
);
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/tools/view-tools.factory.ts b/packages/twenty-server/src/engine/metadata-modules/view/tools/view-tools.factory.ts
index 1393fd6b25e..43f520d9d6b 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/tools/view-tools.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/tools/view-tools.factory.ts
@@ -12,7 +12,10 @@ import {
} from 'twenty-shared/types';
import { z } from 'zod';
-import { formatValidationErrors } from 'src/engine/core-modules/tool-provider/utils/format-validation-errors.util';
+import {
+ ViewException,
+ ViewExceptionCode,
+} from 'src/engine/metadata-modules/view/exceptions/view.exception';
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
import { ViewFieldService } from 'src/engine/metadata-modules/view-field/services/view-field.service';
import { type ViewFilterValue } from 'src/engine/metadata-modules/view-filter/types/view-filter-value.type';
@@ -21,7 +24,6 @@ import { buildObjectIdByNameMaps } from 'src/engine/metadata-modules/flat-object
import { CompleteViewUpsertService } from 'src/engine/metadata-modules/view/tools/services/complete-view-upsert.service';
import { ViewQueryParamsService } from 'src/engine/metadata-modules/view/services/view-query-params.service';
import { ViewService } from 'src/engine/metadata-modules/view/services/view.service';
-import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
import {
isDefined,
isFieldMetadataDateKind,
@@ -331,8 +333,9 @@ export class ViewToolsFactory {
const objectMetadataId = idByNameSingular[objectNameSingular];
if (!objectMetadataId) {
- throw new Error(
+ throw new ViewException(
`Object "${objectNameSingular}" not found. Use get_object_metadata to list available objects.`,
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
@@ -361,8 +364,9 @@ export class ViewToolsFactory {
);
if (!fieldMetadata) {
- throw new Error(
+ throw new ViewException(
`Field "${fieldName}" not found on this object. Use get_field_metadata to list available fields.`,
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
@@ -391,14 +395,16 @@ export class ViewToolsFactory {
);
if (!fieldMetadata) {
- throw new Error(
+ throw new ViewException(
`Field "${fieldName}" not found on this object. Use get_field_metadata to list available fields.`,
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
if (fieldMetadata.type !== FieldMetadataType.SELECT) {
- throw new Error(
+ throw new ViewException(
`Field "${fieldName}" has type "${fieldMetadata.type}" and cannot be used as a group-by field. Only SELECT fields are supported for grouping (board columns and table groups).`,
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
@@ -427,14 +433,16 @@ export class ViewToolsFactory {
);
if (!fieldMetadata) {
- throw new Error(
+ throw new ViewException(
`Field "${fieldName}" not found on this object. Use get_field_metadata to list available fields.`,
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
if (!isFieldMetadataDateKind(fieldMetadata.type)) {
- throw new Error(
+ throw new ViewException(
`Field "${fieldName}" has type "${fieldMetadata.type}" and cannot be used as a calendar field. Only DATE or DATE_TIME fields are supported.`,
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
@@ -458,8 +466,9 @@ export class ViewToolsFactory {
);
}
- throw new Error(
+ throw new ViewException(
'Each field, filter, and sort entry must provide either fieldName or fieldMetadataId.',
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
@@ -488,14 +497,20 @@ export class ViewToolsFactory {
);
if (!existingView) {
- throw new Error(`View with id ${parameters.id} not found`);
+ throw new ViewException(
+ `View with id ${parameters.id} not found`,
+ ViewExceptionCode.VIEW_NOT_FOUND,
+ );
}
if (
existingView.visibility === ViewVisibility.UNLISTED &&
existingView.createdByUserWorkspaceId !== userWorkspaceId
) {
- throw new Error('You can only update your own unlisted views');
+ throw new ViewException(
+ 'You can only update your own unlisted views',
+ ViewExceptionCode.VIEW_MODIFY_PERMISSION_DENIED,
+ );
}
const calendarEndFieldMetadataId = isDefined(
@@ -516,8 +531,9 @@ export class ViewToolsFactory {
}
if (!isDefined(parameters.objectNameSingular)) {
- throw new Error(
+ throw new ViewException(
'objectNameSingular is required when creating a view (no id provided).',
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
@@ -530,21 +546,24 @@ export class ViewToolsFactory {
parameters.type === ViewType.KANBAN &&
!isDefined(parameters.mainGroupByFieldName)
) {
- throw new Error(
+ throw new ViewException(
'KANBAN views require mainGroupByFieldName. Provide a SELECT field name (e.g. "stage").',
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
if (parameters.type === ViewType.CALENDAR) {
if (!isDefined(parameters.calendarFieldName)) {
- throw new Error(
+ throw new ViewException(
'CALENDAR views require calendarFieldName (a DATE or DATE_TIME field name).',
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
if (!isDefined(parameters.calendarLayout)) {
- throw new Error(
+ throw new ViewException(
'CALENDAR views require calendarLayout. Provide one of: "DAY", "WEEK", "MONTH".',
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
}
@@ -701,100 +720,92 @@ VIEW TYPES: TABLE (default), LIST, KANBAN (requires mainGroupByFieldName, a SELE
>;
sorts?: Array<FieldReference & { direction?: ViewSortDirection }>;
}) => {
- try {
- const {
- existingViewId,
- objectMetadataId,
- mainGroupByFieldMetadataId,
- kanbanAggregateOperationFieldMetadataId,
- calendarFieldMetadataId,
- calendarEndFieldMetadataId,
- } = await this.resolveUpsertCompleteViewIdentifiersOrThrow({
- parameters,
- workspaceId,
- userWorkspaceId,
- });
+ const {
+ existingViewId,
+ objectMetadataId,
+ mainGroupByFieldMetadataId,
+ kanbanAggregateOperationFieldMetadataId,
+ calendarFieldMetadataId,
+ calendarEndFieldMetadataId,
+ } = await this.resolveUpsertCompleteViewIdentifiersOrThrow({
+ parameters,
+ workspaceId,
+ userWorkspaceId,
+ });
- const fields = isDefined(parameters.fields)
- ? await Promise.all(
- parameters.fields.map(async (field) => ({
- fieldMetadataId: await this.getFieldMetadataIdOrThrow(
- workspaceId,
- objectMetadataId,
- field,
- ),
- isVisible: field.isVisible ?? true,
- size: field.size ?? 150,
- })),
- )
- : undefined;
-
- const filters = isDefined(parameters.filters)
- ? await Promise.all(
- parameters.filters.map(async (filter) => ({
- fieldMetadataId: await this.getFieldMetadataIdOrThrow(
- workspaceId,
- objectMetadataId,
- filter,
- ),
- operand: filter.operand,
- value: filter.value,
- subFieldName: filter.subFieldName,
- })),
- )
- : undefined;
-
- const sorts = isDefined(parameters.sorts)
- ? await Promise.all(
- parameters.sorts.map(async (sort) => ({
- fieldMetadataId: await this.getFieldMetadataIdOrThrow(
- workspaceId,
- objectMetadataId,
- sort,
- ),
- direction: sort.direction ?? ViewSortDirection.ASC,
- })),
- )
- : undefined;
-
- const view =
- await this.completeViewUpsertService.upsertCompleteView({
- workspaceId,
- userWorkspaceId,
- existingViewId,
- objectMetadataId,
- name: parameters.name,
- icon: parameters.icon,
- type: parameters.type,
- visibility: parameters.visibility,
- mainGroupByFieldMetadataId,
- kanbanAggregateOperation: parameters.kanbanAggregateOperation,
- kanbanAggregateOperationFieldMetadataId,
- calendarLayout: parameters.calendarLayout,
- calendarFieldMetadataId,
- calendarEndFieldMetadataId,
- fields,
- filters,
- sorts,
- });
-
- return {
- id: view.id,
- name: view.name,
- objectMetadataId,
- type: view.type,
- icon: view.icon,
- visibility: view.visibility,
- fieldCount: view.viewFields?.length ?? 0,
- filterCount: view.viewFilters?.length ?? 0,
- sortCount: view.viewSorts?.length ?? 0,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ const fields = isDefined(parameters.fields)
+ ? await Promise.all(
+ parameters.fields.map(async (field) => ({
+ fieldMetadataId: await this.getFieldMetadataIdOrThrow(
+ workspaceId,
+ objectMetadataId,
+ field,
+ ),
+ isVisible: field.isVisible ?? true,
+ size: field.size ?? 150,
+ })),
+ )
+ : undefined;
+
+ const filters = isDefined(parameters.filters)
+ ? await Promise.all(
+ parameters.filters.map(async (filter) => ({
+ fieldMetadataId: await this.getFieldMetadataIdOrThrow(
+ workspaceId,
+ objectMetadataId,
+ filter,
+ ),
+ operand: filter.operand,
+ value: filter.value,
+ subFieldName: filter.subFieldName,
+ })),
+ )
+ : undefined;
+
+ const sorts = isDefined(parameters.sorts)
+ ? await Promise.all(
+ parameters.sorts.map(async (sort) => ({
+ fieldMetadataId: await this.getFieldMetadataIdOrThrow(
+ workspaceId,
+ objectMetadataId,
+ sort,
+ ),
+ direction: sort.direction ?? ViewSortDirection.ASC,
+ })),
+ )
+ : undefined;
+
+ const view = await this.completeViewUpsertService.upsertCompleteView({
+ workspaceId,
+ userWorkspaceId,
+ existingViewId,
+ objectMetadataId,
+ name: parameters.name,
+ icon: parameters.icon,
+ type: parameters.type,
+ visibility: parameters.visibility,
+ mainGroupByFieldMetadataId,
+ kanbanAggregateOperation: parameters.kanbanAggregateOperation,
+ kanbanAggregateOperationFieldMetadataId,
+ calendarLayout: parameters.calendarLayout,
+ calendarFieldMetadataId,
+ calendarEndFieldMetadataId,
+ fields,
+ filters,
+ sorts,
+ });
+
+ return {
+ id: view.id,
+ name: view.name,
+ objectMetadataId,
+ type: view.type,
+ icon: view.icon,
+ visibility: view.visibility,
+ fieldCount: view.viewFields?.length ?? 0,
+ filterCount: view.viewFilters?.length ?? 0,
+ sortCount: view.viewSorts?.length ?? 0,
+ };
},
},
create_view: {
@@ -815,134 +826,129 @@ VIEW TYPES: TABLE (default), LIST, KANBAN (requires mainGroupByFieldName, a SELE
calendarEndFieldName?: string;
fieldNames?: string[];
}) => {
- try {
- const objectMetadataId = await this.resolveObjectMetadataId(
- workspaceId,
- parameters.objectNameSingular,
+ const objectMetadataId = await this.resolveObjectMetadataId(
+ workspaceId,
+ parameters.objectNameSingular,
+ );
+
+ if (
+ parameters.type === ViewType.KANBAN &&
+ !parameters.mainGroupByFieldName
+ ) {
+ throw new ViewException(
+ 'KANBAN views require mainGroupByFieldName. Provide a SELECT field name (e.g., "stage", "status") to group records into columns.',
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
+ }
- if (
- parameters.type === ViewType.KANBAN &&
- !parameters.mainGroupByFieldName
- ) {
- throw new Error(
- 'KANBAN views require mainGroupByFieldName. Provide a SELECT field name (e.g., "stage", "status") to group records into columns.',
+ if (parameters.type === ViewType.CALENDAR) {
+ if (!parameters.calendarFieldName) {
+ throw new ViewException(
+ 'CALENDAR views require calendarFieldName. Provide a DATE or DATE_TIME field name (e.g., "dueAt", "createdAt").',
+ ViewExceptionCode.INVALID_VIEW_DATA,
);
}
- if (parameters.type === ViewType.CALENDAR) {
- if (!parameters.calendarFieldName) {
- throw new Error(
- 'CALENDAR views require calendarFieldName. Provide a DATE or DATE_TIME field name (e.g., "dueAt", "createdAt").',
- );
- }
-
- if (!parameters.calendarLayout) {
- throw new Error(
- 'CALENDAR views require calendarLayout. Provide one of: "DAY", "WEEK", "MONTH".',
- );
- }
- }
-
- let mainGroupByFieldMetadataId: string | undefined;
- let kanbanAggregateOperationFieldMetadataId: string | undefined;
- let calendarFieldMetadataId: string | undefined;
- let calendarEndFieldMetadataId: string | undefined;
-
- if (parameters.mainGroupByFieldName) {
- mainGroupByFieldMetadataId =
- await this.resolveGroupByFieldMetadataId(
- workspaceId,
- objectMetadataId,
- parameters.mainGroupByFieldName,
- );
- }
-
- if (parameters.kanbanAggregateOperationFieldName) {
- kanbanAggregateOperationFieldMetadataId =
- await this.resolveFieldMetadataId(
- workspaceId,
- objectMetadataId,
- parameters.kanbanAggregateOperationFieldName,
- );
+ if (!parameters.calendarLayout) {
+ throw new ViewException(
+ 'CALENDAR views require calendarLayout. Provide one of: "DAY", "WEEK", "MONTH".',
+ ViewExceptionCode.INVALID_VIEW_DATA,
+ );
}
+ }
- if (parameters.calendarFieldName) {
- calendarFieldMetadataId =
- await this.resolveCalendarFieldMetadataId(
- workspaceId,
- objectMetadataId,
- parameters.calendarFieldName,
- );
- }
+ let mainGroupByFieldMetadataId: string | undefined;
+ let kanbanAggregateOperationFieldMetadataId: string | undefined;
+ let calendarFieldMetadataId: string | undefined;
+ let calendarEndFieldMetadataId: string | undefined;
- if (parameters.calendarEndFieldName) {
- calendarEndFieldMetadataId =
- await this.resolveCalendarFieldMetadataId(
- workspaceId,
- objectMetadataId,
- parameters.calendarEndFieldName,
- );
- }
+ if (parameters.mainGroupByFieldName) {
+ mainGroupByFieldMetadataId =
+ await this.resolveGroupByFieldMetadataId(
+ workspaceId,
+ objectMetadataId,
+ parameters.mainGroupByFieldName,
+ );
+ }
- const view = await this.viewService.createOne({
- createViewInput: {
- name: parameters.name,
+ if (parameters.kanbanAggregateOperationFieldName) {
+ kanbanAggregateOperationFieldMetadataId =
+ await this.resolveFieldMetadataId(
+ workspaceId,
objectMetadataId,
- icon: parameters.icon ?? 'IconList',
- type: parameters.type ?? ViewType.TABLE,
- visibility: parameters.visibility ?? ViewVisibility.WORKSPACE,
- mainGroupByFieldMetadataId,
- kanbanAggregateOperation:
- parameters.kanbanAggregateOperation as AggregateOperations,
- kanbanAggregateOperationFieldMetadataId,
- calendarLayout: parameters.calendarLayout,
- calendarFieldMetadataId,
- calendarEndFieldMetadataId,
- },
+ parameters.kanbanAggregateOperationFieldName,
+ );
+ }
+
+ if (parameters.calendarFieldName) {
+ calendarFieldMetadataId = await this.resolveCalendarFieldMetadataId(
workspaceId,
- createdByUserWorkspaceId: userWorkspaceId,
- });
+ objectMetadataId,
+ parameters.calendarFieldName,
+ );
+ }
- if (isNonEmptyArray(parameters.fieldNames)) {
- const resolvedFieldMetadataIds = await Promise.all(
- parameters.fieldNames.map((fieldName) =>
- this.resolveFieldMetadataId(
- workspaceId,
- objectMetadataId,
- fieldName,
- ),
- ),
+ if (parameters.calendarEndFieldName) {
+ calendarEndFieldMetadataId =
+ await this.resolveCalendarFieldMetadataId(
+ workspaceId,
+ objectMetadataId,
+ parameters.calendarEndFieldName,
);
+ }
+
+ const view = await this.viewService.createOne({
+ createViewInput: {
+ name: parameters.name,
+ objectMetadataId,
+ icon: parameters.icon ?? 'IconList',
+ type: parameters.type ?? ViewType.TABLE,
+ visibility: parameters.visibility ?? ViewVisibility.WORKSPACE,
+ mainGroupByFieldMetadataId,
+ kanbanAggregateOperation:
+ parameters.kanbanAggregateOperation as AggregateOperations,
+ kanbanAggregateOperationFieldMetadataId,
+ calendarLayout: parameters.calendarLayout,
+ calendarFieldMetadataId,
+ calendarEndFieldMetadataId,
+ },
+ workspaceId,
+ createdByUserWorkspaceId: userWorkspaceId,
+ });
- await this.viewFieldService.createMany({
- createViewFieldInputs: resolvedFieldMetadataIds.map(
- (fieldMetadataId, index) => ({
- viewId: view.id,
- fieldMetadataId,
- isVisible: true,
- size: 150,
- position: index,
- }),
+ if (isNonEmptyArray(parameters.fieldNames)) {
+ const resolvedFieldMetadataIds = await Promise.all(
+ parameters.fieldNames.map((fieldName) =>
+ this.resolveFieldMetadataId(
+ workspaceId,
+ objectMetadataId,
+ fieldName,
),
- workspaceId,
- });
- }
+ ),
+ );
- return {
- id: view.id,
- name: view.name,
- objectNameSingular: parameters.objectNameSingular,
- type: view.type,
- icon: view.icon,
- visibility: view.visibility,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
+ await this.viewFieldService.createMany({
+ createViewFieldInputs: resolvedFieldMetadataIds.map(
+ (fieldMetadataId, index) => ({
+ viewId: view.id,
+ fieldMetadataId,
+ isVisible: true,
+ size: 150,
+ position: index,
+ }),
+ ),
+ workspaceId,
+ });
}
+
+ return {
+ id: view.id,
+ name: view.name,
+ objectNameSingular: parameters.objectNameSingular,
+ type: view.type,
+ icon: view.icon,
+ visibility: view.visibility,
+ };
},
},
update_view: {
@@ -954,86 +960,84 @@ VIEW TYPES: TABLE (default), LIST, KANBAN (requires mainGroupByFieldName, a SELE
name?: string;
icon?: string;
}) => {
- try {
- const existingView = await this.viewService.findById(
- parameters.id,
- workspaceId,
- );
+ const existingView = await this.viewService.findById(
+ parameters.id,
+ workspaceId,
+ );
- if (!existingView) {
- throw new Error(`View with id ${parameters.id} not found`);
- }
+ if (!existingView) {
+ throw new ViewException(
+ `View with id ${parameters.id} not found`,
+ ViewExceptionCode.VIEW_NOT_FOUND,
+ );
+ }
- if (
- existingView.visibility === ViewVisibility.UNLISTED &&
- existingView.createdByUserWorkspaceId !== userWorkspaceId
- ) {
- throw new Error('You can only update your own unlisted views');
- }
+ if (
+ existingView.visibility === ViewVisibility.UNLISTED &&
+ existingView.createdByUserWorkspaceId !== userWorkspaceId
+ ) {
+ throw new ViewException(
+ 'You can only update your own unlisted views',
+ ViewExceptionCode.VIEW_MODIFY_PERMISSION_DENIED,
+ );
+ }
- const view = await this.viewService.updateOne({
- updateViewInput: {
- id: parameters.id,
- name: parameters.name,
- icon: parameters.icon,
- },
- workspaceId,
- userWorkspaceId,
- });
+ const view = await this.viewService.updateOne({
+ updateViewInput: {
+ id: parameters.id,
+ name: parameters.name,
+ icon: parameters.icon,
+ },
+ workspaceId,
+ userWorkspaceId,
+ });
- return {
- id: view.id,
- name: view.name,
- objectMetadataId: view.objectMetadataId,
- type: view.type,
- icon: view.icon,
- visibility: view.visibility,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return {
+ id: view.id,
+ name: view.name,
+ objectMetadataId: view.objectMetadataId,
+ type: view.type,
+ icon: view.icon,
+ visibility: view.visibility,
+ };
},
},
delete_view: {
description: 'Delete a view by its ID.',
inputSchema: DeleteViewInputSchema,
execute: async (parameters: { id: string }) => {
- try {
- const existingView = await this.viewService.findById(
- parameters.id,
- workspaceId,
- );
+ const existingView = await this.viewService.findById(
+ parameters.id,
+ workspaceId,
+ );
- if (!existingView) {
- throw new Error(`View with id ${parameters.id} not found`);
- }
+ if (!existingView) {
+ throw new ViewException(
+ `View with id ${parameters.id} not found`,
+ ViewExceptionCode.VIEW_NOT_FOUND,
+ );
+ }
- if (
- existingView.visibility === ViewVisibility.UNLISTED &&
- existingView.createdByUserWorkspaceId !== userWorkspaceId
- ) {
- throw new Error('You can only delete your own unlisted views');
- }
+ if (
+ existingView.visibility === ViewVisibility.UNLISTED &&
+ existingView.createdByUserWorkspaceId !== userWorkspaceId
+ ) {
+ throw new ViewException(
+ 'You can only delete your own unlisted views',
+ ViewExceptionCode.VIEW_MODIFY_PERMISSION_DENIED,
+ );
+ }
- const view = await this.viewService.deleteOne({
- deleteViewInput: { id: parameters.id },
- workspaceId,
- });
+ const view = await this.viewService.deleteOne({
+ deleteViewInput: { id: parameters.id },
+ workspaceId,
+ });
- return {
- id: view.id,
- name: view.name,
- deleted: true,
- };
- } catch (error) {
- if (error instanceof WorkspaceMigrationBuilderException) {
- throw new Error(formatValidationErrors(error));
- }
- throw error;
- }
+ return {
+ id: view.id,
+ name: view.name,
+ deleted: true,
+ };
},
},
};
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/utils/view-graphql-api-exception-handler.util.ts b/packages/twenty-server/src/engine/metadata-modules/view/utils/view-graphql-api-exception-handler.util.ts
index a7af9225aae..62f14d60e6c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/utils/view-graphql-api-exception-handler.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/utils/view-graphql-api-exception-handler.util.ts
@@ -60,6 +60,10 @@ export const viewGraphqlApiExceptionHandler = (error: Error) => {
});
case ViewExceptionCode.VIEW_WIDGET_NOT_FOUND:
throw new NotFoundError(error.message);
+ case ViewExceptionCode.INTERNAL_SERVER_ERROR:
+ throw new InternalServerError(error.message, {
+ userFriendlyMessage: error.userFriendlyMessage,
+ });
default: {
return assertUnreachable(error.code);
}