Skip to content

The open alternative to Salesforce, designed for AI.

Remove deprecated subdomainMinLength from ClientConfig (#23915)

Marie0ef79db84202
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
index 9d678f73965..31423102e55 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
@@ -1919,7 +1919,6 @@ type ClientConfig {
isMultiWorkspaceEnabled: Boolean!
isEmailVerificationRequired: Boolean!
defaultSubdomain: String
- subdomainMinLength: Float! @deprecated(reason: "Subdomain minimum length is no longer configurable; kept one release for API compatibility, no longer read by the frontend.")
frontDomain: String!
publicFunctionDomain: String
analyticsEnabled: Boolean!
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
index 96a9211ba0b..dcab22580af 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
@@ -1576,8 +1576,6 @@ export interface ClientConfig {
isMultiWorkspaceEnabled: Scalars['Boolean']
isEmailVerificationRequired: Scalars['Boolean']
defaultSubdomain?: Scalars['String']
- /** @deprecated Subdomain minimum length is no longer configurable; kept one release for API compatibility, no longer read by the frontend. */
- subdomainMinLength: Scalars['Float']
frontDomain: Scalars['String']
publicFunctionDomain?: Scalars['String']
analyticsEnabled: Scalars['Boolean']
@@ -4853,8 +4851,6 @@ export interface ClientConfigGenqlSelection{
isMultiWorkspaceEnabled?: boolean | number
isEmailVerificationRequired?: boolean | number
defaultSubdomain?: boolean | number
- /** @deprecated Subdomain minimum length is no longer configurable; kept one release for API compatibility, no longer read by the frontend. */
- subdomainMinLength?: boolean | number
frontDomain?: boolean | number
publicFunctionDomain?: boolean | number
analyticsEnabled?: boolean | number
diff --git a/packages/twenty-client-sdk/src/metadata/generated/types.ts b/packages/twenty-client-sdk/src/metadata/generated/types.ts
index a217449b234..c3a1e8c498d 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/types.ts
+++ b/packages/twenty-client-sdk/src/metadata/generated/types.ts
@@ -3715,9 +3715,6 @@ export default {
"defaultSubdomain": [
1
],
- "subdomainMinLength": [
- 16
- ],
"frontDomain": [
1
],
diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.ts
index 17ba0bf4110..f911b15cba1 100644
--- a/packages/twenty-front/src/generated-metadata/graphql.ts
+++ b/packages/twenty-front/src/generated-metadata/graphql.ts
@@ -993,8 +993,6 @@ export type ClientConfig = {
publicFunctionDomain?: Maybe<Scalars['String']['output']>;
sentry: Sentry;
signInPrefilled: Scalars['Boolean']['output'];
- /** @deprecated Subdomain minimum length is no longer configurable; kept one release for API compatibility, no longer read by the frontend. */
- subdomainMinLength: Scalars['Float']['output'];
support: Support;
};
diff --git a/packages/twenty-server/src/engine/core-modules/client-config/client-config.controller.spec.ts b/packages/twenty-server/src/engine/core-modules/client-config/client-config.controller.spec.ts
index 8bf5cf617b7..e3b2edb8fc2 100644
--- a/packages/twenty-server/src/engine/core-modules/client-config/client-config.controller.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/client-config/client-config.controller.spec.ts
@@ -68,7 +68,6 @@ describe('ClientConfigController', () => {
isMultiWorkspaceEnabled: true,
isEmailVerificationRequired: false,
defaultSubdomain: 'app',
- subdomainMinLength: 1,
frontDomain: 'localhost',
publicFunctionDomain: null,
support: {
diff --git a/packages/twenty-server/src/engine/core-modules/client-config/client-config.entity.ts b/packages/twenty-server/src/engine/core-modules/client-config/client-config.entity.ts
index d39310d372f..56160341ada 100644
--- a/packages/twenty-server/src/engine/core-modules/client-config/client-config.entity.ts
+++ b/packages/twenty-server/src/engine/core-modules/client-config/client-config.entity.ts
@@ -280,12 +280,6 @@ export class ClientConfig {
@Field(() => String, { nullable: true })
defaultSubdomain: string;
- @Field(() => Number, {
- deprecationReason:
- 'Subdomain minimum length is no longer configurable; kept one release for API compatibility, no longer read by the frontend.',
- })
- subdomainMinLength: number;
-
@Field(() => String)
frontDomain: string;
diff --git a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts
index 5cdc2540a77..4cd4da967f8 100644
--- a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts
+++ b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts
@@ -154,7 +154,6 @@ describe('ClientConfigService', () => {
isMultiWorkspaceEnabled: true,
isEmailVerificationRequired: true,
defaultSubdomain: 'app',
- subdomainMinLength: 1,
frontDomain: 'app.twenty.com',
publicFunctionDomain: null,
support: {
diff --git a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.ts b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.ts
index 9a8fbd5a1e7..4d7dd535d85 100644
--- a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.ts
@@ -27,10 +27,6 @@ import { MODEL_FAMILY_LABELS } from 'src/engine/metadata-modules/ai/ai-models/co
import { getNativeModelCapabilities } from 'src/engine/metadata-modules/ai/ai-models/utils/get-native-model-capabilities.util';
import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
-// Served only so front bundles cached from the previous release keep booting; the
-// subdomain minimum is now fixed at 1 and nothing reads this value anymore.
-const DEPRECATED_SUBDOMAIN_MIN_LENGTH = 1;
-
@Injectable()
export class ClientConfigService {
constructor(
@@ -210,7 +206,6 @@ export class ClientConfigService {
'IS_EMAIL_VERIFICATION_REQUIRED',
),
defaultSubdomain: this.twentyConfigService.get('DEFAULT_SUBDOMAIN'),
- subdomainMinLength: DEPRECATED_SUBDOMAIN_MIN_LENGTH,
frontDomain: this.domainServerConfigService.getFrontUrl().hostname,
publicFunctionDomain:
this.domainServerConfigService.getPublicBaseHostnameOrUndefined() ??