Skip to content

The open alternative to Salesforce, designed for AI.

Fix icon alignment in core object tables (#28071)

Félix Malfait0fcf754337bd
diff --git a/packages/twenty-front/src/modules/object-core/components/CoreObjectTableAddNewRow.tsx b/packages/twenty-front/src/modules/object-core/components/CoreObjectTableAddNewRow.tsx
index 50a6a461629..1a8458a9a9a 100644
--- a/packages/twenty-front/src/modules/object-core/components/CoreObjectTableAddNewRow.tsx
+++ b/packages/twenty-front/src/modules/object-core/components/CoreObjectTableAddNewRow.tsx
@@ -4,7 +4,7 @@ import { themeCssVariables } from 'twenty-ui/theme';
import { CORE_OBJECT_TABLE_CHECKBOX_COLUMN_GRID_TRACK } from '@/object-core/constants/CoreObjectTableCheckboxColumnGridTrack';
-const StyledAddNewRow = styled.button`
+const StyledAddNewRow = styled.button<{ hasCheckboxColumn: boolean }>`
align-items: center;
background: transparent;
border: none;
@@ -16,10 +16,10 @@ const StyledAddNewRow = styled.button`
gap: ${themeCssVariables.spacing[1]};
height: ${themeCssVariables.spacing[8]};
padding: 0 ${themeCssVariables.spacing[2]};
- padding-inline-start: calc(
- ${CORE_OBJECT_TABLE_CHECKBOX_COLUMN_GRID_TRACK} +
- ${themeCssVariables.spacing[2]}
- );
+ padding-inline-start: ${({ hasCheckboxColumn }) =>
+ hasCheckboxColumn
+ ? `calc(${CORE_OBJECT_TABLE_CHECKBOX_COLUMN_GRID_TRACK} + ${themeCssVariables.spacing[2]})`
+ : themeCssVariables.spacing[2]};
width: 100%;
&:not(:disabled) {
@@ -36,14 +36,21 @@ type CoreObjectTableAddNewRowProps = {
label: string;
onClick: () => void;
disabled?: boolean;
+ hasCheckboxColumn?: boolean;
};
export const CoreObjectTableAddNewRow = ({
label,
onClick,
disabled = false,
+ hasCheckboxColumn = false,
}: CoreObjectTableAddNewRowProps) => (
- <StyledAddNewRow type="button" onClick={onClick} disabled={disabled}>
+ <StyledAddNewRow
+ type="button"
+ onClick={onClick}
+ disabled={disabled}
+ hasCheckboxColumn={hasCheckboxColumn}
+ >
<IconPlus size={14} />
{label}
</StyledAddNewRow>
diff --git a/packages/twenty-front/src/modules/object-core/components/cells/CoreObjectNameCell.tsx b/packages/twenty-front/src/modules/object-core/components/cells/CoreObjectNameCell.tsx
index c37bb566786..ddc37426825 100644
--- a/packages/twenty-front/src/modules/object-core/components/cells/CoreObjectNameCell.tsx
+++ b/packages/twenty-front/src/modules/object-core/components/cells/CoreObjectNameCell.tsx
@@ -42,9 +42,11 @@ export const CoreObjectNameCell = ({
<StyledContainer>
<StyledAvatarContainer>
{isDefined(Icon) ? (
- <span aria-hidden>
- <Icon size={theme.icon.size.md} stroke={theme.icon.stroke.sm} />
- </span>
+ <Icon
+ aria-hidden
+ size={theme.icon.size.md}
+ stroke={theme.icon.stroke.sm}
+ />
) : (
<Avatar
name={name ?? undefined}
diff --git a/packages/twenty-front/src/pages/object-core/WorkflowCoreIndexPage.tsx b/packages/twenty-front/src/pages/object-core/WorkflowCoreIndexPage.tsx
index f19ce1baf45..a8f3ae20ade 100644
--- a/packages/twenty-front/src/pages/object-core/WorkflowCoreIndexPage.tsx
+++ b/packages/twenty-front/src/pages/object-core/WorkflowCoreIndexPage.tsx
@@ -140,6 +140,7 @@ export const WorkflowCoreIndexPage = () => {
label={t`New Workflow`}
onClick={createCoreWorkflow}
disabled={isCreatingCoreWorkflow}
+ hasCheckboxColumn
/>
)}
</CoreObjectIndexPageLayout>