Skip to content

The open alternative to Salesforce, designed for AI.

feat(view): let workspaces declare per-locale view name translations (#29095)

Marie11adc5cfeef3
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
index 2ab0981360f..a3ee1d8c6ca 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
@@ -5375,6 +5375,7 @@ input UpdateViewInput {
openRecordIn: ViewOpenRecordIn
position: Float
shouldHideEmptyGroups: Boolean
+ translations: [MetadataTranslationOverrideInput!]
type: ViewType
visibility: ViewVisibility
}
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
index 1a33324a72a..69022aa07f1 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
@@ -8377,7 +8377,7 @@ export interface UpdateViewGroupInputUpdates {fieldMetadataId?: (Scalars['UUID']
export interface UpdateViewInput {anyFieldFilterValue?: (Scalars['String'] | null),calendarEndFieldMetadataId?: (Scalars['UUID'] | null),calendarFieldMetadataId?: (Scalars['UUID'] | null),calendarLayout?: (ViewCalendarLayout | null),groupLoadLimit?: (Scalars['Int'] | null),icon?: (Scalars['String'] | null),id?: (Scalars['UUID'] | null),isCompact?: (Scalars['Boolean'] | null),kanbanAggregateOperation?: (AggregateOperations | null),kanbanAggregateOperationFieldMetadataId?: (Scalars['UUID'] | null),kanbanColumnWidth?: (Scalars['Int'] | null),mainGroupByFieldMetadataId?: (Scalars['UUID'] | null),name?: (Scalars['String'] | null),
/** Deprecated: Superseded by objectMetadata.openRecordIn and the workspace member preference; kept one release for API compatibility, no longer read by the frontend. */
-openRecordIn?: (ViewOpenRecordIn | null),position?: (Scalars['Float'] | null),shouldHideEmptyGroups?: (Scalars['Boolean'] | null),type?: (ViewType | null),visibility?: (ViewVisibility | null)}
+openRecordIn?: (ViewOpenRecordIn | null),position?: (Scalars['Float'] | null),shouldHideEmptyGroups?: (Scalars['Boolean'] | null),translations?: (MetadataTranslationOverrideInput[] | null),type?: (ViewType | null),visibility?: (ViewVisibility | null)}
export interface UpdateViewSortInput {
/** The id of the view sort to update */
diff --git a/packages/twenty-client-sdk/src/metadata/generated/types.ts b/packages/twenty-client-sdk/src/metadata/generated/types.ts
index 24c45b8491a..ae0a2c25213 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/types.ts
+++ b/packages/twenty-client-sdk/src/metadata/generated/types.ts
@@ -14215,6 +14215,9 @@ export default {
"shouldHideEmptyGroups": [
4
],
+ "translations": [
+ 361
+ ],
"type": [
649
],
diff --git a/packages/twenty-front/src/generated-metadata/schema.ts b/packages/twenty-front/src/generated-metadata/schema.ts
index 8f06b88800b..d7fb37bbe46 100644
--- a/packages/twenty-front/src/generated-metadata/schema.ts
+++ b/packages/twenty-front/src/generated-metadata/schema.ts
@@ -7658,6 +7658,7 @@ export type UpdateViewInput = {
openRecordIn?: InputMaybe<ViewOpenRecordIn>;
position?: InputMaybe<Scalars['Float']['input']>;
shouldHideEmptyGroups?: InputMaybe<Scalars['Boolean']['input']>;
+ translations?: InputMaybe<Array<MetadataTranslationOverrideInput>>;
type?: InputMaybe<ViewType>;
visibility?: InputMaybe<ViewVisibility>;
};
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/__tests__/from-update-view-input-to-flat-view-to-update-or-throw.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/__tests__/from-update-view-input-to-flat-view-to-update-or-throw.util.spec.ts
index 98be763307a..76809be0523 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/__tests__/from-update-view-input-to-flat-view-to-update-or-throw.util.spec.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/__tests__/from-update-view-input-to-flat-view-to-update-or-throw.util.spec.ts
@@ -6,6 +6,7 @@ import {
ViewType,
ViewVisibility,
} from 'twenty-shared/types';
+import { isDefined } from 'twenty-shared/utils';
import { createEmptyFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-flat-entity-maps.constant';
import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
@@ -17,6 +18,9 @@ import { type FlatView } from 'src/engine/metadata-modules/flat-view/types/flat-
import { fromUpdateViewInputToFlatViewToUpdateOrThrow } from 'src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util';
import { resolveEffectiveUniversalFlatEntity } from 'src/engine/metadata-modules/overrides/utils/resolve-effective-universal-flat-entity.util';
import { type UpdateViewInput } from 'src/engine/metadata-modules/view/dtos/inputs/update-view.input';
+import { type ViewOverrides } from 'src/engine/metadata-modules/view/entities/view.entity';
+import { fromFlatViewToViewDto } from 'src/engine/metadata-modules/view/utils/from-flat-view-to-view-dto.util';
+import { resolveViewName } from 'src/engine/metadata-modules/view/utils/resolve-view-name.util';
const APPLICATION_UNIVERSAL_IDENTIFIER = '20202020-aaaa-4aaa-8aaa-000000000001';
const WORKSPACE_CUSTOM_APPLICATION_UNIVERSAL_IDENTIFIER =
@@ -73,17 +77,19 @@ const existingViewGroup: FlatViewGroup = {
position: 3,
};
-const updateView = ({
+const getExistingViewGroups = (groupingOverride: string | null) =>
+ isNull(groupingOverride) ? [] : [existingViewGroup];
+
+const buildExistingFlatView = ({
groupingOverride,
- updateViewInput,
+ existingTranslations,
}: {
groupingOverride: string | null;
- updateViewInput: Omit<UpdateViewInput, 'id'>;
-}) => {
- const existingViewGroups = isNull(groupingOverride)
- ? []
- : [existingViewGroup];
- const existingView: FlatView = {
+ existingTranslations?: ViewOverrides['translations'];
+}): FlatView => {
+ const existingViewGroups = getExistingViewGroups(groupingOverride);
+
+ return {
id: VIEW_ID,
universalIdentifier: VIEW_ID,
name: 'By Stage',
@@ -123,6 +129,9 @@ const updateView = ({
[WORKSPACE_CUSTOM_APPLICATION_UNIVERSAL_IDENTIFIER]: {
mainGroupByFieldMetadataId: groupingOverride,
type: isNull(groupingOverride) ? ViewType.TABLE : ViewType.KANBAN,
+ ...(isDefined(existingTranslations) && {
+ translations: existingTranslations,
+ }),
},
},
universalOverrides: null,
@@ -143,6 +152,22 @@ const updateView = ({
navigationMenuItemIds: [],
navigationMenuItemUniversalIdentifiers: [],
};
+};
+
+const updateView = ({
+ groupingOverride,
+ updateViewInput,
+ existingTranslations,
+}: {
+ groupingOverride: string | null;
+ updateViewInput: Omit<UpdateViewInput, 'id'>;
+ existingTranslations?: ViewOverrides['translations'];
+}) => {
+ const existingViewGroups = getExistingViewGroups(groupingOverride);
+ const existingView = buildExistingFlatView({
+ groupingOverride,
+ existingTranslations,
+ });
return fromUpdateViewInputToFlatViewToUpdateOrThrow({
updateViewInput: { id: VIEW_ID, ...updateViewInput },
@@ -221,4 +246,138 @@ describe('fromUpdateViewInputToFlatViewToUpdateOrThrow', () => {
expect(result.flatViewGroupsToDelete).toEqual([existingViewGroup]);
expect(result.flatViewGroupsToCreate).toEqual([]);
});
+
+ describe('translations', () => {
+ const buildI18nContext = (locale: 'en' | 'fr-FR' | 'zh-CN') => ({
+ locale,
+ i18nInstance: { _: (id: string) => id },
+ isStandardApp: false,
+ workspaceCustomApplicationUniversalIdentifier:
+ WORKSPACE_CUSTOM_APPLICATION_UNIVERSAL_IDENTIFIER,
+ ownerApplicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
+ });
+
+ const resolveNameInLocale = ({
+ translations,
+ locale,
+ }: {
+ translations: ViewOverrides['translations'];
+ locale: 'en' | 'fr-FR' | 'zh-CN';
+ }) =>
+ resolveViewName({
+ view: {
+ name: 'By Stage',
+ overrides: {
+ [WORKSPACE_CUSTOM_APPLICATION_UNIVERSAL_IDENTIFIER]: {
+ translations,
+ },
+ },
+ },
+ i18nContext: buildI18nContext(locale),
+ });
+
+ it('stores per-locale name translations authored by the workspace', () => {
+ const { flatViewToUpdate } = updateView({
+ groupingOverride: COMPANY_FIELD_ID,
+ updateViewInput: {
+ translations: [
+ { locale: 'fr-FR', property: 'name', value: 'Par étape' },
+ { locale: 'zh-CN', property: 'name', value: '按阶段' },
+ ],
+ },
+ });
+
+ const workspaceOverrides =
+ flatViewToUpdate.universalOverrides?.[
+ WORKSPACE_CUSTOM_APPLICATION_UNIVERSAL_IDENTIFIER
+ ];
+
+ expect(workspaceOverrides?.type).toBe(ViewType.KANBAN);
+ expect(workspaceOverrides?.translations).toEqual({
+ 'fr-FR': { name: 'Par étape' },
+ 'zh-CN': { name: '按阶段' },
+ });
+
+ expect(
+ resolveNameInLocale({
+ translations: workspaceOverrides?.translations,
+ locale: 'fr-FR',
+ }),
+ ).toBe('Par étape');
+ expect(
+ resolveNameInLocale({
+ translations: workspaceOverrides?.translations,
+ locale: 'zh-CN',
+ }),
+ ).toBe('按阶段');
+ expect(
+ resolveNameInLocale({
+ translations: workspaceOverrides?.translations,
+ locale: 'en',
+ }),
+ ).toBe('By Stage');
+ });
+
+ it('removes a translation when its value is empty and keeps the others', () => {
+ const { flatViewToUpdate } = updateView({
+ groupingOverride: null,
+ existingTranslations: {
+ 'fr-FR': { name: 'Par étape' },
+ 'zh-CN': { name: '按阶段' },
+ },
+ updateViewInput: {
+ translations: [{ locale: 'fr-FR', property: 'name', value: null }],
+ },
+ });
+
+ expect(
+ flatViewToUpdate.universalOverrides?.[
+ WORKSPACE_CUSTOM_APPLICATION_UNIVERSAL_IDENTIFIER
+ ]?.translations,
+ ).toEqual({ 'zh-CN': { name: '按阶段' } });
+ });
+
+ it('saves other updates when translations is null', () => {
+ const { flatViewToUpdate } = updateView({
+ groupingOverride: null,
+ updateViewInput: { name: 'Renamed view', translations: null },
+ });
+
+ expect(
+ resolveEffectiveUniversalFlatEntity({
+ metadataName: 'view',
+ universalFlatEntity: flatViewToUpdate,
+ }).name,
+ ).toBe('Renamed view');
+ });
+
+ it('keeps stored translations on the view DTO for name resolution', () => {
+ const viewDto = fromFlatViewToViewDto(
+ buildExistingFlatView({
+ groupingOverride: null,
+ existingTranslations: { 'fr-FR': { name: 'Par étape' } },
+ }),
+ );
+
+ expect(
+ resolveViewName({
+ view: viewDto,
+ i18nContext: buildI18nContext('fr-FR'),
+ }),
+ ).toBe('Par étape');
+ });
+
+ it('throws when translating a non-translatable property', () => {
+ expect(() =>
+ updateView({
+ groupingOverride: null,
+ updateViewInput: {
+ translations: [
+ { locale: 'fr-FR', property: 'icon', value: 'IconStar' },
+ ],
+ },
+ }),
+ ).toThrow('Cannot translate view properties: icon');
+ });
+ });
});
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util.ts
index c321d1cc99b..8737e3929d8 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-update-view-input-to-flat-view-to-update-or-throw.util.ts
@@ -3,6 +3,7 @@ import { DEFAULT_VIEW_GROUP_LOAD_LIMIT } from 'twenty-shared/constants';
import {
extractAndSanitizeObjectStringFields,
isDefined,
+ isNonEmptyArray,
trimAndRemoveDuplicatedWhitespacesFromObjectStringProperties,
} from 'twenty-shared/utils';
@@ -16,9 +17,12 @@ import { type FlatViewMaps } from 'src/engine/metadata-modules/flat-view/types/f
import { fromViewOverridesToUniversalOverrides } from 'src/engine/metadata-modules/flat-view/utils/from-view-overrides-to-universal-overrides.util';
import { handleFlatViewUpdateSideEffect } from 'src/engine/metadata-modules/flat-view/utils/handle-flat-view-update-side-effect.util';
import { validateViewGroupLoadLimitOrThrow } from 'src/engine/metadata-modules/flat-view/utils/validate-view-group-load-limit-or-throw.util';
+import { findInvalidTranslationOverrideProperties } from 'src/engine/metadata-modules/overrides/utils/find-invalid-translation-override-properties.util';
import { isCallerOverridingEntity } from 'src/engine/metadata-modules/overrides/utils/is-caller-overriding-entity.util';
+import { mergeTranslationsIntoOverrides } from 'src/engine/metadata-modules/overrides/utils/merge-translations-into-overrides.util';
import { sanitizeOverridableEntityInput } from 'src/engine/metadata-modules/overrides/utils/sanitize-overridable-entity-input.util';
import { type UpdateViewInput } from 'src/engine/metadata-modules/view/dtos/inputs/update-view.input';
+import { type ViewOverrides } from 'src/engine/metadata-modules/view/entities/view.entity';
import {
ViewException,
ViewExceptionCode,
@@ -69,9 +73,27 @@ export const fromUpdateViewInputToFlatViewToUpdateOrThrow = ({
);
}
+ const {
+ translations: rawTranslations,
+ ...updateViewInputWithoutTranslations
+ } = rawUpdateViewInput;
+ const translations = rawTranslations ?? [];
+
+ const invalidTranslationProperties = findInvalidTranslationOverrideProperties(
+ translations,
+ 'view',
+ );
+
+ if (isNonEmptyArray(invalidTranslationProperties)) {
+ throw new ViewException(
+ `Cannot translate view properties: ${invalidTranslationProperties.join(', ')}`,
+ ViewExceptionCode.INVALID_VIEW_DATA,
+ );
+ }
+
// NOT NULL column: null means the default, as on create and in manifests
const { groupLoadLimit, ...updateViewInputWithoutGroupLoadLimit } =
- rawUpdateViewInput;
+ updateViewInputWithoutTranslations;
const editableProperties = extractAndSanitizeObjectStringFields(
{
@@ -91,7 +113,7 @@ export const fromUpdateViewInputToFlatViewToUpdateOrThrow = ({
isSystemSideEffect: existingFlatViewToUpdate.isSystemSideEffect,
});
- const { overrides, updatedEditableProperties } =
+ const { overrides: sanitizedOverrides, updatedEditableProperties } =
sanitizeOverridableEntityInput({
metadataName: 'view',
existingFlatEntity: existingFlatViewToUpdate,
@@ -101,6 +123,18 @@ export const fromUpdateViewInputToFlatViewToUpdateOrThrow = ({
workspaceCustomApplicationUniversalIdentifier,
});
+ const overrides = mergeTranslationsIntoOverrides<ViewOverrides>({
+ metadataName: 'view',
+ existingOverrides: sanitizedOverrides,
+ translationEntries: translations,
+ authorUniversalIdentifier: callerApplicationUniversalIdentifier,
+ authorContext: {
+ workspaceCustomApplicationUniversalIdentifier,
+ ownerApplicationUniversalIdentifier:
+ existingFlatViewToUpdate.applicationUniversalIdentifier,
+ },
+ });
+
const mergedRecord = mergeUpdateInExistingRecord({
existing: existingFlatViewToUpdate,
properties: [...FLAT_VIEW_EDITABLE_PROPERTIES],
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/controllers/view.controller.ts b/packages/twenty-server/src/engine/metadata-modules/view/controllers/view.controller.ts
index a343a0027f2..a73d3fce0ca 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/controllers/view.controller.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/controllers/view.controller.ts
@@ -10,6 +10,8 @@ import {
Req,
UseFilters,
UseGuards,
+ UsePipes,
+ ValidationPipe,
} from '@nestjs/common';
import { type APP_LOCALES } from 'twenty-shared/translations';
@@ -31,7 +33,6 @@ import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/
import { ApplicationTranslationCatalogService } from 'src/engine/metadata-modules/application-translation-catalog/services/application-translation-catalog.service';
import { buildViewNameObjectLabels } from 'src/engine/metadata-modules/view/utils/build-view-name-object-labels.util';
import { resolveViewName } from 'src/engine/metadata-modules/view/utils/resolve-view-name.util';
-import { getTwentyStandardApplicationIdOrThrow } from 'src/engine/metadata-modules/utils/get-twenty-standard-application-id-or-throw.util';
import { belongsToTwentyStandardApp } from 'src/engine/metadata-modules/utils/belongs-to-twenty-standard-app.util';
import { CreateViewInput } from 'src/engine/metadata-modules/view/dtos/inputs/create-view.input';
import { UpdateViewInput } from 'src/engine/metadata-modules/view/dtos/inputs/update-view.input';
@@ -164,6 +165,7 @@ export class ViewController {
@Patch(':id')
@UseGuards(ViewPermissionGuard)
+ @UsePipes(new ValidationPipe())
async update(
@Param('id') id: string,
@Body() input: UpdateViewInput,
@@ -209,28 +211,14 @@ export class ViewController {
workspaceId: string,
locale?: keyof typeof APP_LOCALES,
): Promise<ViewDTO[]> {
- const hasTemplates = views.some((view) =>
- hasObjectMetadataLabelPlaceholder(view.name),
- );
-
- const { flatObjectMetadataMaps, flatApplicationMaps } =
+ const { flatObjectMetadataMaps } =
await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
- flatMapsKeys: ['flatObjectMetadataMaps', 'flatApplicationMaps'],
+ flatMapsKeys: ['flatObjectMetadataMaps'],
},
);
- const twentyStandardApplicationId =
- getTwentyStandardApplicationIdOrThrow(flatApplicationMaps);
-
- if (
- !hasTemplates &&
- views.every((view) => view.applicationId !== twentyStandardApplicationId)
- ) {
- return views;
- }
-
const getI18nContext =
await this.applicationTranslationCatalogService.getI18nContextByApplicationId(
{
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/dtos/inputs/update-view.input.spec.ts b/packages/twenty-server/src/engine/metadata-modules/view/dtos/inputs/update-view.input.spec.ts
new file mode 100644
index 00000000000..ddf7e36b879
--- /dev/null
+++ b/packages/twenty-server/src/engine/metadata-modules/view/dtos/inputs/update-view.input.spec.ts
@@ -0,0 +1,35 @@
+import { plainToInstance } from 'class-transformer';
+import { validate } from 'class-validator';
+
+import { UpdateViewInput } from 'src/engine/metadata-modules/view/dtos/inputs/update-view.input';
+
+const validateUpdateViewInput = (input: Record<string, unknown>) =>
+ validate(plainToInstance(UpdateViewInput, input));
+
+describe('UpdateViewInput', () => {
+ it('accepts a numeric position without an id', async () => {
+ expect(await validateUpdateViewInput({ position: 2.5 })).toHaveLength(0);
+ });
+
+ it('accepts names with apostrophes and dots', async () => {
+ expect(
+ await validateUpdateViewInput({ name: "Deals d'été v2.0" }),
+ ).toHaveLength(0);
+ });
+
+ it('accepts supported translation locales', async () => {
+ expect(
+ await validateUpdateViewInput({
+ translations: [{ locale: 'fr-FR', property: 'name', value: 'Tous' }],
+ }),
+ ).toHaveLength(0);
+ });
+
+ it('rejects unsupported translation locales', async () => {
+ const errors = await validateUpdateViewInput({
+ translations: [{ locale: 'fr_FR', property: 'name', value: 'Tous' }],
+ });
+
+ expect(errors.map(({ property }) => property)).toEqual(['translations']);
+ });
+});
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/dtos/inputs/update-view.input.ts b/packages/twenty-server/src/engine/metadata-modules/view/dtos/inputs/update-view.input.ts
index ff204730356..3e4720764c1 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/dtos/inputs/update-view.input.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/dtos/inputs/update-view.input.ts
@@ -1,15 +1,18 @@
import { Field, InputType, Int } from '@nestjs/graphql';
+import { Type } from 'class-transformer';
import {
IsBoolean,
IsEnum,
IsInt,
IsNotEmpty,
+ IsNumber,
IsOptional,
IsString,
IsUUID,
Max,
Min,
+ ValidateNested,
} from 'class-validator';
import {
AggregateOperations,
@@ -20,7 +23,7 @@ import {
} from 'twenty-shared/types';
import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
-import { IsValidMetadataName } from 'src/engine/decorators/metadata/is-valid-metadata-name.decorator';
+import { MetadataTranslationOverrideInput } from 'src/engine/metadata-modules/metadata-translation/dtos/metadata-translation-override.input';
import { KANBAN_COLUMN_MAX_WIDTH } from 'src/engine/metadata-modules/view/constants/kanban-column-max-width.constant';
import { KANBAN_COLUMN_MIN_WIDTH } from 'src/engine/metadata-modules/view/constants/kanban-column-min-width.constant';
import { VIEW_OPEN_RECORD_IN_DEPRECATION } from 'src/engine/metadata-modules/view/constants/view-open-record-in-deprecation.constant';
@@ -28,13 +31,14 @@ import { VIEW_OPEN_RECORD_IN_DEPRECATION } from 'src/engine/metadata-modules/vie
// TODO: refactor like view-field.input.ts; extending CreateViewInput added defaults for unset fields
@InputType()
export class UpdateViewInput {
+ @IsOptional()
@IsUUID()
@Field(() => UUIDScalarType, { nullable: true })
id: string;
@IsOptional()
+ @IsString()
@IsNotEmpty()
- @IsValidMetadataName()
@Field({ nullable: true })
name?: string;
@@ -49,7 +53,7 @@ export class UpdateViewInput {
icon?: string;
@IsOptional()
- @IsBoolean()
+ @IsNumber()
@Field({ nullable: true })
position?: number;
@@ -121,4 +125,10 @@ export class UpdateViewInput {
@IsOptional()
@Field(() => Int, { nullable: true })
groupLoadLimit?: number | null;
+
+ @Type(() => MetadataTranslationOverrideInput)
+ @ValidateNested({ each: true })
+ @IsOptional()
+ @Field(() => [MetadataTranslationOverrideInput], { nullable: true })
+ translations?: MetadataTranslationOverrideInput[] | null;
}
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/entities/view.entity.ts b/packages/twenty-server/src/engine/metadata-modules/view/entities/view.entity.ts
index fd0d4c3e0bd..b2f7c9c1198 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/entities/view.entity.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/entities/view.entity.ts
@@ -13,6 +13,7 @@ import {
UpdateDateColumn,
} from 'typeorm';
import { DEFAULT_VIEW_GROUP_LOAD_LIMIT } from 'twenty-shared/constants';
+import { type APP_LOCALES } from 'twenty-shared/translations';
import {
AggregateOperations,
type SerializedRelation,
@@ -61,6 +62,9 @@ export type ViewOverrides = {
shouldHideEmptyGroups?: boolean;
kanbanColumnWidth?: number | null;
groupLoadLimit?: number;
+ translations?: Partial<
+ Record<keyof typeof APP_LOCALES, { name?: string | null }>
+ > | null;
};
// TODO: make this type dynamic to the view type
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/resolvers/view.resolver.ts b/packages/twenty-server/src/engine/metadata-modules/view/resolvers/view.resolver.ts
index 52d3b3d8e1c..14a77018b8e 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/resolvers/view.resolver.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/resolvers/view.resolver.ts
@@ -214,6 +214,7 @@ export class ViewResolver {
@Mutation(() => ViewDTO)
@UseGuards(ViewPermissionGuard)
+ @UsePipes(ResolverValidationPipe)
async updateView(
@Args('id', { type: () => String }) id: string,
@Args('input') input: UpdateViewInput,
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/utils/from-flat-view-to-view-dto.util.ts b/packages/twenty-server/src/engine/metadata-modules/view/utils/from-flat-view-to-view-dto.util.ts
index 604dbf34097..7946a2617b5 100644
--- a/packages/twenty-server/src/engine/metadata-modules/view/utils/from-flat-view-to-view-dto.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/view/utils/from-flat-view-to-view-dto.util.ts
@@ -7,13 +7,7 @@ export const fromFlatViewToViewDto = (flatView: FlatView): ViewDTO => {
metadataName: 'view',
flatEntity: flatView,
});
- const {
- createdAt,
- updatedAt,
- deletedAt,
- overrides: _overrides,
- ...rest
- } = effectiveFlatView;
+ const { createdAt, updatedAt, deletedAt, ...rest } = effectiveFlatView;
return {
...rest,