The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Include Note/Task rich-text body in field lists and add unit test (#25195)
Félix Malfait1291c6928b68
diff --git a/packages/twenty-front/src/modules/object-record/record-field-list/hooks/__tests__/useFieldListFieldMetadataItems.test.tsx b/packages/twenty-front/src/modules/object-record/record-field-list/hooks/__tests__/useFieldListFieldMetadataItems.test.tsxnew file mode 100644index 00000000000..b68871c16a6--- /dev/null+++ b/packages/twenty-front/src/modules/object-record/record-field-list/hooks/__tests__/useFieldListFieldMetadataItems.test.tsx@@ -0,0 +1,52 @@+import { useLabelIdentifierFieldMetadataItem } from '@/object-metadata/hooks/useLabelIdentifierFieldMetadataItem';+import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';+import { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';+import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';+import { useObjectPermissions } from '@/object-record/hooks/useObjectPermissions';+import { useFieldListFieldMetadataItems } from '@/object-record/record-field-list/hooks/useFieldListFieldMetadataItems';+import { renderHook } from '@testing-library/react';+import { CoreObjectNameSingular, FieldMetadataType } from 'twenty-shared/types';++jest.mock('@/object-metadata/hooks/useLabelIdentifierFieldMetadataItem');+jest.mock('@/object-metadata/hooks/useObjectMetadataItem');+jest.mock('@/object-metadata/hooks/useObjectMetadataItems');+jest.mock('@/object-record/hooks/useObjectPermissions');++const activityBodyField = {+ id: 'activity-body-field-id',+ name: 'bodyV2',+ type: FieldMetadataType.RICH_TEXT,+ isActive: true,+} as FieldMetadataItem;++describe('useFieldListFieldMetadataItems', () => {+ beforeEach(() => {+ jest.mocked(useLabelIdentifierFieldMetadataItem).mockReturnValue({+ labelIdentifierFieldMetadataItem: undefined,+ });+ jest.mocked(useObjectMetadataItem).mockReturnValue({+ objectMetadataItem: {+ readableFields: [activityBodyField],+ } as ReturnType<typeof useObjectMetadataItem>['objectMetadataItem'],+ });+ jest.mocked(useObjectMetadataItems).mockReturnValue({+ objectMetadataItems: [],+ });+ jest.mocked(useObjectPermissions).mockReturnValue({+ objectPermissionsByObjectMetadataId: {},+ });+ });++ it.each([CoreObjectNameSingular.Note, CoreObjectNameSingular.Task])(+ 'includes the %s body in field lists',+ (objectNameSingular) => {+ const { result } = renderHook(() =>+ useFieldListFieldMetadataItems({ objectNameSingular }),+ );++ expect(result.current.inlineFieldMetadataItems).toEqual([+ activityBodyField,+ ]);+ },+ );+});diff --git a/packages/twenty-front/src/modules/object-record/record-field-list/hooks/useFieldListFieldMetadataItems.ts b/packages/twenty-front/src/modules/object-record/record-field-list/hooks/useFieldListFieldMetadataItems.tsindex 5f24839bbc8..97cd2aa1ca3 100644--- a/packages/twenty-front/src/modules/object-record/record-field-list/hooks/useFieldListFieldMetadataItems.ts+++ b/packages/twenty-front/src/modules/object-record/record-field-list/hooks/useFieldListFieldMetadataItems.ts@@ -5,7 +5,7 @@ import { useObjectPermissions } from '@/object-record/hooks/useObjectPermissionsimport { categorizeRelationFields } from '@/object-record/record-field-list/utils/categorizeRelationFields';import { isFieldCellSupported } from '@/object-record/utils/isFieldCellSupported';import groupBy from 'lodash.groupby';-import { CoreObjectNameSingular, FieldMetadataType } from 'twenty-shared/types';+import { FieldMetadataType } from 'twenty-shared/types';type UseFieldListFieldMetadataItemsProps = {objectNameSingular: string;@@ -55,21 +55,11 @@ export const useFieldListFieldMetadataItems = ({);const { inlineFieldMetadataItems, relationFieldMetadataItems } = groupBy(- availableFieldMetadataItems- .filter(- (fieldMetadataItem) =>- fieldMetadataItem.name !== 'createdAt' &&- fieldMetadataItem.name !== 'deletedAt',- )- .filter(- (fieldMetadataItem) =>- !(- fieldMetadataItem.type === FieldMetadataType.RICH_TEXT &&- fieldMetadataItem.name === 'bodyV2' &&- (objectNameSingular === CoreObjectNameSingular.Note ||- objectNameSingular === CoreObjectNameSingular.Task)- ),- ),+ availableFieldMetadataItems.filter(+ (fieldMetadataItem) =>+ fieldMetadataItem.name !== 'createdAt' &&+ fieldMetadataItem.name !== 'deletedAt',+ ),(fieldMetadataItem) =>fieldMetadataItem.type === FieldMetadataType.RELATION ||fieldMetadataItem.type === FieldMetadataType.MORPH_RELATION