Skip to content

The open alternative to Salesforce, designed for AI.

Remove the IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED feature flag (#28252)

Charles Bochet17f659dcb7a3
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
index 35f5a8823da..0dfec254713 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql
@@ -2117,7 +2117,6 @@ enum FeatureFlagKey {
IS_APP_PREFERENCES_ENABLED
IS_ASYNC_CSV_EXPORT_ENABLED
IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED
- IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED
IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED
IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED
IS_JSON_FILTER_ENABLED
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
index c7b8d5751d1..86ea6df81c6 100644
--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts
+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts
@@ -1364,7 +1364,7 @@ export interface FeatureFlag {
__typename: 'FeatureFlag'
}
-export type FeatureFlagKey = 'IS_AI_CHAT_INBOX_ENABLED' | 'IS_APP_PREFERENCES_ENABLED' | 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED' | 'IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_LOGS_SETTINGS_SECTION_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED' | 'IS_RECORD_LEVEL_SHARING_ENABLED' | 'IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT'
+export type FeatureFlagKey = 'IS_AI_CHAT_INBOX_ENABLED' | 'IS_APP_PREFERENCES_ENABLED' | 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_LOGS_SETTINGS_SECTION_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED' | 'IS_RECORD_LEVEL_SHARING_ENABLED' | 'IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT'
export interface Field {
applicationId: Scalars['UUID']
@@ -11624,7 +11624,6 @@ export const enumFeatureFlagKey = {
IS_APP_PREFERENCES_ENABLED: 'IS_APP_PREFERENCES_ENABLED' as const,
IS_ASYNC_CSV_EXPORT_ENABLED: 'IS_ASYNC_CSV_EXPORT_ENABLED' as const,
IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED: 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED' as const,
- IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED: 'IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED' as const,
IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED: 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' as const,
IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED: 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' as const,
IS_JSON_FILTER_ENABLED: 'IS_JSON_FILTER_ENABLED' as const,
diff --git a/packages/twenty-front/src/generated-admin/graphql.ts b/packages/twenty-front/src/generated-admin/graphql.ts
index 0947f19e9c8..26774e51204 100644
--- a/packages/twenty-front/src/generated-admin/graphql.ts
+++ b/packages/twenty-front/src/generated-admin/graphql.ts
@@ -451,7 +451,6 @@ export enum FeatureFlagKey {
IS_APP_PREFERENCES_ENABLED = 'IS_APP_PREFERENCES_ENABLED',
IS_ASYNC_CSV_EXPORT_ENABLED = 'IS_ASYNC_CSV_EXPORT_ENABLED',
IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED = 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED',
- IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED = 'IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED',
IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED = 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED',
IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED = 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED',
IS_JSON_FILTER_ENABLED = 'IS_JSON_FILTER_ENABLED',
diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.ts
index 0b7764a4c48..fb83aad8afc 100644
--- a/packages/twenty-front/src/generated-metadata/graphql.ts
+++ b/packages/twenty-front/src/generated-metadata/graphql.ts
@@ -2239,7 +2239,6 @@ export enum FeatureFlagKey {
IS_APP_PREFERENCES_ENABLED = 'IS_APP_PREFERENCES_ENABLED',
IS_ASYNC_CSV_EXPORT_ENABLED = 'IS_ASYNC_CSV_EXPORT_ENABLED',
IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED = 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED',
- IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED = 'IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED',
IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED = 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED',
IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED = 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED',
IS_JSON_FILTER_ENABLED = 'IS_JSON_FILTER_ENABLED',
diff --git a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
index bd45295e54d..94c2d559bb0 100644
--- a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
+++ b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts
@@ -48,10 +48,6 @@ export const SETTINGS_ADMIN_FEATURE_FLAG_METADATA: Record<
label: msg`Logs console`,
description: msg`Show a logs console at the bottom of the app in Advanced mode.`,
},
- [FeatureFlagKey.IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED]: {
- label: msg`Skip unchanged calendar records`,
- description: msg`Only write calendar events and participants that changed since the last sync.`,
- },
[FeatureFlagKey.IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED]: {
label: msg`Share calendar events across channels`,
description: msg`Store a meeting synced by several calendars of the same provider once, instead of once per calendar.`,
diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts
index 94676f7e70d..6b97eab0979 100644
--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts
@@ -8,7 +8,6 @@ const DEFAULT_SEEDED_FEATURE_FLAGS: Partial<Record<FeatureFlagKey, boolean>> = {
[FeatureFlagKey.IS_RECORD_CREATION_FORM_ENABLED]: true,
[FeatureFlagKey.IS_LOGS_SETTINGS_SECTION_ENABLED]: true,
[FeatureFlagKey.IS_RECORD_LEVEL_SHARING_ENABLED]: false,
- [FeatureFlagKey.IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED]: true,
[FeatureFlagKey.IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED]: true,
[FeatureFlagKey.IS_AI_CHAT_INBOX_ENABLED]: true,
};
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
index c261819570d..f30beb66eaa 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
@@ -41,12 +41,6 @@ export class CalendarSaveEventsService {
): Promise<{ calendarEventIds: string[] }> {
const authContext = buildSystemAuthContext(workspaceId);
- const shouldSkipUnchangedRecords =
- await this.featureFlagService.isFeatureEnabled(
- FeatureFlagKey.IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED,
- workspaceId,
- );
-
const isCalendarEventSharingEnabled =
await this.featureFlagService.isFeatureEnabled(
FeatureFlagKey.IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED,
@@ -165,8 +159,7 @@ export class CalendarSaveEventsService {
];
const candidateCalendarEvents =
- candidateCalendarEventIds.length > 0 &&
- (shouldSkipUnchangedRecords || sharedAssociations.length > 0)
+ candidateCalendarEventIds.length > 0
? await calendarEventRepository.find({
where: { id: Any(candidateCalendarEventIds) },
})
@@ -203,9 +196,7 @@ export class CalendarSaveEventsService {
} = buildCalendarEventSaveOperations({
fetchedCalendarEvents,
existingAssociations,
- existingCalendarEvents: shouldSkipUnchangedRecords
- ? candidateCalendarEvents
- : [],
+ existingCalendarEvents: candidateCalendarEvents,
calendarChannelId: calendarChannel.id,
channelHandles,
calendarEventIdToLinkByEventExternalId,
@@ -226,7 +217,6 @@ export class CalendarSaveEventsService {
...participantsOfLinkedEvents,
],
existingParticipants,
- shouldSkipUnchangedParticipants: shouldSkipUnchangedRecords,
channelRoleByCalendarEventId,
channelHandles,
});
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/utils/__tests__/build-calendar-event-participant-save-operations.util.spec.ts b/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/utils/__tests__/build-calendar-event-participant-save-operations.util.spec.ts
index 2ab70ed7048..ef10303df27 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/utils/__tests__/build-calendar-event-participant-save-operations.util.spec.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/utils/__tests__/build-calendar-event-participant-save-operations.util.spec.ts
@@ -35,18 +35,15 @@ const buildExistingParticipant = (
const buildOperations = ({
fetchedParticipants,
existingParticipants,
- shouldSkipUnchangedParticipants = true,
channelRole = 'ONLY_CHANNEL',
}: {
fetchedParticipants: FetchedParticipantWithCalendarEventId[];
existingParticipants: CalendarEventParticipantWorkspaceEntity[];
- shouldSkipUnchangedParticipants?: boolean;
channelRole?: CalendarEventChannelRole;
}) =>
buildCalendarEventParticipantSaveOperations({
fetchedParticipants,
existingParticipants,
- shouldSkipUnchangedParticipants,
channelRoleByCalendarEventId: new Map([[CALENDAR_EVENT_ID, channelRole]]),
channelHandles: [CHANNEL_HANDLE],
});
@@ -65,21 +62,6 @@ describe('buildCalendarEventParticipantSaveOperations', () => {
});
});
- it('updates unchanged participants when skipping is disabled', () => {
- const operations = buildOperations({
- fetchedParticipants: [buildFetchedParticipant()],
- existingParticipants: [buildExistingParticipant()],
- shouldSkipUnchangedParticipants: false,
- });
-
- expect(operations.participantsToUpdate).toEqual([
- {
- criteria: 'existing-participant-id',
- partialEntity: buildFetchedParticipant(),
- },
- ]);
- });
-
it('treats a null persisted display name as equal to an empty fetched one', () => {
const operations = buildOperations({
fetchedParticipants: [buildFetchedParticipant({ displayName: '' })],
@@ -173,7 +155,6 @@ describe('buildCalendarEventParticipantSaveOperations', () => {
handle: CHANNEL_HANDLE,
}),
],
- shouldSkipUnchangedParticipants: false,
channelRole,
});
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/utils/build-calendar-event-participant-save-operations.util.ts b/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/utils/build-calendar-event-participant-save-operations.util.ts
index 54f36cf1bb4..3a5ebbd536f 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/utils/build-calendar-event-participant-save-operations.util.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/utils/build-calendar-event-participant-save-operations.util.ts
@@ -30,13 +30,11 @@ const hasParticipantChanged = ({
export const buildCalendarEventParticipantSaveOperations = ({
fetchedParticipants,
existingParticipants,
- shouldSkipUnchangedParticipants,
channelRoleByCalendarEventId,
channelHandles,
}: {
fetchedParticipants: FetchedParticipantWithCalendarEventId[];
existingParticipants: CalendarEventParticipantWorkspaceEntity[];
- shouldSkipUnchangedParticipants: boolean;
channelRoleByCalendarEventId: Map<string, CalendarEventChannelRole>;
channelHandles: string[];
}): CalendarEventParticipantSaveOperations => {
@@ -75,10 +73,7 @@ export const buildCalendarEventParticipantSaveOperations = ({
continue;
}
- if (
- shouldSkipUnchangedParticipants &&
- !hasParticipantChanged({ existingParticipant, fetchedParticipant })
- ) {
+ if (!hasParticipantChanged({ existingParticipant, fetchedParticipant })) {
continue;
}
diff --git a/packages/twenty-shared/src/types/FeatureFlagKey.ts b/packages/twenty-shared/src/types/FeatureFlagKey.ts
index d77c47fb882..29c53e641f4 100644
--- a/packages/twenty-shared/src/types/FeatureFlagKey.ts
+++ b/packages/twenty-shared/src/types/FeatureFlagKey.ts
@@ -8,7 +8,6 @@ export enum FeatureFlagKey {
IS_RECORD_CREATION_FORM_ENABLED = 'IS_RECORD_CREATION_FORM_ENABLED',
IS_LOGS_SETTINGS_SECTION_ENABLED = 'IS_LOGS_SETTINGS_SECTION_ENABLED',
IS_RECORD_LEVEL_SHARING_ENABLED = 'IS_RECORD_LEVEL_SHARING_ENABLED',
- IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED = 'IS_CALENDAR_SYNC_SKIP_UNCHANGED_RECORDS_ENABLED',
IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED = 'IS_CALENDAR_EVENT_SHARED_ACROSS_CHANNELS_ENABLED',
IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED = 'IS_RECORD_SHARE_VISIBILITY_GATING_ENABLED',
IS_AI_CHAT_INBOX_ENABLED = 'IS_AI_CHAT_INBOX_ENABLED',