The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
feat(front): show loading and error states for video attachment previews (#24454)
Emmanuel Hernández Bazán1935c33b6414
diff --git a/packages/twenty-front/src/modules/activities/files/components/DocumentViewer.tsx b/packages/twenty-front/src/modules/activities/files/components/DocumentViewer.tsxindex 35cadacc99d..fa58418f7ab 100644--- a/packages/twenty-front/src/modules/activities/files/components/DocumentViewer.tsx+++ b/packages/twenty-front/src/modules/activities/files/components/DocumentViewer.tsx@@ -1,3 +1,5 @@+import { UnavailableFilePreview } from '@/activities/files/components/UnavailableFilePreview';+import { VideoPreview } from '@/activities/files/components/VideoPreview';import { PREVIEWABLE_EXTENSIONS } from '@/activities/files/const/previewable-extensions.const';import { downloadFile } from '@/activities/files/utils/downloadFile';import {@@ -32,6 +34,7 @@ const StyledDocumentViewerContainer = styled.div`flex-direction: column;height: calc(100vh / var(--t-zoom, 1) - 200px);min-height: 500px;+ position: relative;width: 100%;#react-doc-viewer #header-bar {@@ -68,23 +71,11 @@ const StyledUnavailablePreviewContainer = styled.div`text-align: center;`;-const StyledMessage = styled.div`- color: ${themeCssVariables.font.color.secondary};- font-size: ${themeCssVariables.font.size.lg};- max-width: 400px;-`;-const StyledLightMessage = styled.div`color: ${themeCssVariables.font.color.tertiary};font-size: ${themeCssVariables.font.size.sm};`;-const StyledTitle = styled.div`- color: ${themeCssVariables.font.color.primary};- font-size: ${themeCssVariables.font.size.xl};- font-weight: ${themeCssVariables.font.weight.semiBold};-`;-const StyledCsvTable = styled.table`border-collapse: collapse;font-size: ${themeCssVariables.font.size.sm};@@ -217,6 +208,7 @@ export const DocumentViewer = ({const isMsOfficeFile = MS_OFFICE_EXTENSIONS.includes(fileExtension);const mimeType = isPreviewable ? MIME_TYPE_MAPPING[fileExtension] : undefined;+ const isVideo = mimeType?.startsWith('video/') === true;useEffect(() => {if (fileExtension === 'csv') {@@ -227,12 +219,11 @@ export const DocumentViewer = ({if (!isPreviewable) {return (<StyledDocumentViewerContainer>- <StyledUnavailablePreviewContainer>- <StyledTitle>- <Trans>Preview Not Available</Trans>- </StyledTitle>- <StyledMessage>- {fileCategory === 'ARCHIVE' ? (+ <UnavailableFilePreview+ fileName={documentName}+ fileUrl={documentUrl}+ message={+ fileCategory === 'ARCHIVE' ? (<Trans>Archive files cannot be previewed. Please download the file toaccess its contents.@@ -242,15 +233,21 @@ export const DocumentViewer = ({This file type cannot be previewed. Please download the file toview it.</Trans>- )}- </StyledMessage>- <Button- Icon={IconDownload}- title={t`Download File`}- onClick={() => downloadFile(documentUrl, documentName)}- variant="secondary"- />- </StyledUnavailablePreviewContainer>+ )+ }+ />+ </StyledDocumentViewerContainer>+ );+ }++ if (isVideo) {+ return (+ <StyledDocumentViewerContainer>+ <VideoPreview+ key={documentUrl}+ videoName={documentName}+ videoUrl={documentUrl}+ /></StyledDocumentViewerContainer>);}diff --git a/packages/twenty-front/src/modules/activities/files/components/UnavailableFilePreview.tsx b/packages/twenty-front/src/modules/activities/files/components/UnavailableFilePreview.tsxnew file mode 100644index 00000000000..18924ef86b2--- /dev/null+++ b/packages/twenty-front/src/modules/activities/files/components/UnavailableFilePreview.tsx@@ -0,0 +1,59 @@+import { downloadFile } from '@/activities/files/utils/downloadFile';+import { styled } from '@linaria/react';+import { Trans, useLingui } from '@lingui/react/macro';+import { type ReactNode } from 'react';+import { IconDownload } from 'twenty-ui/icon';+import { Button } from 'twenty-ui/input';+import { themeCssVariables } from 'twenty-ui/theme-constants';++const StyledContainer = styled.div`+ align-items: center;+ display: flex;+ flex-direction: column;+ gap: ${themeCssVariables.spacing[4]};+ height: 100%;+ justify-content: center;+ padding: ${themeCssVariables.spacing[8]};+ text-align: center;+`;++const StyledTitle = styled.div`+ color: ${themeCssVariables.font.color.primary};+ font-size: ${themeCssVariables.font.size.xl};+ font-weight: ${themeCssVariables.font.weight.semiBold};+`;++const StyledMessage = styled.div`+ color: ${themeCssVariables.font.color.secondary};+ font-size: ${themeCssVariables.font.size.lg};+ max-width: 400px;+`;++type UnavailableFilePreviewProps = {+ fileName: string;+ fileUrl: string;+ message: ReactNode;+};++export const UnavailableFilePreview = ({+ fileName,+ fileUrl,+ message,+}: UnavailableFilePreviewProps) => {+ const { t } = useLingui();++ return (+ <StyledContainer>+ <StyledTitle>+ <Trans>Preview Not Available</Trans>+ </StyledTitle>+ <StyledMessage>{message}</StyledMessage>+ <Button+ Icon={IconDownload}+ title={t`Download File`}+ onClick={() => downloadFile(fileUrl, fileName)}+ variant="secondary"+ />+ </StyledContainer>+ );+};diff --git a/packages/twenty-front/src/modules/activities/files/components/VideoPreview.tsx b/packages/twenty-front/src/modules/activities/files/components/VideoPreview.tsxnew file mode 100644index 00000000000..3e16cd2c90b--- /dev/null+++ b/packages/twenty-front/src/modules/activities/files/components/VideoPreview.tsx@@ -0,0 +1,41 @@+import { UnavailableFilePreview } from '@/activities/files/components/UnavailableFilePreview';+import { styled } from '@linaria/react';+import { Trans } from '@lingui/react/macro';+import { useState } from 'react';++const StyledVideo = styled.video`+ height: 100%;+ object-fit: contain;+ width: 100%;+`;++type VideoPreviewProps = {+ videoName: string;+ videoUrl: string;+};++export const VideoPreview = ({ videoName, videoUrl }: VideoPreviewProps) => {+ const [hasFailedToLoad, setHasFailedToLoad] = useState(false);++ if (hasFailedToLoad) {+ return (+ <UnavailableFilePreview+ fileName={videoName}+ fileUrl={videoUrl}+ message={+ <Trans>+ This video could not be loaded. Please download the file to view it.+ </Trans>+ }+ />+ );+ }++ return (+ <StyledVideo+ controls+ src={videoUrl}+ onError={() => setHasFailedToLoad(true)}+ />+ );+};diff --git a/packages/twenty-front/src/modules/activities/files/components/__stories__/VideoPreview.stories.tsx b/packages/twenty-front/src/modules/activities/files/components/__stories__/VideoPreview.stories.tsxnew file mode 100644index 00000000000..4383dc8174e--- /dev/null+++ b/packages/twenty-front/src/modules/activities/files/components/__stories__/VideoPreview.stories.tsx@@ -0,0 +1,51 @@+import { type Meta, type StoryObj } from '@storybook/react-vite';+import { delay, http } from 'msw';+import { expect, fireEvent, within } from 'storybook/test';+import { ComponentDecorator } from 'twenty-ui/testing';++import { VideoPreview } from '@/activities/files/components/VideoPreview';++const VIDEO_URL = '/storybook/product-demo.mp4';++const getVideo = (canvasElement: HTMLElement) =>+ canvasElement.querySelector('video');++const meta: Meta<typeof VideoPreview> = {+ title: 'Modules/Activities/Files/VideoPreview',+ component: VideoPreview,+ decorators: [ComponentDecorator],+ args: {+ videoName: 'Product demo.mp4',+ videoUrl: VIDEO_URL,+ },+ parameters: {+ container: { height: 400, width: 600 },+ // The request never resolves, so the video only fails when a story makes it fail.+ msw: { handlers: [http.get(VIDEO_URL, () => delay('infinite'))] },+ },+};++export default meta;++type Story = StoryObj<typeof VideoPreview>;++export const Player: Story = {+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);++ expect(getVideo(canvasElement)).not.toBeNull();+ expect(canvas.queryByText('Preview Not Available')).toBeNull();+ },+};++export const LoadFailure: Story = {+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);++ fireEvent.error(getVideo(canvasElement) as HTMLVideoElement);++ expect(await canvas.findByText('Preview Not Available')).toBeVisible();+ expect(getVideo(canvasElement)).toBeNull();+ expect(canvas.getByRole('button', { name: /Download File/ })).toBeVisible();+ },+};