The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(front): See Workflow from the workflow runs table and hide See Version with core workflows (#27022)
Thomas Trompette1bb8b44478ee
diff --git a/packages/twenty-front/src/modules/command-menu-item/contexts/CommandMenuContextProviderContent.tsx b/packages/twenty-front/src/modules/command-menu-item/contexts/CommandMenuContextProviderContent.tsxindex ae97b9f64e3..29669c2ef6b 100644--- a/packages/twenty-front/src/modules/command-menu-item/contexts/CommandMenuContextProviderContent.tsx+++ b/packages/twenty-front/src/modules/command-menu-item/contexts/CommandMenuContextProviderContent.tsx@@ -118,6 +118,12 @@ export const CommandMenuContextProviderContent = ({!isCoreWorkflow ||!WORKSPACE_DEFINITION_COMMANDS.has(item.engineComponentKey),)+ .filter(+ (item) =>+ !isCore ||+ item.engineComponentKey !==+ EngineComponentKey.SEE_VERSION_WORKFLOW_RUN,+ ).filter((item) =>item.engineComponentKey !==@@ -156,6 +162,7 @@ export const CommandMenuContextProviderContent = ({commandMenuContextApiForAvailability,globalRecordCreationCommandMenuItems,shouldDisplayGlobalRecordCreationCommands,+ isCore,isCoreWorkflow,commandMenuItems,commandMenuItemsDraft,diff --git a/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeVersionWorkflowRunSingleRecordCommand.tsx b/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeVersionWorkflowRunSingleRecordCommand.tsxindex 55e57e3f984..52bde380d96 100644--- a/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeVersionWorkflowRunSingleRecordCommand.tsx+++ b/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeVersionWorkflowRunSingleRecordCommand.tsx@@ -1,26 +1,12 @@-import { useIsWorkflowCoreEnabled } from '@/workflow/hooks/useIsWorkflowCoreEnabled';import { HeadlessNavigateEngineCommand } from '@/command-menu-item/engine-command/components/HeadlessNavigateEngineCommand';import { useHeadlessCommandContextApi } from '@/command-menu-item/engine-command/hooks/useHeadlessCommandContextApi';import { AppPath, CoreObjectNameSingular } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';export const SeeVersionWorkflowRunSingleRecordCommand = () => {- const isCore = useIsWorkflowCoreEnabled();const { selectedRecords } = useHeadlessCommandContextApi();const selectedRecord = selectedRecords[0];- if (isCore) {- const coreWorkflowId = selectedRecord?.coreWorkflowId;- const coreWorkflowVersionId = selectedRecord?.coreWorkflowVersionId;- return isDefined(coreWorkflowId) && isDefined(coreWorkflowVersionId) ? (- <HeadlessNavigateEngineCommand- to={AppPath.WorkflowCoreShowPage}- params={{ coreWorkflowId }}- queryParams={{ version: coreWorkflowVersionId }}- />- ) : null;- }-if (!isDefined(selectedRecord) ||!isDefined(selectedRecord?.workflowVersion?.id)diff --git a/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeWorkflowWorkflowRunSingleRecordCommand.tsx b/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeWorkflowWorkflowRunSingleRecordCommand.tsxindex bb8e8149a90..597ab223899 100644--- a/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeWorkflowWorkflowRunSingleRecordCommand.tsx+++ b/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeWorkflowWorkflowRunSingleRecordCommand.tsx@@ -1,22 +1,58 @@import { useIsWorkflowCoreEnabled } from '@/workflow/hooks/useIsWorkflowCoreEnabled';+import { HeadlessEngineCommandWrapperEffect } from '@/command-menu-item/engine-command/components/HeadlessEngineCommandWrapperEffect';import { HeadlessNavigateEngineCommand } from '@/command-menu-item/engine-command/components/HeadlessNavigateEngineCommand';import { useHeadlessCommandContextApi } from '@/command-menu-item/engine-command/hooks/useHeadlessCommandContextApi';+import { useLazyFindOneRecord } from '@/object-record/hooks/useLazyFindOneRecord';import { AppPath, CoreObjectNameSingular } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';+import { useNavigateApp } from '~/hooks/useNavigateApp';export const SeeWorkflowWorkflowRunSingleRecordCommand = () => {const isCore = useIsWorkflowCoreEnabled();const { selectedRecords } = useHeadlessCommandContextApi();const selectedRecord = selectedRecords[0];+ const navigateApp = useNavigateApp();++ const { findOneRecord: findWorkflowRun } = useLazyFindOneRecord({+ objectNameSingular: CoreObjectNameSingular.WorkflowRun,+ recordGqlFields: { id: true, coreWorkflowId: true },+ });++ const findCoreWorkflowId = async (): Promise<string | null | undefined> => {+ if (isDefined(selectedRecord?.coreWorkflowId)) {+ return selectedRecord.coreWorkflowId;+ }++ if (!isDefined(selectedRecord?.id)) {+ return undefined;+ }++ let coreWorkflowId: string | null | undefined;++ await findWorkflowRun({+ objectRecordId: selectedRecord.id,+ onCompleted: (workflowRun) => {+ coreWorkflowId = workflowRun.coreWorkflowId;+ },+ });++ return coreWorkflowId;+ };if (isCore) {- const coreWorkflowId = selectedRecord?.coreWorkflowId;- return isDefined(coreWorkflowId) ? (- <HeadlessNavigateEngineCommand- to={AppPath.WorkflowCoreShowPage}- params={{ coreWorkflowId }}+ return (+ <HeadlessEngineCommandWrapperEffect+ execute={async () => {+ const coreWorkflowId = await findCoreWorkflowId();++ if (!isDefined(coreWorkflowId)) {+ return;+ }++ navigateApp(AppPath.WorkflowCoreShowPage, { coreWorkflowId });+ }}/>- ) : null;+ );}if (!isDefined(selectedRecord) || !isDefined(selectedRecord?.workflow?.id)) {