Skip to content

The open alternative to Salesforce, designed for AI.

Add core index column icons and show visibility as tags (#27391)

Thomas des Francs230ee70794ff
diff --git a/packages/twenty-front/src/modules/object-core/agents/constants/CoreAgentTableColumns.tsx b/packages/twenty-front/src/modules/object-core/agents/constants/CoreAgentTableColumns.tsx
index 8fb635702bb..5298ea42e1d 100644
--- a/packages/twenty-front/src/modules/object-core/agents/constants/CoreAgentTableColumns.tsx
+++ b/packages/twenty-front/src/modules/object-core/agents/constants/CoreAgentTableColumns.tsx
@@ -1,4 +1,5 @@
import { msg } from '@lingui/core/macro';
+import { IconCalendarTime, IconCpu, IconTextSize } from 'twenty-ui/icon';
import { CoreAgentModelCell } from '@/object-core/agents/components/CoreAgentModelCell';
import { CoreAgentNameCell } from '@/object-core/agents/components/CoreAgentNameCell';
@@ -10,6 +11,7 @@ export const CORE_AGENT_TABLE_COLUMNS: CoreObjectTableColumn<CoreAgent>[] = [
{
fieldName: 'label',
fieldLabel: msg`Name`,
+ FieldIcon: IconTextSize,
fieldType: 'string',
align: 'left',
gridTrack: 'minmax(200px, 1fr)',
@@ -18,6 +20,7 @@ export const CORE_AGENT_TABLE_COLUMNS: CoreObjectTableColumn<CoreAgent>[] = [
{
fieldName: 'modelId',
fieldLabel: msg`Model`,
+ FieldIcon: IconCpu,
align: 'left',
gridTrack: '200px',
renderCell: (agent) => <CoreAgentModelCell modelId={agent.modelId} />,
@@ -25,6 +28,7 @@ export const CORE_AGENT_TABLE_COLUMNS: CoreObjectTableColumn<CoreAgent>[] = [
{
fieldName: 'updatedAt',
fieldLabel: msg`Last update`,
+ FieldIcon: IconCalendarTime,
fieldType: 'string',
align: 'left',
gridTrack: '150px',
diff --git a/packages/twenty-front/src/modules/object-core/workflows/components/CoreWorkflowVisibilityCell.tsx b/packages/twenty-front/src/modules/object-core/workflows/components/CoreWorkflowVisibilityCell.tsx
index 14eaa0d9f24..85a180ef1ce 100644
--- a/packages/twenty-front/src/modules/object-core/workflows/components/CoreWorkflowVisibilityCell.tsx
+++ b/packages/twenty-front/src/modules/object-core/workflows/components/CoreWorkflowVisibilityCell.tsx
@@ -1,19 +1,10 @@
-import { styled } from '@linaria/react';
import { t } from '@lingui/core/macro';
import { isDefined } from 'twenty-shared/utils';
-import { OverflowingTextWithTooltip } from 'twenty-ui/primitives/typography';
-import { themeCssVariables, useTheme } from 'twenty-ui/theme';
+import { Tag } from 'twenty-ui/primitives/data-display';
import { type WorkflowVisibility } from '~/generated/graphql';
import { CORE_WORKFLOW_VISIBILITY_OPTIONS } from '@/object-core/workflows/constants/CoreWorkflowVisibilityOptions';
-const StyledVisibility = styled.span`
- align-items: center;
- display: flex;
- gap: ${themeCssVariables.spacing[1]};
- min-width: 0;
-`;
-
type CoreWorkflowVisibilityCellProps = {
visibility: WorkflowVisibility;
};
@@ -21,8 +12,6 @@ type CoreWorkflowVisibilityCellProps = {
export const CoreWorkflowVisibilityCell = ({
visibility,
}: CoreWorkflowVisibilityCellProps) => {
- const theme = useTheme();
-
const visibilityOption = CORE_WORKFLOW_VISIBILITY_OPTIONS.find(
({ value }) => value === visibility,
);
@@ -31,13 +20,5 @@ export const CoreWorkflowVisibilityCell = ({
return null;
}
- return (
- <StyledVisibility>
- <visibilityOption.Icon
- size={theme.icon.size.sm}
- stroke={theme.icon.stroke.sm}
- />
- <OverflowingTextWithTooltip text={t(visibilityOption.label)} />
- </StyledVisibility>
- );
+ return <Tag color="gray">{t(visibilityOption.label)}</Tag>;
};
diff --git a/packages/twenty-front/src/modules/object-core/workflows/constants/CoreWorkflowVisibilityOptions.ts b/packages/twenty-front/src/modules/object-core/workflows/constants/CoreWorkflowVisibilityOptions.ts
index d497a29c1c5..cdfff2d37d3 100644
--- a/packages/twenty-front/src/modules/object-core/workflows/constants/CoreWorkflowVisibilityOptions.ts
+++ b/packages/twenty-front/src/modules/object-core/workflows/constants/CoreWorkflowVisibilityOptions.ts
@@ -1,5 +1,4 @@
import { msg } from '@lingui/core/macro';
-import { IconCircle, IconCircleDashed } from 'twenty-ui/icon';
import { type CoreWorkflowVisibilityOption } from '@/object-core/workflows/types/CoreWorkflowVisibilityOption';
import { WorkflowVisibility } from '~/generated/graphql';
@@ -10,12 +9,10 @@ export const CORE_WORKFLOW_VISIBILITY_OPTIONS: CoreWorkflowVisibilityOption[] =
value: WorkflowVisibility.WORKSPACE,
label: msg`Workspace`,
contextualText: msg`Everyone`,
- Icon: IconCircle,
},
{
value: WorkflowVisibility.PRIVATE,
label: msg`Private`,
contextualText: msg`Only you`,
- Icon: IconCircleDashed,
},
];
diff --git a/packages/twenty-front/src/modules/object-core/workflows/constants/WorkflowCoreTableColumns.tsx b/packages/twenty-front/src/modules/object-core/workflows/constants/WorkflowCoreTableColumns.tsx
index 2e0b437da5b..1f99927a7a9 100644
--- a/packages/twenty-front/src/modules/object-core/workflows/constants/WorkflowCoreTableColumns.tsx
+++ b/packages/twenty-front/src/modules/object-core/workflows/constants/WorkflowCoreTableColumns.tsx
@@ -1,4 +1,10 @@
import { msg } from '@lingui/core/macro';
+import {
+ IconCalendarTime,
+ IconShare,
+ IconStatusChange,
+ IconTextSize,
+} from 'twenty-ui/icon';
import { CoreWorkflowNameCell } from '@/object-core/workflows/components/CoreWorkflowNameCell';
import { CoreWorkflowStatusesCell } from '@/object-core/workflows/components/CoreWorkflowStatusesCell';
@@ -12,6 +18,7 @@ export const WORKFLOW_CORE_TABLE_COLUMNS: CoreObjectTableColumn<CoreWorkflow>[]
{
fieldName: 'name',
fieldLabel: msg`Name`,
+ FieldIcon: IconTextSize,
fieldType: 'string',
align: 'left',
gridTrack: 'minmax(200px, 1fr)',
@@ -22,6 +29,7 @@ export const WORKFLOW_CORE_TABLE_COLUMNS: CoreObjectTableColumn<CoreWorkflow>[]
{
fieldName: 'statuses',
fieldLabel: msg`Statuses`,
+ FieldIcon: IconStatusChange,
align: 'left',
gridTrack: '160px',
renderCell: (workflow) => (
@@ -31,6 +39,7 @@ export const WORKFLOW_CORE_TABLE_COLUMNS: CoreObjectTableColumn<CoreWorkflow>[]
{
fieldName: 'visibility',
fieldLabel: msg`Visibility`,
+ FieldIcon: IconShare,
align: 'left',
gridTrack: '120px',
renderCell: (workflow) => (
@@ -40,6 +49,7 @@ export const WORKFLOW_CORE_TABLE_COLUMNS: CoreObjectTableColumn<CoreWorkflow>[]
{
fieldName: 'updatedAt',
fieldLabel: msg`Last update`,
+ FieldIcon: IconCalendarTime,
fieldType: 'string',
align: 'left',
gridTrack: '150px',
diff --git a/packages/twenty-front/src/modules/object-core/workflows/types/CoreWorkflowVisibilityOption.ts b/packages/twenty-front/src/modules/object-core/workflows/types/CoreWorkflowVisibilityOption.ts
index 1260977c6f4..1c1f5ead2de 100644
--- a/packages/twenty-front/src/modules/object-core/workflows/types/CoreWorkflowVisibilityOption.ts
+++ b/packages/twenty-front/src/modules/object-core/workflows/types/CoreWorkflowVisibilityOption.ts
@@ -1,5 +1,4 @@
import { type MessageDescriptor } from '@lingui/core';
-import { type IconComponent } from 'twenty-ui/icon';
import { type WorkflowVisibility } from '~/generated/graphql';
@@ -7,5 +6,4 @@ export type CoreWorkflowVisibilityOption = {
value: WorkflowVisibility;
label: MessageDescriptor;
contextualText: MessageDescriptor;
- Icon: IconComponent;
};