The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Drop the ANSWERED agent run caller outcome (#27554)
Félix Malfait245a2e7505ea
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run-suspension.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run-suspension.service.spec.tsnew file mode 100644index 00000000000..9b795934552--- /dev/null+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run-suspension.service.spec.ts@@ -0,0 +1,126 @@+import { CONTINUE_AGENT_RUN_JOB_NAME } from 'src/engine/metadata-modules/ai/ai-agent-execution/constants/continue-agent-run-job-name.constant';+import { type AgentRunSuspensionEntity } from 'src/engine/metadata-modules/ai/ai-agent-execution/entities/agent-run-suspension.entity';+import { AgentRunSuspensionService } from 'src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run-suspension.service';++const CALLER = {+ type: 'WORKFLOW_STEP' as const,+ ref: { workflowRunId: 'run-id', stepId: 'step-id' },+};++const buildSuspension = (+ overrides: Partial<AgentRunSuspensionEntity> = {},+): AgentRunSuspensionEntity =>+ ({+ id: 'suspension-id',+ workspaceId: 'workspace-id',+ threadId: 'thread-id',+ caller: CALLER,+ runSpec: null,+ summary: null,+ resumeCount: 0,+ ...overrides,+ }) as AgentRunSuspensionEntity;++const buildService = () => {+ const onOutcome = jest.fn().mockResolvedValue(undefined);+ const messageQueueService = { add: jest.fn().mockResolvedValue(undefined) };++ const service = new AgentRunSuspensionService(+ { delete: jest.fn().mockResolvedValue(undefined) } as never,+ { findOne: jest.fn().mockResolvedValue(null) } as never,+ { query: jest.fn().mockResolvedValue(undefined) } as never,+ {} as never,+ {} as never,+ { cancel: jest.fn().mockResolvedValue(undefined) } as never,+ { getHandlerOrThrow: () => ({ onOutcome }) } as never,+ messageQueueService as never,+ );++ return { service, onOutcome, messageQueueService };+};++describe('AgentRunSuspensionService', () => {+ describe('deliverAnswer', () => {+ it('hands the answer to a call the caller posted itself as its completed outcome', async () => {+ const { service, onOutcome, messageQueueService } = buildService();++ await service.deliverAnswer({+ workspaceId: 'workspace-id',+ suspension: buildSuspension(),+ toolResult: {+ success: true,+ result: {+ status: 'approved',+ proposal: {+ toolName: 'update_one_company',+ arguments: { id: 'company-id', employees: 25 },+ },+ output: { id: 'company-id' },+ },+ },+ });++ expect(messageQueueService.add).not.toHaveBeenCalled();+ expect(onOutcome).toHaveBeenCalledTimes(1);+ expect(onOutcome).toHaveBeenCalledWith({+ workspaceId: 'workspace-id',+ caller: CALLER,+ threadId: 'thread-id',+ outcome: {+ status: 'COMPLETED',+ result: {+ threadId: 'thread-id',+ outcome: 'executed',+ toolName: 'update_one_company',+ arguments: { id: 'company-id', employees: 25 },+ output: { id: 'company-id' },+ feedback: null,+ error: null,+ },+ },+ summary: null,+ });+ });++ it('fails the caller when the answer cannot be read', async () => {+ const { service, onOutcome } = buildService();++ await service.deliverAnswer({+ workspaceId: 'workspace-id',+ suspension: buildSuspension(),+ toolResult: { success: true, result: { status: 'pending' } },+ });++ expect(onOutcome).toHaveBeenCalledTimes(1);+ expect(onOutcome).toHaveBeenCalledWith(+ expect.objectContaining({+ outcome: {+ status: 'FAILED',+ error: 'The answer to the proposed call could not be read',+ },+ }),+ );+ });++ it('continues a suspended agent run instead of settling it', async () => {+ const { service, onOutcome, messageQueueService } = buildService();++ await service.deliverAnswer({+ workspaceId: 'workspace-id',+ suspension: buildSuspension({ runSpec: {} as never }),+ toolResult: {},+ });++ expect(messageQueueService.add).toHaveBeenCalledTimes(1);+ expect(messageQueueService.add).toHaveBeenCalledWith(+ CONTINUE_AGENT_RUN_JOB_NAME,+ {+ workspaceId: 'workspace-id',+ suspensionId: 'suspension-id',+ resumeCount: 0,+ },+ );+ expect(onOutcome).not.toHaveBeenCalled();+ });+ });+});diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run-suspension.service.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run-suspension.service.tsindex 29f75fa3116..7faa7f9ed18 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run-suspension.service.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run-suspension.service.ts@@ -203,7 +203,10 @@ export class AgentRunSuspensionService {workspaceId,suspension,outcome: isDefined(answer)- ? { status: 'ANSWERED', answer }+ ? {+ status: 'COMPLETED',+ result: { threadId: suspension.threadId, ...answer },+ }: {status: 'FAILED',error: 'The answer to the proposed call could not be read',diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/types/agent-run-caller-outcome.type.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/types/agent-run-caller-outcome.type.tsindex 93cc1b99a9e..56dc1c7f6e3 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/types/agent-run-caller-outcome.type.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/types/agent-run-caller-outcome.type.ts@@ -1,7 +1,7 @@-import { type ProposedToolCallAnswer } from 'src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/types/proposed-tool-call-answer.type';import { type AgentRunnerOutcome } from 'src/engine/metadata-modules/ai/ai-agent-execution/types/agent-runner-outcome.type';// what a caller gets once it stops waiting: how its run ended, or the answer to a call it posted itself-export type AgentRunCallerOutcome =- | Exclude<AgentRunnerOutcome, { status: 'SUSPENDED' }>- | { status: 'ANSWERED'; answer: ProposedToolCallAnswer };+export type AgentRunCallerOutcome = Exclude<+ AgentRunnerOutcome,+ { status: 'SUSPENDED' }+>;diff --git a/packages/twenty-server/src/modules/workflow/workflow-runner/workspace-services/workflow-agent-run-caller-handler.workspace-service.ts b/packages/twenty-server/src/modules/workflow/workflow-runner/workspace-services/workflow-agent-run-caller-handler.workspace-service.tsindex 7d4da1a2ba2..711b09279f7 100644--- a/packages/twenty-server/src/modules/workflow/workflow-runner/workspace-services/workflow-agent-run-caller-handler.workspace-service.ts+++ b/packages/twenty-server/src/modules/workflow/workflow-runner/workspace-services/workflow-agent-run-caller-handler.workspace-service.ts@@ -94,16 +94,10 @@ export class WorkflowAgentRunCallerHandlerWorkspaceService});}- // the member's answer already ran the call, so a Send Message step only reports itconst actionOutput =outcome.status === 'FAILED'? { error: outcome.error }- : {- result:- outcome.status === 'ANSWERED'- ? { threadId, ...outcome.answer }- : outcome.result,- };+ : { result: outcome.result };// the step stays pending until the job claims it, so the run must not stay running without onetry {