The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Make Edit Layout available across the app (#24865)
Thomas des Francs26b39cd767c3
diff --git a/packages/twenty-front/src/modules/command-menu-item/engine-command/constants/EngineComponentKeyHeadlessComponentMap.tsx b/packages/twenty-front/src/modules/command-menu-item/engine-command/constants/EngineComponentKeyHeadlessComponentMap.tsxindex 7b3f9831884..375353b7e9f 100644--- a/packages/twenty-front/src/modules/command-menu-item/engine-command/constants/EngineComponentKeyHeadlessComponentMap.tsx+++ b/packages/twenty-front/src/modules/command-menu-item/engine-command/constants/EngineComponentKeyHeadlessComponentMap.tsx@@ -8,6 +8,7 @@ import { SendMessageCampaignSingleRecordCommand } from '@/command-menu-item/engiimport { SendMessageCampaignTestSingleRecordCommand } from '@/command-menu-item/engine-command/record/single-record/message-campaign/components/SendMessageCampaignTestSingleRecordCommand';import { OpenEmailBlockSettingsSingleRecordCommand } from '@/command-menu-item/engine-command/record/components/OpenEmailBlockSettingsSingleRecordCommand';import { ComposeEmailCommand } from '@/command-menu-item/engine-command/global/components/ComposeEmailCommand';+import { EditLayoutCommand } from '@/command-menu-item/engine-command/global/components/EditLayoutCommand';import { DeleteRecordsCommand } from '@/command-menu-item/engine-command/record/components/DeleteRecordsCommand';import { DestroyRecordsCommand } from '@/command-menu-item/engine-command/record/components/DestroyRecordsCommand';import { ExportRecordsCommand } from '@/command-menu-item/engine-command/record/components/ExportRecordsCommand';@@ -30,7 +31,6 @@ import { DuplicateDashboardSingleRecordCommand } from '@/command-menu-item/enginimport { EditDashboardSingleRecordCommand } from '@/command-menu-item/engine-command/record/single-record/dashboard/components/EditDashboardSingleRecordCommand';import { SaveDashboardSingleRecordCommand } from '@/command-menu-item/engine-command/record/single-record/dashboard/components/SaveDashboardSingleRecordCommand';import { ReplyToEmailThreadCommand } from '@/command-menu-item/engine-command/record/single-record/message-thread/components/ReplyToEmailThreadCommand';-import { EditRecordPageLayoutSingleRecordCommand } from '@/command-menu-item/engine-command/record/single-record/record-page-layout/components/EditRecordPageLayoutSingleRecordCommand';import { SeeVersionWorkflowRunSingleRecordCommand } from '@/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeVersionWorkflowRunSingleRecordCommand';import { SeeWorkflowWorkflowRunSingleRecordCommand } from '@/command-menu-item/engine-command/record/single-record/workflow-runs/components/SeeWorkflowWorkflowRunSingleRecordCommand';import { RetryWorkflowRunSingleRecordCommand } from '@/command-menu-item/engine-command/record/single-record/workflow-runs/components/RetryWorkflowRunSingleRecordCommand';@@ -123,9 +123,7 @@ export const ENGINE_COMPONENT_KEY_COMPONENT_MAP: Record<[EngineComponentKey.HIDE_DELETED_RECORDS]: (<HideDeletedRecordsNoSelectionRecordCommand />),- [EngineComponentKey.EDIT_RECORD_PAGE_LAYOUT]: (- <EditRecordPageLayoutSingleRecordCommand />- ),+ [EngineComponentKey.EDIT_RECORD_PAGE_LAYOUT]: <EditLayoutCommand />,[EngineComponentKey.EDIT_DASHBOARD_LAYOUT]: (<EditDashboardSingleRecordCommand />),diff --git a/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/record-page-layout/components/EditRecordPageLayoutSingleRecordCommand.tsx b/packages/twenty-front/src/modules/command-menu-item/engine-command/global/components/EditLayoutCommand.tsxsimilarity index 92%rename from packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/record-page-layout/components/EditRecordPageLayoutSingleRecordCommand.tsxrename to packages/twenty-front/src/modules/command-menu-item/engine-command/global/components/EditLayoutCommand.tsxindex 3fae4b6a9eb..e9c896e042c 100644--- a/packages/twenty-front/src/modules/command-menu-item/engine-command/record/single-record/record-page-layout/components/EditRecordPageLayoutSingleRecordCommand.tsx+++ b/packages/twenty-front/src/modules/command-menu-item/engine-command/global/components/EditLayoutCommand.tsx@@ -4,7 +4,7 @@ import { HeadlessEngineCommandWrapperEffect } from '@/command-menu-item/engine-cimport { useEnterLayoutCustomizationMode } from '@/layout-customization/hooks/useEnterLayoutCustomizationMode';import { useSidePanelMenu } from '@/side-panel/hooks/useSidePanelMenu';-export const EditRecordPageLayoutSingleRecordCommand = () => {+export const EditLayoutCommand = () => {const { enterLayoutCustomizationMode } = useEnterLayoutCustomizationMode();const { closeSidePanelMenu } = useSidePanelMenu();const { resetLocationHash } = useResetLocationHash();diff --git a/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts b/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.tsindex 9a46fd6e1ae..722c0f365c2 100644--- a/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts+++ b/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts@@ -375,8 +375,8 @@ export const mockedCommandMenuItems: CommandMenuItemFieldsFragment[] ="isPinned": false,"payload": null,"hotKeys": null,- "conditionalAvailabilityExpression": "pageType == \"RECORD_PAGE\" and not isLayoutCustomizationModeEnabled and noneDefined(selectedRecords, \"deletedAt\") and objectPermissions.canUpdateObjectRecords and objectMetadataItem.nameSingular != \"dashboard\"",- "availabilityType": "RECORD_SELECTION",+ "conditionalAvailabilityExpression": "pageType != \"SETTINGS_PAGE\" and not isLayoutCustomizationModeEnabled and permissionFlags.LAYOUTS",+ "availabilityType": "GLOBAL","availabilityObjectMetadataId": null,"pageLayoutId": null,"isActive": true,diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-upgrade-version-command.module.tsnew file mode 100644index 00000000000..2f8bd80e785--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-upgrade-version-command.module.ts@@ -0,0 +1,16 @@+import { Module } from '@nestjs/common';++import { WorkspaceIteratorModule } from 'src/database/commands/command-runners/workspace-iterator.module';+import { EnableEditLayoutAcrossAppCommand } from 'src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1787906715270-enable-edit-layout-across-app.command';+import { WorkspaceCacheModule } from 'src/engine/workspace-cache/workspace-cache.module';+import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspace-migration/workspace-migration.module';++@Module({+ imports: [+ WorkspaceCacheModule,+ WorkspaceIteratorModule,+ WorkspaceMigrationModule,+ ],+ providers: [EnableEditLayoutAcrossAppCommand],+})+export class V2_38_UpgradeVersionCommandModule {}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1787906715270-enable-edit-layout-across-app.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1787906715270-enable-edit-layout-across-app.command.tsnew file mode 100644index 00000000000..468996c0855--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/2-38-workspace-command-1787906715270-enable-edit-layout-across-app.command.ts@@ -0,0 +1,80 @@+import { Command } from 'nest-commander';+import { TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER } from 'twenty-shared/application';+import { isDefined } from 'twenty-shared/utils';++import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';+import { buildEditLayoutCommandMenuItemUpdate } from 'src/database/commands/upgrade-version-command/2-38/utils/build-edit-layout-command-menu-item-update.util';+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';+import { STANDARD_COMMAND_MENU_ITEMS } from 'src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant';+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';+import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';++@RegisteredWorkspaceCommand('2.38.0', 1787906715270)+@Command({+ name: 'upgrade:2-38:enable-edit-layout-across-app',+ description:+ 'Make the Edit Layout command available across the app outside Settings',+})+export class EnableEditLayoutAcrossAppCommand extends ProvisionedWorkspaceCommandRunner {+ constructor(+ protected readonly workspaceIteratorService: WorkspaceIteratorService,+ private readonly workspaceCacheService: WorkspaceCacheService,+ private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,+ ) {+ super(workspaceIteratorService);+ }++ override async runOnWorkspace({+ workspaceId,+ options,+ }: RunOnWorkspaceArgs): Promise<void> {+ const { flatCommandMenuItemMaps } =+ await this.workspaceCacheService.getOrRecompute(workspaceId, [+ 'flatCommandMenuItemMaps',+ ]);++ const commandMenuItemToUpdate = buildEditLayoutCommandMenuItemUpdate({+ existingCommandMenuItem:+ flatCommandMenuItemMaps.byUniversalIdentifier[+ STANDARD_COMMAND_MENU_ITEMS.editRecordPageLayout.universalIdentifier+ ],+ now: new Date().toISOString(),+ });++ if (!isDefined(commandMenuItemToUpdate)) {+ return;+ }++ if (options.dryRun) {+ this.logger.log(+ `Would enable Edit Layout across the app for workspace ${workspaceId}`,+ );++ return;+ }++ const validateAndBuildResult =+ await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(+ {+ allFlatEntityOperationByMetadataName: {+ commandMenuItem: {+ flatEntityToCreate: [],+ flatEntityToDelete: [],+ flatEntityToUpdate: [commandMenuItemToUpdate],+ },+ },+ workspaceId,+ isSystemBuild: true,+ applicationUniversalIdentifier:+ TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER,+ },+ );++ if (validateAndBuildResult.status === 'fail') {+ throw new WorkspaceMigrationBuilderException(validateAndBuildResult);+ }+ }+}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-edit-layout-command-menu-item-update.util.spec.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-edit-layout-command-menu-item-update.util.spec.tsnew file mode 100644index 00000000000..cae51dddeae--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/__tests__/build-edit-layout-command-menu-item-update.util.spec.ts@@ -0,0 +1,89 @@+import { CommandMenuItemAvailabilityType } from 'twenty-shared/types';++import { buildEditLayoutCommandMenuItemUpdate } from 'src/database/commands/upgrade-version-command/2-38/utils/build-edit-layout-command-menu-item-update.util';+import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';+import { createEmptyFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-flat-entity-maps.constant';+import { createStandardCommandMenuItemFlatMetadata } from 'src/engine/workspace-manager/twenty-standard-application/utils/command-menu-item/create-standard-command-menu-item-flat-metadata.util';++const NOW = '2026-08-27T14:00:00.000Z';+const LEGACY_COMMAND_MENU_ITEM: FlatCommandMenuItem = Object.freeze({+ ...createStandardCommandMenuItemFlatMetadata({+ commandMenuItemName: 'editRecordPageLayout',+ commandMenuItemId: 'edit-layout-command-id',+ workspaceId: 'workspace-id',+ twentyStandardApplicationId: 'application-id',+ dependencyFlatEntityMaps: {+ flatObjectMetadataMaps: createEmptyFlatEntityMaps(),+ },+ now: '2026-08-01T00:00:00.000Z',+ }),+ availabilityType: CommandMenuItemAvailabilityType.RECORD_SELECTION,+ conditionalAvailabilityExpression:+ 'pageType == "RECORD_PAGE" and not isLayoutCustomizationModeEnabled and noneDefined(selectedRecords, "deletedAt") and objectPermissions.canUpdateObjectRecords and objectMetadataItem.nameSingular != "dashboard"',+ label: 'Customize layout',+ isPinned: true,+ position: 42,+ overrides: { label: 'Customize layout' },+ universalOverrides: { label: 'Customize layout' },+});++describe('buildEditLayoutCommandMenuItemUpdate', () => {+ it('updates legacy availability without changing other fields or mutating the input', () => {+ expect(+ buildEditLayoutCommandMenuItemUpdate({+ existingCommandMenuItem: LEGACY_COMMAND_MENU_ITEM,+ now: NOW,+ }),+ ).toEqual({+ ...LEGACY_COMMAND_MENU_ITEM,+ availabilityType: CommandMenuItemAvailabilityType.GLOBAL,+ conditionalAvailabilityExpression:+ 'pageType != "SETTINGS_PAGE" and not isLayoutCustomizationModeEnabled and permissionFlags.LAYOUTS',+ updatedAt: NOW,+ });+ });++ it.each([+ { name: 'missing command', existingCommandMenuItem: undefined },+ {+ name: 'custom availability type',+ existingCommandMenuItem: {+ ...LEGACY_COMMAND_MENU_ITEM,+ availabilityType: CommandMenuItemAvailabilityType.GLOBAL,+ },+ },+ {+ name: 'custom availability expression',+ existingCommandMenuItem: {+ ...LEGACY_COMMAND_MENU_ITEM,+ conditionalAvailabilityExpression: 'false',+ },+ },+ {+ name: 'removed availability expression',+ existingCommandMenuItem: {+ ...LEGACY_COMMAND_MENU_ITEM,+ conditionalAvailabilityExpression: null,+ },+ },+ ])('skips $name', ({ existingCommandMenuItem }) => {+ expect(+ buildEditLayoutCommandMenuItemUpdate({ existingCommandMenuItem, now: NOW }),+ ).toBeUndefined();+ });++ it('does not update an already migrated command', () => {+ const updatedCommandMenuItem = buildEditLayoutCommandMenuItemUpdate({+ existingCommandMenuItem: LEGACY_COMMAND_MENU_ITEM,+ now: NOW,+ });++ expect(updatedCommandMenuItem).toBeDefined();+ expect(+ buildEditLayoutCommandMenuItemUpdate({+ existingCommandMenuItem: updatedCommandMenuItem,+ now: '2026-08-28T14:00:00.000Z',+ }),+ ).toBeUndefined();+ });+});diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-edit-layout-command-menu-item-update.util.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-edit-layout-command-menu-item-update.util.tsnew file mode 100644index 00000000000..b0d88eeec5b--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-38/utils/build-edit-layout-command-menu-item-update.util.ts@@ -0,0 +1,36 @@+import { CommandMenuItemAvailabilityType } from 'twenty-shared/types';+import { isDefined } from 'twenty-shared/utils';++import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';+import { STANDARD_COMMAND_MENU_ITEMS } from 'src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant';++const LEGACY_EDIT_LAYOUT_AVAILABILITY_EXPRESSION =+ 'pageType == "RECORD_PAGE" and not isLayoutCustomizationModeEnabled and noneDefined(selectedRecords, "deletedAt") and objectPermissions.canUpdateObjectRecords and objectMetadataItem.nameSingular != "dashboard"';++export const buildEditLayoutCommandMenuItemUpdate = ({+ existingCommandMenuItem,+ now,+}: {+ existingCommandMenuItem: FlatCommandMenuItem | undefined;+ now: string;+}): FlatCommandMenuItem | undefined => {+ if (+ !isDefined(existingCommandMenuItem) ||+ existingCommandMenuItem.availabilityType !==+ CommandMenuItemAvailabilityType.RECORD_SELECTION ||+ existingCommandMenuItem.conditionalAvailabilityExpression !==+ LEGACY_EDIT_LAYOUT_AVAILABILITY_EXPRESSION+ ) {+ return undefined;+ }++ const standardCommandMenuItem = STANDARD_COMMAND_MENU_ITEMS.editRecordPageLayout;++ return {+ ...existingCommandMenuItem,+ availabilityType: standardCommandMenuItem.availabilityType,+ conditionalAvailabilityExpression:+ standardCommandMenuItem.conditionalAvailabilityExpression,+ updatedAt: now,+ };+};diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.tsindex e0ea164b4d3..3b673c9c492 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts@@ -30,6 +30,7 @@ import { V2_34_UpgradeVersionCommandModule } from 'src/database/commands/upgradeimport { V2_35_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-35/2-35-upgrade-version-command.module';import { V2_36_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-36/2-36-upgrade-version-command.module';import { V2_37_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-37/2-37-upgrade-version-command.module';+import { V2_38_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-38/2-38-upgrade-version-command.module';import { V2_4_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-4/2-4-upgrade-version-command.module';import { V2_5_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-5/2-5-upgrade-version-command.module';import { V2_7_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-7/2-7-upgrade-version-command.module';@@ -73,6 +74,7 @@ import { V2_9_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-V2_35_UpgradeVersionCommandModule,V2_36_UpgradeVersionCommandModule,V2_37_UpgradeVersionCommandModule,+ V2_38_UpgradeVersionCommandModule,],})export class WorkspaceCommandProviderModule {}diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.tsindex 4bbc0951ebc..dbc6016d15b 100644--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts@@ -376,9 +376,9 @@ export const STANDARD_COMMAND_MENU_ITEMS = {shortLabel: i18nLabel(msg({ message: `Edit Layout`, context: 'commandMenuItem.shortLabel' }),),- availabilityType: CommandMenuItemAvailabilityType.RECORD_SELECTION,+ availabilityType: CommandMenuItemAvailabilityType.GLOBAL,conditionalAvailabilityExpression:- 'pageType == "RECORD_PAGE" and not isLayoutCustomizationModeEnabled and noneDefined(selectedRecords, "deletedAt") and objectPermissions.canUpdateObjectRecords and objectMetadataItem.nameSingular != "dashboard"',+ 'pageType != "SETTINGS_PAGE" and not isLayoutCustomizationModeEnabled and permissionFlags.LAYOUTS',availabilityObjectMetadataUniversalIdentifier: null,frontComponentUniversalIdentifier: null,engineComponentKey: EngineComponentKey.EDIT_RECORD_PAGE_LAYOUT,